Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
feat(new-layout): notifications view and channels view updates (#6296)
dev-rb13f89bba5c02
diff --git a/apps/web/src/components/app/app-sidebar/sidebar.tsx b/apps/web/src/components/app/app-sidebar/sidebar.tsxindex 00e86382c3..f3078c858e 100644--- a/apps/web/src/components/app/app-sidebar/sidebar.tsx+++ b/apps/web/src/components/app/app-sidebar/sidebar.tsx@@ -189,7 +189,7 @@ const markdownDocumentsQuery = buildDocumentTypeQuery(['doc-markdown']);const SIDEBAR_LINKS = [{id: 'inbox',- label: 'Inbox',+ label: 'Notifications',href: LIST_VIEW_PATHS.inbox,icon: AnimatedInboxIcon,hotkey: 'i',diff --git a/apps/web/src/components/app/mobile/MobileDockRow.tsx b/apps/web/src/components/app/mobile/MobileDockRow.tsxindex 1744d7f2f6..a945172bf9 100644--- a/apps/web/src/components/app/mobile/MobileDockRow.tsx+++ b/apps/web/src/components/app/mobile/MobileDockRow.tsx@@ -174,7 +174,7 @@ function MoreViewsMenu(props: {</MobileTouchMenu.Item><MobileTouchMenu.Separator />{/* Rows render top → bottom ending at the thumb: reverse the shared- canonical order so Inbox lands nearest it. */}+ canonical order so Notifications lands nearest it. */}<For each={[...dockViews()].reverse()}>{(view) => (<MobileTouchMenu.Itemdiff --git a/apps/web/src/components/app/mobile/mobile-dock-views.ts b/apps/web/src/components/app/mobile/mobile-dock-views.tsindex 22c18aa4c4..e36741ba13 100644--- a/apps/web/src/components/app/mobile/mobile-dock-views.ts+++ b/apps/web/src/components/app/mobile/mobile-dock-views.ts@@ -26,12 +26,17 @@ export type MobileDockView = {/*** The navigation views shared by the search scope pills (MobileViewsRow) and* the dock's Views menu (MoreViewsMenu), in canonical order: the pill row- * renders it as-is after the "All" pill, the menu reversed so Inbox stays+ * renders it as-is after the "All" pill, the menu reversed so Notifications stays* nearest the thumb. "All" (pills only) and Settings (menu only) are* per-surface additions at the edges.*/const MOBILE_DOCK_VIEWS: MobileDockView[] = [- { id: 'inbox', label: 'Inbox', icon: AnimatedInboxIcon, pillIcon: BellIcon },+ {+ id: 'inbox',+ label: 'Notifications',+ icon: AnimatedInboxIcon,+ pillIcon: BellIcon,+ },{id: 'calendar',label: 'Calendar',diff --git a/apps/web/src/components/app/sidebar-next/nav-items.ts b/apps/web/src/components/app/sidebar-next/nav-items.tsindex ecd9eb8367..47e08cbf8a 100644--- a/apps/web/src/components/app/sidebar-next/nav-items.ts+++ b/apps/web/src/components/app/sidebar-next/nav-items.ts@@ -39,14 +39,14 @@ export type SidebarNextNavItem = SidebarItem & {** The labels are new but every destination is an existing view id, so the* `hotkeyToken`s are the ones `GoToHotkeys` already registers — `g i` still- * reaches Activity, `g f` still reaches Drive. `GoToHotkeys` is mounted from+ * reaches Notifications, `g f` still reaches Drive. `GoToHotkeys` is mounted from* `Layout` off `buildSidebarLinks` and is independent of which sidebar renders,* so the shortcuts work unchanged; these tokens only label the tooltips.*/const SIDEBAR_NEXT_NAV_ITEMS = [{id: 'inbox',- label: 'Activity',+ label: 'Notifications',href: LIST_VIEW_PATHS.inbox,icon: BellIcon,iconActive: BellFillIcon,diff --git a/apps/web/src/components/app/split-layout/componentRegistry.tsx b/apps/web/src/components/app/split-layout/componentRegistry.tsxindex 5837181be9..d0f7f23f0d 100644--- a/apps/web/src/components/app/split-layout/componentRegistry.tsx+++ b/apps/web/src/components/app/split-layout/componentRegistry.tsx@@ -241,7 +241,7 @@ function LegacyInboxView() {const preset = getViewPreset('inbox');return (<SoupView- viewName="Inbox"+ viewName="Notifications"initialFilters={preset?.filters}initialClientFilters={preset?.clientFilters}initialGroupBy={preset?.groupBy}diff --git a/apps/web/src/features/channels-view/channels-view.tsx b/apps/web/src/features/channels-view/channels-view.tsxindex b4222a6f92..6fbd9b1552 100644--- a/apps/web/src/features/channels-view/channels-view.tsx+++ b/apps/web/src/features/channels-view/channels-view.tsx@@ -58,6 +58,7 @@ function ChannelsViewRoot() {width: state.asideWidth,min: CHANNELS_MIN_RAIL_WIDTH,max: CHANNELS_MAX_RAIL_WIDTH,+ preserveDuringResize: false,};const sources = useChannelsSources((scope) =>@@ -113,7 +114,7 @@ function ChannelsViewRoot() {aside={railLayout()}breakpoints={{ collapsed: 0 }}layoutBreakpoint="collapsed"- main={{ min: 224 }}+ main={{ min: 224, preferredWidth: 640 }}resizable={railMode() === 'full'}><ViewShell.Asidediff --git a/apps/web/src/features/channels-view/components/rail/ChannelsRail.tsx b/apps/web/src/features/channels-view/components/rail/ChannelsRail.tsxindex ed36b54c27..2b67d161f5 100644--- a/apps/web/src/features/channels-view/components/rail/ChannelsRail.tsx+++ b/apps/web/src/features/channels-view/components/rail/ChannelsRail.tsx@@ -373,7 +373,7 @@ export function ChannelsRail(props: ChannelsRailProps) {<ChannelsRailProvider value={rail}><asidearia-label="Chat navigation"- class="flex size-full min-h-0 flex-col gap-3 bg-inset pt-2"+ class="flex size-full min-h-0 flex-col gap-3 border-r border-edge bg-panel pt-2">{props.mode === 'full' ? (<ExpandedChannelsRail />diff --git a/apps/web/src/features/channels-view/components/rail/ChannelsRailSection.tsx b/apps/web/src/features/channels-view/components/rail/ChannelsRailSection.tsxindex cdadb37cb0..cdfedfe9b0 100644--- a/apps/web/src/features/channels-view/components/rail/ChannelsRailSection.tsx+++ b/apps/web/src/features/channels-view/components/rail/ChannelsRailSection.tsx@@ -42,7 +42,7 @@ function SectionScrollArea(props: {<ScrollIndicatorsscrollRef={scrollRoot}appearance="gradient"- gradientColor="inset"+ gradientColor="panel"/><Show when={activity.direction()}>{(direction) => (diff --git a/apps/web/src/features/inbox-view/components/InboxEmptyState.tsx b/apps/web/src/features/inbox-view/components/InboxEmptyState.tsxindex c828ccc35a..d420311d21 100644--- a/apps/web/src/features/inbox-view/components/InboxEmptyState.tsx+++ b/apps/web/src/features/inbox-view/components/InboxEmptyState.tsx@@ -46,7 +46,7 @@ export function InboxEmptyState() {<Match when={!emailActive()}><EmptyStatePanelgraphic={EmptyStateInboxTrayGraphic}- title="Your inbox is empty"+ title="No notifications yet"description="Bring your inbox into Macro to triage signal from noise, reply faster, and let agents work alongside your mail."primaryAction={{label: 'Connect email',@@ -72,20 +72,11 @@ export function InboxEmptyState() {/></Match>- <Match when={state.tab === 'all'}>- <EmptyStatePanel- graphic={EmptyStateInboxTrayGraphic}- title="Inbox zero"- description="You're all caught up. New items will appear here as they arrive."- documentationUrl={`${DOCS_BASE}/product/inbox`}- />- </Match>-<Match when={true}><EmptyStatePanelgraphic={EmptyStateInboxTrayGraphic}- title="Inbox zero"- description="You're all caught up. Important items will appear here as they arrive."+ title="You're all caught up"+ description="Important items will appear here as they arrive."documentationUrl={`${DOCS_BASE}/product/inbox`}/></Match>diff --git a/apps/web/src/features/inbox-view/components/InboxHeader.tsx b/apps/web/src/features/inbox-view/components/InboxHeader.tsxindex 5ac3adadb8..b8021f5b4f 100644--- a/apps/web/src/features/inbox-view/components/InboxHeader.tsx+++ b/apps/web/src/features/inbox-view/components/InboxHeader.tsx@@ -17,7 +17,7 @@ export function InboxHeader(props: ParentProps) {<Show when={!isTouchDevice()}><div class="flex h-8 min-w-0 items-center"><h1 class="m-0 min-w-0 flex-1 truncate text-2xl font-semibold tracking-[-0.035em] text-ink">- Inbox+ Notifications</h1></div></Show>diff --git a/apps/web/src/features/inbox-view/components/InboxList.tsx b/apps/web/src/features/inbox-view/components/InboxList.tsxindex fd3ddf5bed..58c3e198f1 100644--- a/apps/web/src/features/inbox-view/components/InboxList.tsx+++ b/apps/web/src/features/inbox-view/components/InboxList.tsx@@ -67,7 +67,6 @@ import {type InboxDataSourceItem,useInboxDataSource,} from '../queries/use-inbox-query';-import { useInboxPreview } from '../use-inbox-preview';import { InboxDateGroupHeader } from './InboxDateGroupHeader';import { InboxEmptyState } from './InboxEmptyState';@@ -81,8 +80,12 @@ type InboxListActivationMetadata = {newSplit?: boolean;};-/** Compact Inbox-card list used by the Activity-layout Inbox workspace. */-export function InboxList() {+type InboxListProps = {+ onPreviewEntityChange: (entity: EntityData | undefined) => void;+};++/** Compact notification list used by the Notifications workspace. */+export function InboxList(props: InboxListProps) {const { state } = useInboxView();const panel = useSplitPanelOrThrow();const notificationSource = useGlobalNotificationSource();@@ -120,18 +123,6 @@ export function InboxList() {});});- const preview = useInboxPreview({- controller: list,- handle: panel.handle,- onPreview: (entity) => {- void openEntity(entity, {- newSplit: false,- replacePair: false,- mergeHistory: true,- });- },- });-const { buildActionGroups } = createSoupEntityActions();const entityActionViewContext = () =>resolveEntityActionViewContext({@@ -158,28 +149,38 @@ export function InboxList() {const newSplit =metadata?.newSplit === true || metadata?.event?.shiftKey === true;- preview.cancel();+ if (!isTouchDevice() && !newSplit) {+ showPreview(sourceRow.entity);+ return;+ }void openEntity(sourceRow.entity, {event: metadata?.event,newSplit,- replacePair: metadata?.event?.altKey === true && !newSplit,});}+ function markEntitySeen(entity: WithNotification<EntityData>) {+ markReminderSeenOnOpen(entity, notificationSource);+ if (!isNonMemberChannelEntity(entity)) {+ markChannelNotificationsSeenOnOpen(entity, notificationSource);+ }+ }++ function showPreview(entity: WithNotification<EntityData>) {+ markEntitySeen(entity);+ props.onPreviewEntityChange(entity);+ }+async function openEntity(entity: WithNotification<EntityData>,options: {event?: MouseEvent;newSplit: boolean;- replacePair: boolean;mergeHistory?: boolean;}) {- markReminderSeenOnOpen(entity, notificationSource);- if (!isNonMemberChannelEntity(entity)) {- markChannelNotificationsSeenOnOpen(entity, notificationSource);- }+ markEntitySeen(entity);const finishTouchHighlight = options.event? persistSoupNavigationTouchHighlight(options.event)@@ -188,7 +189,6 @@ export function InboxList() {try {await openEntityInSplitFromUnifiedList(entity, {openInNewSplit: options.newSplit,- replacePreview: options.replacePair,splitHandle: panel.handle,referredFrom: 'inbox',mergeHistory: options.mergeHistory,@@ -297,8 +297,8 @@ export function InboxList() {navigation: {onNavigate: (event) => {const row = event.result?.item;- if (row?.kind === 'entity') {- preview.request(row.entity);+ if (!isTouchDevice() && row?.kind === 'entity') {+ showPreview(row.entity);}if (event.kind !== 'move' || event.direction !== 1) return;@@ -386,10 +386,8 @@ export function InboxList() {if (nextTab === activeTab) return;activeTab = nextTab;- preview.cancel();listInteractions.selection.clear();list.focus.clear({ reason: 'programmatic' });- panel.handle.resetPreview();setPersistedListState((current) => ({ ...current, scrollOffset: 0 }));});@@ -399,20 +397,9 @@ export function InboxList() {if (list.focus.result()) return;- const restored = list.focus.restore(list.focus.requestedKey(), {+ list.focus.restore(list.focus.requestedKey(), {retainUnavailable: false,});- if (restored) return;- if (isTouchDevice()) return;- if (panel.handle.isControllerSplit()) {- panel.handle.resetPreview();- return;- }-- list.focus.first({- isNavigable: (row) => row.kind === 'entity',- reason: 'restore',- });});function checkNearEnd() {@@ -433,7 +420,7 @@ export function InboxList() {<divref={listRoot}role="grid"- aria-label="Inbox"+ aria-label="Notifications"aria-multiselectable="true"aria-activedescendant={list.focus.key()}tabIndex={0}@@ -471,7 +458,7 @@ export function InboxList() {><div class="grid min-h-0 flex-1 place-items-center text-ink-muted"><SpinnerIcon- aria-label="Loading inbox"+ aria-label="Loading notifications"class="size-5 animate-spin"/></div>@@ -482,7 +469,7 @@ export function InboxList() {ref={setEmptyViewport}class="flex min-h-0 flex-1 flex-col items-center justify-center gap-3 overflow-y-auto pb-[max(1rem,var(--mobile-content-inset-bottom,0px))] text-sm text-ink-muted">- <span>Inbox couldn’t be loaded.</span>+ <span>Notifications couldn’t be loaded.</span><Buttonvariant="outline"size="sm"diff --git a/apps/web/src/features/inbox-view/components/InboxTabs.tsx b/apps/web/src/features/inbox-view/components/InboxTabs.tsxindex 949ef1c9eb..7e0bbf793a 100644--- a/apps/web/src/features/inbox-view/components/InboxTabs.tsx+++ b/apps/web/src/features/inbox-view/components/InboxTabs.tsx@@ -11,7 +11,6 @@ import { InboxFilterDrawer, InboxFilterDropdown } from './InboxFilters';const INBOX_TABS: { value: InboxTab; label: string }[] = [{ value: 'signal', label: 'Signal' },{ value: 'noise', label: 'Noise' },- { value: 'all', label: 'All' },];const INBOX_TAB_IDS = INBOX_TABS.map((tab) => tab.value);@@ -41,7 +40,7 @@ export function InboxTabs() {fallback={<div class="flex h-8 min-w-0 flex-1 items-center gap-3"><Tabs- aria-label="Inbox views"+ aria-label="Notification views"list={INBOX_TABS}value={state.tab}onChange={handleTabChange}diff --git a/apps/web/src/features/inbox-view/inbox-view.tsx b/apps/web/src/features/inbox-view/inbox-view.tsxindex ad84371760..47d1634c0c 100644--- a/apps/web/src/features/inbox-view/inbox-view.tsx+++ b/apps/web/src/features/inbox-view/inbox-view.tsx@@ -1,11 +1,13 @@import { ViewShell } from '@app/components/view-shell';+import { useGlobalBlockOrchestrator } from '@components/app/GlobalAppState';+import { PreviewPanel } from '@components/app/PreviewPanel';import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';import { SplitPanel } from '@components/app/split-panel';import { StaticMarkdownContext } from '@core/component/LexicalMarkdown/component/core/StaticMarkdown';import { isTouchDevice } from '@core/mobile/isTouchDevice';-import { ListEntityMetadataQueryProvider } from '@entity';+import { type EntityData, ListEntityMetadataQueryProvider } from '@entity';import SpinnerIcon from '@phosphor/spinner.svg';-import { createEffect, onMount, Suspense } from 'solid-js';+import { createEffect, createSignal, onMount, Show, Suspense } from 'solid-js';import { InboxHeader } from './components/InboxHeader';import { InboxList } from './components/InboxList';import { InboxTabs } from './components/InboxTabs';@@ -20,14 +22,43 @@ export type InboxViewProps = {function InboxFallback() {return (<div class="grid min-h-0 min-w-0 flex-1 place-items-center text-ink-muted">- <SpinnerIcon aria-label="Loading inbox" class="size-5 animate-spin" />+ <SpinnerIcon+ aria-label="Loading notifications"+ class="size-5 animate-spin"+ /></div>);}+function NotificationsListPane(props: {+ onPreviewEntityChange: (entity: EntityData | undefined) => void;+}) {+ return (+ <>+ <InboxHeader>+ <InboxTabs />+ </InboxHeader>+ <Suspense fallback={<InboxFallback />}>+ <InboxList onPreviewEntityChange={props.onPreviewEntityChange} />+ </Suspense>+ </>+ );+}+function InboxViewRoot() {const panel = useSplitPanelOrThrow();+ const orchestrator = useGlobalBlockOrchestrator();const { state, setTab } = useInboxView();+ const [previewEntity, setPreviewEntity] = createSignal<EntityData>();++ let activeTab = state.tab;+ createEffect(() => {+ const nextTab = state.tab;+ if (nextTab === activeTab) return;++ activeTab = nextTab;+ setPreviewEntity(undefined);+ });createEffect(() => {if (state.tab !== 'reminders') return;@@ -35,27 +66,74 @@ function InboxViewRoot() {setTab('signal');});- onMount(() => panel.handle.setDisplayName('Inbox'));+ onMount(() => panel.handle.setDisplayName('Notifications'));return (<ListEntityMetadataQueryProvider><StaticMarkdownContext><SplitPanel.Root><SplitPanel.Body>- <ViewShell.Root- aside={false}- main={{ min: 224 }}- class={isTouchDevice() ? undefined : 'bg-inset'}+ <Show+ when={isTouchDevice()}+ fallback={+ <div class="size-full min-h-0 bg-panel">+ <ViewShell.Root+ aside={{+ width: 360,+ min: 300,+ max: 420,+ preserveDuringResize: false,+ }}+ breakpoints={{ collapsed: 0 }}+ layoutBreakpoint="collapsed"+ main={{ min: 224, preferredWidth: 640 }}+ resizable+ >+ <ViewShell.Aside class="flex flex-col border-r border-edge bg-panel">+ <NotificationsListPane+ onPreviewEntityChange={setPreviewEntity}+ />+ </ViewShell.Aside>+ <ViewShell.Main class="overflow-hidden">+ <Show+ when={previewEntity()}+ fallback={+ <div class="flex size-full items-center justify-center px-6 text-center">+ <div class="flex max-w-sm flex-col gap-2">+ <h2 class="text-base font-semibold text-ink">+ Select a notification+ </h2>+ <p class="text-sm leading-5 text-ink-muted">+ Choose an item from the sidebar to preview it+ here.+ </p>+ </div>+ </div>+ }+ >+ {(entity) => (+ <Suspense>+ <PreviewPanel+ selectedEntity={entity()}+ orchestrator={orchestrator}+ splitPanelContext={panel}+ />+ </Suspense>+ )}+ </Show>+ </ViewShell.Main>+ </ViewShell.Root>+ </div>+ }>- <ViewShell.Main>- <InboxHeader>- <InboxTabs />- </InboxHeader>- <Suspense fallback={<InboxFallback />}>- <InboxList />- </Suspense>- </ViewShell.Main>- </ViewShell.Root>+ <ViewShell.Root aside={false} main={{ min: 224 }}>+ <ViewShell.Main>+ <NotificationsListPane+ onPreviewEntityChange={setPreviewEntity}+ />+ </ViewShell.Main>+ </ViewShell.Root>+ </Show></SplitPanel.Body></SplitPanel.Root></StaticMarkdownContext>diff --git a/apps/web/src/features/inbox-view/persistence.ts b/apps/web/src/features/inbox-view/persistence.tsindex d6fa9a33b3..644761712e 100644--- a/apps/web/src/features/inbox-view/persistence.ts+++ b/apps/web/src/features/inbox-view/persistence.ts@@ -14,7 +14,7 @@ export const INBOX_LIST_ENTRY_STATE_KEY = 'inbox.listState';const inboxEntryStateSchemaWithDefaults = z.object({version: z.literal(1).default(1),- tab: z.enum(['signal', 'noise', 'all']).default('signal'),+ tab: z.enum(['signal', 'noise']).default('signal'),});type InboxEntryState = z.infer<typeof inboxEntryStateSchemaWithDefaults>;diff --git a/apps/web/src/features/inbox-view/queries/inbox-item-filter.test.ts b/apps/web/src/features/inbox-view/queries/inbox-item-filter.test.tsindex f737dacd15..3547f81d51 100644--- a/apps/web/src/features/inbox-view/queries/inbox-item-filter.test.ts+++ b/apps/web/src/features/inbox-view/queries/inbox-item-filter.test.ts@@ -60,13 +60,6 @@ describe('noise tab', () => {});});-describe('all tab', () => {- it('accepts emails of either importance', () => {- expect(soupItemMatchesInboxTab(noiseEmail, 'all')).toBe(true);- expect(soupItemMatchesInboxTab(signalEmail, 'all')).toBe(true);- });-});-describe('reminders tab', () => {it('accepts only reminders', () => {expect(soupItemMatchesInboxTab(reminderItem, 'reminders')).toBe(true);diff --git a/apps/web/src/features/inbox-view/queries/inbox-item-filter.ts b/apps/web/src/features/inbox-view/queries/inbox-item-filter.tsindex d4560e2811..3c93948926 100644--- a/apps/web/src/features/inbox-view/queries/inbox-item-filter.ts+++ b/apps/web/src/features/inbox-view/queries/inbox-item-filter.ts@@ -27,7 +27,6 @@ export function soupItemMatchesInboxTab('noise',() => item.tag === 'emailThread' && item.data.isSignal === false)- .with('all', () => true).with('reminders', () => item.tag === 'reminder').exhaustive();}diff --git a/apps/web/src/features/inbox-view/queries/inbox-query.ts b/apps/web/src/features/inbox-view/queries/inbox-query.tsindex cbd17603af..27a4bdaf8b 100644--- a/apps/web/src/features/inbox-view/queries/inbox-query.ts+++ b/apps/web/src/features/inbox-view/queries/inbox-query.ts@@ -23,10 +23,6 @@ export type InboxQueryCapabilities = {snippets: boolean;};-function visibleEntity(field: string): TargetExpr {- return clause.not(clause.eq(field, NIL_UUID));-}-function documentClause(expressions: TargetExpr[],capabilities: InboxQueryCapabilities@@ -107,29 +103,6 @@ function noiseClause(): FacetClause {});}-function allClause(- capabilities: InboxQueryCapabilities,- userId: string | undefined-): FacetClause {- const filters: FacetClause = {- df: documentClause([visibleEntity('documentId')], capabilities),- ef: visibleEntity('threadId'),- chanf: visibleEntity('channelId'),- cthf: clause.eq('channelThreadParticipantId', userId ?? NIL_UUID),- cf: visibleEntity('chatId'),- pf: visibleEntity('folderId'),- };-- if (capabilities.foreignEntities) {- filters.fef = clause.and(- clause.eq('foreignEntitySource', 'github_pull_request'),- clause.eq('foreignEntityIncludesMe', true)- );- }-- return confine(filters);-}-function remindersClause(): FacetClause {return confine({remf: clause.and(@@ -149,7 +122,6 @@ function tabClause(return match(tab).with('signal', () => signalClause(capabilities, now, userId)).with('noise', noiseClause)- .with('all', () => allClause(capabilities, userId)).with('reminders', remindersClause).exhaustive();}@@ -196,8 +168,6 @@ export function buildInboxQuery(if (context.tab === 'signal' || context.tab === 'noise') {body.emailView = 'inbox';- } else if (context.tab === 'all') {- body.emailView = 'all';}return {diff --git a/apps/web/src/features/inbox-view/queries/inbox-results.test.ts b/apps/web/src/features/inbox-view/queries/inbox-results.test.tsindex 155c9e2e01..4b8719a28b 100644--- a/apps/web/src/features/inbox-view/queries/inbox-results.test.ts+++ b/apps/web/src/features/inbox-view/queries/inbox-results.test.ts@@ -68,15 +68,13 @@ describe('inbox sort method per tab', () => {});it('keeps recency ordering on the other tabs', () => {- for (const tab of ['all', 'reminders'] as const) {- expect(buildInboxQuery({ ...context, tab }).params.sort_method).toBe(- 'updated_at'- );- }+ expect(+ buildInboxQuery({ ...context, tab: 'reminders' }).params.sort_method+ ).toBe('updated_at');});it('keeps recency ordering everywhere while the notified sort is off', () => {- for (const tab of ['signal', 'noise', 'all', 'reminders'] as const) {+ for (const tab of ['signal', 'noise', 'reminders'] as const) {expect(buildInboxQuery({ ...withoutNotifiedSort, tab }).params.sort_method).toBe('updated_at');@@ -103,13 +101,13 @@ describe('inbox date buckets', () => {expect(inboxGroupTimestamp(freshEmail, { tab: 'signal', capabilities })).toBe('2026-09-02T16:00:00Z');- const all = { tab: 'all' as const, capabilities };- expect(inboxGroupTimestamp(staleTaskFreshComment, all)).toBe(+ const reminders = { tab: 'reminders' as const, capabilities };+ expect(inboxGroupTimestamp(staleTaskFreshComment, reminders)).toBe('2026-08-31T19:00:00Z');const groups = groupInboxEntitiesByDate([freshEmail, staleTaskFreshComment],- all,+ reminders,now);expect(groups.map((group) => group.label)).toEqual([diff --git a/apps/web/src/features/inbox-view/queries/inbox-search.ts b/apps/web/src/features/inbox-view/queries/inbox-search.tsindex 6bfb564c89..4752676ea2 100644--- a/apps/web/src/features/inbox-view/queries/inbox-search.ts+++ b/apps/web/src/features/inbox-view/queries/inbox-search.ts@@ -24,15 +24,6 @@ const tabTypes: Record<InboxTab, ReadonlySet<InboxTypeFilter>> = {'calendar',]),noise: new Set(['email']),- all: new Set([- 'documents',- 'tasks',- 'email',- 'channels',- 'agents',- 'projects',- 'github',- ]),reminders: new Set(['reminders']),};diff --git a/apps/web/src/features/inbox-view/queries/use-inbox-query.ts b/apps/web/src/features/inbox-view/queries/use-inbox-query.tsindex a4e588104c..eb4e77c615 100644--- a/apps/web/src/features/inbox-view/queries/use-inbox-query.ts+++ b/apps/web/src/features/inbox-view/queries/use-inbox-query.ts@@ -30,7 +30,6 @@ import { startOfDay, subWeeks } from 'date-fns';import { createMemo } from 'solid-js';import { match } from 'ts-pattern';import {- explicitNoiseFilter,noiseFilter,signalFilter,} from '../../next-soup/filters/inbox-filters';@@ -94,7 +93,6 @@ function matchesTab();}).with('noise', () => noiseFilter(entity) && notDoneFilter(source)(entity))- .with('all', () => !explicitNoiseFilter(entity)).with('reminders', () => scheduledRemindersFilter(entity)).exhaustive();}diff --git a/apps/web/src/features/inbox-view/types.ts b/apps/web/src/features/inbox-view/types.tsindex d118e270d0..2f4f86ff72 100644--- a/apps/web/src/features/inbox-view/types.ts+++ b/apps/web/src/features/inbox-view/types.ts@@ -1,6 +1,6 @@import type { FacetSelection } from '@app/features/soup/filters/facets/types';-export type InboxTab = 'signal' | 'noise' | 'all' | 'reminders';+export type InboxTab = 'signal' | 'noise' | 'reminders';export type InboxGroupBy = 'date' | 'type' | 'none';diff --git a/apps/web/src/features/inbox-view/use-inbox-preview.ts b/apps/web/src/features/inbox-view/use-inbox-preview.tsdeleted file mode 100644index f6fb88fdfb..0000000000--- a/apps/web/src/features/inbox-view/use-inbox-preview.ts+++ /dev/null@@ -1,63 +0,0 @@-import type { ListController } from '@app/components/list';-import type { SplitHandle } from '@components/app/split-layout/layoutManager';-import type { EntityData } from '@entity/types/entity';-import type { WithNotification } from '@entity/types/notification';-import { debounce } from '@solid-primitives/scheduled';-import { createEffect, onCleanup } from 'solid-js';-import type { InboxDataSourceItem } from './queries/use-inbox-query';--export type InboxPreviewController = {- request: (entity: WithNotification<EntityData>) => void;- cancel: () => void;-};--export type UseInboxPreviewOptions = {- controller: Pick<ListController<InboxDataSourceItem>, 'focus'>;- handle: Pick<- SplitHandle,- 'canEngagePreview' | 'engagePreview' | 'isControllerSplit' | 'isViewerSplit'- >;- onPreview: (entity: WithNotification<EntityData>) => void;-};--export function useInboxPreview(- options: UseInboxPreviewOptions-): InboxPreviewController {- const openPreviewDebounced = debounce(- (entity: WithNotification<EntityData>) => {- if (!options.handle.isControllerSplit()) return;-- const row = options.controller.focus.result()?.item;- if (row?.kind !== 'entity' || row.entity.id !== entity.id) return;-- options.onPreview(entity);- },- 150- );- onCleanup(() => openPreviewDebounced.clear());-- let initialPreviewResolved = false;- createEffect(() => {- if (initialPreviewResolved) return;- if (options.handle.isViewerSplit()) {- initialPreviewResolved = true;- return;- }- if (!options.handle.canEngagePreview()) return;-- options.controller.focus.clear({ reason: 'programmatic' });- options.handle.engagePreview();- if (options.handle.isControllerSplit()) {- initialPreviewResolved = true;- }- });-- return {- request: (entity) => {- if (!options.handle.isControllerSplit()) return;-- openPreviewDebounced(entity);- },- cancel: openPreviewDebounced.clear,- };-}diff --git a/docs/AGENT_GUIDE/navigation.md b/docs/AGENT_GUIDE/navigation.mdindex 722880ff4b..4d64d915ed 100644--- a/docs/AGENT_GUIDE/navigation.md+++ b/docs/AGENT_GUIDE/navigation.md@@ -30,7 +30,7 @@ Splits: the app is a tiling window manager. A second pane appends its own segmen## Sidebar (a11y names are load-bearing)- Top: buttons `Search` and `Create`.-- Nav: `Go to Home`, `Go to Getting Started`, `Go to Inbox`, `Go to Recent`, `Go to Activity`.+- Nav: `Go to Home`, `Go to Getting Started`, `Go to Notifications`, `Go to Recent`, `Go to Activity`.- Workspace: `Go to Email`, `Go to Channels`, `Go to Calls`, `Go to Files`, `Go to Tasks`,`Go to Calendar`, `Go to Agents`, `Go to Customers`.- Then `Favorites` (pinned items) and `Latest` (recent channels/DMs with an `Unread` switch).diff --git a/docs/AGENT_GUIDE/surfaces.md b/docs/AGENT_GUIDE/surfaces.mdindex aa76133fd3..0f6105e1bd 100644--- a/docs/AGENT_GUIDE/surfaces.md+++ b/docs/AGENT_GUIDE/surfaces.md@@ -27,16 +27,15 @@ that entity's last operation in the batch. Emitted `SoupUpdated` items are non-nIf viewer-scoped hydration finds no item, the backend logs and omits that update;it does not imply deletion. Only explicit `GraphqlCacheDeletion` events remove records.-## Inbox — `/app/component/inbox`+## Notifications — `/app/component/inbox`Unified triage list (emails, channel messages, task assignments, doc mentions, agent-results). Filter radios: `Signal` (default, AI-filtered "needs attention") / `Noise` / `All`-/ `Reminders`; plus `Filter` menu and `Preview` toggle (split list + preview pane; the empty-preview shows "No content selected"). With the `enable-inbox-notified-sort` flag on, `Signal`-and `Noise` order rows (and their date headers) by when you were last notified about the-item, so a fresh comment on an old task sits under "Today"; with it off they order by-recency like `All` and `Reminders`. Keyboard: `j`/`k` move, `space` preview, `enter` open, `e` mark done.-Rows are buttons named `<channel> <sender>:<snippet> <time>`.+results). Tabs are `Signal` (default, AI-filtered "needs attention") and `Noise`, with a+Filter menu. On desktop, selecting a row renders its block in the inline preview beside+the notification sidebar. With the `enable-inbox-notified-sort` flag on, both tabs order+rows and date headers by when you were last notified about the item, so a fresh comment+on an old task sits under "Today"; with it off they order by content recency. Keyboard:+`j`/`k` move between rows and update the preview; alternate activation opens a new split.## Email — `/app/component/mail`