Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(notifications): use desktop wording for native permission prompt (#8368)

Eric Hayes1c79d10bc018
diff --git a/apps/web/AGENTS.md b/apps/web/AGENTS.md
index be7f0a6185..f72afcc35f 100644
--- a/apps/web/AGENTS.md
+++ b/apps/web/AGENTS.md
@@ -78,6 +78,8 @@ without changing the active route. Backend registration still verifies account
ownership. Cancel, logout, and the ten-minute timeout retire pending callbacks.
### General
+- Label the notification permission toast **Enable Desktop Notifications** in
+ the desktop app and keep its Enable action on the native notification provider.
- Keep signed-out Drive document routes on the shared detail viewer without
mounting private list/sidebar sources; let document access checks decide visibility.
- Gate account-only queries, comment readers, and account WebSockets on confirmed
diff --git a/apps/web/src/features/notifications/components/BrowserNotificationModal.tsx b/apps/web/src/features/notifications/components/BrowserNotificationModal.tsx
index a23e17c2d4..3a5adbbe20 100644
--- a/apps/web/src/features/notifications/components/BrowserNotificationModal.tsx
+++ b/apps/web/src/features/notifications/components/BrowserNotificationModal.tsx
@@ -38,7 +38,9 @@ function NotificationToastTrigger(props: {
onMount(() => {
const toastId = toast.custom(
{
- title: 'Enable Browser Notifications',
+ title: isPlatform('desktop')
+ ? 'Enable Desktop Notifications'
+ : 'Enable Browser Notifications',
icon: Bell,
color: 'var(--color-accent)',
content: () => (
diff --git a/docs/agent-guide/settings.md b/docs/agent-guide/settings.md
index dbdd34b428..ecf64d4504 100644
--- a/docs/agent-guide/settings.md
+++ b/docs/agent-guide/settings.md
@@ -76,6 +76,14 @@ With a composer open, save a changed signature or reply-signature preference and
verify its preview updates. Once the account refresh completes, reopen a composer
offline and confirm it uses the saved settings.
+### Notification permission prompt
+
+After onboarding, an eligible desktop app user sees **Enable Desktop
+Notifications**. Select **Enable** to request permission through the native
+notification provider; macOS uses its system permission dialog. The web prompt
+continues to say **Enable Browser Notifications** and uses browser permissions.
+Select **Hide** to dismiss the prompt.
+
### Notification snoozes
Open **Settings → Notifications** to see **Snoozed items** and their local resume