Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

feat(crm): move team CRM config into team_crm_settings with /crm/settings endpoints (#4995)

Evan Hutnik1f3064133c69
diff --git a/.sqlx/query-eaa347f84f5dbdaaf4afa3056a618956aab6be2b682414dab0ba8e50dbf65f00.json b/.sqlx/query-eaa347f84f5dbdaaf4afa3056a618956aab6be2b682414dab0ba8e50dbf65f00.json
new file mode 100644
index 0000000000..5cc7c43d47
--- /dev/null
+++ b/.sqlx/query-eaa347f84f5dbdaaf4afa3056a618956aab6be2b682414dab0ba8e50dbf65f00.json
@@ -0,0 +1,85 @@
+{
+ "db_name": "PostgreSQL",
+ "query": "\n SELECT edit_stages_role AS \"edit_stages_role: CrmPermissionRole\",\n move_closed_deals_role AS \"move_closed_deals_role: CrmPermissionRole\",\n delete_records_role AS \"delete_records_role: CrmPermissionRole\",\n closed_stage_ids,\n team_views,\n default_team_view_id\n FROM team_crm_settings\n WHERE team_id = $1\n ",
+ "describe": {
+ "columns": [
+ {
+ "ordinal": 0,
+ "name": "edit_stages_role: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 1,
+ "name": "move_closed_deals_role: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 2,
+ "name": "delete_records_role: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 3,
+ "name": "closed_stage_ids",
+ "type_info": "UuidArray"
+ },
+ {
+ "ordinal": 4,
+ "name": "team_views",
+ "type_info": "Jsonb"
+ },
+ {
+ "ordinal": 5,
+ "name": "default_team_view_id",
+ "type_info": "Text"
+ }
+ ],
+ "parameters": {
+ "Left": [
+ "Uuid"
+ ]
+ },
+ "nullable": [
+ false,
+ false,
+ false,
+ true,
+ false,
+ true
+ ]
+ },
+ "hash": "eaa347f84f5dbdaaf4afa3056a618956aab6be2b682414dab0ba8e50dbf65f00"
+}
diff --git a/.sqlx/query-ff405bc5e288a4914436b6811c883416459ce49e240e2eba19505303f06bec54.json b/.sqlx/query-ff405bc5e288a4914436b6811c883416459ce49e240e2eba19505303f06bec54.json
new file mode 100644
index 0000000000..fdada01d41
--- /dev/null
+++ b/.sqlx/query-ff405bc5e288a4914436b6811c883416459ce49e240e2eba19505303f06bec54.json
@@ -0,0 +1,93 @@
+{
+ "db_name": "PostgreSQL",
+ "query": "\n INSERT INTO team_crm_settings (\n team_id, edit_stages_role, move_closed_deals_role, delete_records_role,\n closed_stage_ids, team_views, default_team_view_id\n )\n VALUES (\n $1,\n COALESCE($2::text::team_role, 'admin'),\n COALESCE($3::text::team_role, 'admin'),\n COALESCE($4::text::team_role, 'admin'),\n CASE WHEN $5 THEN $6::uuid[] END,\n COALESCE($7, '[]'::jsonb),\n CASE WHEN $8 THEN $9 END\n )\n ON CONFLICT (team_id) DO UPDATE SET\n edit_stages_role = COALESCE($2::text::team_role, team_crm_settings.edit_stages_role),\n move_closed_deals_role = COALESCE($3::text::team_role, team_crm_settings.move_closed_deals_role),\n delete_records_role = COALESCE($4::text::team_role, team_crm_settings.delete_records_role),\n closed_stage_ids = CASE WHEN $5 THEN $6::uuid[] ELSE team_crm_settings.closed_stage_ids END,\n team_views = COALESCE($7, team_crm_settings.team_views),\n default_team_view_id = CASE WHEN $8 THEN $9 ELSE team_crm_settings.default_team_view_id END,\n updated_at = now()\n RETURNING\n edit_stages_role AS \"edit_stages_role!: CrmPermissionRole\",\n move_closed_deals_role AS \"move_closed_deals_role!: CrmPermissionRole\",\n delete_records_role AS \"delete_records_role!: CrmPermissionRole\",\n closed_stage_ids,\n team_views AS \"team_views!\",\n default_team_view_id\n ",
+ "describe": {
+ "columns": [
+ {
+ "ordinal": 0,
+ "name": "edit_stages_role!: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 1,
+ "name": "move_closed_deals_role!: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 2,
+ "name": "delete_records_role!: CrmPermissionRole",
+ "type_info": {
+ "Custom": {
+ "name": "team_role",
+ "kind": {
+ "Enum": [
+ "member",
+ "admin",
+ "owner"
+ ]
+ }
+ }
+ }
+ },
+ {
+ "ordinal": 3,
+ "name": "closed_stage_ids",
+ "type_info": "UuidArray"
+ },
+ {
+ "ordinal": 4,
+ "name": "team_views!",
+ "type_info": "Jsonb"
+ },
+ {
+ "ordinal": 5,
+ "name": "default_team_view_id",
+ "type_info": "Text"
+ }
+ ],
+ "parameters": {
+ "Left": [
+ "Uuid",
+ "Text",
+ "Text",
+ "Text",
+ "Bool",
+ "UuidArray",
+ "Jsonb",
+ "Bool",
+ "Text"
+ ]
+ },
+ "nullable": [
+ false,
+ false,
+ false,
+ true,
+ false,
+ true
+ ]
+ },
+ "hash": "ff405bc5e288a4914436b6811c883416459ce49e240e2eba19505303f06bec54"
+}
diff --git a/apps/web/src/features/companies/crm/saved-views.ts b/apps/web/src/features/companies/crm/saved-views.ts
index 82637843ed..ff56ee4f1b 100644
--- a/apps/web/src/features/companies/crm/saved-views.ts
+++ b/apps/web/src/features/companies/crm/saved-views.ts
@@ -207,12 +207,15 @@ export function useTeamCrmViews() {
const defaultView = () => views().find((view) => view.id === defaultViewId());
const setDefault = (id: string | undefined) => {
- update.mutate((current) => ({ ...current, defaultTeamViewId: id }), {
- onError: (error: Error) => {
- console.error('Failed to set default team view', error);
- toast.failure('Failed to set default team view');
- },
- });
+ update.mutate(
+ { defaultTeamViewId: id ?? null },
+ {
+ onError: (error: Error) => {
+ console.error('Failed to set default team view', error);
+ toast.failure('Failed to set default team view');
+ },
+ }
+ );
};
const add = (name: string, viewConfig: CrmViewConfig) => {
@@ -224,10 +227,9 @@ export function useTeamCrmViews() {
createdAt: new Date().toISOString(),
};
update.mutate(
- (current) => ({
- ...current,
- teamViews: [...(current.teamViews ?? []), view],
- }),
+ // Updater form: derives from the latest cache when the (serialized)
+ // mutation actually runs, so rapid saves don't drop each other.
+ { teamViews: (current) => [...current, view] },
{
onError: (error: Error) => {
console.error('Failed to save team view', error);
@@ -239,15 +241,13 @@ export function useTeamCrmViews() {
const remove = (id: string) => {
update.mutate(
- (current) => ({
- ...current,
- teamViews: (current.teamViews ?? []).filter((view) => view.id !== id),
+ {
+ teamViews: (current) => current.filter((view) => view.id !== id),
// A deleted view can't stay the team default.
- defaultTeamViewId:
- current.defaultTeamViewId === id
- ? undefined
- : current.defaultTeamViewId,
- }),
+ ...(config().defaultTeamViewId === id
+ ? { defaultTeamViewId: null }
+ : {}),
+ },
{
onError: (error: Error) => {
console.error('Failed to delete team view', error);
diff --git a/apps/web/src/features/companies/crm/team-crm-config.ts b/apps/web/src/features/companies/crm/team-crm-config.ts
index 8bfc0cf755..e5f9af0c2c 100644
--- a/apps/web/src/features/companies/crm/team-crm-config.ts
+++ b/apps/web/src/features/companies/crm/team-crm-config.ts
@@ -2,34 +2,26 @@
* Team-shared CRM configuration (permissions, closed-stage set, team saved
* views, display defaults).
*
- * There is no generic team key-value store yet, so the config rides on the
- * existing team-scoped property-definition infrastructure: a reserved
- * definition (`__macro:crm-config`) holds a single select option whose
- * string value is the JSON config. Every team member can read it (team
- * definitions are team-visible) and writes go through the existing option
- * endpoints. Reserved `__macro:`-prefixed definitions are filtered out of
- * property pickers (see `isReservedPropertyDefinitionName`).
+ * Stored on `team_crm_settings` and served by GET/PUT `/crm/settings`
+ * (document storage service). Any team member can read and can update
+ * the views fields (`teamViews`, `defaultTeamViewId`); the governance
+ * fields (permission thresholds, `closedStageIds`) are admin/owner-gated
+ * server-side. Updates are field-wise partial: omitted fields keep their
+ * current values, `null` clears the nullable ones, and `teamViews` is
+ * replaced whole (last write wins).
*/
import { useUserId } from '@core/context/user';
import { throwOnErr } from '@core/util/result';
-import { RESERVED_PROPERTY_DEFINITION_PREFIX } from '@property/constants';
-import { useListPropertiesQuery } from '@queries/properties/definitions';
import { useCurrentTeamQuery, useIsTeamAdmin } from '@queries/team/teams';
import { TeamRole } from '@service-auth/generated/schemas/teamRole';
-import { propertiesServiceClient } from '@service-properties/client';
-import type { PropertyDefinitionResponse } from '@service-properties/generated/schemas/propertyDefinitionResponse';
-import type { PropertyDefinitionWithOptions } from '@service-properties/generated/schemas/propertyDefinitionWithOptions';
-import { useMutation, useQueryClient } from '@tanstack/solid-query';
+import { storageServiceClient } from '@service-storage/client';
+import type { CrmTeamSettingsResponse } from '@service-storage/generated/schemas/crmTeamSettingsResponse';
+import type { UpdateCrmTeamSettingsRequest } from '@service-storage/generated/schemas/updateCrmTeamSettingsRequest';
+import { useMutation, useQuery, useQueryClient } from '@tanstack/solid-query';
import { type Accessor, createMemo } from 'solid-js';
-// Canonical home is `@property/constants`; re-exported for existing callers.
-export {
- isReservedPropertyDefinitionName,
- RESERVED_PROPERTY_DEFINITION_PREFIX,
-} from '@property/constants';
-
-const CRM_CONFIG_DEFINITION_NAME = `${RESERVED_PROPERTY_DEFINITION_PREFIX}crm-config`;
+const CRM_TEAM_SETTINGS_QUERY_KEY = ['crm', 'team-settings'] as const;
/**
* Minimum team role required for a CRM capability. Team members are
@@ -57,8 +49,7 @@ export type TeamCrmSavedView = {
};
export type TeamCrmConfig = {
- version: 1;
- permissions?: Partial<CrmPermissions>;
+ permissions?: CrmPermissions;
/**
* Stage option ids that count as "closed" deals (used by the
* move-closed-deals permission). When unset, stages labeled like
@@ -70,6 +61,24 @@ export type TeamCrmConfig = {
defaultTeamViewId?: string;
};
+/**
+ * Field-wise partial update of the shared config. Omitted fields keep
+ * their current values; `null` clears `closedStageIds` /
+ * `defaultTeamViewId`; `teamViews` replaces the whole list. Pass a
+ * function for `teamViews` to derive the new list from the latest
+ * cached value at execution time — mutations are serialized (shared
+ * scope), so queued updates see the previous write instead of a stale
+ * snapshot.
+ */
+export type TeamCrmConfigPatch = {
+ permissions?: Partial<CrmPermissions>;
+ closedStageIds?: string[] | null;
+ teamViews?:
+ | TeamCrmSavedView[]
+ | ((current: TeamCrmSavedView[]) => TeamCrmSavedView[]);
+ defaultTeamViewId?: string | null;
+};
+
export const DEFAULT_CRM_PERMISSIONS: CrmPermissions = {
editStages: 'admin',
moveClosedDeals: 'admin',
@@ -79,128 +88,72 @@ export const DEFAULT_CRM_PERMISSIONS: CrmPermissions = {
/** Labels treated as closed when no explicit closed set is configured. */
const DEFAULT_CLOSED_STAGE_LABEL = /customer|churned|closed|won|lost/i;
-function findConfigDefinition(
- definitions: PropertyDefinitionResponse[] | undefined
-): PropertyDefinitionWithOptions | undefined {
- return definitions?.find(
- (entry): entry is PropertyDefinitionWithOptions =>
- 'definition' in entry &&
- entry.definition.display_name === CRM_CONFIG_DEFINITION_NAME &&
- !entry.definition.is_system &&
- entry.definition.owner.scope === 'team'
- );
-}
-
-function parseConfig(definition: PropertyDefinitionWithOptions | undefined): {
- config: TeamCrmConfig;
- optionId?: string;
-} {
- const empty: TeamCrmConfig = { version: 1 };
- if (!definition) return { config: empty };
- const option = [...definition.property_options].sort(
- (a, b) => a.display_order - b.display_order
- )[0];
- const raw = option?.value;
- if (
- !raw ||
- typeof raw !== 'object' ||
- !('value' in raw) ||
- typeof raw.value !== 'string'
- ) {
- return { config: empty, optionId: option?.id };
- }
- try {
- const parsed = JSON.parse(raw.value) as TeamCrmConfig;
- return { config: { ...empty, ...parsed }, optionId: option?.id };
- } catch {
- return { config: empty, optionId: option?.id };
- }
-}
-
export function useTeamCrmConfig() {
const queryClient = useQueryClient();
- const teamDefinitionsQuery = useListPropertiesQuery(() => ({
- scope: 'team',
- includeOptions: true,
- }));
-
- const parsed = createMemo(() =>
- parseConfig(findConfigDefinition(teamDefinitionsQuery.data))
- );
- const config = createMemo(() => parsed().config);
+ const settingsQuery = useQuery(() => ({
+ queryKey: CRM_TEAM_SETTINGS_QUERY_KEY,
+ queryFn: async () =>
+ await throwOnErr(() => storageServiceClient.getCrmTeamSettings()),
+ }));
- const invalidate = () =>
- queryClient.invalidateQueries({
- predicate: ({ queryKey }) =>
- queryKey.includes('properties') && queryKey.includes('definitions'),
- });
+ const config = createMemo((): TeamCrmConfig => {
+ const data = settingsQuery.data;
+ if (!data) return {};
+ return {
+ permissions: {
+ editStages: data.edit_stages_role,
+ moveClosedDeals: data.move_closed_deals_role,
+ deleteRecords: data.delete_records_role,
+ },
+ closedStageIds: data.closed_stage_ids ?? undefined,
+ teamViews: (data.team_views as TeamCrmSavedView[]) ?? [],
+ defaultTeamViewId: data.default_team_view_id ?? undefined,
+ };
+ });
- /**
- * Read-modify-write of the shared config. Creates the reserved
- * definition/option on first write; concurrent writers are last-wins.
- */
const updateMutation = useMutation(() => ({
- mutationFn: async (updater: (current: TeamCrmConfig) => TeamCrmConfig) => {
- // Re-list right before writing to reduce lost updates.
- const definitions = await throwOnErr(
- async () =>
- await propertiesServiceClient.listProperties({
- scope: 'team',
- include_options: true,
- })
- );
- const existing = findConfigDefinition(definitions);
- const definitionId = existing
- ? existing.definition.id
- : (
- await throwOnErr(
- async () =>
- await propertiesServiceClient.createPropertyDefinition({
- body: {
- display_name: CRM_CONFIG_DEFINITION_NAME,
- data_type: {
- type: 'select_string',
- multi: false,
- options: [],
- },
- scope: 'team',
- },
- })
+ // Serialize updates: with whole-list team_views writes, concurrent
+ // PUTs would clobber each other. Scoped mutations run one at a time,
+ // and updater-style teamViews patches read the cache only once the
+ // previous mutation's response has been written back.
+ scope: { id: 'crm-team-settings' },
+ mutationFn: async (patch: TeamCrmConfigPatch) => {
+ const teamViews =
+ typeof patch.teamViews === 'function'
+ ? patch.teamViews(
+ (queryClient.getQueryData<CrmTeamSettingsResponse>(
+ CRM_TEAM_SETTINGS_QUERY_KEY
+ )?.team_views as TeamCrmSavedView[]) ?? []
)
- ).id;
- const { config: current, optionId } = parseConfig(existing);
- const next = updater(current);
- const serialized = JSON.stringify(next);
- if (optionId) {
- await throwOnErr(
- async () =>
- await propertiesServiceClient.updatePropertyOption({
- definition_id: definitionId,
- option_id: optionId,
- body: { value: serialized },
- })
- );
- } else {
- await throwOnErr(
- async () =>
- await propertiesServiceClient.addPropertyOption({
- definition_id: definitionId,
- body: {
- type: 'select_string',
- option: { value: serialized, display_order: 0 },
- },
- })
- );
- }
- return next;
+ : patch.teamViews;
+ const body: UpdateCrmTeamSettingsRequest = {
+ edit_stages_role: patch.permissions?.editStages,
+ move_closed_deals_role: patch.permissions?.moveClosedDeals,
+ delete_records_role: patch.permissions?.deleteRecords,
+ ...(patch.closedStageIds !== undefined
+ ? { closed_stage_ids: patch.closedStageIds }
+ : {}),
+ ...(teamViews !== undefined ? { team_views: teamViews } : {}),
+ ...(patch.defaultTeamViewId !== undefined
+ ? { default_team_view_id: patch.defaultTeamViewId }
+ : {}),
+ };
+ return await throwOnErr(() =>
+ storageServiceClient.updateCrmTeamSettings(body)
+ );
+ },
+ onSuccess: (settings) => {
+ // The PUT returns the resulting row — seed the cache with it.
+ queryClient.setQueryData(CRM_TEAM_SETTINGS_QUERY_KEY, settings);
},
- onSettled: () => invalidate(),
+ onSettled: () =>
+ queryClient.invalidateQueries({ queryKey: CRM_TEAM_SETTINGS_QUERY_KEY }),
}));
return {
config,
- isLoading: () => teamDefinitionsQuery.isLoading,
+ isLoading: () => settingsQuery.isLoading,
update: updateMutation,
};
}
diff --git a/apps/web/src/features/property/component/modal/SelectPropertyModal.tsx b/apps/web/src/features/property/component/modal/SelectPropertyModal.tsx
index 370d073e2a..baced88e88 100644
--- a/apps/web/src/features/property/component/modal/SelectPropertyModal.tsx
+++ b/apps/web/src/features/property/component/modal/SelectPropertyModal.tsx
@@ -3,10 +3,7 @@ import { ENABLE_CREATE_PROPERTY } from '@core/constant/featureFlags';
import { useListKeyBindings } from '@core/util/useListKeyBindings';
import PlusIcon from '@phosphor/plus.svg';
import LoadingSpinner from '@phosphor/spinner.svg';
-import {
- CRM_TEAM_STAGE_DEFINITION_NAME,
- isReservedPropertyDefinitionName,
-} from '@property/constants';
+import { CRM_TEAM_STAGE_DEFINITION_NAME } from '@property/constants';
import { useListPropertiesQuery } from '@queries/properties/definitions';
import { useAddEntityPropertyMutation } from '@queries/properties/entity';
import { useTagsQuery } from '@queries/properties/tags';
@@ -79,14 +76,12 @@ export function SelectPropertyModal(props: PropertySelectorProps) {
return toPropertyDefinitionDomain(item);
})
.filter(
- // Reserved internal definitions (`__macro:*` config carriers) and
- // the CRM-managed team Stage definition must never surface in
+ // The CRM-managed team Stage definition must never surface in
// property pickers. Tags have their own top-level sidepanel section
// and picker, so exclude the backing tag definitions here too. The
// value-type check covers the initial render before the tags query
// has returned definition ids.
(property) =>
- !isReservedPropertyDefinitionName(property.displayName) &&
property.valueType !== 'TAG' &&
!tagDefinitionIds.has(property.id) &&
!(
diff --git a/apps/web/src/features/property/constants.ts b/apps/web/src/features/property/constants.ts
index 0904ee6c28..f4f8a8a290 100644
--- a/apps/web/src/features/property/constants.ts
+++ b/apps/web/src/features/property/constants.ts
@@ -7,14 +7,6 @@ import type { BlockAlias, BlockName } from '@core/block';
export const NUMBER_DECIMAL_PLACES = 4;
-/** Prefix for internal, non-user-facing property definitions. */
-export const RESERVED_PROPERTY_DEFINITION_PREFIX = '__macro:';
-
-/** True for internal definitions that must not appear in property UIs. */
-export function isReservedPropertyDefinitionName(displayName: string): boolean {
- return displayName.startsWith(RESERVED_PROPERTY_DEFINITION_PREFIX);
-}
-
/**
* Reserved display name of the team-scoped CRM deal-stage definition
* (unique per team). Managed exclusively from CRM settings, so generic
diff --git a/apps/web/src/features/property/side-panel/properties/EntityPropertiesSection.tsx b/apps/web/src/features/property/side-panel/properties/EntityPropertiesSection.tsx
index 3340e06430..fcdec1e781 100644
--- a/apps/web/src/features/property/side-panel/properties/EntityPropertiesSection.tsx
+++ b/apps/web/src/features/property/side-panel/properties/EntityPropertiesSection.tsx
@@ -1,5 +1,4 @@
import { useFeatureFlag } from '@app/lib/analytics/posthog';
-import { isReservedPropertyDefinitionName } from '@companies/crm/team-crm-config';
import { SidePanel } from '@components/app/side-panel/SidePanel';
import type { BlockAlias, BlockName } from '@core/block';
import { PopupPreview } from '@core/component/DocumentPreview';
@@ -135,14 +134,12 @@ export function EntityPropertiesSection(props: EntityPropertiesSectionProps) {
);
// Fetched properties merged with any default placeholders whose
- // definition the entity doesn't carry yet. Hidden definitions and
- // reserved internal definitions (`__macro:*`) are dropped first.
+ // definition the entity doesn't carry yet. Hidden definitions are
+ // dropped first.
const mergedProperties = createMemo(() => {
const hiddenDefinitionIds = new Set(props.hidePropertyDefinitionIds ?? []);
const fetched = properties().filter(
- (property) =>
- !hiddenDefinitionIds.has(property.propertyDefinitionId) &&
- !isReservedPropertyDefinitionName(property.displayName)
+ (property) => !hiddenDefinitionIds.has(property.propertyDefinitionId)
);
const defaults = props.defaultProperties?.() ?? [];
if (defaults.length === 0) return fetched;
diff --git a/apps/web/src/lib/service-clients/service-storage/client.ts b/apps/web/src/lib/service-clients/service-storage/client.ts
index 1c4fc9bec4..9c08d490a8 100644
--- a/apps/web/src/lib/service-clients/service-storage/client.ts
+++ b/apps/web/src/lib/service-clients/service-storage/client.ts
@@ -93,6 +93,7 @@ import type { CrmCommentEntityType } from './generated/schemas/crmCommentEntityT
import type { CrmCommentThread } from './generated/schemas/crmCommentThread';
import type { CrmCompanyResponse } from './generated/schemas/crmCompanyResponse';
import type { CrmContactResponse } from './generated/schemas/crmContactResponse';
+import type { CrmTeamSettingsResponse } from './generated/schemas/crmTeamSettingsResponse';
import type { DeleteCommentResponse } from './generated/schemas/deleteCommentResponse';
import type { DeleteCrmCommentResult } from './generated/schemas/deleteCrmCommentResult';
import type { DeleteEntityMentionResponse } from './generated/schemas/deleteEntityMentionResponse';
@@ -140,6 +141,7 @@ import type { SharePermissionV2 } from './generated/schemas/sharePermissionV2';
import type { SyncServiceVersionID } from './generated/schemas/syncServiceVersionID';
import type { ThreadResponse } from './generated/schemas/threadResponse';
import type { TypedSuccessResponse } from './generated/schemas/typedSuccessResponse';
+import type { UpdateCrmTeamSettingsRequest } from './generated/schemas/updateCrmTeamSettingsRequest';
import type { UploadExtractFolderHandler200 } from './generated/schemas/uploadExtractFolderHandler200';
import type { UserPinsResponse } from './generated/schemas/userPinsResponse';
import type { UserViewsResponse } from './generated/schemas/userViewsResponse';
@@ -2327,6 +2329,17 @@ export const storageServiceClient = {
body: JSON.stringify({ email_sync: emailSync }),
});
},
+ async getCrmTeamSettings() {
+ return await dssFetch<CrmTeamSettingsResponse>('/crm/settings', {
+ method: 'GET',
+ });
+ },
+ async updateCrmTeamSettings(body: UpdateCrmTeamSettingsRequest) {
+ return await dssFetch<CrmTeamSettingsResponse>('/crm/settings', {
+ method: 'PUT',
+ body: JSON.stringify(body),
+ });
+ },
crmComments: {
async list({
entityType,
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmPermissionRole.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmPermissionRole.ts
new file mode 100644
index 0000000000..28fc387227
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmPermissionRole.ts
@@ -0,0 +1,21 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+/**
+ * Minimum team role required for a CRM capability. Members are
+view-only at the platform level, so the configurable range is
+admin (default) vs owner. Maps to the `team_role` Postgres enum;
+`member` is deliberately not representable.
+ */
+export type CrmPermissionRole =
+ (typeof CrmPermissionRole)[keyof typeof CrmPermissionRole];
+
+// eslint-disable-next-line @typescript-eslint/no-redeclare
+export const CrmPermissionRole = {
+ admin: 'admin',
+ owner: 'owner',
+} as const;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponse.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponse.ts
new file mode 100644
index 0000000000..38c1278853
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponse.ts
@@ -0,0 +1,31 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+import type { CrmPermissionRole } from './crmPermissionRole';
+import type { CrmTeamSettingsResponseClosedStageIds } from './crmTeamSettingsResponseClosedStageIds';
+import type { CrmTeamSettingsResponseDefaultTeamViewId } from './crmTeamSettingsResponseDefaultTeamViewId';
+
+/**
+ * The team's CRM configuration (everything on `team_crm_settings`
+except the `crm_enabled` killswitch, which is managed via
+`PATCH /team/crm` on the auth service).
+ */
+export interface CrmTeamSettingsResponse {
+ /** Stage option ids counting as closed deals; absent = the client
+falls back to its label heuristic. */
+ closed_stage_ids?: CrmTeamSettingsResponseClosedStageIds;
+ /** Team view applied by default when a member opens the CRM view. */
+ default_team_view_id?: CrmTeamSettingsResponseDefaultTeamViewId;
+ /** Who can delete (hide) CRM records. */
+ delete_records_role: CrmPermissionRole;
+ /** Who can change the deal stage set in CRM settings. */
+ edit_stages_role: CrmPermissionRole;
+ /** Who can move deals out of a closed stage. */
+ move_closed_deals_role: CrmPermissionRole;
+ /** Team saved views — an opaque JSON array owned by the frontend. */
+ team_views: unknown;
+}
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseClosedStageIds.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseClosedStageIds.ts
new file mode 100644
index 0000000000..f69e054e71
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseClosedStageIds.ts
@@ -0,0 +1,12 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+/**
+ * Stage option ids counting as closed deals; absent = the client
+falls back to its label heuristic.
+ */
+export type CrmTeamSettingsResponseClosedStageIds = string[] | null;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseDefaultTeamViewId.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseDefaultTeamViewId.ts
new file mode 100644
index 0000000000..d98fdde637
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/crmTeamSettingsResponseDefaultTeamViewId.ts
@@ -0,0 +1,11 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+/**
+ * Team view applied by default when a member opens the CRM view.
+ */
+export type CrmTeamSettingsResponseDefaultTeamViewId = string | null;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/index.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/index.ts
index 914979f853..fa683e327a 100644
--- a/apps/web/src/lib/service-clients/service-storage/generated/schemas/index.ts
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/index.ts
@@ -338,6 +338,10 @@ export * from './crmCompanyResponseName';
export * from './crmContactResponse';
export * from './crmContactResponseName';
export * from './crmDomainResponse';
+export * from './crmPermissionRole';
+export * from './crmTeamSettingsResponse';
+export * from './crmTeamSettingsResponseClosedStageIds';
+export * from './crmTeamSettingsResponseDefaultTeamViewId';
export * from './crmThread';
export * from './crmThreadDeletedAt';
export * from './customSpeakerAssignment';
@@ -994,6 +998,12 @@ export * from './unthreadedPdfUuidRequestOneOf';
export * from './unthreadedPdfUuidRequestOneOfAttachmentType';
export * from './updateChannelSharePermission';
export * from './updateChannelSharePermissionAccessLevel';
+export * from './updateCrmTeamSettingsRequest';
+export * from './updateCrmTeamSettingsRequestClosedStageIds';
+export * from './updateCrmTeamSettingsRequestDefaultTeamViewId';
+export * from './updateCrmTeamSettingsRequestDeleteRecordsRole';
+export * from './updateCrmTeamSettingsRequestEditStagesRole';
+export * from './updateCrmTeamSettingsRequestMoveClosedDealsRole';
export * from './updateOperation';
export * from './updateSharePermissionRequestV2';
export * from './updateSharePermissionRequestV2ChannelSharePermissions';
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequest.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequest.ts
new file mode 100644
index 0000000000..ad185f81c1
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequest.ts
@@ -0,0 +1,29 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+import type { UpdateCrmTeamSettingsRequestClosedStageIds } from './updateCrmTeamSettingsRequestClosedStageIds';
+import type { UpdateCrmTeamSettingsRequestDefaultTeamViewId } from './updateCrmTeamSettingsRequestDefaultTeamViewId';
+import type { UpdateCrmTeamSettingsRequestDeleteRecordsRole } from './updateCrmTeamSettingsRequestDeleteRecordsRole';
+import type { UpdateCrmTeamSettingsRequestEditStagesRole } from './updateCrmTeamSettingsRequestEditStagesRole';
+import type { UpdateCrmTeamSettingsRequestMoveClosedDealsRole } from './updateCrmTeamSettingsRequestMoveClosedDealsRole';
+
+/**
+ * Request body for `PUT /crm/settings`. Every field is optional:
+omitted fields keep their current values.
+ */
+export interface UpdateCrmTeamSettingsRequest {
+ /** New closed-stage set. Omit to keep the current value; pass
+`null` to clear it (falling back to the client label heuristic). */
+ closed_stage_ids?: UpdateCrmTeamSettingsRequestClosedStageIds;
+ /** New default team view id. Omit to keep the current value; pass
+`null` to clear it. */
+ default_team_view_id?: UpdateCrmTeamSettingsRequestDefaultTeamViewId;
+ delete_records_role?: UpdateCrmTeamSettingsRequestDeleteRecordsRole;
+ edit_stages_role?: UpdateCrmTeamSettingsRequestEditStagesRole;
+ move_closed_deals_role?: UpdateCrmTeamSettingsRequestMoveClosedDealsRole;
+ /** Replacement team-views array (whole-blob, last write wins). */
+ team_views?: unknown;
+}
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestClosedStageIds.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestClosedStageIds.ts
new file mode 100644
index 0000000000..22fc0016c8
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestClosedStageIds.ts
@@ -0,0 +1,12 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+/**
+ * New closed-stage set. Omit to keep the current value; pass
+`null` to clear it (falling back to the client label heuristic).
+ */
+export type UpdateCrmTeamSettingsRequestClosedStageIds = string[] | null;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDefaultTeamViewId.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDefaultTeamViewId.ts
new file mode 100644
index 0000000000..8312444fe3
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDefaultTeamViewId.ts
@@ -0,0 +1,12 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+
+/**
+ * New default team view id. Omit to keep the current value; pass
+`null` to clear it.
+ */
+export type UpdateCrmTeamSettingsRequestDefaultTeamViewId = string | null;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDeleteRecordsRole.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDeleteRecordsRole.ts
new file mode 100644
index 0000000000..b489acaa76
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestDeleteRecordsRole.ts
@@ -0,0 +1,10 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+import type { CrmPermissionRole } from './crmPermissionRole';
+
+export type UpdateCrmTeamSettingsRequestDeleteRecordsRole =
+ null | CrmPermissionRole;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestEditStagesRole.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestEditStagesRole.ts
new file mode 100644
index 0000000000..11d6f59fef
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestEditStagesRole.ts
@@ -0,0 +1,10 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+import type { CrmPermissionRole } from './crmPermissionRole';
+
+export type UpdateCrmTeamSettingsRequestEditStagesRole =
+ null | CrmPermissionRole;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestMoveClosedDealsRole.ts b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestMoveClosedDealsRole.ts
new file mode 100644
index 0000000000..427e6645e0
--- /dev/null
+++ b/apps/web/src/lib/service-clients/service-storage/generated/schemas/updateCrmTeamSettingsRequestMoveClosedDealsRole.ts
@@ -0,0 +1,10 @@
+/**
+ * Generated by orval v7.21.0 🍺
+ * Do not edit manually.
+ * document_storage_service
+ * OpenAPI spec version: 0.1.0
+ */
+import type { CrmPermissionRole } from './crmPermissionRole';
+
+export type UpdateCrmTeamSettingsRequestMoveClosedDealsRole =
+ null | CrmPermissionRole;
diff --git a/apps/web/src/lib/service-clients/service-storage/generated/zod.ts b/apps/web/src/lib/service-clients/service-storage/generated/zod.ts
index fe577f1eee..676f695b7d 100644
--- a/apps/web/src/lib/service-clients/service-storage/generated/zod.ts
+++ b/apps/web/src/lib/service-clients/service-storage/generated/zod.ts
@@ -3424,6 +3424,149 @@ export const setContactHiddenBody = zod
})
.describe('Request body for `PUT \/contacts\/{contact_id}\/hidden`.');
+/**
+ * @summary Read the caller's team CRM configuration. Any team member may read;
+teams without a settings row get the defaults.
+ */
+export const getCrmTeamSettingsResponse = zod
+ .object({
+ closed_stage_ids: zod
+ .array(zod.uuid())
+ .nullish()
+ .describe(
+ 'Stage option ids counting as closed deals; absent = the client\nfalls back to its label heuristic.'
+ ),
+ default_team_view_id: zod
+ .string()
+ .nullish()
+ .describe(
+ 'Team view applied by default when a member opens the CRM view.'
+ ),
+ delete_records_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ edit_stages_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ move_closed_deals_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ team_views: zod
+ .unknown()
+ .describe(
+ 'Team saved views — an opaque JSON array owned by the frontend.'
+ ),
+ })
+ .describe(
+ "The team's CRM configuration (everything on `team_crm_settings`\nexcept the `crm_enabled` killswitch, which is managed via\n`PATCH \/team\/crm` on the auth service)."
+ );
+
+/**
+ * @summary Partially update the caller's team CRM configuration. Any team
+member may update the views fields (`team_views`,
+`default_team_view_id`); the governance fields (permission
+thresholds, `closed_stage_ids`) require an admin/owner team role
+(403 otherwise). Omitted fields keep their current values;
+`team_views` is replaced whole. Returns the resulting settings.
+ */
+export const putCrmTeamSettingsBody = zod
+ .object({
+ closed_stage_ids: zod
+ .array(zod.uuid())
+ .nullish()
+ .describe(
+ 'New closed-stage set. Omit to keep the current value; pass\n`null` to clear it (falling back to the client label heuristic).'
+ ),
+ default_team_view_id: zod
+ .string()
+ .nullish()
+ .describe(
+ 'New default team view id. Omit to keep the current value; pass\n`null` to clear it.'
+ ),
+ delete_records_role: zod
+ .union([
+ zod.null(),
+ zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ ])
+ .optional(),
+ edit_stages_role: zod
+ .union([
+ zod.null(),
+ zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ ])
+ .optional(),
+ move_closed_deals_role: zod
+ .union([
+ zod.null(),
+ zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ ])
+ .optional(),
+ team_views: zod
+ .unknown()
+ .optional()
+ .describe('Replacement team-views array (whole-blob, last write wins).'),
+ })
+ .describe(
+ 'Request body for `PUT \/crm\/settings`. Every field is optional:\nomitted fields keep their current values.'
+ );
+
+export const putCrmTeamSettingsResponse = zod
+ .object({
+ closed_stage_ids: zod
+ .array(zod.uuid())
+ .nullish()
+ .describe(
+ 'Stage option ids counting as closed deals; absent = the client\nfalls back to its label heuristic.'
+ ),
+ default_team_view_id: zod
+ .string()
+ .nullish()
+ .describe(
+ 'Team view applied by default when a member opens the CRM view.'
+ ),
+ delete_records_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ edit_stages_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ move_closed_deals_role: zod
+ .enum(['admin', 'owner'])
+ .describe(
+ 'Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.'
+ ),
+ team_views: zod
+ .unknown()
+ .describe(
+ 'Team saved views — an opaque JSON array owned by the frontend.'
+ ),
+ })
+ .describe(
+ "The team's CRM configuration (everything on `team_crm_settings`\nexcept the `crm_enabled` killswitch, which is managed via\n`PATCH \/team\/crm` on the auth service)."
+ );
+
/**
* @summary Gets the users documents to populate their recent document list
*/
diff --git a/apps/web/src/lib/service-clients/service-storage/openapi.json b/apps/web/src/lib/service-clients/service-storage/openapi.json
index 762db33cb1..7ac4e45249 100644
--- a/apps/web/src/lib/service-clients/service-storage/openapi.json
+++ b/apps/web/src/lib/service-clients/service-storage/openapi.json
@@ -4625,6 +4625,112 @@
}
}
},
+ "/crm/settings": {
+ "get": {
+ "tags": ["crm::inbound::axum_router::team_settings"],
+ "summary": "Read the caller's team CRM configuration. Any team member may read;\nteams without a settings row get the defaults.",
+ "operationId": "get_crm_team_settings",
+ "responses": {
+ "200": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/CrmTeamSettingsResponse"
+ }
+ }
+ }
+ },
+ "401": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ },
+ "500": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ }
+ }
+ },
+ "put": {
+ "tags": ["crm::inbound::axum_router::team_settings"],
+ "summary": "Partially update the caller's team CRM configuration. Any team\nmember may update the views fields (`team_views`,\n`default_team_view_id`); the governance fields (permission\nthresholds, `closed_stage_ids`) require an admin/owner team role\n(403 otherwise). Omitted fields keep their current values;\n`team_views` is replaced whole. Returns the resulting settings.",
+ "operationId": "put_crm_team_settings",
+ "requestBody": {
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/UpdateCrmTeamSettingsRequest"
+ }
+ }
+ },
+ "required": true
+ },
+ "responses": {
+ "200": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/CrmTeamSettingsResponse"
+ }
+ }
+ }
+ },
+ "400": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ },
+ "401": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ },
+ "403": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ },
+ "500": {
+ "description": "",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/ErrorResponse"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
"/documents": {
"get": {
"tags": ["document"],
@@ -13159,6 +13265,50 @@
}
}
},
+ "CrmPermissionRole": {
+ "type": "string",
+ "description": "Minimum team role required for a CRM capability. Members are\nview-only at the platform level, so the configurable range is\nadmin (default) vs owner. Maps to the `team_role` Postgres enum;\n`member` is deliberately not representable.",
+ "enum": ["admin", "owner"]
+ },
+ "CrmTeamSettingsResponse": {
+ "type": "object",
+ "description": "The team's CRM configuration (everything on `team_crm_settings`\nexcept the `crm_enabled` killswitch, which is managed via\n`PATCH /team/crm` on the auth service).",
+ "required": [
+ "edit_stages_role",
+ "move_closed_deals_role",
+ "delete_records_role",
+ "team_views"
+ ],
+ "properties": {
+ "closed_stage_ids": {
+ "type": ["array", "null"],
+ "items": {
+ "type": "string",
+ "format": "uuid"
+ },
+ "description": "Stage option ids counting as closed deals; absent = the client\nfalls back to its label heuristic."
+ },
+ "default_team_view_id": {
+ "type": ["string", "null"],
+ "description": "Team view applied by default when a member opens the CRM view."
+ },
+ "delete_records_role": {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "Who can delete (hide) CRM records."
+ },
+ "edit_stages_role": {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "Who can change the deal stage set in CRM settings."
+ },
+ "move_closed_deals_role": {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "Who can move deals out of a closed stage."
+ },
+ "team_views": {
+ "description": "Team saved views — an opaque JSON array owned by the frontend."
+ }
+ }
+ },
"CrmThread": {
"type": "object",
"description": "A CRM comment thread: the parent record one or more comments hang off.",
@@ -19837,6 +19987,60 @@
}
}
},
+ "UpdateCrmTeamSettingsRequest": {
+ "type": "object",
+ "description": "Request body for `PUT /crm/settings`. Every field is optional:\nomitted fields keep their current values.",
+ "properties": {
+ "closed_stage_ids": {
+ "type": ["array", "null"],
+ "items": {
+ "type": "string",
+ "format": "uuid"
+ },
+ "description": "New closed-stage set. Omit to keep the current value; pass\n`null` to clear it (falling back to the client label heuristic)."
+ },
+ "default_team_view_id": {
+ "type": ["string", "null"],
+ "description": "New default team view id. Omit to keep the current value; pass\n`null` to clear it."
+ },
+ "delete_records_role": {
+ "oneOf": [
+ {
+ "type": "null"
+ },
+ {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "New `delete_records_role`, if provided."
+ }
+ ]
+ },
+ "edit_stages_role": {
+ "oneOf": [
+ {
+ "type": "null"
+ },
+ {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "New `edit_stages_role`, if provided."
+ }
+ ]
+ },
+ "move_closed_deals_role": {
+ "oneOf": [
+ {
+ "type": "null"
+ },
+ {
+ "$ref": "#/components/schemas/CrmPermissionRole",
+ "description": "New `move_closed_deals_role`, if provided."
+ }
+ ]
+ },
+ "team_views": {
+ "description": "Replacement team-views array (whole-blob, last write wins)."
+ }
+ }
+ },
"UpdateOperation": {
"type": "string",
"enum": ["add", "remove", "replace"]
diff --git a/crates/crm/src/domain/auth.rs b/crates/crm/src/domain/auth.rs
index 66974f45f5..81e6de1dce 100644
--- a/crates/crm/src/domain/auth.rs
+++ b/crates/crm/src/domain/auth.rs
@@ -193,6 +193,13 @@ impl<T: RequiredPermission> CrmTeamReceipt<T> {
/// Derived from the receipt's actual team role, so the service — not
/// the caller — enforces the hidden gate.
pub(crate) fn include_hidden(&self) -> bool {
+ self.has_admin_role()
+ }
+
+ /// Whether the caller's actual team role is admin/owner. Used by the
+ /// service to gate admin-only mutations that share an endpoint with
+ /// member-level ones (e.g. the governance fields of team settings).
+ pub(crate) fn has_admin_role(&self) -> bool {
self.receipt
.entity_permission()
.allows_team_role(entity_access::domain::models::TeamRole::Admin)
diff --git a/crates/crm/src/domain/companies_repo.rs b/crates/crm/src/domain/companies_repo.rs
index 90ff74eb49..c8ef3349ad 100644
--- a/crates/crm/src/domain/companies_repo.rs
+++ b/crates/crm/src/domain/companies_repo.rs
@@ -5,7 +5,7 @@ use crate::domain::comment::{
};
use crate::domain::model::{
CrmCompanyForSoup, CrmCompanyWithContacts, CrmContact, CrmError, CrmScopePrecheck,
- DomainMetadata,
+ CrmTeamSettings, CrmTeamSettingsPatch, DomainMetadata,
};
use chrono::{DateTime, Utc};
use serde_json::Value;
@@ -488,4 +488,21 @@ pub trait CompaniesRepository: Clone + Send + Sync + 'static {
&self,
comment_id: &uuid::Uuid,
) -> impl Future<Output = Result<Option<(CrmCommentEntityType, uuid::Uuid)>, CrmError>> + Send;
+
+ /// Read the team's CRM configuration from `team_crm_settings`.
+ /// A missing row yields [`CrmTeamSettings::default`].
+ fn get_team_settings(
+ &self,
+ team_id: &uuid::Uuid,
+ ) -> impl Future<Output = Result<CrmTeamSettings, CrmError>> + Send;
+
+ /// Field-wise partial upsert of the team's CRM configuration.
+ /// Unprovided fields keep their current values (or column defaults
+ /// on insert); `team_views` is replaced whole. Never touches
+ /// `crm_enabled`. Returns the resulting row.
+ fn update_team_settings(
+ &self,
+ team_id: &uuid::Uuid,
+ patch: &CrmTeamSettingsPatch,
+ ) -> impl Future<Output = Result<CrmTeamSettings, CrmError>> + Send;
}
diff --git a/crates/crm/src/domain/model.rs b/crates/crm/src/domain/model.rs
index 8b3d17011e..077aba067b 100644
--- a/crates/crm/src/domain/model.rs
+++ b/crates/crm/src/domain/model.rs
@@ -240,6 +240,88 @@ pub struct CrmAddressStatus {
pub email_sync: bool,
}
+/// Minimum team role required for a CRM capability. Members are
+/// view-only at the platform level, so the configurable range is
+/// admin (default) vs owner. Maps to the `team_role` Postgres enum;
+/// `member` is deliberately not representable.
+#[derive(Debug, Clone, Copy, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
+#[serde(rename_all = "lowercase")]
+#[cfg_attr(feature = "outbound", derive(sqlx::Type))]
+#[cfg_attr(
+ feature = "outbound",
+ sqlx(type_name = "team_role", rename_all = "lowercase")
+)]
+#[cfg_attr(feature = "axum", derive(utoipa::ToSchema))]
+pub enum CrmPermissionRole {
+ /// Team admins and owners.
+ Admin,
+ /// Team owners only.
+ Owner,
+}
+
+impl CrmPermissionRole {
+ /// The `team_role` enum literal for SQL binds (queries bind text and
+ /// cast with `::team_role`).
+ pub fn as_db_str(&self) -> &'static str {
+ match self {
+ CrmPermissionRole::Admin => "admin",
+ CrmPermissionRole::Owner => "owner",
+ }
+ }
+}
+
+/// Team-level CRM configuration stored on `team_crm_settings`
+/// (everything except the `crm_enabled` killswitch, which stays owned
+/// by the teams crate).
+#[derive(Debug, Clone)]
+pub struct CrmTeamSettings {
+ /// Who can change the deal stage set in CRM settings.
+ pub edit_stages_role: CrmPermissionRole,
+ /// Who can move deals out of a closed stage.
+ pub move_closed_deals_role: CrmPermissionRole,
+ /// Who can delete (hide) CRM records.
+ pub delete_records_role: CrmPermissionRole,
+ /// Stage option ids counting as closed deals; `None` = the client
+ /// falls back to its label heuristic.
+ pub closed_stage_ids: Option<Vec<uuid::Uuid>>,
+ /// Team saved views — an opaque JSON array owned by the frontend.
+ pub team_views: Value,
+ /// Team view applied by default when a member opens the CRM view.
+ pub default_team_view_id: Option<String>,
+}
+
+impl Default for CrmTeamSettings {
+ fn default() -> Self {
+ Self {
+ edit_stages_role: CrmPermissionRole::Admin,
+ move_closed_deals_role: CrmPermissionRole::Admin,
+ delete_records_role: CrmPermissionRole::Admin,
+ closed_stage_ids: None,
+ team_views: Value::Array(Vec::new()),
+ default_team_view_id: None,
+ }
+ }
+}
+
+/// Field-wise partial update of [`CrmTeamSettings`]. Outer `None` =
+/// leave the column unchanged; for the two nullable columns the inner
+/// `None` clears the value. `team_views` is replaced whole (last-wins).
+#[derive(Debug, Clone, Default)]
+pub struct CrmTeamSettingsPatch {
+ /// New `edit_stages_role`, if provided.
+ pub edit_stages_role: Option<CrmPermissionRole>,
+ /// New `move_closed_deals_role`, if provided.
+ pub move_closed_deals_role: Option<CrmPermissionRole>,
+ /// New `delete_records_role`, if provided.
+ pub delete_records_role: Option<CrmPermissionRole>,
+ /// New `closed_stage_ids`; `Some(None)` clears to the heuristic.
+ pub closed_stage_ids: Option<Option<Vec<uuid::Uuid>>>,
+ /// Replacement `team_views` array.
+ pub team_views: Option<Value>,
+ /// New `default_team_view_id`; `Some(None)` clears it.
+ pub default_team_view_id: Option<Option<String>>,
+}
+
/// Errors that can occur in the CRM domain.
#[derive(Debug, thiserror::Error)]
pub enum CrmError {
@@ -270,6 +352,11 @@ pub enum CrmError {
/// below admin/owner.
#[error("Querying hidden CRM companies requires admin/owner team role")]
AdminRoleRequired,
+ /// The request changes governance fields of the team CRM settings
+ /// (permission thresholds, closed stages) but the caller's team role
+ /// is below admin/owner.
+ #[error("changing crm permission or stage settings requires admin/owner team role")]
+ SettingsAdminRequired,
/// Tried to mutate a CRM company in a way that contradicts its
/// `hidden = true` state — currently raised when attempting to
/// re-enable `email_sync` on a hidden company.
diff --git a/crates/crm/src/domain/service.rs b/crates/crm/src/domain/service.rs
index c5d946053c..c308122f57 100644
--- a/crates/crm/src/domain/service.rs
+++ b/crates/crm/src/domain/service.rs
@@ -1,12 +1,18 @@
//! The CrmService trait and its default implementation.
+#[cfg(test)]
+mod test;
+
use crate::domain::{
auth::{CrmCommentReceipt, CrmCompanyReceipt, CrmContactReceipt, CrmTeamReceipt},
comment::{CrmComment, CrmCommentEntityType, CrmCommentThread, DeleteCrmCommentResult},
companies_repo::{CompaniesRepository, CrmCompanyListSort, CrmCompanySoupCursor},
company_metadata_resolver::CompanyMetadataResolver,
generic_email_domains::is_generic_email_domain,
- model::{CrmCompanyForSoup, CrmCompanyWithContacts, CrmContact, CrmError, CrmScopePrecheck},
+ model::{
+ CrmCompanyForSoup, CrmCompanyWithContacts, CrmContact, CrmError, CrmScopePrecheck,
+ CrmTeamSettings, CrmTeamSettingsPatch,
+ },
};
use chrono::{DateTime, Utc};
use entity_access::domain::models::{EditAccessLevel, MemberTeamRole, ViewAccessLevel};
@@ -274,6 +280,28 @@ pub trait CrmService: Clone + Send + Sync + 'static {
&self,
comment_id: &uuid::Uuid,
) -> impl Future<Output = Result<Option<(CrmCommentEntityType, uuid::Uuid)>, CrmError>> + Send;
+
+ /// Read the team's CRM configuration. Any team member may read;
+ /// a team without a settings row gets the defaults. See
+ /// [`CompaniesRepository::get_team_settings`].
+ fn get_team_settings(
+ &self,
+ access: &CrmTeamReceipt<MemberTeamRole>,
+ ) -> impl Future<Output = Result<CrmTeamSettings, CrmError>> + Send;
+
+ /// Field-wise partial update of the team's CRM configuration.
+ /// Any team member may update the views fields (`team_views`,
+ /// `default_team_view_id`); the governance fields (permission
+ /// thresholds, `closed_stage_ids`) require an admin/owner role on
+ /// the receipt ([`CrmError::SettingsAdminRequired`] otherwise).
+ /// `team_views` is replaced whole (last-wins). Returns the
+ /// resulting settings. See
+ /// [`CompaniesRepository::update_team_settings`].
+ fn update_team_settings(
+ &self,
+ access: &CrmTeamReceipt<MemberTeamRole>,
+ patch: CrmTeamSettingsPatch,
+ ) -> impl Future<Output = Result<CrmTeamSettings, CrmError>> + Send;
}
/// Implementation of [`CrmService`] backed by a [`CompaniesRepository`]
@@ -665,6 +693,63 @@ where
.get_comment_entity(comment_id)
.await
}
+
+ #[tracing::instrument(skip(self, access), err)]
+ async fn get_team_settings(
+ &self,
+ access: &CrmTeamReceipt<MemberTeamRole>,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ self.companies_repository
+ .get_team_settings(&access.team_id())
+ .await
+ }
+
+ #[tracing::instrument(skip(self, access, patch), err)]
+ async fn update_team_settings(
+ &self,
+ access: &CrmTeamReceipt<MemberTeamRole>,
+ patch: CrmTeamSettingsPatch,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ // Members may manage team views; the governance fields require
+ // admin/owner. Checked against the receipt's actual role, so the
+ // service — not the caller — enforces the gate.
+ let touches_governance = patch.edit_stages_role.is_some()
+ || patch.move_closed_deals_role.is_some()
+ || patch.delete_records_role.is_some()
+ || patch.closed_stage_ids.is_some();
+ if touches_governance && !access.has_admin_role() {
+ return Err(CrmError::SettingsAdminRequired);
+ }
+
+ // team_views is an opaque blob, but it must at least be an array
+ // and stay within a sane size.
+ if let Some(views) = &patch.team_views {
+ if !views.is_array() {
+ return Err(CrmError::InvalidRequest(
+ "team_views must be a JSON array".into(),
+ ));
+ }
+ const MAX_TEAM_VIEWS_BYTES: usize = 256 * 1024;
+ let serialized_len = serde_json::to_string(views)
+ .map(|s| s.len())
+ .unwrap_or(usize::MAX);
+ if serialized_len > MAX_TEAM_VIEWS_BYTES {
+ return Err(CrmError::InvalidRequest(
+ "team_views exceeds the maximum size".into(),
+ ));
+ }
+ }
+ const MAX_CLOSED_STAGE_IDS: usize = 200;
+ if let Some(Some(ids)) = &patch.closed_stage_ids
+ && ids.len() > MAX_CLOSED_STAGE_IDS
+ {
+ return Err(CrmError::InvalidRequest("too many closed stage ids".into()));
+ }
+
+ self.companies_repository
+ .update_team_settings(&access.team_id(), &patch)
+ .await
+ }
}
/// No-op [`CrmService`] for binaries that need to satisfy the bound
@@ -821,4 +906,19 @@ impl CrmService for NoOpCrmService {
) -> Result<Option<(CrmCommentEntityType, uuid::Uuid)>, CrmError> {
Ok(None)
}
+
+ async fn get_team_settings(
+ &self,
+ _access: &CrmTeamReceipt<MemberTeamRole>,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ unimplemented!("NoOpCrmService.get_team_settings")
+ }
+
+ async fn update_team_settings(
+ &self,
+ _access: &CrmTeamReceipt<MemberTeamRole>,
+ _patch: CrmTeamSettingsPatch,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ unimplemented!("NoOpCrmService.update_team_settings")
+ }
}
diff --git a/crates/crm/src/domain/service/test.rs b/crates/crm/src/domain/service/test.rs
new file mode 100644
index 0000000000..50a16f34e7
--- /dev/null
+++ b/crates/crm/src/domain/service/test.rs
@@ -0,0 +1,321 @@
+//! Service-level policy tests for team CRM settings: members may write
+//! the views fields, governance fields require admin/owner. The repo is
+//! a stub so only the service's policy layer is under test.
+
+use super::*;
+use crate::domain::model::CrmPermissionRole;
+use crate::outbound::no_op_resolver::NoOpCompanyMetadataResolver;
+use entity_access::domain::models::{
+ Entity, EntityAccessReceipt, EntityPermission, EntityType, TeamRole,
+};
+use macro_user_id::{cowlike::CowLike, user_id::MacroUserIdStr};
+use serde_json::json;
+
+/// Stub [`CompaniesRepository`]: the two settings methods behave like an
+/// empty store; everything else panics.
+#[derive(Clone)]
+struct StubRepo;
+
+impl CompaniesRepository for StubRepo {
+ async fn populate_contact(
+ &self,
+ _team_id: &uuid::Uuid,
+ _link_id: &uuid::Uuid,
+ _domain: &str,
+ _email: &str,
+ _name: Option<&str>,
+ _first_at: DateTime<Utc>,
+ _last_at: DateTime<Utc>,
+ _is_sent: bool,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn lookup_domain_metadata(
+ &self,
+ _domain: &str,
+ ) -> Result<Option<crate::domain::model::DomainMetadata>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn upsert_domain_metadata(
+ &self,
+ _domain: &str,
+ _metadata: &crate::domain::model::DomainMetadata,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn depopulate_contact(
+ &self,
+ _team_id: &uuid::Uuid,
+ _link_id: &uuid::Uuid,
+ _domain: &str,
+ _email: &str,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn depopulate_link_in_team(
+ &self,
+ _team_id: &uuid::Uuid,
+ _link_id: &uuid::Uuid,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_team_id_for_user(&self, _macro_id: &str) -> Result<Option<uuid::Uuid>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn set_email_sync(
+ &self,
+ _team_id: &uuid::Uuid,
+ _company_id: &uuid::Uuid,
+ _email_sync: bool,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn set_company_hidden(
+ &self,
+ _team_id: &uuid::Uuid,
+ _company_id: &uuid::Uuid,
+ _hidden: bool,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn set_contact_hidden(
+ &self,
+ _team_id: &uuid::Uuid,
+ _contact_id: &uuid::Uuid,
+ _hidden: bool,
+ ) -> Result<(), CrmError> {
+ unimplemented!()
+ }
+
+ async fn crm_scope_precheck(
+ &self,
+ _team_id: &uuid::Uuid,
+ _domains: &[String],
+ _addresses: &[String],
+ ) -> Result<CrmScopePrecheck, CrmError> {
+ unimplemented!()
+ }
+
+ #[allow(clippy::too_many_arguments)]
+ async fn list_companies_for_soup(
+ &self,
+ _team_id: &uuid::Uuid,
+ _user_id: &str,
+ _company_ids: &[uuid::Uuid],
+ _hidden: Option<bool>,
+ _sort: CrmCompanyListSort,
+ _cursor: Option<CrmCompanySoupCursor>,
+ _limit: i64,
+ ) -> Result<Vec<CrmCompanyForSoup>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn list_contacts_for_company(
+ &self,
+ _team_id: &uuid::Uuid,
+ _company_id: &uuid::Uuid,
+ _include_hidden: bool,
+ ) -> Result<Vec<CrmContact>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_contact_for_team(
+ &self,
+ _team_id: &uuid::Uuid,
+ _contact_id: &uuid::Uuid,
+ _include_hidden: bool,
+ ) -> Result<Option<CrmContact>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_company_for_team(
+ &self,
+ _team_id: &uuid::Uuid,
+ _company_id: &uuid::Uuid,
+ _include_hidden: bool,
+ ) -> Result<Option<CrmCompanyWithContacts>, CrmError> {
+ unimplemented!()
+ }
+
+ #[allow(clippy::too_many_arguments)]
+ async fn create_crm_comment(
+ &self,
+ _team_id: &uuid::Uuid,
+ _entity_type: CrmCommentEntityType,
+ _entity_id: &uuid::Uuid,
+ _owner: &str,
+ _thread_id: Option<uuid::Uuid>,
+ _thread_metadata: Option<Value>,
+ _text: &str,
+ _metadata: Option<Value>,
+ _include_hidden: bool,
+ ) -> Result<CrmCommentThread, CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_crm_comment_threads(
+ &self,
+ _team_id: &uuid::Uuid,
+ _entity_type: CrmCommentEntityType,
+ _entity_id: &uuid::Uuid,
+ _include_hidden: bool,
+ ) -> Result<Vec<CrmCommentThread>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn edit_crm_comment(
+ &self,
+ _team_id: &uuid::Uuid,
+ _comment_id: &uuid::Uuid,
+ _text: &str,
+ _include_hidden: bool,
+ _requester: &str,
+ ) -> Result<CrmComment, CrmError> {
+ unimplemented!()
+ }
+
+ async fn delete_crm_comment(
+ &self,
+ _team_id: &uuid::Uuid,
+ _comment_id: &uuid::Uuid,
+ _include_hidden: bool,
+ _requester: &str,
+ ) -> Result<DeleteCrmCommentResult, CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_comment_entity(
+ &self,
+ _comment_id: &uuid::Uuid,
+ ) -> Result<Option<(CrmCommentEntityType, uuid::Uuid)>, CrmError> {
+ unimplemented!()
+ }
+
+ async fn get_team_settings(&self, _team_id: &uuid::Uuid) -> Result<CrmTeamSettings, CrmError> {
+ Ok(CrmTeamSettings::default())
+ }
+
+ async fn update_team_settings(
+ &self,
+ _team_id: &uuid::Uuid,
+ patch: &CrmTeamSettingsPatch,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ // Echo the patch onto defaults so tests can see what got through.
+ let mut settings = CrmTeamSettings::default();
+ if let Some(role) = patch.edit_stages_role {
+ settings.edit_stages_role = role;
+ }
+ if let Some(views) = &patch.team_views {
+ settings.team_views = views.clone();
+ }
+ if let Some(default_id) = &patch.default_team_view_id {
+ settings.default_team_view_id = default_id.clone();
+ }
+ Ok(settings)
+ }
+}
+
+fn service() -> CrmServiceImpl<StubRepo, NoOpCompanyMetadataResolver> {
+ CrmServiceImpl::new(StubRepo, NoOpCompanyMetadataResolver)
+}
+
+fn receipt_with_role(role: TeamRole) -> CrmTeamReceipt<MemberTeamRole> {
+ let user = MacroUserIdStr::parse_from_str("macro|[email protected]")
+ .unwrap()
+ .into_owned();
+ CrmTeamReceipt::from_team_receipt(
+ EntityAccessReceipt::<MemberTeamRole>::try_new_authenticated_user(
+ user,
+ Entity {
+ entity_id: uuid::Uuid::now_v7().to_string(),
+ entity_type: EntityType::Team,
+ },
+ EntityPermission::TeamRole { role },
+ )
+ .unwrap(),
+ )
+ .unwrap()
+}
+
+#[tokio::test]
+async fn member_can_update_team_views_and_default() {
+ let access = receipt_with_role(TeamRole::Member);
+ let patch = CrmTeamSettingsPatch {
+ team_views: Some(json!([{ "id": "v1" }])),
+ default_team_view_id: Some(Some("v1".to_string())),
+ ..Default::default()
+ };
+ let settings = service()
+ .update_team_settings(&access, patch)
+ .await
+ .unwrap();
+ assert_eq!(settings.team_views, json!([{ "id": "v1" }]));
+ assert_eq!(settings.default_team_view_id, Some("v1".to_string()));
+}
+
+#[tokio::test]
+async fn member_cannot_update_governance_fields() {
+ let access = receipt_with_role(TeamRole::Member);
+ for patch in [
+ CrmTeamSettingsPatch {
+ edit_stages_role: Some(CrmPermissionRole::Owner),
+ ..Default::default()
+ },
+ CrmTeamSettingsPatch {
+ move_closed_deals_role: Some(CrmPermissionRole::Owner),
+ ..Default::default()
+ },
+ CrmTeamSettingsPatch {
+ delete_records_role: Some(CrmPermissionRole::Owner),
+ ..Default::default()
+ },
+ CrmTeamSettingsPatch {
+ closed_stage_ids: Some(Some(vec![uuid::Uuid::now_v7()])),
+ ..Default::default()
+ },
+ ] {
+ let err = service()
+ .update_team_settings(&access, patch)
+ .await
+ .unwrap_err();
+ assert!(matches!(err, CrmError::SettingsAdminRequired));
+ }
+}
+
+#[tokio::test]
+async fn admin_and_owner_can_update_governance_fields() {
+ for role in [TeamRole::Admin, TeamRole::Owner] {
+ let access = receipt_with_role(role);
+ let patch = CrmTeamSettingsPatch {
+ edit_stages_role: Some(CrmPermissionRole::Owner),
+ ..Default::default()
+ };
+ let settings = service()
+ .update_team_settings(&access, patch)
+ .await
+ .unwrap();
+ assert_eq!(settings.edit_stages_role, CrmPermissionRole::Owner);
+ }
+}
+
+#[tokio::test]
+async fn team_views_must_be_an_array() {
+ let access = receipt_with_role(TeamRole::Admin);
+ let patch = CrmTeamSettingsPatch {
+ team_views: Some(json!({ "not": "an array" })),
+ ..Default::default()
+ };
+ let err = service()
+ .update_team_settings(&access, patch)
+ .await
+ .unwrap_err();
+ assert!(matches!(err, CrmError::InvalidRequest(_)));
+}
diff --git a/crates/crm/src/inbound/axum_extractors/test.rs b/crates/crm/src/inbound/axum_extractors/test.rs
index 10727bd907..98e8287e2b 100644
--- a/crates/crm/src/inbound/axum_extractors/test.rs
+++ b/crates/crm/src/inbound/axum_extractors/test.rs
@@ -394,6 +394,21 @@ impl CrmService for FakeCrmService {
.push(*comment_id);
Ok(self.comment_entity)
}
+
+ async fn get_team_settings(
+ &self,
+ _access: &CrmTeamReceipt<MemberTeamRole>,
+ ) -> Result<crate::domain::model::CrmTeamSettings, CrmError> {
+ panic!("unexpected get_team_settings call")
+ }
+
+ async fn update_team_settings(
+ &self,
+ _access: &CrmTeamReceipt<MemberTeamRole>,
+ _patch: crate::domain::model::CrmTeamSettingsPatch,
+ ) -> Result<crate::domain::model::CrmTeamSettings, CrmError> {
+ panic!("unexpected update_team_settings call")
+ }
}
async fn company_handler(
diff --git a/crates/crm/src/inbound/axum_router/mod.rs b/crates/crm/src/inbound/axum_router/mod.rs
index 588f72f186..a84fec1808 100644
--- a/crates/crm/src/inbound/axum_router/mod.rs
+++ b/crates/crm/src/inbound/axum_router/mod.rs
@@ -23,6 +23,10 @@ pub mod get_company;
/// Comment threads on a `crm_companies` / `crm_contacts` row.
pub mod comments;
+/// Team-level CRM configuration (permission thresholds, closed stages,
+/// team saved views).
+pub mod team_settings;
+
use std::sync::Arc;
use axum::{
@@ -136,6 +140,11 @@ where
patch(comments::edit_handler::<C, Eas, Auth>)
.delete(comments::delete_handler::<C, Eas, Auth>),
)
+ .route(
+ "/settings",
+ get(team_settings::get_handler::<C, Eas, Auth>)
+ .put(team_settings::update_handler::<C, Eas, Auth>),
+ )
.with_state(state)
}
@@ -184,6 +193,14 @@ impl IntoResponse for CrmError {
message: "querying hidden crm entities requires admin/owner team role".into(),
}),
),
+ CrmError::SettingsAdminRequired => (
+ StatusCode::FORBIDDEN,
+ Json(ErrorResponse {
+ message:
+ "changing crm permission or stage settings requires admin/owner team role"
+ .into(),
+ }),
+ ),
CrmError::CompanyHidden => (
StatusCode::CONFLICT,
Json(ErrorResponse {
diff --git a/crates/crm/src/inbound/axum_router/team_settings.rs b/crates/crm/src/inbound/axum_router/team_settings.rs
new file mode 100644
index 0000000000..b169ba7cc0
--- /dev/null
+++ b/crates/crm/src/inbound/axum_router/team_settings.rs
@@ -0,0 +1,160 @@
+use axum::{Json, extract::State};
+use entity_access::{
+ domain::{models::MemberTeamRole, ports::EntityAccessService},
+ inbound::axum_extractors::MacroUserTeamExtractorV2,
+};
+use macro_authorization::MacroAuthorizationService;
+use model_error_response::ErrorResponse;
+use serde::{Deserialize, Deserializer, Serialize};
+use serde_json::Value;
+use utoipa::ToSchema;
+use uuid::Uuid;
+
+use crate::domain::{
+ auth::CrmTeamReceipt,
+ model::{CrmError, CrmPermissionRole, CrmTeamSettings, CrmTeamSettingsPatch},
+ service::CrmService,
+};
+
+use super::CrmRouterState;
+
+/// The team's CRM configuration (everything on `team_crm_settings`
+/// except the `crm_enabled` killswitch, which is managed via
+/// `PATCH /team/crm` on the auth service).
+#[derive(Debug, Serialize, ToSchema)]
+pub struct CrmTeamSettingsResponse {
+ /// Who can change the deal stage set in CRM settings.
+ pub edit_stages_role: CrmPermissionRole,
+ /// Who can move deals out of a closed stage.
+ pub move_closed_deals_role: CrmPermissionRole,
+ /// Who can delete (hide) CRM records.
+ pub delete_records_role: CrmPermissionRole,
+ /// Stage option ids counting as closed deals; absent = the client
+ /// falls back to its label heuristic.
+ pub closed_stage_ids: Option<Vec<Uuid>>,
+ /// Team saved views — an opaque JSON array owned by the frontend.
+ pub team_views: Value,
+ /// Team view applied by default when a member opens the CRM view.
+ pub default_team_view_id: Option<String>,
+}
+
+impl From<CrmTeamSettings> for CrmTeamSettingsResponse {
+ fn from(settings: CrmTeamSettings) -> Self {
+ Self {
+ edit_stages_role: settings.edit_stages_role,
+ move_closed_deals_role: settings.move_closed_deals_role,
+ delete_records_role: settings.delete_records_role,
+ closed_stage_ids: settings.closed_stage_ids,
+ team_views: settings.team_views,
+ default_team_view_id: settings.default_team_view_id,
+ }
+ }
+}
+
+/// Deserializes a field so that a missing key and an explicit `null`
+/// are distinguishable: missing → outer `None`, `null` → `Some(None)`.
+fn double_option<'de, T, D>(de: D) -> Result<Option<Option<T>>, D::Error>
+where
+ T: Deserialize<'de>,
+ D: Deserializer<'de>,
+{
+ Deserialize::deserialize(de).map(Some)
+}
+
+/// Request body for `PUT /crm/settings`. Every field is optional:
+/// omitted fields keep their current values.
+#[derive(Debug, Deserialize, ToSchema)]
+pub struct UpdateCrmTeamSettingsRequest {
+ /// New `edit_stages_role`, if provided.
+ pub edit_stages_role: Option<CrmPermissionRole>,
+ /// New `move_closed_deals_role`, if provided.
+ pub move_closed_deals_role: Option<CrmPermissionRole>,
+ /// New `delete_records_role`, if provided.
+ pub delete_records_role: Option<CrmPermissionRole>,
+ /// New closed-stage set. Omit to keep the current value; pass
+ /// `null` to clear it (falling back to the client label heuristic).
+ #[serde(default, deserialize_with = "double_option")]
+ pub closed_stage_ids: Option<Option<Vec<Uuid>>>,
+ /// Replacement team-views array (whole-blob, last write wins).
+ pub team_views: Option<Value>,
+ /// New default team view id. Omit to keep the current value; pass
+ /// `null` to clear it.
+ #[serde(default, deserialize_with = "double_option")]
+ pub default_team_view_id: Option<Option<String>>,
+}
+
+impl From<UpdateCrmTeamSettingsRequest> for CrmTeamSettingsPatch {
+ fn from(req: UpdateCrmTeamSettingsRequest) -> Self {
+ Self {
+ edit_stages_role: req.edit_stages_role,
+ move_closed_deals_role: req.move_closed_deals_role,
+ delete_records_role: req.delete_records_role,
+ closed_stage_ids: req.closed_stage_ids,
+ team_views: req.team_views,
+ default_team_view_id: req.default_team_view_id,
+ }
+ }
+}
+
+/// Read the caller's team CRM configuration. Any team member may read;
+/// teams without a settings row get the defaults.
+#[utoipa::path(
+ get,
+ path = "/crm/settings",
+ operation_id = "get_crm_team_settings",
+ responses(
+ (status = 200, body = CrmTeamSettingsResponse),
+ (status = 401, body = ErrorResponse),
+ (status = 500, body = ErrorResponse),
+ ),
+)]
+#[tracing::instrument(skip_all, err)]
+pub async fn get_handler<
+ C: CrmService,
+ Eas: EntityAccessService,
+ Auth: MacroAuthorizationService,
+>(
+ access: MacroUserTeamExtractorV2<MemberTeamRole, Eas, Auth>,
+ State(state): State<CrmRouterState<C, Eas, Auth>>,
+) -> Result<Json<CrmTeamSettingsResponse>, CrmError> {
+ let receipt = CrmTeamReceipt::from_team_receipt(access.entity_access_receipt)?;
+ let settings = state.service.get_team_settings(&receipt).await?;
+ Ok(Json(settings.into()))
+}
+
+/// Partially update the caller's team CRM configuration. Any team
+/// member may update the views fields (`team_views`,
+/// `default_team_view_id`); the governance fields (permission
+/// thresholds, `closed_stage_ids`) require an admin/owner team role
+/// (403 otherwise). Omitted fields keep their current values;
+/// `team_views` is replaced whole. Returns the resulting settings.
+#[utoipa::path(
+ put,
+ path = "/crm/settings",
+ operation_id = "put_crm_team_settings",
+ request_body = UpdateCrmTeamSettingsRequest,
+ responses(
+ (status = 200, body = CrmTeamSettingsResponse),
+ (status = 400, body = ErrorResponse),
+ (status = 401, body = ErrorResponse),
+ (status = 403, body = ErrorResponse),
+ (status = 500, body = ErrorResponse),
+ ),
+)]
+#[tracing::instrument(skip_all, err)]
+pub async fn update_handler<
+ C: CrmService,
+ Eas: EntityAccessService,
+ Auth: MacroAuthorizationService,
+>(
+ access: MacroUserTeamExtractorV2<MemberTeamRole, Eas, Auth>,
+ State(state): State<CrmRouterState<C, Eas, Auth>>,
+ Json(req): Json<UpdateCrmTeamSettingsRequest>,
+) -> Result<Json<CrmTeamSettingsResponse>, CrmError> {
+ let receipt = CrmTeamReceipt::from_team_receipt(access.entity_access_receipt)?;
+ let settings = state
+ .service
+ .update_team_settings(&receipt, req.into())
+ .await?;
+ Ok(Json(settings.into()))
+}
diff --git a/crates/crm/src/outbound/companies_repo.rs b/crates/crm/src/outbound/companies_repo.rs
index c05d8a9df4..825abd6441 100644
--- a/crates/crm/src/outbound/companies_repo.rs
+++ b/crates/crm/src/outbound/companies_repo.rs
@@ -10,7 +10,8 @@ use crate::domain::{
companies_repo::{CompaniesRepository, CrmCompanyListSort, CrmCompanySoupCursor},
model::{
CrmAddressStatus, CrmCompany, CrmCompanyForSoup, CrmCompanyWithContacts, CrmContact,
- CrmDomain, CrmDomainStatus, CrmError, CrmScopePrecheck, DomainMetadata,
+ CrmDomain, CrmDomainStatus, CrmError, CrmPermissionRole, CrmScopePrecheck, CrmTeamSettings,
+ CrmTeamSettingsPatch, DomainMetadata,
},
};
use chrono::{DateTime, Utc};
@@ -1849,6 +1850,109 @@ impl CompaniesRepository for CompaniesRepositoryImpl {
(None, None) => None,
}))
}
+
+ #[tracing::instrument(skip(self), err)]
+ async fn get_team_settings(&self, team_id: &Uuid) -> Result<CrmTeamSettings, CrmError> {
+ let row = sqlx::query!(
+ r#"
+ SELECT edit_stages_role AS "edit_stages_role: CrmPermissionRole",
+ move_closed_deals_role AS "move_closed_deals_role: CrmPermissionRole",
+ delete_records_role AS "delete_records_role: CrmPermissionRole",
+ closed_stage_ids,
+ team_views,
+ default_team_view_id
+ FROM team_crm_settings
+ WHERE team_id = $1
+ "#,
+ team_id,
+ )
+ .fetch_optional(&self.pool)
+ .await
+ .map_err(|e| CrmError::StorageLayerError(e.into()))?;
+
+ Ok(row
+ .map(|r| CrmTeamSettings {
+ edit_stages_role: r.edit_stages_role,
+ move_closed_deals_role: r.move_closed_deals_role,
+ delete_records_role: r.delete_records_role,
+ closed_stage_ids: r.closed_stage_ids,
+ team_views: r.team_views,
+ default_team_view_id: r.default_team_view_id,
+ })
+ .unwrap_or_default())
+ }
+
+ #[tracing::instrument(skip(self, patch), err)]
+ async fn update_team_settings(
+ &self,
+ team_id: &Uuid,
+ patch: &CrmTeamSettingsPatch,
+ ) -> Result<CrmTeamSettings, CrmError> {
+ // Roles bind as text and cast in SQL; NULL = keep current value.
+ let edit_stages = patch.edit_stages_role.map(|r| r.as_db_str());
+ let move_closed = patch.move_closed_deals_role.map(|r| r.as_db_str());
+ let delete_records = patch.delete_records_role.map(|r| r.as_db_str());
+ // The two nullable columns need a separate "provided" flag: NULL
+ // is a meaningful new value, so COALESCE can't express "keep".
+ let closed_provided = patch.closed_stage_ids.is_some();
+ let closed_value: Option<Vec<Uuid>> = patch.closed_stage_ids.clone().flatten();
+ let default_provided = patch.default_team_view_id.is_some();
+ let default_value: Option<String> = patch.default_team_view_id.clone().flatten();
+
+ let row = sqlx::query!(
+ r#"
+ INSERT INTO team_crm_settings (
+ team_id, edit_stages_role, move_closed_deals_role, delete_records_role,
+ closed_stage_ids, team_views, default_team_view_id
+ )
+ VALUES (
+ $1,
+ COALESCE($2::text::team_role, 'admin'),
+ COALESCE($3::text::team_role, 'admin'),
+ COALESCE($4::text::team_role, 'admin'),
+ CASE WHEN $5 THEN $6::uuid[] END,
+ COALESCE($7, '[]'::jsonb),
+ CASE WHEN $8 THEN $9 END
+ )
+ ON CONFLICT (team_id) DO UPDATE SET
+ edit_stages_role = COALESCE($2::text::team_role, team_crm_settings.edit_stages_role),
+ move_closed_deals_role = COALESCE($3::text::team_role, team_crm_settings.move_closed_deals_role),
+ delete_records_role = COALESCE($4::text::team_role, team_crm_settings.delete_records_role),
+ closed_stage_ids = CASE WHEN $5 THEN $6::uuid[] ELSE team_crm_settings.closed_stage_ids END,
+ team_views = COALESCE($7, team_crm_settings.team_views),
+ default_team_view_id = CASE WHEN $8 THEN $9 ELSE team_crm_settings.default_team_view_id END,
+ updated_at = now()
+ RETURNING
+ edit_stages_role AS "edit_stages_role!: CrmPermissionRole",
+ move_closed_deals_role AS "move_closed_deals_role!: CrmPermissionRole",
+ delete_records_role AS "delete_records_role!: CrmPermissionRole",
+ closed_stage_ids,
+ team_views AS "team_views!",
+ default_team_view_id
+ "#,
+ team_id,
+ edit_stages as Option<&str>,
+ move_closed as Option<&str>,
+ delete_records as Option<&str>,
+ closed_provided,
+ closed_value.as_deref(),
+ patch.team_views.as_ref(),
+ default_provided,
+ default_value.as_deref(),
+ )
+ .fetch_one(&self.pool)
+ .await
+ .map_err(|e| CrmError::StorageLayerError(e.into()))?;
+
+ Ok(CrmTeamSettings {
+ edit_stages_role: row.edit_stages_role,
+ move_closed_deals_role: row.move_closed_deals_role,
+ delete_records_role: row.delete_records_role,
+ closed_stage_ids: row.closed_stage_ids,
+ team_views: row.team_views,
+ default_team_view_id: row.default_team_view_id,
+ })
+ }
}
/// Maps a CRM entity type to the team-scoped not-found error used when the
diff --git a/crates/crm/src/outbound/companies_repo/test.rs b/crates/crm/src/outbound/companies_repo/test.rs
index 463cb2ee93..da5bc57586 100644
--- a/crates/crm/src/outbound/companies_repo/test.rs
+++ b/crates/crm/src/outbound/companies_repo/test.rs
@@ -15,3 +15,4 @@ mod populate_contact;
mod set_company_hidden;
mod set_contact_hidden;
mod set_email_sync;
+mod team_settings;
diff --git a/crates/crm/src/outbound/companies_repo/test/team_settings.rs b/crates/crm/src/outbound/companies_repo/test/team_settings.rs
new file mode 100644
index 0000000000..f42f4fbd10
--- /dev/null
+++ b/crates/crm/src/outbound/companies_repo/test/team_settings.rs
@@ -0,0 +1,167 @@
+use super::helpers::*;
+use crate::domain::companies_repo::*;
+use crate::domain::model::{CrmPermissionRole, CrmTeamSettingsPatch};
+use crate::outbound::companies_repo::*;
+use macro_db_migrator::MACRO_DB_MIGRATIONS;
+use serde_json::json;
+use sqlx::PgPool;
+use uuid::Uuid;
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn get_team_settings_missing_row_returns_defaults(pool: PgPool) -> anyhow::Result<()> {
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let settings = repo.get_team_settings(&team_id).await?;
+
+ assert_eq!(settings.edit_stages_role, CrmPermissionRole::Admin);
+ assert_eq!(settings.move_closed_deals_role, CrmPermissionRole::Admin);
+ assert_eq!(settings.delete_records_role, CrmPermissionRole::Admin);
+ assert_eq!(settings.closed_stage_ids, None);
+ assert_eq!(settings.team_views, json!([]));
+ assert_eq!(settings.default_team_view_id, None);
+ Ok(())
+}
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn get_team_settings_row_from_enable_flow_returns_defaults(
+ pool: PgPool,
+) -> anyhow::Result<()> {
+ // A row created by the enable-CRM flow (crm_enabled only) must read
+ // back the config column defaults.
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+ sqlx::query(r#"INSERT INTO team_crm_settings (team_id, crm_enabled) VALUES ($1, TRUE)"#)
+ .bind(team_id)
+ .execute(&pool)
+ .await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let settings = repo.get_team_settings(&team_id).await?;
+
+ assert_eq!(settings.edit_stages_role, CrmPermissionRole::Admin);
+ assert_eq!(settings.closed_stage_ids, None);
+ assert_eq!(settings.team_views, json!([]));
+ assert_eq!(settings.default_team_view_id, None);
+ Ok(())
+}
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn update_team_settings_inserts_and_preserves_crm_enabled(
+ pool: PgPool,
+) -> anyhow::Result<()> {
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let patch = CrmTeamSettingsPatch {
+ edit_stages_role: Some(CrmPermissionRole::Owner),
+ ..Default::default()
+ };
+ let settings = repo.update_team_settings(&team_id, &patch).await?;
+
+ assert_eq!(settings.edit_stages_role, CrmPermissionRole::Owner);
+ assert_eq!(settings.move_closed_deals_role, CrmPermissionRole::Admin);
+
+ // The insert must not flip the killswitch.
+ let crm_enabled: bool =
+ sqlx::query_scalar(r#"SELECT crm_enabled FROM team_crm_settings WHERE team_id = $1"#)
+ .bind(team_id)
+ .fetch_one(&pool)
+ .await?;
+ assert!(!crm_enabled);
+ Ok(())
+}
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn update_team_settings_partial_changes_only_provided_fields(
+ pool: PgPool,
+) -> anyhow::Result<()> {
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let stage_id = Uuid::now_v7();
+ let full = CrmTeamSettingsPatch {
+ edit_stages_role: Some(CrmPermissionRole::Owner),
+ move_closed_deals_role: Some(CrmPermissionRole::Owner),
+ delete_records_role: Some(CrmPermissionRole::Owner),
+ closed_stage_ids: Some(Some(vec![stage_id])),
+ team_views: Some(json!([{ "id": "v1", "name": "My view" }])),
+ default_team_view_id: Some(Some("v1".to_string())),
+ };
+ repo.update_team_settings(&team_id, &full).await?;
+
+ // Change one field; everything else must survive.
+ let partial = CrmTeamSettingsPatch {
+ move_closed_deals_role: Some(CrmPermissionRole::Admin),
+ ..Default::default()
+ };
+ let settings = repo.update_team_settings(&team_id, &partial).await?;
+
+ assert_eq!(settings.move_closed_deals_role, CrmPermissionRole::Admin);
+ assert_eq!(settings.edit_stages_role, CrmPermissionRole::Owner);
+ assert_eq!(settings.delete_records_role, CrmPermissionRole::Owner);
+ assert_eq!(settings.closed_stage_ids, Some(vec![stage_id]));
+ assert_eq!(
+ settings.team_views,
+ json!([{ "id": "v1", "name": "My view" }])
+ );
+ assert_eq!(settings.default_team_view_id, Some("v1".to_string()));
+ Ok(())
+}
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn update_team_settings_tristate_clears_nullable_fields(pool: PgPool) -> anyhow::Result<()> {
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let set = CrmTeamSettingsPatch {
+ closed_stage_ids: Some(Some(vec![Uuid::now_v7()])),
+ default_team_view_id: Some(Some("v1".to_string())),
+ ..Default::default()
+ };
+ repo.update_team_settings(&team_id, &set).await?;
+
+ // Omitted (outer None) leaves the values alone.
+ let untouched = repo
+ .update_team_settings(&team_id, &CrmTeamSettingsPatch::default())
+ .await?;
+ assert!(untouched.closed_stage_ids.is_some());
+ assert_eq!(untouched.default_team_view_id, Some("v1".to_string()));
+
+ // Explicit inner None clears them.
+ let clear = CrmTeamSettingsPatch {
+ closed_stage_ids: Some(None),
+ default_team_view_id: Some(None),
+ ..Default::default()
+ };
+ let cleared = repo.update_team_settings(&team_id, &clear).await?;
+ assert_eq!(cleared.closed_stage_ids, None);
+ assert_eq!(cleared.default_team_view_id, None);
+ Ok(())
+}
+
+#[sqlx::test(migrator = "MACRO_DB_MIGRATIONS")]
+async fn update_team_settings_replaces_team_views_whole(pool: PgPool) -> anyhow::Result<()> {
+ let team_id = Uuid::now_v7();
+ seed_team(&pool, team_id, "macro|[email protected]").await?;
+
+ let repo = CompaniesRepositoryImpl::new(pool.clone());
+ let first = CrmTeamSettingsPatch {
+ team_views: Some(json!([{ "id": "a" }, { "id": "b" }])),
+ ..Default::default()
+ };
+ repo.update_team_settings(&team_id, &first).await?;
+
+ let second = CrmTeamSettingsPatch {
+ team_views: Some(json!([{ "id": "c" }])),
+ ..Default::default()
+ };
+ let settings = repo.update_team_settings(&team_id, &second).await?;
+
+ assert_eq!(settings.team_views, json!([{ "id": "c" }]));
+ Ok(())
+}
diff --git a/crates/macro_db_client/migrations/20260717161623_team_crm_settings_config.sql b/crates/macro_db_client/migrations/20260717161623_team_crm_settings_config.sql
new file mode 100644
index 0000000000..4e0ddfb366
--- /dev/null
+++ b/crates/macro_db_client/migrations/20260717161623_team_crm_settings_config.sql
@@ -0,0 +1,90 @@
+-- Team CRM configuration moves from the legacy `__macro:crm-config` property
+-- definition hack into real columns on team_crm_settings.
+-- Team saved views intentionally stay an opaque jsonb blob for fast iteration.
+
+ALTER TABLE team_crm_settings
+ ADD COLUMN edit_stages_role team_role NOT NULL DEFAULT 'admin',
+ ADD COLUMN move_closed_deals_role team_role NOT NULL DEFAULT 'admin',
+ ADD COLUMN delete_records_role team_role NOT NULL DEFAULT 'admin',
+ ADD COLUMN closed_stage_ids uuid[],
+ ADD COLUMN team_views jsonb NOT NULL DEFAULT '[]'::jsonb,
+ ADD COLUMN default_team_view_id text;
+
+COMMENT ON COLUMN team_crm_settings.closed_stage_ids IS
+ 'Stage option ids counting as closed deals; NULL = label heuristic on the client';
+COMMENT ON COLUMN team_crm_settings.team_views IS
+ 'Opaque array of team saved views, owned by the frontend';
+
+-- Backfill from the legacy `__macro:crm-config` property definitions, whose
+-- single select option holds the JSON config in string_value. Invalid or
+-- unparsable configs are skipped (columns keep their defaults).
+DO $$
+DECLARE
+ rec RECORD;
+ cfg jsonb;
+ v_edit team_role;
+ v_move team_role;
+ v_del team_role;
+ v_closed uuid[];
+ v_views jsonb;
+ v_default text;
+BEGIN
+ FOR rec IN
+ SELECT DISTINCT ON (pd.team_id) pd.team_id, po.string_value
+ FROM property_definitions pd
+ JOIN property_options po ON po.property_definition_id = pd.id
+ WHERE pd.display_name = '__macro:crm-config'
+ AND pd.team_id IS NOT NULL
+ ORDER BY pd.team_id, pd.created_at ASC, po.display_order ASC
+ LOOP
+ BEGIN
+ cfg := rec.string_value::jsonb;
+ EXCEPTION WHEN others THEN
+ CONTINUE;
+ END;
+ IF cfg IS NULL OR jsonb_typeof(cfg) <> 'object' THEN
+ CONTINUE;
+ END IF;
+
+ v_edit := CASE WHEN cfg #>> '{permissions,editStages}' IN ('admin', 'owner')
+ THEN (cfg #>> '{permissions,editStages}')::team_role
+ ELSE 'admin' END;
+ v_move := CASE WHEN cfg #>> '{permissions,moveClosedDeals}' IN ('admin', 'owner')
+ THEN (cfg #>> '{permissions,moveClosedDeals}')::team_role
+ ELSE 'admin' END;
+ v_del := CASE WHEN cfg #>> '{permissions,deleteRecords}' IN ('admin', 'owner')
+ THEN (cfg #>> '{permissions,deleteRecords}')::team_role
+ ELSE 'admin' END;
+
+ v_closed := NULL;
+ IF jsonb_typeof(cfg -> 'closedStageIds') = 'array' THEN
+ BEGIN
+ SELECT array_agg(value::uuid) INTO v_closed
+ FROM jsonb_array_elements_text(cfg -> 'closedStageIds');
+ EXCEPTION WHEN others THEN
+ -- Non-uuid entries: fall back to the label heuristic.
+ v_closed := NULL;
+ END;
+ END IF;
+
+ v_views := CASE WHEN jsonb_typeof(cfg -> 'teamViews') = 'array'
+ THEN cfg -> 'teamViews'
+ ELSE '[]'::jsonb END;
+ v_default := cfg ->> 'defaultTeamViewId';
+
+ -- INSERT branch leaves crm_enabled at its FALSE default, matching
+ -- the existing "no row = disabled" semantics.
+ INSERT INTO team_crm_settings (team_id, edit_stages_role, move_closed_deals_role,
+ delete_records_role, closed_stage_ids, team_views,
+ default_team_view_id)
+ VALUES (rec.team_id, v_edit, v_move, v_del, v_closed, v_views, v_default)
+ ON CONFLICT (team_id) DO UPDATE SET
+ edit_stages_role = EXCLUDED.edit_stages_role,
+ move_closed_deals_role = EXCLUDED.move_closed_deals_role,
+ delete_records_role = EXCLUDED.delete_records_role,
+ closed_stage_ids = EXCLUDED.closed_stage_ids,
+ team_views = EXCLUDED.team_views,
+ default_team_view_id = EXCLUDED.default_team_view_id,
+ updated_at = now();
+ END LOOP;
+END $$;
diff --git a/services/document_storage_service/src/api/swagger.rs b/services/document_storage_service/src/api/swagger.rs
index a77be9d2fe..3bb9b2db41 100644
--- a/services/document_storage_service/src/api/swagger.rs
+++ b/services/document_storage_service/src/api/swagger.rs
@@ -327,6 +327,8 @@ use utoipa::OpenApi;
crm::inbound::axum_router::comments::create_handler,
crm::inbound::axum_router::comments::edit_handler,
crm::inbound::axum_router::comments::delete_handler,
+ crm::inbound::axum_router::team_settings::get_handler,
+ crm::inbound::axum_router::team_settings::update_handler,
),
components(
schemas(
@@ -609,6 +611,9 @@ use utoipa::OpenApi;
crm::domain::comment::CrmComment,
crm::domain::comment::CrmCommentThread,
crm::domain::comment::DeleteCrmCommentResult,
+ crm::inbound::axum_router::team_settings::CrmTeamSettingsResponse,
+ crm::inbound::axum_router::team_settings::UpdateCrmTeamSettingsRequest,
+ crm::domain::model::CrmPermissionRole,
),
),
tags(