Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(home): show the mention sender in channel thread rows (#8366)

gbirman28a7e741c876
diff --git a/apps/web/src/features/home/components/HomeListEntity.tsx b/apps/web/src/features/home/components/HomeListEntity.tsx
index 6b3738f47e..f29da0f668 100644
--- a/apps/web/src/features/home/components/HomeListEntity.tsx
+++ b/apps/web/src/features/home/components/HomeListEntity.tsx
@@ -147,7 +147,10 @@ function HomeThreadTitle(
const entity = props.entity;
if (entity.type !== 'channel_thread') return undefined;
const notification = entity.notifications?.()?.[0];
- if (notification?.notification_metadata?.tag === 'channel_message_reply') {
+ if (
+ notification?.notification_metadata?.tag === 'channel_message_reply' ||
+ notification?.notification_metadata?.tag === 'channel_mention'
+ ) {
return {
id: notification.sender_id,
displayName:
diff --git a/apps/web/src/features/home/components/home-press.test.tsx b/apps/web/src/features/home/components/home-press.test.tsx
index 14f899e2cd..bb9e72b925 100644
--- a/apps/web/src/features/home/components/home-press.test.tsx
+++ b/apps/web/src/features/home/components/home-press.test.tsx
@@ -101,6 +101,44 @@ describe('Home channel reply row', () => {
expect(row.textContent).not.toContain('Peter');
});
+ it.each([
+ { senderId: 'macro|[email protected]', displayName: null, label: 'Teo' },
+ { senderId: null, displayName: 'Codex', label: 'Codex' },
+ { senderId: 'test-user', displayName: null, label: 'You' },
+ { senderId: null, displayName: null, label: 'Someone' },
+ ])(
+ 'names the mention sender as $label when a mention follows a reply',
+ ({ senderId, displayName, label }) => {
+ const previousReply = replyNotification('macro|[email protected]');
+ const { row, setNotifications } = renderThread([previousReply]);
+ expect(row.textContent).toContain('Peter in #bug-reports');
+
+ setNotifications([
+ {
+ ...replyNotification(senderId),
+ id: 'mention-notification',
+ created_at: '2026-10-01T16:35:48Z',
+ updated_at: '2026-10-01T16:35:48Z',
+ notification_event_type: 'channel_mention',
+ notification_metadata: {
+ tag: 'channel_mention',
+ content: {
+ messageId: 'mention',
+ messageContent: '@test-user',
+ threadId: 'root',
+ channelType: 'private',
+ senderDisplayName: displayName,
+ },
+ },
+ },
+ previousReply,
+ ]);
+
+ expect(row.textContent).toContain(`${label} in #bug-reports`);
+ expect(row.textContent).not.toContain('Peter');
+ }
+ );
+
it('uses the thread author when there is no notification', () => {
expect(renderThread().row.textContent).toContain('Peter in #bug-reports');
});
diff --git a/docs/agent-guide/home.md b/docs/agent-guide/home.md
index 1861641cd1..80bbd00f57 100644
--- a/docs/agent-guide/home.md
+++ b/docs/agent-guide/home.md
@@ -77,7 +77,11 @@ overrides saved filters. Returning through split history resets navigation to Si
Channel thread replies remain separate Home entries from their parent channel,
using single-line rows and a reply arrow icon on desktop, labeled
-with the sender and channel (for example, **Peter in #battlefield**). Channel names
+with the sender and channel (for example, **Peter in #battlefield**). Replies and
+mentions name the latest notification's sender, including bots, even after the
+notification is read. To verify, mention yourself from a second account in a
+thread started by someone else: the row must name the mentioner and open their
+message. Channel names
prefer the current channel cache, then a matching thread notification's name,
then **Unknown channel** if neither source has a name. Selecting a
thread opens that thread in the channel preview; Shift-click opens it in a split.