Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(analytics): disable Meta pixel in native apps (#7118)
Peter Chinman2a1fc5ff36e2
diff --git a/apps/web/src/lib/analytics/analytics.test.ts b/apps/web/src/lib/analytics/analytics.test.tsnew file mode 100644index 0000000000..c6c073a0a7--- /dev/null+++ b/apps/web/src/lib/analytics/analytics.test.ts@@ -0,0 +1,129 @@+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';++const mocks = vi.hoisted(() => ({+ platform: 'web' as 'web' | 'ios' | 'android' | 'desktop',+ touch: false,+ capture: vi.fn(),+ identify: vi.fn(),+ gtag: vi.fn(),+ fbq: vi.fn(),+}));++vi.mock('@core/util/platform', () => ({+ getPlatform: () => mocks.platform,+ isTauri: () => mocks.platform !== 'web',+}));+vi.mock('@core/mobile/isTouchDevice', () => ({+ isTouchDevice: () => mocks.touch,+}));+vi.mock('@core/constant/featureFlags', () => ({+ DEV_MODE_ENV: false,+ PROD_MODE_ENV: true,+}));+vi.mock('posthog-js', () => ({+ PostHog: class {+ capture = mocks.capture;+ identify = mocks.identify;+ },+}));++beforeEach(() => {+ vi.resetModules();+ vi.clearAllMocks();+ vi.stubEnv('DEV', false);+ vi.stubEnv('VITE_POSTHOG_API_KEY', '');+ vi.stubGlobal('gtag', mocks.gtag);+ vi.stubGlobal('fbq', mocks.fbq);+ mocks.platform = 'web';+ mocks.touch = false;+});++afterEach(() => {+ document.head.replaceChildren();+ vi.unstubAllEnvs();+ vi.unstubAllGlobals();+ vi.restoreAllMocks();+});++function hasMetaPixel() {+ return document.head.innerHTML.includes('connect.facebook.net');+}++describe('Meta pixel platform support', () => {+ it.each(['ios', 'android', 'desktop'] as const)(+ 'does not load or call Meta on %s, while keeping other analytics working',+ async (platform) => {+ mocks.platform = platform;+ // Native builds never install fbq. A missed guard would also prevent+ // the subsequent PostHog identify/pageview in the shared try blocks.+ vi.stubGlobal('fbq', undefined);+ const error = vi.spyOn(console, 'error').mockImplementation(() => {});+ const { analytics } = await import('./analytics');++ analytics.initializeProviders();+ expect(hasMetaPixel()).toBe(false);+ expect(document.head.querySelector('noscript')).toBeNull();++ analytics.trackMeta('Lead');+ analytics.track('test_event', {}, ['meta-pixel', 'ga', 'posthog']);+ analytics.identify('test-user', {});+ analytics.pageView('Inbox');++ expect(mocks.identify).toHaveBeenCalledWith('test-user', {});+ expect(mocks.capture).toHaveBeenCalledWith(+ 'test_event',+ expect.any(Object),+ undefined+ );+ expect(mocks.capture).toHaveBeenCalledWith(+ '$pageview',+ expect.objectContaining({ $title: 'Inbox' })+ );+ expect(mocks.gtag).toHaveBeenCalledWith(+ 'event',+ 'page_view',+ expect.objectContaining({ page_title: 'Inbox' })+ );+ expect(error).not.toHaveBeenCalled();+ }+ );++ it.each([false, true])(+ 'keeps Meta initialization and tracking on web (touch: %s)',+ async (touch) => {+ mocks.touch = touch;+ const { analytics } = await import('./analytics');+ expect(hasMetaPixel()).toBe(true);++ analytics.trackMeta('Lead', {}, { eventID: 'test-lead' });+ analytics.track('test_custom_event', {}, ['meta-pixel']);+ analytics.identify('test-user', {});+ analytics.pageView('Inbox');++ expect(mocks.fbq).toHaveBeenCalledWith(+ 'track',+ 'Lead',+ expect.objectContaining({+ macro_device: touch ? 'mobile-web' : 'desktop-web',+ }),+ { eventID: 'test-lead' }+ );+ expect(mocks.fbq).toHaveBeenCalledWith(+ 'trackCustom',+ 'test_custom_event',+ expect.any(Object),+ undefined+ );+ expect(mocks.fbq).toHaveBeenCalledWith(+ 'init',+ expect.any(String),+ expect.objectContaining({ external_id: 'test-user' })+ );+ expect(mocks.fbq).toHaveBeenCalledWith(+ 'track',+ 'PageView',+ expect.objectContaining({ content_name: 'Inbox' })+ );+ }+ );+});diff --git a/apps/web/src/lib/analytics/analytics.ts b/apps/web/src/lib/analytics/analytics.tsindex 095263939b..ec5ac393d5 100644--- a/apps/web/src/lib/analytics/analytics.ts+++ b/apps/web/src/lib/analytics/analytics.ts@@ -9,7 +9,7 @@ import {} from '@app/lib/analytics/providers';import { DEV_MODE_ENV, PROD_MODE_ENV } from '@core/constant/featureFlags';import { isTouchDevice } from '@core/mobile/isTouchDevice';-import { getPlatform } from '@core/util/platform';+import { getPlatform, isTauri } from '@core/util/platform';import {redactCallLinkProperties,redactCallLinkTokens,@@ -186,13 +186,16 @@ const createAnalytics = () => {const posthog = new PostHog();const disabled = import.meta.env.DEV === true;+ // Meta can submit events through hidden frames. Native navigation handlers+ // can mistake those loads for external links and open the system browser.+ const metaPixelEnabled = !isTauri();const initializeProviders = () => {if (disabled) return;if (!isPrivateCallPage()) {tryInitialize(initializeGoogleAnalytics);- tryInitialize(initializeMetaPixel);+ if (metaPixelEnabled) tryInitialize(initializeMetaPixel);}tryInitialize(() => initializePosthog(posthog));};@@ -219,6 +222,7 @@ const createAnalytics = () => {gtag('event', event, enriched);}).with('meta-pixel', () => {+ if (!metaPixelEnabled) return;const fbqMethod = META_STANDARD_EVENTS.has(event)? 'track': 'trackCustom';@@ -319,10 +323,12 @@ const createAnalytics = () => {...(info.os && { os: info.os }),});- fbq('init', '639142540393286', {- external_id: userID,- em: info.email,- });+ if (metaPixelEnabled) {+ fbq('init', '639142540393286', {+ external_id: userID,+ em: info.email,+ });+ }posthog.identify(userID, { ...info });} catch (e) {@@ -379,11 +385,13 @@ const createAnalytics = () => {page_path: pagePath,});- fbq('track', 'PageView', {- [DEVICE_PROPERTY]: deviceType,- [ENVIRONMENT_PROPERTY]: environment,- content_name: pageTitle,- });+ if (metaPixelEnabled) {+ fbq('track', 'PageView', {+ [DEVICE_PROPERTY]: deviceType,+ [ENVIRONMENT_PROPERTY]: environment,+ content_name: pageTitle,+ });+ }posthog.capture('$pageview', {[DEVICE_PROPERTY]: deviceType,