Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(email): don't strip light backgrounds layered on colored elements (#4455)
Evan Hutnik34281569b6f7
diff --git a/js/app/packages/core/email/tests/transform-email-colors.test.ts b/js/app/packages/core/email/tests/transform-email-colors.test.tsindex 6a8714dee0..e7342a1abf 100644--- a/js/app/packages/core/email/tests/transform-email-colors.test.ts+++ b/js/app/packages/core/email/tests/transform-email-colors.test.ts@@ -4,6 +4,7 @@ import {normalizeRGBA,parseRGBA,rgbaToOklch,+ stripContentBackgrounds,} from '../transform-email-colors';describe('parseRGBA', () => {@@ -89,6 +90,64 @@ describe('rgbaToOklch', () => {});});+describe('stripContentBackgrounds', () => {+ function render(html: string): HTMLElement {+ const root = document.createElement('div');+ root.innerHTML = html;+ document.body.appendChild(root);+ return root;+ }++ function bg(el: Element | null) {+ return (el as HTMLElement).style.backgroundColor;+ }++ it('strips light page-like backgrounds', () => {+ const root = render(+ '<div id="page" style="background-color:#ffffff">text</div>'+ );+ stripContentBackgrounds(root);+ expect(bg(root.querySelector('#page'))).toBe('transparent');+ root.remove();+ });++ it('keeps dark/colored backgrounds', () => {+ const root = render(+ '<a id="btn" style="background-color:#7e82c9;color:#ffffff">button</a>'+ );+ stripContentBackgrounds(root);+ expect(bg(root.querySelector('#btn'))).toBe('rgb(126, 130, 201)');+ root.remove();+ });++ it('keeps a light background layered on a kept colored ancestor (1px-border button trick)', () => {+ // Outer div is a colored "border", inner anchor is the light button face+ // with text color matching the border. Stripping the face would leave+ // same-on-same invisible text.+ const root = render(+ '<div id="border" style="background-color:#51b1e7;padding:1px">' ++ '<a id="face" style="background-color:#e4ecf2;color:#51b1e7">Very disappointed</a>' ++ '</div>'+ );+ stripContentBackgrounds(root);+ expect(bg(root.querySelector('#border'))).toBe('rgb(81, 177, 231)');+ expect(bg(root.querySelector('#face'))).toBe('rgb(228, 236, 242)');+ root.remove();+ });++ it('strips nested light backgrounds once the ancestor light bg is stripped', () => {+ const root = render(+ '<div id="outer" style="background-color:#ffffff">' ++ '<div id="inner" style="background-color:#f2f2f2">text</div>' ++ '</div>'+ );+ stripContentBackgrounds(root);+ expect(bg(root.querySelector('#outer'))).toBe('transparent');+ expect(bg(root.querySelector('#inner'))).toBe('transparent');+ root.remove();+ });+});+describe('findClosestContrastingColor', () => {const CONTRAST_THRESHOLD = 0.5;diff --git a/js/app/packages/core/email/transform-email-colors.ts b/js/app/packages/core/email/transform-email-colors.tsindex 3241b1a3f1..47e66774f2 100644--- a/js/app/packages/core/email/transform-email-colors.ts+++ b/js/app/packages/core/email/transform-email-colors.ts@@ -107,7 +107,7 @@ const LIGHT_BG_THRESHOLD = 0.85;/** Remove light/white backgrounds from all elements, preserving colored/dark backgrounds (buttons, banners).* Uses getComputedStyle to resolve all color formats (named colors, hex, rgb, etc.) */-function stripContentBackgrounds(root: Node) {+export function stripContentBackgrounds(root: Node) {const walker = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT);let el = walker.nextNode();while (el) {@@ -117,7 +117,11 @@ function stripContentBackgrounds(root: Node) {const rgba = normalizeRGBA(parseRGBA(bgColor));if (rgba && rgba.a > 0) {const oklch = rgbaToOklch(rgba);- if (oklch && oklch.l > LIGHT_BG_THRESHOLD) {+ if (+ oklch &&+ oklch.l > LIGHT_BG_THRESHOLD &&+ !hasOpaqueAncestorBackground(el, root)+ ) {el.style.setProperty('background-color','transparent',@@ -132,6 +136,23 @@ function stripContentBackgrounds(root: Node) {}}+/** True if an ancestor still has an opaque background. Parents are visited+ * before children, so any remaining opaque ancestor bg is one we kept+ * (non-light) — a light bg layered on it is content (e.g. a button face+ * inside a colored border div), not page chrome, and stripping it would+ * expose the colored bg behind text that wasn't styled to contrast with it. */+function hasOpaqueAncestorBackground(el: HTMLElement, root: Node): boolean {+ let ancestor = el.parentElement;+ while (ancestor && ancestor !== root) {+ const bg = normalizeRGBA(+ parseRGBA(getComputedStyle(ancestor).backgroundColor)+ );+ if (bg && bg.a > 0) return true;+ ancestor = ancestor.parentElement;+ }+ return false;+}+export function rgbaToOklch(rgba: RGBA | null): OKLCH | null {if (!rgba) return null;const { r, g, b, a } = rgba;