Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

Seanaye/chore/update gql flags (#5718)

Sean Aye342c7a255321
diff --git a/apps/web/src/lib/core/constant/featureFlags.ts b/apps/web/src/lib/core/constant/featureFlags.ts
index 6acb7f6d1c..39246d5607 100644
--- a/apps/web/src/lib/core/constant/featureFlags.ts
+++ b/apps/web/src/lib/core/constant/featureFlags.ts
@@ -487,11 +487,10 @@ export const ENABLE_GRAPHQL_SOUP_OVERRIDE = getFeatureFlagOverride(
const parseBooleanOverride = (value: unknown): boolean | undefined =>
value === 'true' ? true : value === 'false' ? false : undefined;
-/** Browser-only Turso/OPFS cache rollout. Production defaults off. */
-export const ENABLE_BROWSER_TURSO_CACHE_FLAG = 'enable-browser-turso-cache';
-const BROWSER_TURSO_CACHE_ENV = import.meta.env.VITE_ENABLE_BROWSER_TURSO_CACHE;
-export const ENABLE_BROWSER_TURSO_CACHE_OVERRIDE = parseBooleanOverride(
- BROWSER_TURSO_CACHE_ENV
+/** Controls the cache-warming GraphQL soup backfill. */
+export const ENABLE_GRAPHQL_BACKFILL = resolveFeatureFlag(
+ 'ENABLE_GRAPHQL_BACKFILL',
+ false
);
/** Independent emergency stop. Any true env/PostHog source wins. */
diff --git a/apps/web/src/lib/graphql-cache/rollout-policy.test.ts b/apps/web/src/lib/graphql-cache/rollout-policy.test.ts
index 4683377ba2..efc1436472 100644
--- a/apps/web/src/lib/graphql-cache/rollout-policy.test.ts
+++ b/apps/web/src/lib/graphql-cache/rollout-policy.test.ts
@@ -7,56 +7,39 @@ import {
const values: BooleanFlag[] = [undefined, false, true];
describe('browser Turso cache rollout policy', () => {
- it('is exhaustive: kill wins, explicit enable override is next, undefined fails closed', () => {
- for (const enableEnvOverride of values) {
- for (const disableEnvOverride of values) {
- for (const posthogEnable of values) {
- for (const posthogDisable of values) {
- const decision = resolveBrowserTursoCacheRollout({
- isTauri: false,
- graphqlTransportEnabled: true,
- enableEnvOverride,
- disableEnvOverride,
- posthogEnable,
- posthogDisable,
- });
- const killed =
- disableEnvOverride === true || posthogDisable === true;
- const expected = killed
- ? false
- : enableEnvOverride !== undefined
- ? enableEnvOverride
- : posthogEnable === true;
- expect(
- decision.enabled,
- JSON.stringify({
- enableEnvOverride,
- disableEnvOverride,
- posthogEnable,
- posthogDisable,
- })
- ).toBe(expected);
- if (killed) expect(decision.reason).toBe('emergency-disabled');
- }
- }
+ it('follows the GraphQL soup gate unless an emergency kill is active', () => {
+ for (const disableEnvOverride of values) {
+ for (const posthogDisable of values) {
+ const decision = resolveBrowserTursoCacheRollout({
+ isTauri: false,
+ graphqlTransportEnabled: true,
+ disableEnvOverride,
+ posthogDisable,
+ });
+ const killed = disableEnvOverride === true || posthogDisable === true;
+ expect(
+ decision.enabled,
+ JSON.stringify({ disableEnvOverride, posthogDisable })
+ ).toBe(!killed);
+ expect(decision.reason).toBe(
+ killed ? 'emergency-disabled' : 'graphql-transport-enabled'
+ );
}
}
});
- it('keeps production-style undefined flags off', () => {
+ it('enables browser cache when GraphQL soup is enabled', () => {
expect(
resolveBrowserTursoCacheRollout({
isTauri: false,
graphqlTransportEnabled: true,
- enableEnvOverride: undefined,
disableEnvOverride: undefined,
- posthogEnable: undefined,
posthogDisable: undefined,
})
).toEqual({
- enabled: false,
- cohort: 'control',
- reason: 'not-enabled',
+ enabled: true,
+ cohort: 'treatment',
+ reason: 'graphql-transport-enabled',
nativeCacheUnchanged: false,
});
});
@@ -66,9 +49,7 @@ describe('browser Turso cache rollout policy', () => {
resolveBrowserTursoCacheRollout({
isTauri: false,
graphqlTransportEnabled: false,
- enableEnvOverride: true,
disableEnvOverride: false,
- posthogEnable: true,
posthogDisable: false,
})
).toMatchObject({
@@ -84,10 +65,8 @@ describe('browser Turso cache rollout policy', () => {
resolveBrowserTursoCacheRollout({
isTauri: true,
graphqlTransportEnabled,
- // Even contradictory browser values are irrelevant on native.
- enableEnvOverride: !graphqlTransportEnabled,
+ // Browser emergency values are irrelevant on native.
disableEnvOverride: true,
- posthogEnable: !graphqlTransportEnabled,
posthogDisable: true,
})
).toEqual({
diff --git a/apps/web/src/lib/graphql-cache/rollout-policy.ts b/apps/web/src/lib/graphql-cache/rollout-policy.ts
index 4311335164..93e20038f6 100644
--- a/apps/web/src/lib/graphql-cache/rollout-policy.ts
+++ b/apps/web/src/lib/graphql-cache/rollout-policy.ts
@@ -5,9 +5,7 @@ export type BooleanFlag = boolean | undefined;
export type BrowserTursoCacheRolloutInput = {
isTauri: boolean;
graphqlTransportEnabled: boolean;
- enableEnvOverride: BooleanFlag;
disableEnvOverride: BooleanFlag;
- posthogEnable: BooleanFlag;
posthogDisable: BooleanFlag;
};
@@ -18,17 +16,15 @@ export type BrowserTursoCacheRolloutDecision = {
| 'tauri-native-unchanged'
| 'graphql-transport-disabled'
| 'emergency-disabled'
- | 'env-enabled'
- | 'posthog-enabled'
- | 'not-enabled';
+ | 'graphql-transport-enabled';
/** Whether the caller must retain the existing native cache path. */
nativeCacheUnchanged: boolean;
};
/**
- * Pure cache rollout policy. The emergency flag is intentionally independent from the
- * rollout flag and any true kill source wins. Undefined PostHog values fail
- * closed. Tauri returns before browser policy is considered.
+ * Pure cache rollout policy. The GraphQL soup gate enables both transport and
+ * cache. The emergency flag is independent and any true kill source wins.
+ * Tauri returns before browser policy is considered.
*/
export function resolveBrowserTursoCacheRollout(
input: BrowserTursoCacheRolloutInput
@@ -57,26 +53,10 @@ export function resolveBrowserTursoCacheRollout(
nativeCacheUnchanged: false,
};
}
- if (input.enableEnvOverride !== undefined) {
- return {
- enabled: input.enableEnvOverride,
- cohort: input.enableEnvOverride ? 'override' : 'control',
- reason: input.enableEnvOverride ? 'env-enabled' : 'not-enabled',
- nativeCacheUnchanged: false,
- };
- }
- if (input.posthogEnable === true) {
- return {
- enabled: true,
- cohort: 'treatment',
- reason: 'posthog-enabled',
- nativeCacheUnchanged: false,
- };
- }
return {
- enabled: false,
- cohort: 'control',
- reason: 'not-enabled',
+ enabled: true,
+ cohort: 'treatment',
+ reason: 'graphql-transport-enabled',
nativeCacheUnchanged: false,
};
}
diff --git a/apps/web/src/lib/graphql-cache/rollout.test.ts b/apps/web/src/lib/graphql-cache/rollout.test.ts
index d9d6540770..691e4a7f40 100644
--- a/apps/web/src/lib/graphql-cache/rollout.test.ts
+++ b/apps/web/src/lib/graphql-cache/rollout.test.ts
@@ -9,9 +9,7 @@ const mocks = vi.hoisted(() => ({
vi.mock('@core/util/platform', () => ({ isTauri: mocks.isTauri }));
vi.mock('@core/constant/featureFlags', () => ({
ENABLE_GRAPHQL_SOUP: mocks.graphqlEnabled,
- ENABLE_BROWSER_TURSO_CACHE_FLAG: 'enable-browser-turso-cache',
DISABLE_BROWSER_TURSO_CACHE_FLAG: 'disable-browser-turso-cache',
- ENABLE_BROWSER_TURSO_CACHE_OVERRIDE: undefined,
DISABLE_BROWSER_TURSO_CACHE_OVERRIDE: undefined,
}));
vi.mock('@app/lib/analytics', () => ({
@@ -32,20 +30,15 @@ describe('browser Turso cache production gate', () => {
mocks.isFeatureEnabled.mockReturnValue(undefined);
});
- it('fails closed while PostHog flags are undefined', () => {
+ it('enables browser cache with the GraphQL soup gate', () => {
expect(getBrowserTursoCacheRolloutDecision()).toMatchObject({
- enabled: false,
- cohort: 'control',
- reason: 'not-enabled',
+ enabled: true,
+ cohort: 'treatment',
+ reason: 'graphql-transport-enabled',
});
});
- it('uses a Boolean PostHog rollout and lets the independent kill win', () => {
- mocks.isFeatureEnabled.mockImplementation(
- (flag) => flag === 'enable-browser-turso-cache'
- );
- expect(getBrowserTursoCacheRolloutDecision().enabled).toBe(true);
-
+ it('lets the independent emergency kill win', () => {
mocks.isFeatureEnabled.mockReturnValue(true);
expect(getBrowserTursoCacheRolloutDecision()).toMatchObject({
enabled: false,
@@ -53,6 +46,14 @@ describe('browser Turso cache production gate', () => {
});
});
+ it('disables browser cache with the GraphQL soup gate', () => {
+ mocks.graphqlEnabled.mockReturnValue(false);
+ expect(getBrowserTursoCacheRolloutDecision()).toMatchObject({
+ enabled: false,
+ reason: 'graphql-transport-disabled',
+ });
+ });
+
it('does not read browser PostHog flags or subscribe on Tauri', () => {
mocks.isTauri.mockReturnValue(true);
mocks.graphqlEnabled.mockReturnValue(true);
diff --git a/apps/web/src/lib/graphql-cache/rollout.ts b/apps/web/src/lib/graphql-cache/rollout.ts
index de649a4b77..eaa5fd9741 100644
--- a/apps/web/src/lib/graphql-cache/rollout.ts
+++ b/apps/web/src/lib/graphql-cache/rollout.ts
@@ -2,8 +2,6 @@ import { analytics } from '@app/lib/analytics';
import {
DISABLE_BROWSER_TURSO_CACHE_FLAG,
DISABLE_BROWSER_TURSO_CACHE_OVERRIDE,
- ENABLE_BROWSER_TURSO_CACHE_FLAG,
- ENABLE_BROWSER_TURSO_CACHE_OVERRIDE,
ENABLE_GRAPHQL_SOUP,
} from '@core/constant/featureFlags';
import { isTauri } from '@core/util/platform';
@@ -22,9 +20,7 @@ export function getBrowserTursoCacheRolloutDecision(): BrowserTursoCacheRolloutD
return resolveBrowserTursoCacheRollout({
isTauri: true,
graphqlTransportEnabled,
- enableEnvOverride: undefined,
disableEnvOverride: undefined,
- posthogEnable: undefined,
posthogDisable: undefined,
});
}
@@ -32,11 +28,7 @@ export function getBrowserTursoCacheRolloutDecision(): BrowserTursoCacheRolloutD
return resolveBrowserTursoCacheRollout({
isTauri: false,
graphqlTransportEnabled,
- enableEnvOverride: ENABLE_BROWSER_TURSO_CACHE_OVERRIDE,
disableEnvOverride: DISABLE_BROWSER_TURSO_CACHE_OVERRIDE,
- posthogEnable: analytics.posthog.isFeatureEnabled(
- ENABLE_BROWSER_TURSO_CACHE_FLAG
- ),
posthogDisable: analytics.posthog.isFeatureEnabled(
DISABLE_BROWSER_TURSO_CACHE_FLAG
),
diff --git a/apps/web/src/lib/graphql-cache/worker/browser-test/graphql-soup-rollout-harness.ts b/apps/web/src/lib/graphql-cache/worker/browser-test/graphql-soup-rollout-harness.ts
index 04f0dd74e6..be879a6fd9 100644
--- a/apps/web/src/lib/graphql-cache/worker/browser-test/graphql-soup-rollout-harness.ts
+++ b/apps/web/src/lib/graphql-cache/worker/browser-test/graphql-soup-rollout-harness.ts
@@ -82,7 +82,6 @@ function overrideRolloutFlags(
analytics.posthog.featureFlags.overrideFeatureFlags({
flags: {
'enable-graphql-soup': true,
- 'enable-browser-turso-cache': true,
'disable-browser-turso-cache': disabled,
},
suppressWarning: true,
@@ -124,8 +123,6 @@ const api = {
overrideRolloutFlags(analytics, false);
const overrideApplied =
analytics.posthog.isFeatureEnabled('enable-graphql-soup') === true &&
- analytics.posthog.isFeatureEnabled('enable-browser-turso-cache') ===
- true &&
analytics.posthog.isFeatureEnabled('disable-browser-turso-cache') ===
false;
if (!overrideApplied) {
diff --git a/apps/web/src/lib/queries/soup/backfill.ts b/apps/web/src/lib/queries/soup/backfill.ts
index c6c573d95e..f97e451e15 100644
--- a/apps/web/src/lib/queries/soup/backfill.ts
+++ b/apps/web/src/lib/queries/soup/backfill.ts
@@ -1,3 +1,4 @@
+import { ENABLE_GRAPHQL_BACKFILL } from '@core/constant/featureFlags';
import { createTabLeaderSignal } from '@notifications/notification-election';
import type { SoupPage } from '@service-storage/generated/schemas/soupPage';
import {
@@ -428,6 +429,7 @@ export function useSoupBackfills(userId: Accessor<string | undefined>) {
const currentUserId = userId();
const currentLeadership = leadership();
const backfillEnabled =
+ ENABLE_GRAPHQL_BACKFILL &&
currentUserId !== undefined &&
graphqlCacheEnabled() &&
currentLeadership.isLeader;
diff --git a/apps/web/src/lib/service-clients/service-storage/graphql-soup.test.ts b/apps/web/src/lib/service-clients/service-storage/graphql-soup.test.ts
index be28946d24..f7a624e230 100644
--- a/apps/web/src/lib/service-clients/service-storage/graphql-soup.test.ts
+++ b/apps/web/src/lib/service-clients/service-storage/graphql-soup.test.ts
@@ -84,7 +84,9 @@ vi.mock('@graphql-cache/rollout', () => ({
(): BrowserTursoCacheRolloutDecision => ({
enabled: mocks.tauri ? mocks.graphqlEnabled : mocks.enabled,
cohort: mocks.tauri ? 'unknown' : 'treatment',
- reason: mocks.tauri ? 'tauri-native-unchanged' : 'posthog-enabled',
+ reason: mocks.tauri
+ ? 'tauri-native-unchanged'
+ : 'graphql-transport-enabled',
nativeCacheUnchanged: mocks.tauri,
}),
}));
diff --git a/apps/web/src/vite-env.d.ts b/apps/web/src/vite-env.d.ts
index 2205896d6a..9a4afc616c 100644
--- a/apps/web/src/vite-env.d.ts
+++ b/apps/web/src/vite-env.d.ts
@@ -10,7 +10,6 @@ interface ImportMetaEnv {
readonly VITE_OTEL_ENV?: string;
readonly VITE_ENABLE_BROWSER_OTEL?: string;
readonly VITE_ENABLE_REMINDERS?: string;
- readonly VITE_ENABLE_BROWSER_TURSO_CACHE?: string;
readonly VITE_DISABLE_BROWSER_TURSO_CACHE?: string;
}