Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

Add floating format menu to markdown textarea (#4459)

Jacob Beckerman34a19152ad41
diff --git a/js/app/packages/block-email/component/BaseInput.tsx b/js/app/packages/block-email/component/BaseInput.tsx
index 90cba0d4b8..d30c76d5fa 100644
--- a/js/app/packages/block-email/component/BaseInput.tsx
+++ b/js/app/packages/block-email/component/BaseInput.tsx
@@ -1712,6 +1712,7 @@ export function BaseInput(props: {
</div>
<MarkdownTextarea
autoLinkMatchMode="common-tlds"
+ floatingFormatMenu
captureEditor={(editor) => {
setEditor(editor);
form().setCapturedEditor(editor);
diff --git a/js/app/packages/block-email/component/compose/ComposeBody.tsx b/js/app/packages/block-email/component/compose/ComposeBody.tsx
index 7728501c19..44de22a04b 100644
--- a/js/app/packages/block-email/component/compose/ComposeBody.tsx
+++ b/js/app/packages/block-email/component/compose/ComposeBody.tsx
@@ -161,6 +161,7 @@ export function ComposeBody(props: {
<Scroll>
<MarkdownTextarea
autoLinkMatchMode="common-tlds"
+ floatingFormatMenu
domRef={props.inputRef}
captureEditor={captureEditor}
scrollRef={props.mobileScrollRef}
diff --git a/js/app/packages/channel/Input/configured-markdown-editor.ts b/js/app/packages/channel/Input/configured-markdown-editor.ts
index 75517bafea..468cf83b32 100644
--- a/js/app/packages/channel/Input/configured-markdown-editor.ts
+++ b/js/app/packages/channel/Input/configured-markdown-editor.ts
@@ -61,7 +61,8 @@ export function createConfiguredChannelMarkdownEditor(
.withHistory({ timeGap: 400 })
.withCode()
.withRestoreFocus()
- .withSelectionData();
+ .withSelectionData()
+ .withFloatingFormatMenu();
if (options.onAttachFromDisk) {
const onAttachFromDisk = options.onAttachFromDisk;
diff --git a/js/app/packages/channel/Input/tests/input-slots.test.tsx b/js/app/packages/channel/Input/tests/input-slots.test.tsx
index 93549e3892..fd2d01e70d 100644
--- a/js/app/packages/channel/Input/tests/input-slots.test.tsx
+++ b/js/app/packages/channel/Input/tests/input-slots.test.tsx
@@ -150,6 +150,7 @@ vi.mock(
withFilePaste: () => builder,
withRestoreFocus: () => builder,
withSelectionData: () => builder,
+ withFloatingFormatMenu: () => builder,
use: () => builder,
onChange: () => builder,
onEnter: () => builder,
diff --git a/js/app/packages/core/component/AI/component/input/buildChatEditor.ts b/js/app/packages/core/component/AI/component/input/buildChatEditor.ts
index 4821f42a82..46d5042671 100644
--- a/js/app/packages/core/component/AI/component/input/buildChatEditor.ts
+++ b/js/app/packages/core/component/AI/component/input/buildChatEditor.ts
@@ -19,6 +19,7 @@ export function buildChatEditor() {
.withCode()
.withRestoreFocus()
.withSelectionData()
+ .withFloatingFormatMenu()
.use(
tablePlugin({
hasCellMerge: true,
diff --git a/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownConfigBuilder.ts b/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownConfigBuilder.ts
index a8e8d2eb27..2355591140 100644
--- a/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownConfigBuilder.ts
+++ b/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownConfigBuilder.ts
@@ -37,6 +37,7 @@ export class EditorConfigBuilder implements EditorBuilder {
restoreFocus: false,
withIds: false,
selectionData: false,
+ floatingFormatMenu: false,
actions: false as const,
skipPreviewFetch: false,
};
@@ -110,6 +111,18 @@ export class EditorConfigBuilder implements EditorBuilder {
return this;
}
+ /**
+ * Show a floating format toolbar (headings, lists, inline styles, links)
+ * over the current text selection, like the markdown block's popup.
+ * Implies `.withSelectionData()`. The link button is only shown when
+ * `.withLinks({ floatingMenu: true })` is also enabled.
+ */
+ withFloatingFormatMenu(): this {
+ this.state.floatingFormatMenu = true;
+ this.state.selectionData = true;
+ return this;
+ }
+
/** Skip backend fetches in decorator components (e.g. mention preview API). */
withSkipPreviewFetch(): this {
this.state.skipPreviewFetch = true;
diff --git a/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownShell.tsx b/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownShell.tsx
index 0cfa23ad14..c43fde16bb 100644
--- a/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownShell.tsx
+++ b/js/app/packages/core/component/LexicalMarkdown/builder/MarkdownShell.tsx
@@ -22,6 +22,7 @@ import { DecoratorRenderer } from '../component/core/DecoratorRenderer';
import { NodeAccessoryRenderer } from '../component/core/NodeAccessoryRenderer';
import { ActionMenu } from '../component/menu/ActionsMenu';
import { EmojiMenu } from '../component/menu/EmojiMenu';
+import { FloatingFormatMenu } from '../component/menu/FloatingFormatMenu';
import { FloatingLinkMenu } from '../component/menu/FloatingLinkMenu';
import { MentionsMenu } from '../component/menu/MentionsMenu';
import { SnippetsMenu } from '../component/menu/SnippetsMenu';
@@ -315,12 +316,25 @@ export const MarkdownShell: Component<
)}
</Show>
- {/* Floating Link Menu */}
- <Show when={builderConfig.links?.floatingMenu}>
+ {/* Floating Link & Selection Format Menus */}
+ <Show
+ when={
+ builderConfig.links?.floatingMenu ||
+ builderConfig.floatingFormatMenu
+ }
+ >
<FloatingMenuGroup>
- <FloatingLinkMenu
- autoLinkMatchMode={builderConfig.links?.autoLinkMatchMode}
- />
+ <Show when={builderConfig.links?.floatingMenu}>
+ <FloatingLinkMenu
+ autoLinkMatchMode={builderConfig.links?.autoLinkMatchMode}
+ />
+ </Show>
+ <Show when={builderConfig.floatingFormatMenu}>
+ <FloatingFormatMenu
+ portalScope={props.portalScope}
+ showLinkButton={!!builderConfig.links?.floatingMenu}
+ />
+ </Show>
</FloatingMenuGroup>
</Show>
</div>
diff --git a/js/app/packages/core/component/LexicalMarkdown/builder/types.ts b/js/app/packages/core/component/LexicalMarkdown/builder/types.ts
index f3108c6491..d406092b81 100644
--- a/js/app/packages/core/component/LexicalMarkdown/builder/types.ts
+++ b/js/app/packages/core/component/LexicalMarkdown/builder/types.ts
@@ -136,6 +136,8 @@ export interface EditorConfig {
focusLeave?: FocusLeaveCallbacks;
withIds: boolean;
selectionData: boolean;
+ /** Show a floating format toolbar over the current text selection. */
+ floatingFormatMenu: boolean;
actions: ActionsOptions | false;
/** When true, decorator components skip backend fetches (e.g. preview API). */
skipPreviewFetch: boolean;
diff --git a/js/app/packages/core/component/LexicalMarkdown/component/core/MarkdownTextarea.tsx b/js/app/packages/core/component/LexicalMarkdown/component/core/MarkdownTextarea.tsx
index 50733bbd23..4e2fcd5520 100644
--- a/js/app/packages/core/component/LexicalMarkdown/component/core/MarkdownTextarea.tsx
+++ b/js/app/packages/core/component/LexicalMarkdown/component/core/MarkdownTextarea.tsx
@@ -59,6 +59,7 @@ import {
} from '../../utils';
import type { UserMentionRecord } from '../../utils/mentionsUtils';
import { EmojiMenu } from '../menu/EmojiMenu';
+import { FloatingFormatMenu } from '../menu/FloatingFormatMenu';
import { FloatingLinkMenu } from '../menu/FloatingLinkMenu';
import { MentionsMenu } from '../menu/MentionsMenu';
import { SnippetsMenu } from '../menu/SnippetsMenu';
@@ -109,6 +110,11 @@ interface MarkdownTextareaProps {
directories: FileSystemDirectoryEntry[]
) => void;
autoLinkMatchMode?: AutoLinkMatchMode;
+ /**
+ * Show a floating format toolbar (headings, lists, inline styles, links)
+ * over the current text selection, like the markdown block's popup.
+ */
+ floatingFormatMenu?: boolean;
}
export function MarkdownTextarea(props: MarkdownTextareaProps) {
@@ -382,6 +388,9 @@ export function MarkdownTextarea(props: MarkdownTextareaProps) {
/>
<FloatingMenuGroup>
<FloatingLinkMenu autoLinkMatchMode={props.autoLinkMatchMode} />
+ <Show when={props.floatingFormatMenu}>
+ <FloatingFormatMenu portalScope={props.portalScope} />
+ </Show>
</FloatingMenuGroup>
</div>
</LexicalWrapperContext.Provider>
diff --git a/js/app/packages/core/component/LexicalMarkdown/component/menu/FloatingFormatMenu.tsx b/js/app/packages/core/component/LexicalMarkdown/component/menu/FloatingFormatMenu.tsx
new file mode 100644
index 0000000000..6fee3b1d06
--- /dev/null
+++ b/js/app/packages/core/component/LexicalMarkdown/component/menu/FloatingFormatMenu.tsx
@@ -0,0 +1,432 @@
+/**
+ * @file A floating format toolbar that appears over the current text
+ * selection. Offers the same markdown controls as the markdown/tasks block
+ * selection popup (block styles, inline styles, links) without the
+ * block-specific actions, so lightweight editors like the email composer can
+ * opt in via MarkdownTextarea.
+ */
+import { type PortalScope, ScopedPortal } from '@core/component/ScopedPortal';
+import { isMobile } from '@core/mobile/isMobile';
+import { debouncedDependent } from '@core/util/debounce';
+import TextCode from '@phosphor/code.svg';
+import CodeBlock from '@phosphor/code-block.svg';
+import BrokenLinkIcon from '@phosphor/link-break.svg';
+import LinkIcon from '@phosphor/link-simple.svg';
+import ListBullets from '@phosphor/list-bullets.svg';
+import ListChecks from '@phosphor/list-checks.svg';
+import ListNumbers from '@phosphor/list-numbers.svg';
+import TextHighlight from '@phosphor/paint-roller.svg';
+import Quote from '@phosphor/quotes.svg';
+import TextAA from '@phosphor/text-aa.svg';
+import TextBold from '@phosphor/text-b.svg';
+import TextH from '@phosphor/text-h.svg';
+import TextH1 from '@phosphor/text-h-one.svg';
+import TextH3 from '@phosphor/text-h-three.svg';
+import TextH2 from '@phosphor/text-h-two.svg';
+import TextItalic from '@phosphor/text-italic.svg';
+import TextStriketrough from '@phosphor/text-strikethrough.svg';
+import TextSub from '@phosphor/text-subscript.svg';
+import TextSuper from '@phosphor/text-superscript.svg';
+import TextT from '@phosphor/text-t.svg';
+import TextUnderline from '@phosphor/text-underline.svg';
+import { Button, Dropdown, Layer, SingleSelectCheck } from '@ui';
+import {
+ COMMAND_PRIORITY_HIGH,
+ FORMAT_TEXT_COMMAND,
+ KEY_ESCAPE_COMMAND,
+} from 'lexical';
+import {
+ type Component,
+ createSignal,
+ For,
+ type JSX,
+ onCleanup,
+ Show,
+ useContext,
+} from 'solid-js';
+import { Dynamic } from 'solid-js/web';
+import {
+ createMenuOpenSignal,
+ MenuPriority,
+} from '../../context/FloatingMenuContext';
+import { LexicalWrapperContext } from '../../context/LexicalWrapperContext';
+import { floatWithSelection } from '../../directive/floatWithSelection';
+import {
+ autoRegister,
+ type EnhancedSelection,
+ NODE_TRANSFORM,
+ type NodeTransformType,
+ popupPlugin,
+ registerRootEventListener,
+ type SelectionData,
+ TRY_INSERT_LINK_COMMAND,
+ UNLINK_COMMAND,
+} from '../../plugins';
+
+false && floatWithSelection;
+
+const MENU_ID = 'floating-format-menu';
+
+type SvgIcon = Component<JSX.SvgSVGAttributes<SVGSVGElement>>;
+
+type InlineFormat =
+ | 'bold'
+ | 'italic'
+ | 'underline'
+ | 'strikethrough'
+ | 'highlight'
+ | 'code'
+ | 'superscript'
+ | 'subscript';
+
+// Only cmd+b/i/u are registered by Lexical's rich text in MarkdownTextarea,
+// so only those shortcuts are advertised here.
+const InlineFormatOptions: Array<{
+ format: InlineFormat;
+ icon: SvgIcon;
+ label: string;
+ shortcut?: string;
+}> = [
+ { format: 'bold', icon: TextBold, label: 'Bold', shortcut: 'cmd+b' },
+ { format: 'italic', icon: TextItalic, label: 'Italic', shortcut: 'cmd+i' },
+ {
+ format: 'underline',
+ icon: TextUnderline,
+ label: 'Underline',
+ shortcut: 'cmd+u',
+ },
+ { format: 'strikethrough', icon: TextStriketrough, label: 'Strikethrough' },
+ { format: 'code', icon: TextCode, label: 'Inline code' },
+ { format: 'highlight', icon: TextHighlight, label: 'Highlight' },
+ { format: 'superscript', icon: TextSuper, label: 'Superscript' },
+ { format: 'subscript', icon: TextSub, label: 'Subscript' },
+];
+
+type ElementOption = {
+ format: NodeTransformType;
+ icon: SvgIcon;
+ label: string;
+};
+
+const HeadingOptions: ElementOption[] = [
+ { format: 'heading1', icon: TextH1, label: 'Heading 1' },
+ { format: 'heading2', icon: TextH2, label: 'Heading 2' },
+ { format: 'heading3', icon: TextH3, label: 'Heading 3' },
+];
+
+const ListOptions: ElementOption[] = [
+ { format: 'list-bullet', icon: ListBullets, label: 'Bullet List' },
+ { format: 'list-number', icon: ListNumbers, label: 'Numbered List' },
+ { format: 'list-check', icon: ListChecks, label: 'Checklist' },
+];
+
+export function FloatingFormatMenu(props: {
+ portalScope?: PortalScope;
+ /**
+ * The link button dispatches commands handled by the links plugin, which is
+ * registered by FloatingLinkMenu. Pass false when no FloatingLinkMenu is
+ * mounted alongside this menu. Defaults to true.
+ */
+ showLinkButton?: boolean;
+}) {
+ const lexicalWrapper = useContext(LexicalWrapperContext);
+ if (!lexicalWrapper) {
+ console.error('FloatingFormatMenu requires LexicalWrapperContext!');
+ return '';
+ }
+
+ // On mobile the native selection toolbar takes this menu's place.
+ if (isMobile()) return '';
+
+ const { editor, plugins } = lexicalWrapper;
+ const selection = (): SelectionData | undefined => lexicalWrapper.selection;
+
+ const [menuOpen, setMenuOpen] = createMenuOpenSignal(
+ MENU_ID,
+ MenuPriority.Normal
+ );
+ const [selectionInfo, setSelectionInfo] =
+ createSignal<EnhancedSelection | null>(null, { equals: () => false });
+
+ plugins.use(
+ popupPlugin({
+ setIsPopupVisible: setMenuOpen,
+ setSelection: setSelectionInfo,
+ })
+ );
+
+ // Lag the open state so the menu doesn't flash while a selection is being
+ // dragged out (same delay as the markdown block popup).
+ const showMenu = debouncedDependent(menuOpen, 100);
+
+ const [menuRef, setMenuRef] = createSignal<HTMLDivElement>();
+
+ autoRegister(
+ registerRootEventListener(editor, 'focusout', ({ relatedTarget }) => {
+ if (relatedTarget instanceof Node && menuRef()?.contains(relatedTarget)) {
+ return;
+ }
+ setMenuOpen(false);
+ }),
+ editor.registerCommand(
+ NODE_TRANSFORM,
+ () => {
+ setMenuOpen(false);
+ return false;
+ },
+ COMMAND_PRIORITY_HIGH
+ ),
+ editor.registerCommand(
+ KEY_ESCAPE_COMMAND,
+ () => {
+ if (!menuOpen()) return false;
+ setMenuOpen(false);
+ return true;
+ },
+ COMMAND_PRIORITY_HIGH
+ )
+ );
+
+ onCleanup(() => {
+ setMenuOpen(false);
+ });
+
+ const refocusEditor = () => {
+ editor.focus();
+ };
+
+ const inlineFormat = (format: InlineFormat) => {
+ editor.dispatchCommand(FORMAT_TEXT_COMMAND, format);
+ };
+
+ const nodeFormat = (transform: NodeTransformType) => {
+ const isActive = selection()?.elementsInRange?.has(transform);
+ // If the node type is already active, transform back to paragraph.
+ editor.dispatchCommand(NODE_TRANSFORM, isActive ? 'paragraph' : transform);
+ };
+
+ const handleLink = () => {
+ if (selection()?.hasLinks) {
+ editor.dispatchCommand(UNLINK_COMMAND, undefined);
+ setTimeout(() => {
+ editor.focus();
+ });
+ return;
+ }
+ editor.dispatchCommand(TRY_INSERT_LINK_COMMAND, undefined);
+ };
+
+ const domSelection = () => {
+ const info = selectionInfo();
+ return info?.type === 'range' ? info.domSelection : undefined;
+ };
+
+ return (
+ <Show
+ when={showMenu() && lexicalWrapper.isInteractable() && domSelection()}
+ >
+ <ScopedPortal scope={props.portalScope}>
+ <Layer depth={2}>
+ <div
+ ref={setMenuRef}
+ class="fixed top-0 left-0 z-highlight-menu bg-surface shadow-xl ring-1 ring-edge rounded-lg p-1 flex flex-row items-center gap-1"
+ use:floatWithSelection={{
+ selection: domSelection(),
+ reactiveOnContainer: editor.getRootElement(),
+ useBlockBoundary: true,
+ moveWithSelection: true,
+ }}
+ >
+ <ElementFormatButton
+ format="paragraph"
+ icon={TextT}
+ label="Body"
+ selection={selection}
+ onFormat={nodeFormat}
+ />
+ <ElementFormatMenu
+ items={HeadingOptions}
+ icon={TextH}
+ label="Headings"
+ selection={selection}
+ onFormat={nodeFormat}
+ onCloseAutoFocus={refocusEditor}
+ />
+ <ElementFormatMenu
+ items={ListOptions}
+ icon={ListBullets}
+ label="Lists"
+ selection={selection}
+ onFormat={nodeFormat}
+ onCloseAutoFocus={refocusEditor}
+ />
+ <ElementFormatButton
+ format="code"
+ icon={CodeBlock}
+ label="Code"
+ selection={selection}
+ onFormat={nodeFormat}
+ />
+ <ElementFormatButton
+ format="quote"
+ icon={Quote}
+ label="Quote"
+ selection={selection}
+ onFormat={nodeFormat}
+ />
+ <InlineFormatMenu
+ selection={selection}
+ onFormat={inlineFormat}
+ onCloseAutoFocus={refocusEditor}
+ />
+ <Show when={props.showLinkButton ?? true}>
+ <Button
+ variant="ghost"
+ size="icon-sm"
+ class="rounded-md"
+ depth={3}
+ onPointerDown={(e: PointerEvent) => e.preventDefault()}
+ onClick={handleLink}
+ tooltip={selection()?.hasLinks ? 'Remove Link' : 'Insert Link'}
+ >
+ <Dynamic
+ component={selection()?.hasLinks ? BrokenLinkIcon : LinkIcon}
+ />
+ </Button>
+ </Show>
+ </div>
+ </Layer>
+ </ScopedPortal>
+ </Show>
+ );
+}
+
+function ElementFormatButton(props: {
+ format: NodeTransformType;
+ icon: SvgIcon;
+ label: string;
+ selection: () => SelectionData | undefined;
+ onFormat: (format: NodeTransformType) => void;
+}) {
+ const isActive = () =>
+ !!props.selection()?.elementsInRange?.has(props.format);
+ return (
+ <Button
+ tooltip={props.label}
+ size="icon-sm"
+ class="rounded-md"
+ depth={3}
+ variant={isActive() ? 'active' : 'ghost'}
+ onPointerDown={(e: PointerEvent) => e.preventDefault()}
+ onClick={(e: MouseEvent | KeyboardEvent) => {
+ e.preventDefault();
+ e.stopPropagation();
+ props.onFormat(props.format);
+ }}
+ >
+ <Dynamic component={props.icon} />
+ </Button>
+ );
+}
+
+function ElementFormatMenu(props: {
+ items: ElementOption[];
+ icon: SvgIcon;
+ label: string;
+ selection: () => SelectionData | undefined;
+ onFormat: (format: NodeTransformType) => void;
+ onCloseAutoFocus: () => void;
+}) {
+ const isAnyActive = () =>
+ props.items.some((item) =>
+ props.selection()?.elementsInRange?.has(item.format)
+ );
+ return (
+ <Dropdown>
+ <Dropdown.Trigger
+ variant={isAnyActive() ? 'active' : 'ghost'}
+ size="icon-sm"
+ class="rounded-md"
+ depth={3}
+ tooltip={props.label}
+ tabIndex={-1}
+ >
+ <Dynamic component={props.icon} />
+ </Dropdown.Trigger>
+ <Dropdown.Content onCloseAutoFocus={props.onCloseAutoFocus}>
+ <Dropdown.Group>
+ <For each={props.items}>
+ {(item) => {
+ const isActive = () =>
+ !!props.selection()?.elementsInRange?.has(item.format);
+ return (
+ <Dropdown.Item
+ onSelect={() => props.onFormat(item.format)}
+ class={isActive() ? 'text-ink' : ''}
+ role="menuitemradio"
+ aria-checked={isActive()}
+ >
+ <Dynamic component={item.icon} class="size-4 shrink-0" />
+ <span class="flex-1 truncate">{item.label}</span>
+ <SingleSelectCheck active={isActive()} />
+ </Dropdown.Item>
+ );
+ }}
+ </For>
+ </Dropdown.Group>
+ </Dropdown.Content>
+ </Dropdown>
+ );
+}
+
+function InlineFormatMenu(props: {
+ selection: () => SelectionData | undefined;
+ onFormat: (format: InlineFormat) => void;
+ onCloseAutoFocus: () => void;
+}) {
+ const [open, setOpen] = createSignal(false);
+ const isAnyActive = () =>
+ InlineFormatOptions.some((item) => props.selection()?.[item.format]);
+ return (
+ <Dropdown open={open()} onOpenChange={setOpen}>
+ <Dropdown.Trigger
+ variant={isAnyActive() ? 'active' : 'ghost'}
+ size="icon-sm"
+ class="rounded-md"
+ depth={3}
+ tooltip="Text Styles"
+ tabIndex={-1}
+ >
+ <TextAA />
+ </Dropdown.Trigger>
+ <Dropdown.Content onCloseAutoFocus={props.onCloseAutoFocus}>
+ <Dropdown.Group>
+ <div class="w-full flex gap-1 justify-center items-center">
+ <For each={InlineFormatOptions}>
+ {(item) => (
+ <Button
+ label={item.label}
+ shortcut={item.shortcut}
+ size="icon-sm"
+ variant={
+ props.selection()?.[item.format] ? 'active' : 'ghost'
+ }
+ class="rounded-md"
+ depth={3}
+ onClick={(e: MouseEvent | KeyboardEvent) => {
+ e.preventDefault();
+ e.stopPropagation();
+ props.onFormat(item.format);
+ setOpen(false);
+ }}
+ >
+ <Dynamic component={item.icon} />
+ </Button>
+ )}
+ </For>
+ </div>
+ </Dropdown.Group>
+ </Dropdown.Content>
+ </Dropdown>
+ );
+}
diff --git a/js/app/packages/core/component/LexicalMarkdown/directive/floatWithSelection.ts b/js/app/packages/core/component/LexicalMarkdown/directive/floatWithSelection.ts
index 769b0b862a..f9b5a42724 100644
--- a/js/app/packages/core/component/LexicalMarkdown/directive/floatWithSelection.ts
+++ b/js/app/packages/core/component/LexicalMarkdown/directive/floatWithSelection.ts
@@ -130,9 +130,8 @@ export function floatWithSelection(
const selectionChangeHandler = () => {
let selection = document.getSelection();
- let range = selection?.getRangeAt(0);
- if (!range) return;
- setCurrentAnchor(range);
+ if (!selection || selection.rangeCount === 0) return;
+ setCurrentAnchor(selection.getRangeAt(0));
setInitialFloatingPosition(selection);
};