Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(calendar): show tooltips on event details actions (#8585)

gbirman40be79e2ecaa
diff --git a/apps/web/src/features/calendar-view/components/SelectedEventDetails.tsx b/apps/web/src/features/calendar-view/components/SelectedEventDetails.tsx
index cb6f7c9126..bdf6c5cfa1 100644
--- a/apps/web/src/features/calendar-view/components/SelectedEventDetails.tsx
+++ b/apps/web/src/features/calendar-view/components/SelectedEventDetails.tsx
@@ -227,7 +227,7 @@ function EventDetailsDrawer(props: EventDetailsOverlayProps) {
<div class="flex items-center gap-1">
<Show when={!props.event.teamProjection}>
<Button
- aria-label="Copy event"
+ label="Copy event"
variant="ghost"
size="icon-md"
depth={3}
@@ -237,7 +237,7 @@ function EventDetailsDrawer(props: EventDetailsOverlayProps) {
<LinkIcon />
</Button>
<Button
- aria-label="Download .ics"
+ label="Download .ics"
variant="ghost"
size="icon-md"
depth={3}
@@ -247,7 +247,7 @@ function EventDetailsDrawer(props: EventDetailsOverlayProps) {
<DownloadSimpleIcon />
</Button>
<Button
- aria-label="Forward by email"
+ label="Forward by email"
variant="ghost"
size="icon-md"
depth={3}
@@ -259,7 +259,7 @@ function EventDetailsDrawer(props: EventDetailsOverlayProps) {
</Show>
<Show when={canModify()}>
<Button
- aria-label="Edit event"
+ label="Edit event"
variant="ghost"
size="icon-md"
depth={3}
@@ -269,7 +269,7 @@ function EventDetailsDrawer(props: EventDetailsOverlayProps) {
<PencilSimpleIcon />
</Button>
<Button
- aria-label="Delete event"
+ label="Delete event"
variant="ghost"
size="icon-md"
depth={3}
@@ -512,7 +512,7 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
<div class="flex shrink-0 items-center justify-end gap-1 px-2 pt-2">
<Show when={!props.event.teamProjection}>
<Button
- aria-label="Copy event"
+ label="Copy event"
variant="ghost"
size="icon-sm"
depth={3}
@@ -522,7 +522,7 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
<LinkIcon />
</Button>
<Button
- aria-label="Download .ics"
+ label="Download .ics"
variant="ghost"
size="icon-sm"
depth={3}
@@ -532,7 +532,7 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
<DownloadSimpleIcon />
</Button>
<Button
- aria-label="Forward by email"
+ label="Forward by email"
variant="ghost"
size="icon-sm"
depth={3}
@@ -544,7 +544,7 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
</Show>
<Show when={canModify()}>
<Button
- aria-label="Edit event"
+ label="Edit event"
variant="ghost"
size="icon-sm"
depth={3}
@@ -554,7 +554,7 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
<PencilSimpleIcon />
</Button>
<Button
- aria-label="Delete event"
+ label="Delete event"
variant="ghost"
size="icon-sm"
depth={3}
@@ -564,9 +564,12 @@ function EventDetailsPopover(props: EventDetailsPopoverProps) {
<TrashIcon />
</Button>
</Show>
+ {/* Kobalte names the button "Dismiss" unless it gets an
+ aria-label, which Button prefers over `label`. */}
<Popover.CloseButton
as={Button}
aria-label="Close event details"
+ tooltip="Close event details"
variant="ghost"
size="icon-sm"
depth={3}
diff --git a/apps/web/src/features/calendar/components/EventRsvpScopeDialog.tsx b/apps/web/src/features/calendar/components/EventRsvpScopeDialog.tsx
index d74d4f787a..61b924f4bb 100644
--- a/apps/web/src/features/calendar/components/EventRsvpScopeDialog.tsx
+++ b/apps/web/src/features/calendar/components/EventRsvpScopeDialog.tsx
@@ -33,7 +33,13 @@ export function EventRsvpScopeDialog(props: {
>
<Panel depth={2} class="max-w-[calc(100vw-2rem)] rounded-xl text-ink">
<Panel.Header class="gap-1 px-2">
- <Dialog.CloseButton as={Button} variant="ghost" size="icon-sm">
+ <Dialog.CloseButton
+ as={Button}
+ aria-label="Close RSVP"
+ tooltip="Close RSVP"
+ variant="ghost"
+ size="icon-sm"
+ >
<CloseIcon />
</Dialog.CloseButton>
<Dialog.Title as="span" class="m-0 p-0 text-sm font-medium">
diff --git a/docs/agent-guide/calendar.md b/docs/agent-guide/calendar.md
index 02c8fb43b8..fae9a76ab5 100644
--- a/docs/agent-guide/calendar.md
+++ b/docs/agent-guide/calendar.md
@@ -477,6 +477,10 @@ Nothing is saved as a draft until you edit something. The file is `METHOD:PUBLIS
recipients get a copy to add to their calendar, not an invitation they can answer. If the file
cannot be fetched, no composer opens and a `Failed to forward event` toast shows; to check it,
answer the `.ics` route with an error.
+On desktop, every icon button in the details header (`Copy event`, `Download .ics`, `Forward
+by email`, `Edit event`, `Delete event`, `Close event details`) and in the guests row shows its
+name as a tooltip on hover, as does the close button of the recurring RSVP dialog. Touch
+devices show no tooltips; the phone drawer's buttons keep the same accessible names.
With the `enable-calendar-team-ooo` flag on, teammates' Google Calendar out-of-office events
overlay the grid as read-only chips titled `<name>: <event title>`. The sidebar's