Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

feat(models_permissions): add initiative share constructor and TeamShareCreation::Initiative (#6416)

Will Hutchinson4746bd9b4dc8
diff --git a/crates/models_permissions/src/share_permission.rs b/crates/models_permissions/src/share_permission.rs
index 2244f5fe09..d71de8ee39 100644
--- a/crates/models_permissions/src/share_permission.rs
+++ b/crates/models_permissions/src/share_permission.rs
@@ -95,6 +95,12 @@ impl SharePermissionV2 {
let (link_share, link_share_access_level) = Self::resolve(team_default, (None, None));
Self::new(link_share, link_share_access_level)
}
+
+ /// Creates a new share permission object for an initiative
+ pub fn new_initiative_share_permission(team_default: Option<TeamLinkShareDefault>) -> Self {
+ let (link_share, link_share_access_level) = Self::resolve(team_default, (None, None));
+ Self::new(link_share, link_share_access_level)
+ }
}
/// Deserializes an optional field while preserving explicit `null` values.
diff --git a/crates/models_permissions/src/share_permission/team_share.rs b/crates/models_permissions/src/share_permission/team_share.rs
index e8be9c52a5..623304574c 100644
--- a/crates/models_permissions/src/share_permission/team_share.rs
+++ b/crates/models_permissions/src/share_permission/team_share.rs
@@ -212,6 +212,8 @@ pub enum TeamShareCreation {
ExplicitTask,
/// A new call initializes View only if its creator currently belongs to a team.
Call,
+ /// A new initiative initializes Edit; missing membership is an error.
+ Initiative,
}
impl TeamShareCreation {
@@ -230,6 +232,10 @@ impl TeamShareCreation {
team_id,
level: TeamShareLevel::View,
})),
+ Self::Initiative => Ok(Some(TeamShareGrant {
+ team_id: owner_team_id.ok_or(TeamSharePolicyError::MissingTeam)?,
+ level: TeamShareLevel::Edit,
+ })),
}
}
}
diff --git a/crates/models_permissions/src/share_permission/team_share/test.rs b/crates/models_permissions/src/share_permission/team_share/test.rs
index f9bcf54549..c5cfdf5175 100644
--- a/crates/models_permissions/src/share_permission/team_share/test.rs
+++ b/crates/models_permissions/src/share_permission/team_share/test.rs
@@ -263,7 +263,7 @@ fn invalid_or_exhausted_revisions_cannot_produce_commands() {
}
#[test]
-fn creation_contract_distinguishes_ordinary_task_and_call_defaults() {
+fn creation_contract_distinguishes_ordinary_task_call_and_initiative_defaults() {
let team_id = Uuid::from_u128(1);
for team in [None, Some(team_id)] {
assert_eq!(TeamShareCreation::Unshared.resolve(team), Ok(None));
@@ -286,6 +286,17 @@ fn creation_contract_distinguishes_ordinary_task_and_call_defaults() {
level: TeamShareLevel::Comment,
}))
);
+ assert_eq!(
+ TeamShareCreation::Initiative.resolve(None),
+ Err(TeamSharePolicyError::MissingTeam)
+ );
+ assert_eq!(
+ TeamShareCreation::Initiative.resolve(Some(team_id)),
+ Ok(Some(TeamShareGrant {
+ team_id,
+ level: TeamShareLevel::Edit,
+ }))
+ );
}
#[test]
diff --git a/crates/models_permissions/src/share_permission/test.rs b/crates/models_permissions/src/share_permission/test.rs
index e179eb3b5d..04268e9718 100644
--- a/crates/models_permissions/src/share_permission/test.rs
+++ b/crates/models_permissions/src/share_permission/test.rs
@@ -119,6 +119,30 @@ fn project_constructor_follows_team_default() {
);
}
+#[test]
+fn initiative_constructor_without_team_disables_link_sharing() {
+ assert_eq!(
+ SharePermissionV2::new_initiative_share_permission(None),
+ share(None, None)
+ );
+}
+
+#[test]
+fn initiative_constructor_follows_team_default() {
+ assert_eq!(
+ SharePermissionV2::new_initiative_share_permission(TEAM_PUBLIC),
+ share(Some(LinkShare::Public), Some(AccessLevel::View))
+ );
+ assert_eq!(
+ SharePermissionV2::new_initiative_share_permission(TEAM_TEAM),
+ share(Some(LinkShare::Team), Some(AccessLevel::View))
+ );
+ assert_eq!(
+ SharePermissionV2::new_initiative_share_permission(TEAM_OFF),
+ share(None, None)
+ );
+}
+
#[test]
fn resolved_permissions_never_have_a_level_without_a_scope() {
// Mirrors the DB check constraint: linkShareAccessLevel must be NULL when linkShare is NULL.
@@ -129,6 +153,7 @@ fn resolved_permissions_never_have_a_level_without_a_scope() {
SharePermissionV2::new_document_share_permission(None, team_default),
SharePermissionV2::new_chat_share_permission(team_default),
SharePermissionV2::new_project_share_permission(team_default),
+ SharePermissionV2::new_initiative_share_permission(team_default),
] {
assert_eq!(permission.team_share_access_level, None);
if permission.link_share.is_none() {