Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(reviews): redirect disabled Reviews list to Tasks (#7161)

dev-rb4a6ecca04517
diff --git a/apps/web/src/features/reviews-view/route.tsx b/apps/web/src/features/reviews-view/route.tsx
index 9c3243b8fc..2a0b3cf89a 100644
--- a/apps/web/src/features/reviews-view/route.tsx
+++ b/apps/web/src/features/reviews-view/route.tsx
@@ -1,9 +1,13 @@
-import { defineRoute } from '@app/lib/split-router';
+import { tasksSplitRoute } from '@app/features/tasks-view/route';
+import { useFeatureFlag } from '@app/lib/analytics/posthog';
+import { defineRoute, useNavigate, useParams } from '@app/lib/split-router';
import {
usePageViewTracking,
withAuth,
} from '@components/app/split-layout/split-router/app-route-shell';
-import { lazy } from 'solid-js';
+import { LoadingBlock } from '@core/component/LoadingBlock';
+import { enableTasksReviews } from '@core/constant/featureFlags';
+import { lazy, onMount, Show } from 'solid-js';
import { z } from 'zod';
import { reviewsTabSearch } from './reviews-tab-search';
@@ -15,12 +19,35 @@ const ReviewsPrDetailRouteView = lazy(async () => ({
.ReviewsPrDetailRouteView,
}));
+function DisabledReviewsRoute() {
+ const navigate = useNavigate();
+ onMount(() =>
+ navigate({ route: tasksSplitRoute, params: {} }, { replace: true })
+ );
+ return null;
+}
+
function TrackedReviewsView() {
usePageViewTracking('reviews');
return <ReviewsView />;
}
-export const ReviewsRouteView = withAuth(TrackedReviewsView);
+export const ReviewsRouteView = withAuth(() => {
+ const params = useParams<{ foreignEntityId?: string }>();
+ const flag = useFeatureFlag(enableTasksReviews);
+ return (
+ <Show
+ when={params.foreignEntityId || flag().enabled}
+ fallback={
+ <Show when={!flag().loading} fallback={<LoadingBlock />}>
+ <DisabledReviewsRoute />
+ </Show>
+ }
+ >
+ <TrackedReviewsView />
+ </Show>
+ );
+});
export const reviewsPrRoute = defineRoute({
id: 'reviews-pr',
diff --git a/docs/AGENT_GUIDE/tasks.md b/docs/AGENT_GUIDE/tasks.md
index 3fd62f6c1a..634df29c5a 100644
--- a/docs/AGENT_GUIDE/tasks.md
+++ b/docs/AGENT_GUIDE/tasks.md
@@ -57,8 +57,9 @@ global Favorites sidebar or command menu.
Select a PR to open `/app/reviews/pr/<foreignEntityId>` in the Reviews shell.
Its breadcrumb returns to the Reviews list. Old `/app/pr/<id>` links redirect
-to the Reviews detail. When the flag is off, the Reviews shortcut is hidden,
-but copied PR detail links still work.
+to the Reviews detail. When the flag is off, the Reviews shortcut is hidden and
+opening `/app/reviews` redirects to `/app/tasks` after flags load. Copied PR
+detail links still work; check both URLs with the flag off.
Check all three tab URLs, author avatars and display names, row selection and
context menu, favorites add/remove and collapse/empty visibility, filters, sort,