Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

test(search): cover bot-owned document indexing (#6766)

Will Hutchinson773beb590098
diff --git a/crates/models_search/src/lib.rs b/crates/models_search/src/lib.rs
index f0432d6a57..8270a653b5 100644
--- a/crates/models_search/src/lib.rs
+++ b/crates/models_search/src/lib.rs
@@ -1,3 +1,6 @@
+//! An indexed `owner_id` is the owner's canonical principal string. "Mine" filters compare it
+//! directly with the caller's principal string, so indexing must preserve prefixes such as `bot|`.
+
use schemars::JsonSchema;
use serde::{Deserialize, Serialize};
use strum::{Display, EnumString};
diff --git a/services/search_processing_service/src/inbound/kafka_consumer/test.rs b/services/search_processing_service/src/inbound/kafka_consumer/test.rs
index 39086526f3..52962298f6 100644
--- a/services/search_processing_service/src/inbound/kafka_consumer/test.rs
+++ b/services/search_processing_service/src/inbound/kafka_consumer/test.rs
@@ -1460,6 +1460,47 @@ fn document_extractor_messages_disable_index_overrides_and_set_expected_users()
assert_eq!(sync.index_override, None);
}
+#[test]
+fn bot_owned_document_event_preserves_the_principal_for_indexing() {
+ const BOT_PRINCIPAL: &str = "bot|00000000-0000-0000-0000-00000000a1a1";
+
+ let message = TestMessage {
+ topic: MacroDocumentsTopic::TOPIC_STR,
+ key: Some(DOCUMENT_ID.to_string()),
+ payload: Some(
+ br#"{
+ "event_id":"00000000-0000-0000-0000-000000000001",
+ "schema_version":1,
+ "event_type":"document.content_uploaded",
+ "metadata":{
+ "document_id":"document-id",
+ "owner":"bot|00000000-0000-0000-0000-00000000a1a1",
+ "file_type":"pdf",
+ "document_version_id":"convert"
+ }
+ }"#
+ .to_vec(),
+ ),
+ };
+
+ let decoded = DeclaredMacroEvent::decode(&message).expect("decodable document event");
+ let DeclaredMacroEvent::DocumentMacroEvent(event) = decoded else {
+ panic!("expected document event");
+ };
+ let DocumentIndexAction::ExtractText {
+ owner,
+ file_type,
+ document_version_id,
+ } = describe_document_event(&event.event().event).action
+ else {
+ panic!("expected document extraction");
+ };
+ let extractor_message =
+ stored_extractor_message(DOCUMENT_ID, owner, file_type, document_version_id);
+
+ assert_eq!(extractor_message.user_id, BOT_PRINCIPAL);
+}
+
#[test]
fn maps_all_project_lifecycle_events_to_reconciliation_actions() {
let cases = project_event_cases();
diff --git a/services/search_processing_service/src/process/document/raw_document/test.rs b/services/search_processing_service/src/process/document/raw_document/test.rs
index 65a74ac5d5..736a06d819 100644
--- a/services/search_processing_service/src/process/document/raw_document/test.rs
+++ b/services/search_processing_service/src/process/document/raw_document/test.rs
@@ -102,6 +102,24 @@ fn parent_only_document_info(file_type: Option<&str>) -> DocumentMetadata {
}
}
+#[test]
+fn generate_upserts_preserves_a_bot_owner_principal() {
+ const BOT_PRINCIPAL: &str = "bot|00000000-0000-0000-0000-00000000a1a1";
+
+ let mut document_info = parent_only_document_info(Some("md"));
+ document_info.owner = BOT_PRINCIPAL.to_string().try_into().unwrap();
+ let markdown_result = vec![MarkdownParseResult {
+ node_id: "node1".to_string(),
+ raw_content: "# Bot document".to_string(),
+ content: "Bot document".to_string(),
+ }];
+
+ let upserts = generate_upserts(document_info, markdown_result).expect("valid upsert");
+
+ assert_eq!(upserts.len(), 1);
+ assert_eq!(upserts[0].owner_id, BOT_PRINCIPAL);
+}
+
#[test]
fn test_generate_parent_only_upsert() {
let args = generate_parent_only_upsert(parent_only_document_info(Some("zip")))