Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(mobile): filter by assignee (#5646)

Peter Chinman7a684a88e80d
diff --git a/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx b/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
index e0ae879874..8f2f18ffc2 100644
--- a/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
+++ b/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
@@ -72,17 +72,11 @@ function scrollAccordionItemToTop(
}
export const MobileFilterDrawer = () => {
- const { consolidatedFiltersList, resetToTabDefaults } =
+ const { consolidatedFiltersList, resetToTabDefaults, handleAssigneeChange } =
useFilterRefinements();
- const {
- soup,
- queryFilters,
- assigneeFilter,
- setAssigneeFilter,
- inboxFilter,
- setInboxFilter,
- } = useSoupView();
+ const { soup, queryFilters, assigneeFilter, inboxFilter, setInboxFilter } =
+ useSoupView();
const panel = useSplitPanelOrThrow();
const contacts = useContacts();
const userId = useUserId();
@@ -194,13 +188,14 @@ export const MobileFilterDrawer = () => {
}
};
+ // Routes through handleAssigneeChange so the assignee predicate and the
+ // server-side property query stay in sync with the selection — setting the
+ // signal alone updates the badge but never filters the list.
const toggleAssignee = (id: string) => {
const current = assigneeFilter();
- if (current.includes(id)) {
- setAssigneeFilter(current.filter((a) => a !== id));
- } else {
- setAssigneeFilter([...current, id]);
- }
+ handleAssigneeChange(
+ current.includes(id) ? current.filter((a) => a !== id) : [...current, id]
+ );
};
const assigneeOptions = createMemo(() => {
diff --git a/apps/web/src/features/next-soup/soup-view/filters-bar/use-filter-refinements.tsx b/apps/web/src/features/next-soup/soup-view/filters-bar/use-filter-refinements.tsx
index 5efa63d642..89969ae7b1 100644
--- a/apps/web/src/features/next-soup/soup-view/filters-bar/use-filter-refinements.tsx
+++ b/apps/web/src/features/next-soup/soup-view/filters-bar/use-filter-refinements.tsx
@@ -963,5 +963,6 @@ export function useFilterRefinements() {
resetToTabDefaults,
currentView,
consolidatedFiltersList,
+ handleAssigneeChange,
};
}