Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(agents): hide empty card when advanced settings collapse (#8888)
gbirman827d0dce91ca
diff --git a/apps/web/src/features/settings/Agents.tsx b/apps/web/src/features/settings/Agents.tsxindex 2fb6dc80b7..71cac51206 100644--- a/apps/web/src/features/settings/Agents.tsx+++ b/apps/web/src/features/settings/Agents.tsx@@ -1342,6 +1342,7 @@ function AgentEditorPage(props: {<AgentFormSectiontitle="Advanced"description={advancedSummary()}+ expanded={advancedOpen()}actions={<Buttontype="button"@@ -1548,6 +1549,7 @@ function AgentFormSection(props: {title: string;description: string;actions?: JSX.Element;+ expanded?: boolean;children: JSX.Element;}) {return (@@ -1555,6 +1557,7 @@ function AgentFormSection(props: {title={props.title}description={props.description}actions={props.actions}+ expanded={props.expanded}><div class="pt-2">{props.children}</div></SettingsSection>diff --git a/apps/web/src/features/settings/primitives.tsx b/apps/web/src/features/settings/primitives.tsxindex 5d8716f485..d07fcc31f8 100644--- a/apps/web/src/features/settings/primitives.tsx+++ b/apps/web/src/features/settings/primitives.tsx@@ -121,6 +121,8 @@ export function SettingsPage(props: {export function SettingsSection(props: {title?: JSX.Element;description?: string;+ /** Collapsible sections keep their heading visible when the body is closed. */+ expanded?: boolean;/** Right-aligned controls beside the section heading. */actions?: JSX.Element;class?: string;@@ -154,9 +156,11 @@ export function SettingsSection(props: {</Show></div></Show>- <SettingsSurface class="flex flex-col gap-2 p-4">- {props.children}- </SettingsSurface>+ <Show when={props.expanded ?? true}>+ <SettingsSurface class="flex flex-col gap-2 p-4">+ {props.children}+ </SettingsSurface>+ </Show></section>);}diff --git a/docs/agent-guide/settings.md b/docs/agent-guide/settings.mdindex da9dd748d0..ce0616545d 100644--- a/docs/agent-guide/settings.md+++ b/docs/agent-guide/settings.md@@ -625,7 +625,10 @@ mention picker; select text to open the formatting menu. Saved instructionsretain mention identities using the shared editor's Markdown format and reopenwith their formatting intact. Enter adds a new paragraph; use `Create agent` or`Save changes` to submit. The form also includes runtime selectors.-Under the runtime, `Answering a mention` chooses between `Coding agent` (a+`Advanced` starts collapsed on desktop and mobile, showing only its heading,+summary, and `Show` action, without an empty card beneath it. `Show` reveals the+settings; `Hide` collapses them again and preserves the selected options.+Under `Advanced`, `Answering a mention` chooses between `Coding agent` (achannel mention is answered with a magic chip that opens into the live session)and `Chat agent` (the agent replies in the thread, like `@macro`). It is theagent's own setting and always saved: a new form starts from the selected runtime