Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(notifications): keep the phone prompt off email threads and search (#8718)
gbirman938afce699b7
diff --git a/.agents/rules/web/mobile.md b/.agents/rules/web/mobile.mdindex e95d901b37..328d43ea1c 100644--- a/.agents/rules/web/mobile.md+++ b/.agents/rules/web/mobile.md@@ -62,8 +62,10 @@ read their code, and follow that pattern rather than inventing a new one.- Persistent prompts (`toast.custom` with `persistent`) go to the promptregion (`useKeyedPersistentToasts` does it), which hides while a popover,dialog, or drawer is open, or while a presented pane carries- `data-holds-prompts` (the touch email composer does); a prompt in the- transient region would cover a sheet's controls.+ `data-holds-prompts`. Mark a full-frame touch view with it when its last+ controls sit right above the dock, as the email composer, email thread and+ search results do; a prompt in the transient region would cover a sheet's+ controls.## Keyboard and focusdiff --git a/apps/web/src/features/command/mobile/MobileSearchResults.tsx b/apps/web/src/features/command/mobile/MobileSearchResults.tsxindex 4ff5491e04..19446e7cb7 100644--- a/apps/web/src/features/command/mobile/MobileSearchResults.tsx+++ b/apps/web/src/features/command/mobile/MobileSearchResults.tsx@@ -367,7 +367,11 @@ function MobileFullTextResults(props: {);}-/** The dock owns the input; only the result subtree changes search modes. */+/**+ * The dock owns the input; only the result subtree changes search modes.+ * Persistent prompts wait while results are presented, so they never cover+ * the last rows above the search bar.+ */export function MobileSearchResults() {const session = createMobileSearchEntry();const accountId = useUserId();@@ -375,6 +379,7 @@ export function MobileSearchResults() {return (<divclass="relative size-full min-h-0 min-w-0"+ data-holds-promptsstyle={{'--mobile-content-inset-top': 'calc(var(--safe-top, 0px) + 3.75rem)',}}diff --git a/apps/web/src/features/email-thread/views/email-thread.tsx b/apps/web/src/features/email-thread/views/email-thread.tsxindex 9ada66e2bb..9b9952584f 100644--- a/apps/web/src/features/email-thread/views/email-thread.tsx+++ b/apps/web/src/features/email-thread/views/email-thread.tsx@@ -115,8 +115,13 @@ export function EmailThreadView(props: EmailThreadViewProps) {}}>{/* Edge-to-edge on mobile/tablet: the message list carries its own- insets in-scroll and under-scrolls the floating chrome. */}- <div class="size-full select-none overscroll-none overflow-hidden flex flex-col">+ insets in-scroll and under-scrolls the floating chrome, so+ persistent prompts wait rather than cover its last+ attachments and actions. */}+ <div+ class="size-full select-none overscroll-none overflow-hidden flex flex-col"+ data-holds-prompts={isTouchDevice() ? '' : undefined}+ >{props.header}{props.actions}{viewContext.rendering.renderOrganizationStatus?.({diff --git a/apps/web/src/lib/core/component/Toast/ToastRegion.tsx b/apps/web/src/lib/core/component/Toast/ToastRegion.tsxindex 405a57c5ba..aed574c1fb 100644--- a/apps/web/src/lib/core/component/Toast/ToastRegion.tsx+++ b/apps/web/src/lib/core/component/Toast/ToastRegion.tsx@@ -53,7 +53,8 @@ export function ToastRegion() {soon as a new one is shown. Persistent prompts live in their ownregion above that slot, capped at one visible card with the restqueued until it is answered. Prompts step aside as on desktop: while a- drawer, sheet, dialog, or full-screen composer is open.+ drawer, sheet, or dialog is open, or a full-frame view that holds them+ (composer, email thread, search) is presented.*/}<divclass="fixed left-1/2 -translate-x-1/2 w-full max-w-[420px] px-(--mobile-chrome-gutter) pointer-events-none z-toast-region flex flex-col gap-2"diff --git a/docs/agent-guide/settings.md b/docs/agent-guide/settings.mdindex 277e68a315..1a2cac9cc0 100644--- a/docs/agent-guide/settings.md+++ b/docs/agent-guide/settings.md@@ -84,8 +84,10 @@ notification provider; macOS uses its system permission dialog. The web promptcontinues to say **Enable Browser Notifications** and uses browser permissions.Select **Hide** to dismiss the prompt. It waits in the same region as otherprompts, one card at a time. It steps aside while a popover, dialog, drawer, or-sheet is open (the calendar event details, for example) and, on touch devices,-while the full-screen email composer is open, and it comes back when they close.+sheet is open (the calendar event details, for example). On touch devices it+also waits while an email thread, the full-screen email composer, or search+results are open, since their last controls sit where the prompt would. It comes+back when they close.### Notification snoozes