Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(channels): make mobile Invite button a tappable glass island (#7170)

teo9aeeab030ebf
diff --git a/apps/web/src/features/block-channel/component/NewChannelBlockAdapter.tsx b/apps/web/src/features/block-channel/component/NewChannelBlockAdapter.tsx
index 7a7ad44d21..57b7fccdc3 100644
--- a/apps/web/src/features/block-channel/component/NewChannelBlockAdapter.tsx
+++ b/apps/web/src/features/block-channel/component/NewChannelBlockAdapter.tsx
@@ -254,11 +254,16 @@ function NewTop(props: { channelId: string }) {
/>
</SplitTitleFileMenu>
<SplitHeaderRight>
- <ChannelInviteButton
- channelId={props.channelId}
- channelName={channelName() ?? 'New Channel'}
- channelType={channelType()}
- />
+ {/* On mobile the split header is pointer-events-none; only islands
+ (glass pills) take taps. `empty:hidden` drops the pill when the
+ button is not offered (DMs, non-participants). */}
+ <HeaderIsland class="px-1">
+ <ChannelInviteButton
+ channelId={props.channelId}
+ channelName={channelName() ?? 'New Channel'}
+ channelType={channelType()}
+ />
+ </HeaderIsland>
</SplitHeaderRight>
{/* Desktop only: on mobile the action lives in the title drawer above. */}
<Show when={!isMobile() && askMacroEntity()}>
diff --git a/apps/web/src/features/channel/channel-invite-button.tsx b/apps/web/src/features/channel/channel-invite-button.tsx
index 7e1b6ac8c0..dbc227ad30 100644
--- a/apps/web/src/features/channel/channel-invite-button.tsx
+++ b/apps/web/src/features/channel/channel-invite-button.tsx
@@ -1,10 +1,11 @@
import { useUserId } from '@core/context/user';
+import { isTouchDevice } from '@core/mobile/isTouchDevice';
import { useCombinedRecipients } from '@core/signal/useCombinedRecipient';
import UserPlusIcon from '@phosphor/user-plus.svg';
import { useChannelParticipantsQuery } from '@queries/channel/channel-participants';
import { useAddParticipantsMutation } from '@queries/channel/participants';
import { useCurrentTeamQuery } from '@queries/team/teams';
-import { Button } from '@ui';
+import { Button, cn } from '@ui';
import { createSignal, Show, Suspense } from 'solid-js';
import { ChannelInviteModal } from './views/channel-invite-modal';
@@ -25,10 +26,13 @@ export function ChannelInviteButton(props: {
return (
<Show when={canInvite()}>
<Button
- variant="outline"
+ // On touch the button sits inside a floating header island, which
+ // already draws the glass pill; an outline border inside it doubles up.
+ variant={isTouchDevice() ? 'ghost' : 'outline'}
size="sm"
label="Invite people"
tooltip="Invite people"
+ class={cn(isTouchDevice() && 'active:bg-transparent')}
onClick={() => setOpen(true)}
>
<UserPlusIcon />
diff --git a/docs/AGENT_GUIDE/channels.md b/docs/AGENT_GUIDE/channels.md
index 83f9420889..29919c13d9 100644
--- a/docs/AGENT_GUIDE/channels.md
+++ b/docs/AGENT_GUIDE/channels.md
@@ -684,17 +684,20 @@ shows Connecting and waits for that request before registering again.
## Channel tabs
Private and team channels show an `Invite` button on the right of both the
-split header and the inline conversation header for current participants.
-Click it to open `Invite people to <channel>` using the standard dialog at the
-top of the viewport, matching the create menu and create-channel dialog (a
-drawer on mobile). Choose `Add all members of <team>` to add current teammates
-once, or `Add specific people` to search teammates and enter external email
-addresses using the same recipient picker as channel creation. Existing channel
-members are excluded. `Add` submits; Cancel, Close, or Escape dismisses without
-sending. Failed additions preserve the selection for retry. The team option is
-disabled when no team is available. This action does not enable team auto-join.
-Check opening and reopening, switching options, keyboard recipient selection,
-external email chips, cancellation, and focus restoration before sending invites.
+split header and the inline conversation header for current participants. On
+mobile it renders as its own floating glass pill next to the `Call` pill (the
+split header is `pointer-events-none`, so the button must sit in a
+`HeaderIsland` to be tappable). Click it to open `Invite people to <channel>`
+using the standard dialog at the top of the viewport, matching the create menu
+and create-channel dialog (a drawer on mobile). Choose `Add all members of
+<team>` to add current teammates once, or `Add specific people` to search
+teammates and enter external email addresses using the same recipient picker as
+channel creation. Existing channel members are excluded. `Add` submits; Cancel,
+Close, or Escape dismisses without sending. Failed additions preserve the
+selection for retry. The team option is disabled when no team is available.
+This action does not enable team auto-join. Check opening and reopening,
+switching options, keyboard recipient selection, external email chips,
+cancellation, and focus restoration before sending invites.
Radio group at the top of the channel pane: `Messages` / `Attachments` / `Calls` / `Participants`,
plus `Ask Macro` and `Call` buttons. The `Calls` tab lists recordings for that channel