Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(onboarding): keep connector continue button visible (#8320)
Eric Hayes9dcc51f291d8
diff --git a/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid-mobile.png b/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid-mobile.pngnew file mode 100644index 0000000000..7714b30dbaBinary files /dev/null and b/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid-mobile.png differdiff --git a/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid.png b/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid.pngindex 7bc7592c30..15cc05e49d 100644Binary files a/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid.png and b/apps/web/src/features/onboarding/browser-test/screenshots/connector-grid.png differdiff --git a/apps/web/src/features/onboarding/browser-test/tools-layout.browser.e2e.ts b/apps/web/src/features/onboarding/browser-test/tools-layout.browser.e2e.tsnew file mode 100644index 0000000000..c542d6e01b--- /dev/null+++ b/apps/web/src/features/onboarding/browser-test/tools-layout.browser.e2e.ts@@ -0,0 +1,81 @@+import { expect, test } from '@playwright/test';+import { heading, openFixture } from './fixture-page';++for (const viewport of [+ { width: 1280, height: 720 },+ { width: 1440, height: 900 },+ { width: 390, height: 667 },+ { width: 820, height: 1180 },+]) {+ test.describe(`${viewport.width}×${viewport.height} connector layout`, () => {+ test.use({ viewport, hasTouch: true });++ test('scrolls the page and keeps Continue reachable', async ({+ page,+ }, testInfo) => {+ await openFixture(page, '/?view=flow&theme=cream', {+ catalog: Array.from({ length: 24 }, (_, index) => ({+ slug: `tool-${index}`,+ name: `Tool ${index}`,+ iconUrl: null,+ })),+ });+ await page.evaluate(() =>+ sessionStorage.setItem(+ 'onboarding-flow-step',+ JSON.stringify({ user: 'macro|[email protected]', step: 'tools' })+ )+ );+ await page.reload();+ await expect(heading(page, 'Connect your tools.')).toBeVisible();+ const next = page.getByRole('button', { name: 'Continue', exact: true });+ const catalog = page.getByRole('region', {+ name: 'Available integrations',+ });+ const scroller = page.locator('[data-onboarding-scroll]');+ await expect(next).toBeInViewport({ ratio: 1 });+ expect(+ await catalog.evaluate((el) => el.scrollHeight - el.clientHeight)+ ).toBe(0);+ await page.screenshot({ path: testInfo.outputPath('tools-top.png') });++ await catalog.getByRole('button').first().hover();+ await page.mouse.wheel(0, 350);+ await expect+ .poll(() => scroller.evaluate((el) => el.scrollTop))+ .toBeGreaterThan(0);+ expect(await catalog.evaluate((el) => el.scrollTop)).toBe(0);+ await expect(next).toBeInViewport({ ratio: 1 });++ await scroller.evaluate((el) => el.scrollTo(0, el.scrollHeight));+ const last = catalog.getByRole('button', {+ name: 'Connect Tool 23',+ exact: true,+ });+ await expect(last).toBeInViewport({ ratio: 1 });+ await last.tap();+ await expect(+ catalog.getByRole('button', {+ name: 'Connected to Tool 23',+ exact: true,+ })+ ).toBeDisabled();+ await expect(next).toBeInViewport({ ratio: 1 });+ await page.screenshot({ path: testInfo.outputPath('tools-bottom.png') });++ await page.getByRole('searchbox').fill('Tool 23');+ await expect(catalog.getByRole('button')).toHaveCount(1);+ await expect(next).toBeInViewport({ ratio: 1 });+ await page.getByRole('searchbox').fill('no results');+ await expect(page.getByText(/No integrations match/)).toBeVisible();+ await expect(next).toBeInViewport({ ratio: 1 });+ expect(+ await page.evaluate(+ () => document.documentElement.scrollWidth <= innerWidth+ )+ ).toBe(true);+ await next.tap();+ await expect(heading(page, 'Built for teams.')).toBeVisible();+ });+ });+}diff --git a/apps/web/src/features/onboarding/views/tools-step.tsx b/apps/web/src/features/onboarding/views/tools-step.tsxindex b8220eacbf..62204c6566 100644--- a/apps/web/src/features/onboarding/views/tools-step.tsx+++ b/apps/web/src/features/onboarding/views/tools-step.tsx@@ -41,13 +41,7 @@ export function ToolsStep(props: { onContinue: () => void }) {class="min-w-0 flex-1 bg-transparent text-base outline-none placeholder:text-ink-placeholder"/></label>- <div- role="region"- aria-label="Available integrations"- tabindex="0"- class="h-[32rem] overflow-y-auto rounded-xl px-1 py-1 outline-none focus-visible:ring-1 focus-visible:ring-ink/30"- style={{ 'scrollbar-gutter': 'stable' }}- >+ <div role="region" aria-label="Available integrations" class="px-1 py-1"><div class="grid grid-cols-3 gap-x-2 gap-y-5 sm:grid-cols-4"><For each={entries()}>{(tool) => (@@ -129,10 +123,12 @@ export function ToolsStep(props: { onContinue: () => void }) {</button></Show></div>- <ContinueButton- disabled={busy() !== undefined}- onClick={props.onContinue}- />+ <div class="sticky bottom-0 z-10 bg-surface pb-[var(--safe-bottom,0px)]">+ <ContinueButton+ disabled={busy() !== undefined}+ onClick={props.onContinue}+ />+ </div></div>);}diff --git a/docs/agent-guide/login.md b/docs/agent-guide/login.mdindex 0663853c24..7f31c42780 100644--- a/docs/agent-guide/login.md+++ b/docs/agent-guide/login.md@@ -202,6 +202,9 @@ Slack aliases must not duplicate cards. New Slack connections use `slack_v2`;existing `slack` accounts remain recognized. Production release requires a realSlack authorization and a successful read-only tool call, not just fixture tests.Cards use the Pipedream logo, with bundled icons and a generic plug as fallbacks.+The catalog scrolls with the page; Continue stays visible in a sticky footer.+At desktop and phone widths, verify scrolling over the cards moves the page,+the last row remains reachable, and Continue stays fully visible after searching.GitHub uses Macro's native OAuth/re-authorization flow and returns to the toolsstep. It shows **Account linked**, distinct from agent-tool readiness. A