Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(web): handle floating promises in blocks, views and app components (#8260)

teoa7ace9b9d43d
diff --git a/apps/web/src/components/app/GlobalHotkeys.tsx b/apps/web/src/components/app/GlobalHotkeys.tsx
index 170c4489dd..fa19d50b14 100644
--- a/apps/web/src/components/app/GlobalHotkeys.tsx
+++ b/apps/web/src/components/app/GlobalHotkeys.tsx
@@ -32,6 +32,7 @@ import {
openFilePicker,
openFolderPicker,
} from '@core/util/upload';
+import { Telemetry } from '@macro-inc/observability';
import IconGear from '@phosphor/gear.svg';
import Plus from '@phosphor/plus.svg';
import LogoutIcon from '@phosphor/sign-out.svg';
@@ -343,7 +344,10 @@ export default function GlobalShortcuts() {
description: 'Logout',
icon: LogoutIcon,
keyDownHandler: () => {
- logout();
+ logout().catch((error) => {
+ Telemetry.error(error, { surface: 'logout' });
+ toast.failure('Failed to sign out');
+ });
return true;
},
runWithInputFocused: true,
@@ -575,7 +579,7 @@ export default function GlobalShortcuts() {
keyDownHandler: (e) => {
if (!undoCtx.canUndo()) return false;
e?.preventDefault();
- undoCtx.undo({ onError: () => toast.failure('Failed to undo') });
+ void undoCtx.undo({ onError: () => toast.failure('Failed to undo') });
return true;
},
condition: () => undoCtx.canUndo(),
@@ -589,7 +593,7 @@ export default function GlobalShortcuts() {
keyDownHandler: (e) => {
if (!undoCtx.canRedo()) return false;
e?.preventDefault();
- undoCtx.redo({ onError: () => toast.failure('Failed to redo') });
+ void undoCtx.redo({ onError: () => toast.failure('Failed to redo') });
return true;
},
condition: () => undoCtx.canRedo(),
diff --git a/apps/web/src/components/app/sidebar-next/list-nav.test.tsx b/apps/web/src/components/app/sidebar-next/list-nav.test.tsx
index 24b098978d..99b367aaee 100644
--- a/apps/web/src/components/app/sidebar-next/list-nav.test.tsx
+++ b/apps/web/src/components/app/sidebar-next/list-nav.test.tsx
@@ -475,7 +475,7 @@ describe('ListNav', () => {
expectSelection('Home');
});
- it('does not reclaim the highlight when Settings becomes active again', () => {
+ it('does not reclaim the highlight when Settings becomes active again', async () => {
const { router, history } = setup('/settings');
expectSelection();
press('Agents');
@@ -483,7 +483,7 @@ describe('ListNav', () => {
expectSelection('Agents');
// Settings opens from outside the rail list (the gear, a hotkey).
- router.navigatePane(router.panes()[0]!, '/settings');
+ await router.navigatePane(router.panes()[0]!, '/settings');
expect(history.read().path).toBe('/settings');
expectSelection();
});
diff --git a/apps/web/src/components/app/split-layout/tests/stacked-panes.test.ts b/apps/web/src/components/app/split-layout/tests/stacked-panes.test.ts
index 347322fceb..0d6669620c 100644
--- a/apps/web/src/components/app/split-layout/tests/stacked-panes.test.ts
+++ b/apps/web/src/components/app/split-layout/tests/stacked-panes.test.ts
@@ -243,12 +243,12 @@ describe('stacked panes', () => {
expectAll();
});
- it('moves the pane holding a claim to the front when a router open lands on it', () => {
+ it('moves the pane holding a claim to the front when a router open lands on it', async () => {
const { router, manager, shown, active } = setup('/home');
manager.openWithSplit(settings);
manager.openWithSplit(documents);
- router.open('/settings', { newPane: true });
+ await router.open('/settings', { newPane: true });
expect(shown()).toEqual(['home', 'documents', 'settings']);
expect(active()).toBe('settings');
});
diff --git a/apps/web/src/features/block-agent/context/create-queue-controller.ts b/apps/web/src/features/block-agent/context/create-queue-controller.ts
index 859f3029dd..6b50468fa2 100644
--- a/apps/web/src/features/block-agent/context/create-queue-controller.ts
+++ b/apps/web/src/features/block-agent/context/create-queue-controller.ts
@@ -108,7 +108,7 @@ export function createQueueController(options: {
onCleanup(
subscribeSocketSessionStarted(() => {
socketAuthoritative = false;
- baseline();
+ void baseline();
})
);
diff --git a/apps/web/src/features/block-ai/queries/create-ai.ts b/apps/web/src/features/block-ai/queries/create-ai.ts
index 89ac08ecbb..fc4fcb83bf 100644
--- a/apps/web/src/features/block-ai/queries/create-ai.ts
+++ b/apps/web/src/features/block-ai/queries/create-ai.ts
@@ -5,6 +5,7 @@
import { analytics } from '@app/lib/analytics';
import { AiEngine } from '@core/ai-engine/client';
import { contentHash } from '@core/util/hash';
+import { Telemetry } from '@macro-inc/observability';
import { invalidateUserQuota } from '@queries/auth';
import { postNewHistoryItem } from '@queries/history/history';
import { setPreviewOnCreate } from '@queries/preview/preview';
@@ -29,7 +30,7 @@ export async function createAiDocument(args: {
sha,
projectId: args.projectId,
});
- invalidateUserQuota();
+ void invalidateUserQuota();
if (created.isErr()) return undefined;
const doc = created.value;
const upload = await uploadToPresignedUrl({
@@ -40,7 +41,7 @@ export async function createAiDocument(args: {
});
if (upload.isErr()) return undefined;
const documentId = doc.metadata.documentId;
- postNewHistoryItem('document', documentId);
+ void postNewHistoryItem('document', documentId);
setPreviewOnCreate({
itemId: documentId,
itemType: 'document',
@@ -50,7 +51,9 @@ export async function createAiDocument(args: {
refetchSoupEntity(documentId, 'document', {
ownTouch: true,
refreshGraphql: true,
- });
+ }).catch((error) =>
+ Telemetry.error(error, { surface: 'create-ai-document' })
+ );
analytics.track('create_entity', {
entityType: 'ai',
entityId: documentId,
diff --git a/apps/web/src/features/block-canvas/component/TopBar.tsx b/apps/web/src/features/block-canvas/component/TopBar.tsx
index a47c6ff41d..c1fc07528f 100644
--- a/apps/web/src/features/block-canvas/component/TopBar.tsx
+++ b/apps/web/src/features/block-canvas/component/TopBar.tsx
@@ -59,7 +59,7 @@ export function TopBar(props: { state: CanvasDocumentChrome }) {
const file = props.state.savedFile() ?? canvasFile();
if (!file) return;
- downloadFile(file, downloadName());
+ void downloadFile(file, downloadName());
analytics.track('download', { blockType: 'canvas' });
});
@@ -70,7 +70,7 @@ export function TopBar(props: { state: CanvasDocumentChrome }) {
[URL_PARAMS.y]: location.y.toString(),
[URL_PARAMS.s]: location.s.toString(),
};
- copyEntityLink(
+ void copyEntityLink(
buildSimpleEntityUrl({ type: 'canvas', id: documentId }, params)
);
analytics.track('copy_share_link', { blockType: 'canvas' });
diff --git a/apps/web/src/features/block-chat/component/Chat.tsx b/apps/web/src/features/block-chat/component/Chat.tsx
index 838fef689f..03efbd3512 100644
--- a/apps/web/src/features/block-chat/component/Chat.tsx
+++ b/apps/web/src/features/block-chat/component/Chat.tsx
@@ -55,6 +55,7 @@ import { blockHandleSignal } from '@core/signal/load';
import { useCanEdit } from '@core/signal/permissions';
import { markMessageSent } from '@core/util/message-send-motion';
import { createRenameDssEntityMutation } from '@entity';
+import { Telemetry } from '@macro-inc/observability';
import { invalidateUserQuota } from '@queries/auth';
import { cognitionApiServiceClient } from '@service-cognition/client';
import { createCallback } from '@solid-primitives/rootless';
@@ -174,7 +175,7 @@ function ChatInner(props: {
// Sync isGenerating from controller phase
createEffect(() => {
input.setIsGenerating(chat.isGenerating());
- if (chat.isGenerating()) invalidateUserQuota();
+ if (chat.isGenerating()) void invalidateUserQuota();
});
const blockHandle = blockHandleSignal.get;
@@ -238,7 +239,7 @@ function ChatInner(props: {
}
chat.dispatch({ type: 'stream_connected', stream: result.stream, owner });
- invalidateUserQuota();
+ void invalidateUserQuota();
});
const onStop = async () => {
@@ -266,7 +267,7 @@ function ChatInner(props: {
createMethodRegistration(blockHandle, {
sendMessage: async (sendRequest: SendBuilder) => {
- onSend({
+ await onSend({
content: sendRequest.userRequest,
model: sendRequest.model ?? input.model(),
attachments: sendRequest.attachments ?? [],
@@ -287,7 +288,9 @@ function ChatInner(props: {
speed: pendingSend.speed,
attachments: pendingSend.attachments ?? [],
toolset: { type: 'all' },
- });
+ }).catch((error) =>
+ Telemetry.error(error, { surface: 'chat-pending-send' })
+ );
}
registerScopeSignalHotkey(scopeId, {
diff --git a/apps/web/src/features/block-code/component/TopBar.tsx b/apps/web/src/features/block-code/component/TopBar.tsx
index 59c1a7fee6..0fdd4a2973 100644
--- a/apps/web/src/features/block-code/component/TopBar.tsx
+++ b/apps/web/src/features/block-code/component/TopBar.tsx
@@ -62,7 +62,7 @@ export const TopBar: Component<{
const content = text();
if (!text || !name) return;
const file = new Blob([content ?? ''], { type: 'text/plain' });
- downloadFile(file, downloadName());
+ void downloadFile(file, downloadName());
analytics.track('download', { blockType: 'code' });
});
diff --git a/apps/web/src/features/block-database/browser-test/document.browser.e2e.ts b/apps/web/src/features/block-database/browser-test/document.browser.e2e.ts
index 02c26e4cbe..452ad6c2d7 100644
--- a/apps/web/src/features/block-database/browser-test/document.browser.e2e.ts
+++ b/apps/web/src/features/block-database/browser-test/document.browser.e2e.ts
@@ -43,9 +43,9 @@ async function fixture(page: Page, multipleTables = false) {
errors.push(error.message);
console.error(error);
});
- await page.routeWebSocket('**', (socket) => {
+ await page.routeWebSocket('**', async (socket) => {
if (!socket.url().includes('connection-gateway')) {
- socket.close();
+ await socket.close();
return;
}
gateway = socket;
diff --git a/apps/web/src/features/block-database/views/database-page-actions.tsx b/apps/web/src/features/block-database/views/database-page-actions.tsx
index a09f2fe13c..2ae638cfae 100644
--- a/apps/web/src/features/block-database/views/database-page-actions.tsx
+++ b/apps/web/src/features/block-database/views/database-page-actions.tsx
@@ -97,7 +97,7 @@ export function DatabasePageActions(props: {
const exported = await exportDatabaseTableCsv(props.detail, table);
setExporting(false);
exported.match(
- (blob) => downloadFile(blob, `${table.table.name}.csv`),
+ (blob) => void downloadFile(blob, `${table.table.name}.csv`),
(failure) =>
toast.failure(
failure.kind === 'too-large'
diff --git a/apps/web/src/features/block-email/component/useEmailThreadTools.tsx b/apps/web/src/features/block-email/component/useEmailThreadTools.tsx
index 4904d05431..f09c55022e 100644
--- a/apps/web/src/features/block-email/component/useEmailThreadTools.tsx
+++ b/apps/web/src/features/block-email/component/useEmailThreadTools.tsx
@@ -150,7 +150,7 @@ export function useEmailThreadTools(props: EmailThreadToolsOptions) {
} else if (soup && nextRow) {
soup.selection.clear();
soup.focus.set(nextRow.id);
- openEntityInSplitFromUnifiedList(nextRow.original, {});
+ void openEntityInSplitFromUnifiedList(nextRow.original, {});
}
const toastId = toast.success('Moved to Trash', {
@@ -223,7 +223,11 @@ export function useEmailThreadTools(props: EmailThreadToolsOptions) {
action: () => {
const threadId = emailCtx.thread()?.db_id;
if (!threadId) return;
- openChatWithAgent({ type: 'email', id: threadId, name: props.title });
+ void openChatWithAgent({
+ type: 'email',
+ id: threadId,
+ name: props.title,
+ });
},
condition: () => !!emailCtx.thread()?.db_id,
},
@@ -274,7 +278,11 @@ export function useEmailThreadTools(props: EmailThreadToolsOptions) {
action: () => {
const threadId = emailCtx.thread()?.db_id;
if (!threadId) return;
- openChatWithAgent({ type: 'email', id: threadId, name: props.title });
+ void openChatWithAgent({
+ type: 'email',
+ id: threadId,
+ name: props.title,
+ });
},
condition: () => !!emailCtx.thread()?.db_id,
buttonComponent: () => {
diff --git a/apps/web/src/features/block-fig/queries/create-fig.ts b/apps/web/src/features/block-fig/queries/create-fig.ts
index 0d0a00b288..573166610b 100644
--- a/apps/web/src/features/block-fig/queries/create-fig.ts
+++ b/apps/web/src/features/block-fig/queries/create-fig.ts
@@ -5,6 +5,7 @@
import { analytics } from '@app/lib/analytics';
import { FigEngine } from '@core/fig-engine/client';
import { contentHash } from '@core/util/hash';
+import { Telemetry } from '@macro-inc/observability';
import { invalidateUserQuota } from '@queries/auth';
import { postNewHistoryItem } from '@queries/history/history';
import { setPreviewOnCreate } from '@queries/preview/preview';
@@ -28,7 +29,7 @@ export async function createFigDocument(args: {
sha,
projectId: args.projectId,
});
- invalidateUserQuota();
+ void invalidateUserQuota();
if (created.isErr()) return undefined;
const doc = created.value;
const upload = await uploadToPresignedUrl({
@@ -39,7 +40,7 @@ export async function createFigDocument(args: {
});
if (upload.isErr()) return undefined;
const documentId = doc.metadata.documentId;
- postNewHistoryItem('document', documentId);
+ void postNewHistoryItem('document', documentId);
setPreviewOnCreate({
itemId: documentId,
itemType: 'document',
@@ -49,7 +50,9 @@ export async function createFigDocument(args: {
refetchSoupEntity(documentId, 'document', {
ownTouch: true,
refreshGraphql: true,
- });
+ }).catch((error) =>
+ Telemetry.error(error, { surface: 'create-fig-document' })
+ );
analytics.track('create_entity', {
entityType: 'fig',
entityId: documentId,
diff --git a/apps/web/src/features/block-fig/views/fig-viewer.tsx b/apps/web/src/features/block-fig/views/fig-viewer.tsx
index a4b2ecf4cb..dd34446bc1 100644
--- a/apps/web/src/features/block-fig/views/fig-viewer.tsx
+++ b/apps/web/src/features/block-fig/views/fig-viewer.tsx
@@ -509,11 +509,11 @@ export function FigViewer() {
.with('place-image', () => placeImage())
.with('undo', () => {
editor.endVectorEdit();
- editor.undo();
+ void editor.undo();
})
.with('redo', () => {
editor.endVectorEdit();
- editor.redo();
+ void editor.redo();
})
.with('delete', () => void editor.deleteSelection())
.with('duplicate', () => void editor.duplicateSelection())
diff --git a/apps/web/src/features/block-image/component/TopBar.tsx b/apps/web/src/features/block-image/component/TopBar.tsx
index c37eab8644..8491a9674d 100644
--- a/apps/web/src/features/block-image/component/TopBar.tsx
+++ b/apps/web/src/features/block-image/component/TopBar.tsx
@@ -49,7 +49,7 @@ export function TopBar() {
const downloadDocument = createCallback(async () => {
const file = imageFile();
if (!file) return;
- downloadFile(file, downloadName());
+ void downloadFile(file, downloadName());
});
const ops: FileOperation[] = [
diff --git a/apps/web/src/features/block-md/component/ComposeSkill.tsx b/apps/web/src/features/block-md/component/ComposeSkill.tsx
index 6a877d075c..eeb764298e 100644
--- a/apps/web/src/features/block-md/component/ComposeSkill.tsx
+++ b/apps/web/src/features/block-md/component/ComposeSkill.tsx
@@ -21,6 +21,7 @@ import { registerHotkey, useHotkeyDOMScope } from '@core/hotkey/hotkeys';
import { createSkill } from '@core/util/create';
import { buildSimpleEntityUrl } from '@core/util/url';
import { mergeRegister } from '@lexical/utils';
+import { Telemetry } from '@macro-inc/observability';
import ArrowSquareOutIcon from '@phosphor/arrow-square-out.svg';
import ArrowsOutIcon from '@phosphor/arrows-out.svg';
import SplitIcon from '@phosphor/square-half.svg';
@@ -303,7 +304,7 @@ export function ComposeSkill(props: ComposeSkillProps) {
const documentId = await submitSkill();
if (documentId && !props.onSuccess) {
- showSkillCreatedToast(documentId);
+ await showSkillCreatedToast(documentId);
}
};
@@ -338,7 +339,9 @@ export function ComposeSkill(props: ComposeSkillProps) {
scopeId: composeHotkeyScope,
description: 'Create skill',
keyDownHandler: () => {
- handleCreateSkill();
+ handleCreateSkill().catch((error) =>
+ Telemetry.error(error, { surface: 'compose-skill' })
+ );
return true;
},
runWithInputFocused: true,
diff --git a/apps/web/src/features/block-md/component/ComposeTask.tsx b/apps/web/src/features/block-md/component/ComposeTask.tsx
index 5d99e2f1b3..27e9fb2d8c 100644
--- a/apps/web/src/features/block-md/component/ComposeTask.tsx
+++ b/apps/web/src/features/block-md/component/ComposeTask.tsx
@@ -29,6 +29,7 @@ import { useUserId } from '@core/context/user';
import { registerHotkey, useHotkeyDOMScope } from '@core/hotkey/hotkeys';
import { buildSimpleEntityUrl } from '@core/util/url';
import { mergeRegister } from '@lexical/utils';
+import { Telemetry } from '@macro-inc/observability';
import ArrowSquareOutIcon from '@phosphor/arrow-square-out.svg';
import ArrowsOutIcon from '@phosphor/arrows-out.svg';
import PaperclipIcon from '@phosphor/paperclip.svg';
@@ -664,7 +665,7 @@ export function ComposeTask(props: ComposeTaskProps) {
if (props.onSuccess) {
props.onSuccess({ documentId, title: taskTitle, content: taskContent });
} else {
- showTaskCreatedToast(documentId, initialSnapshot);
+ void showTaskCreatedToast(documentId, initialSnapshot);
}
props.onCreateTask?.(taskTitle, taskContent);
return;
@@ -695,7 +696,7 @@ export function ComposeTask(props: ComposeTaskProps) {
if (props.onSuccess) {
props.onSuccess({ documentId, title: taskTitle, content: taskContent });
} else {
- showTaskCreatedToast(documentId, initialSnapshot);
+ void showTaskCreatedToast(documentId, initialSnapshot);
}
props.onCreateTask?.(taskTitle, taskContent);
};
@@ -848,7 +849,9 @@ export function ComposeTask(props: ComposeTaskProps) {
scopeId: composeHotkeyScope,
description: 'Create task',
keyDownHandler: () => {
- handleCreateTask();
+ handleCreateTask().catch((error) =>
+ Telemetry.error(error, { surface: 'compose-task' })
+ );
return true;
},
runWithInputFocused: true,
diff --git a/apps/web/src/features/block-md/component/DispatchAgentMenu.tsx b/apps/web/src/features/block-md/component/DispatchAgentMenu.tsx
index ffe5b321ee..723291adfd 100644
--- a/apps/web/src/features/block-md/component/DispatchAgentMenu.tsx
+++ b/apps/web/src/features/block-md/component/DispatchAgentMenu.tsx
@@ -366,7 +366,7 @@ export function DispatchAgentButton(
<Dropdown.Group>
<Dropdown.Item
onSelect={() => {
- executeAction(COPY_ACTION);
+ void executeAction(COPY_ACTION);
setOpen(false);
}}
>
@@ -376,7 +376,7 @@ export function DispatchAgentButton(
<Show when={isTask()}>
<Dropdown.Item
onSelect={() => {
- copyBranchNameToClipboard(blockId);
+ void copyBranchNameToClipboard(blockId);
setOpen(false);
}}
>
@@ -400,7 +400,7 @@ export function DispatchAgentButton(
{(action) => (
<Dropdown.Item
onSelect={() => {
- executeAction(action);
+ void executeAction(action);
setOpen(false);
}}
>
diff --git a/apps/web/src/features/block-md/component/FindAndReplace.tsx b/apps/web/src/features/block-md/component/FindAndReplace.tsx
index 764343b658..e1afb281ba 100644
--- a/apps/web/src/features/block-md/component/FindAndReplace.tsx
+++ b/apps/web/src/features/block-md/component/FindAndReplace.tsx
@@ -155,7 +155,7 @@ export function FindAndReplace(props: { hotkeyScope?: string } = {}) {
// Search
- const _performSearch = createCallback(async (jump: boolean) => {
+ const _performSearch = createCallback((jump: boolean) => {
const query: string = findAndReplaceStore.searchInputText;
if (!query) {
setFindAndReplaceStore('listOffset', []);
diff --git a/apps/web/src/features/block-md/component/InstructionsEditor.tsx b/apps/web/src/features/block-md/component/InstructionsEditor.tsx
index 9daa638769..06ad69d90d 100644
--- a/apps/web/src/features/block-md/component/InstructionsEditor.tsx
+++ b/apps/web/src/features/block-md/component/InstructionsEditor.tsx
@@ -47,6 +47,7 @@ import {
type PeerIdValidator,
peerIdPlugin,
} from '@macro-inc/lexical-core';
+import { Telemetry } from '@macro-inc/observability';
import { onElementConnect } from '@solid-primitives/lifecycle';
import { debounce } from '@solid-primitives/scheduled';
import type { EditorState } from 'lexical';
@@ -276,11 +277,16 @@ export function InstructionsEditor(props: {
};
const [fileArrayBuffer, setFileArrayBuffer] = createSignal<ArrayBuffer>();
+ const readFileArrayBuffer = async (file: Blob) => {
+ setFileArrayBuffer(await file.arrayBuffer());
+ };
createEffect(() => {
const source = documentSource();
if (source.type !== 'dss') return;
- source.file.arrayBuffer().then(setFileArrayBuffer);
+ readFileArrayBuffer(source.file).catch((error) =>
+ Telemetry.error(error, { surface: 'instructions-editor' })
+ );
});
createEffect(() => {
diff --git a/apps/web/src/features/block-md/component/MarkdownEditor.tsx b/apps/web/src/features/block-md/component/MarkdownEditor.tsx
index 877be9da8a..017bec6400 100644
--- a/apps/web/src/features/block-md/component/MarkdownEditor.tsx
+++ b/apps/web/src/features/block-md/component/MarkdownEditor.tsx
@@ -88,6 +88,7 @@ import {
createPeerIdValidator,
type PeerIdValidator,
} from '@macro-inc/lexical-core';
+import { Telemetry } from '@macro-inc/observability';
import { useDocTags } from '@property/tags';
import { EntityType } from '@service-properties/generated/schemas/entityType';
import { onElementConnect } from '@solid-primitives/lifecycle';
@@ -553,11 +554,16 @@ export function MarkdownEditor(props: {
);
const [fileArrayBuffer, setFileArrayBuffer] = createSignal<ArrayBuffer>();
+ const readFileArrayBuffer = async (file: Blob) => {
+ setFileArrayBuffer(await file.arrayBuffer());
+ };
createEffect(() => {
const source = documentSource();
if (source.type !== 'dss') return;
- source.file.arrayBuffer().then(setFileArrayBuffer);
+ readFileArrayBuffer(source.file).catch((error) =>
+ Telemetry.error(error, { surface: 'markdown-editor' })
+ );
});
createEffect(() => {
diff --git a/apps/web/src/features/block-md/component/MediaSelector.tsx b/apps/web/src/features/block-md/component/MediaSelector.tsx
index 827adf271e..7041ba5004 100644
--- a/apps/web/src/features/block-md/component/MediaSelector.tsx
+++ b/apps/web/src/features/block-md/component/MediaSelector.tsx
@@ -102,7 +102,7 @@ export function MediaSelector(props: MediaSelectorProps) {
return null;
};
- const uploadStaticMediaFiles = async (files: File[]) => {
+ const uploadStaticMediaFiles = (files: File[]) => {
for (const file of files) {
const mediaType = lookUpMediaFileType(file);
if (mediaType === null) continue;
diff --git a/apps/web/src/features/block-md/component/useMarkdownDocumentDownload.ts b/apps/web/src/features/block-md/component/useMarkdownDocumentDownload.ts
index 0f244716ed..32e05bbcad 100644
--- a/apps/web/src/features/block-md/component/useMarkdownDocumentDownload.ts
+++ b/apps/web/src/features/block-md/component/useMarkdownDocumentDownload.ts
@@ -19,7 +19,7 @@ export function useDownloadDocumentAsMarkdownText() {
const markdownString = editorStateAsMarkdown(editor, 'external');
const blob = new Blob([markdownString], { type: 'text/markdown' });
- downloadFile(blob, fileNameWithExtension);
+ void downloadFile(blob, fileNameWithExtension);
});
}
@@ -56,6 +56,6 @@ export function useDownloadDocumentAsJson() {
const blob = new Blob([JSON.stringify(json, null, 2)], {
type: 'application/json',
});
- downloadFile(blob, fileNameWithExtension);
+ void downloadFile(blob, fileNameWithExtension);
});
}
diff --git a/apps/web/src/features/block-md/component/useTaskBranchNameHotkey.ts b/apps/web/src/features/block-md/component/useTaskBranchNameHotkey.ts
index b5d80bf65d..add7491914 100644
--- a/apps/web/src/features/block-md/component/useTaskBranchNameHotkey.ts
+++ b/apps/web/src/features/block-md/component/useTaskBranchNameHotkey.ts
@@ -20,7 +20,7 @@ export function useTaskBranchNameHotkey(options: {
hotkeyToken: TOKENS.entity.action.copyBranchName,
description: 'Copy branch name',
keyDownHandler: () => {
- copyBranchNameToClipboard(options.documentId());
+ void copyBranchNameToClipboard(options.documentId());
return true;
},
runWithInputFocused: true,
diff --git a/apps/web/src/features/block-md/queries/create-document-with-tags.ts b/apps/web/src/features/block-md/queries/create-document-with-tags.ts
index e18a90e311..1ab2c862f4 100644
--- a/apps/web/src/features/block-md/queries/create-document-with-tags.ts
+++ b/apps/web/src/features/block-md/queries/create-document-with-tags.ts
@@ -1,5 +1,6 @@
import { toast } from '@core/component/Toast/Toast';
import { createMarkdownFile } from '@core/util/create';
+import { Telemetry } from '@macro-inc/observability';
import { propertyValueToApi } from '@property/api/converters';
import type { PropertyApiValues } from '@property/types';
import { refetchSoupEntity } from '@queries/soup/cache';
@@ -80,7 +81,10 @@ export async function createDocumentWithTags(
body: { properties: tagUpdates },
});
if (result.isErr()) throw result.error;
- refetchSoupEntity(documentId, 'document', { refreshGraphql: true });
+ refetchSoupEntity(documentId, 'document', { refreshGraphql: true }).catch(
+ (error) =>
+ Telemetry.error(error, { surface: 'create-document-with-tags' })
+ );
} catch {
toast.failure(
'Document created, but tags could not be saved. Add them from the document.'
diff --git a/apps/web/src/features/block-pdf/PdfViewer/InternalPDFViewer.ts b/apps/web/src/features/block-pdf/PdfViewer/InternalPDFViewer.ts
index 657f63c5da..b156f1127a 100644
--- a/apps/web/src/features/block-pdf/PdfViewer/InternalPDFViewer.ts
+++ b/apps/web/src/features/block-pdf/PdfViewer/InternalPDFViewer.ts
@@ -1,5 +1,6 @@
import { ENABLE_SCRIPTING } from '@core/constant/featureFlags';
import { showMessageBoxSync } from '@core/util/dialog';
+import { Telemetry } from '@macro-inc/observability';
import debounce from 'lodash/debounce';
import { AnnotationMode, type PageViewport } from 'pdfjs-dist';
import scriptingSandbox from 'pdfjs-dist/build/pdf.sandbox.js?url';
@@ -561,7 +562,11 @@ export class InternalPDFViewer {
const popupViewer = this._popupViewer;
popupViewer?._viewer._pagesCapability.promise.then(() => {
- popupViewer._linkService.goToDestination(destination);
+ popupViewer._linkService
+ .goToDestination(destination)
+ .catch((error) =>
+ Telemetry.error(error, { surface: 'pdf-viewer' })
+ );
this.showPopupAt(el);
});
};
diff --git a/apps/web/src/features/block-pdf/PdfViewer/index.ts b/apps/web/src/features/block-pdf/PdfViewer/index.ts
index d230f5b4fb..70da2d2a78 100644
--- a/apps/web/src/features/block-pdf/PdfViewer/index.ts
+++ b/apps/web/src/features/block-pdf/PdfViewer/index.ts
@@ -1,4 +1,5 @@
import type { WithRequired } from '@core/util/withRequired';
+import { Telemetry } from '@macro-inc/observability';
import { debounce } from '@solid-primitives/scheduled';
import type { PDFDocumentProxy } from 'pdfjs-dist';
import type { PDFPageView } from 'pdfjs-dist/web/pdf_viewer';
@@ -45,7 +46,9 @@ export class PDFViewer extends InternalPDFViewer {
}
async destroy() {
- super.destroy();
+ super
+ .destroy()
+ .catch((error) => Telemetry.error(error, { surface: 'pdf-viewer' }));
}
load(pdfDocument: PDFDocumentProxy) {
@@ -363,6 +366,8 @@ export class PDFViewer extends InternalPDFViewer {
}
goToDestination(dest: TDestArray) {
- this._linkService.goToDestination(dest);
+ this._linkService
+ .goToDestination(dest)
+ .catch((error) => Telemetry.error(error, { surface: 'pdf-viewer' }));
}
}
diff --git a/apps/web/src/features/block-pdf/component/DefinitionLookup/index.tsx b/apps/web/src/features/block-pdf/component/DefinitionLookup/index.tsx
index 8bfc969abf..2224d7b484 100644
--- a/apps/web/src/features/block-pdf/component/DefinitionLookup/index.tsx
+++ b/apps/web/src/features/block-pdf/component/DefinitionLookup/index.tsx
@@ -5,6 +5,7 @@ import {
offset,
shift,
} from '@floating-ui/dom';
+import { Telemetry } from '@macro-inc/observability';
import {
createEffect,
createMemo,
@@ -123,7 +124,11 @@ export function DefinitionLookup(props: IProps) {
placement: 'bottom',
strategy: 'absolute',
middleware: [offset(props.index === 0 ? 2 : 8), shift({ padding: 8 })],
- }).then(setCoord);
+ })
+ .then(setCoord)
+ .catch((error) =>
+ Telemetry.error(error, { surface: 'pdf-definition-lookup' })
+ );
};
createEffect((prevPageWidth) => {
const newPageWidth = pageWidth();
diff --git a/apps/web/src/features/block-pdf/component/Document.tsx b/apps/web/src/features/block-pdf/component/Document.tsx
index 1bf5553faf..c56f9eef2d 100644
--- a/apps/web/src/features/block-pdf/component/Document.tsx
+++ b/apps/web/src/features/block-pdf/component/Document.tsx
@@ -18,6 +18,7 @@ import {
import { IS_MAC } from '@core/constant/isMac';
import { observedSize } from '@core/directive/observedSize';
import { isInDOMRect } from '@core/util/rect';
+import { Telemetry } from '@macro-inc/observability';
import { createCallback } from '@solid-primitives/rootless';
import { debounce } from '@solid-primitives/scheduled';
import { cn } from '@ui';
@@ -251,7 +252,8 @@ export function Document() {
rootViewer = undefined;
pdfViewer.clearPair();
setDestroying(false);
- });
+ })
+ .catch((error) => Telemetry.error(error, { surface: 'pdf-document' }));
});
const saveModificationData = useSaveModificationData();
@@ -272,7 +274,11 @@ export function Document() {
const annotationsPromise = loadAnnotations(documentProxy);
if (updateModificationDataOnLoad()) {
- annotationsPromise.then(() => saveModificationData());
+ annotationsPromise
+ .then(() => saveModificationData())
+ .catch((error) =>
+ Telemetry.error(error, { surface: 'pdf-document' })
+ );
}
const documentId = pdf.documentId();
@@ -533,7 +539,7 @@ export function Document() {
const revision = currentRevision();
if (revision <= savedRevision()) return;
- saveModificationData().then(() => setSavedRevision(revision));
+ void saveModificationData().then(() => setSavedRevision(revision));
});
}
@@ -595,5 +601,7 @@ export function Document() {
export default Document;
if (import.meta.hot) {
- import('./PageOverlay');
+ import('./PageOverlay').catch((error) =>
+ Telemetry.error(error, { surface: 'pdf-document' })
+ );
}
diff --git a/apps/web/src/features/block-pdf/component/PageNumberInput.tsx b/apps/web/src/features/block-pdf/component/PageNumberInput.tsx
index e3c51b0e97..fd5eb54e7e 100644
--- a/apps/web/src/features/block-pdf/component/PageNumberInput.tsx
+++ b/apps/web/src/features/block-pdf/component/PageNumberInput.tsx
@@ -28,7 +28,7 @@ export function PageNumberInput() {
const onBlur = createCallback((_e: FocusEvent) => {
const pageNumber = parseInt(intermediateVal(), 10);
if (Number.isInteger(pageNumber)) {
- getRootViewer()?.scrollTo({ pageNumber });
+ void getRootViewer()?.scrollTo({ pageNumber });
} else if (inputRef) {
inputRef.value = currentPageNumber().toString();
}
diff --git a/apps/web/src/features/block-pdf/component/PageOverlay.tsx b/apps/web/src/features/block-pdf/component/PageOverlay.tsx
index d45ec33807..9c698577e7 100644
--- a/apps/web/src/features/block-pdf/component/PageOverlay.tsx
+++ b/apps/web/src/features/block-pdf/component/PageOverlay.tsx
@@ -14,6 +14,7 @@ import { useIsAuthenticated } from '@core/auth';
import type { ThreadId } from '@core/comments/commentType';
import { openLoginModal } from '@core/component/TopBar/LoginButton';
import { useCopyLink } from '@core/util/useCopyLink';
+import { Telemetry } from '@macro-inc/observability';
import { cn } from '@ui';
import { detect } from 'detect-browser';
import type { PageViewport } from 'pdfjs-dist';
@@ -154,7 +155,7 @@ export function PageOverlay(props: IPageOverlayProps) {
analytics.track('block_pdf_section_open');
- getPopupViewer()?.scrollTo({ pageNumber: page + 1, yPos: y });
+ void getPopupViewer()?.scrollTo({ pageNumber: page + 1, yPos: y });
if (!isPopup) getRootViewer()?.showPopupAt(tgt as HTMLElement);
} else {
if (!pageOverlayRef.contains(e.target as Node)) {
@@ -389,7 +390,7 @@ export function PageOverlay(props: IPageOverlayProps) {
const copyLink = useCopyLink();
const shareLinkProps = () => ({
share: () => {
- copyLink(createShareUrl(LocationType.Annotation), { silent: true });
+ void copyLink(createShareUrl(LocationType.Annotation), { silent: true });
},
});
@@ -415,7 +416,9 @@ export function PageOverlay(props: IPageOverlayProps) {
)}
on:click={(e) => {
if (mode() !== PayloadMode.NoMode) {
- createPlaceable(e);
+ createPlaceable(e).catch((error) =>
+ Telemetry.error(error, { surface: 'pdf-page-overlay' })
+ );
}
}}
>
diff --git a/apps/web/src/features/block-pdf/component/Placeable.tsx b/apps/web/src/features/block-pdf/component/Placeable.tsx
index 748bb1690b..6b36612a1f 100644
--- a/apps/web/src/features/block-pdf/component/Placeable.tsx
+++ b/apps/web/src/features/block-pdf/component/Placeable.tsx
@@ -343,7 +343,7 @@ export const Placeable: Component<{
const debouncedUpdatePlaceablePosition = debounce(
(...args: Parameters<typeof updatePlaceablePosition>) => {
- updatePlaceablePosition(...args);
+ void updatePlaceablePosition(...args);
resetPlaceablePosition();
},
100
diff --git a/apps/web/src/features/block-pdf/signal/search.ts b/apps/web/src/features/block-pdf/signal/search.ts
index ec7ecdca47..0f416bb4c3 100644
--- a/apps/web/src/features/block-pdf/signal/search.ts
+++ b/apps/web/src/features/block-pdf/signal/search.ts
@@ -216,7 +216,7 @@ export function useJumpToResult() {
matchIndex: match.matchNumber,
});
} else {
- rootViewer()?.scrollTo({
+ void rootViewer()?.scrollTo({
pageNumber: match.page + 1,
yPos: match.yPos,
});
diff --git a/apps/web/src/features/block-pdf/signal/tab.ts b/apps/web/src/features/block-pdf/signal/tab.ts
index eb7ea550ac..b29bd0f55d 100644
--- a/apps/web/src/features/block-pdf/signal/tab.ts
+++ b/apps/web/src/features/block-pdf/signal/tab.ts
@@ -43,7 +43,7 @@ export function useGoToLocation() {
viewer.hidePopup();
const pageNumber = loc.pageIndex + 1;
- viewer.scrollTo({
+ void viewer.scrollTo({
pageNumber,
yPos: Math.floor(loc.yPos),
topPadding: TOP_PADDING,
diff --git a/apps/web/src/features/block-pdf/store/comments/commentEffect.ts b/apps/web/src/features/block-pdf/store/comments/commentEffect.ts
index 3bd7b1bc81..e61ceca1b6 100644
--- a/apps/web/src/features/block-pdf/store/comments/commentEffect.ts
+++ b/apps/web/src/features/block-pdf/store/comments/commentEffect.ts
@@ -41,7 +41,7 @@ const useScrollToActiveThreadEffect = () => {
if (!hasActiveThread()) return;
if (!isPdfDraftThreadId(activeThreadId))
- scrollToCommentThread(activeThreadId);
+ void scrollToCommentThread(activeThreadId);
});
};
diff --git a/apps/web/src/features/block-pdf/store/comments/commentOperations.ts b/apps/web/src/features/block-pdf/store/comments/commentOperations.ts
index 2817d4f161..7e1f37179f 100644
--- a/apps/web/src/features/block-pdf/store/comments/commentOperations.ts
+++ b/apps/web/src/features/block-pdf/store/comments/commentOperations.ts
@@ -210,7 +210,7 @@ export function useScrollToCommentThread() {
mutationObserver.disconnect();
intersectionObserver.disconnect();
- viewer_.scrollTo({
+ void viewer_.scrollTo({
pageNumber: rootComment.layout.pageIndex + 1,
});
diff --git a/apps/web/src/features/block-project/component/Block.tsx b/apps/web/src/features/block-project/component/Block.tsx
index ad66967625..701a5988b7 100644
--- a/apps/web/src/features/block-project/component/Block.tsx
+++ b/apps/web/src/features/block-project/component/Block.tsx
@@ -23,6 +23,7 @@ import {
type UploadInput,
uploadFiles,
} from '@core/util/upload';
+import { Telemetry } from '@macro-inc/observability';
import { refetchSoupEntity } from '@queries/soup/cache';
import type { SoupApiItem } from '@service-storage/generated/schemas';
import { refetchResources } from '@service-storage/util/refetchResources';
@@ -63,7 +64,9 @@ const Block: Component = () => {
const successfulUploads = uploads.filter((result) => !result.pending);
for (const upload of successfulUploads) {
if (upload.type === 'document') {
- refetchSoupEntity(upload.documentId, 'document');
+ refetchSoupEntity(upload.documentId, 'document').catch((error) =>
+ Telemetry.error(error, { surface: 'project-upload' })
+ );
}
}
if (successfulUploads.length > 0) {
@@ -79,7 +82,9 @@ const Block: Component = () => {
const resolved = await Promise.all(pendingFolderUploads);
for (const projectId of resolved) {
if (projectId) {
- refetchSoupEntity(projectId, 'project');
+ refetchSoupEntity(projectId, 'project').catch((error) =>
+ Telemetry.error(error, { surface: 'project-upload' })
+ );
}
}
refetchResources();
@@ -109,7 +114,11 @@ const Block: Component = () => {
onDragStart: () => setIsDragging(true),
onDragEnd: () => setIsDragging(false),
onDrop: (fileEntries, folderEntries) => {
- handleFileFolderDrop(fileEntries, folderEntries, handleFileUpload);
+ void handleFileFolderDrop(
+ fileEntries,
+ folderEntries,
+ handleFileUpload
+ );
},
disabled: isSpecialProject,
}}
diff --git a/apps/web/src/features/block-project/component/ProjectCreateMenu.tsx b/apps/web/src/features/block-project/component/ProjectCreateMenu.tsx
index afedf9961f..a1f0df90a9 100644
--- a/apps/web/src/features/block-project/component/ProjectCreateMenu.tsx
+++ b/apps/web/src/features/block-project/component/ProjectCreateMenu.tsx
@@ -330,7 +330,7 @@ function ProjectCreateDialog(props: {
});
return;
}
- createBlock({
+ void createBlock({
blockName: spec.blockName,
loading: spec.loading,
createFn: () => spec.createFn(props.projectId),
diff --git a/apps/web/src/features/block-psd/queries/create-psd.ts b/apps/web/src/features/block-psd/queries/create-psd.ts
index cf1e886da2..5a6a843acb 100644
--- a/apps/web/src/features/block-psd/queries/create-psd.ts
+++ b/apps/web/src/features/block-psd/queries/create-psd.ts
@@ -6,6 +6,7 @@
import { analytics } from '@app/lib/analytics';
import { PsdEngine } from '@core/psd-engine/client';
import { contentHash } from '@core/util/hash';
+import { Telemetry } from '@macro-inc/observability';
import { invalidateUserQuota } from '@queries/auth';
import { postNewHistoryItem } from '@queries/history/history';
import { setPreviewOnCreate } from '@queries/preview/preview';
@@ -36,7 +37,7 @@ export async function createPsdDocument(args: {
sha,
projectId: args.projectId,
});
- invalidateUserQuota();
+ void invalidateUserQuota();
if (created.isErr()) return undefined;
const doc = created.value;
const upload = await uploadToPresignedUrl({
@@ -47,7 +48,7 @@ export async function createPsdDocument(args: {
});
if (upload.isErr()) return undefined;
const documentId = doc.metadata.documentId;
- postNewHistoryItem('document', documentId);
+ void postNewHistoryItem('document', documentId);
setPreviewOnCreate({
itemId: documentId,
itemType: 'document',
@@ -57,7 +58,9 @@ export async function createPsdDocument(args: {
refetchSoupEntity(documentId, 'document', {
ownTouch: true,
refreshGraphql: true,
- });
+ }).catch((error) =>
+ Telemetry.error(error, { surface: 'create-psd-document' })
+ );
analytics.track('create_entity', {
entityType: 'psd',
entityId: documentId,
diff --git a/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.test.ts b/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.test.ts
index 4ed0042af1..43a43d8711 100644
--- a/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.test.ts
+++ b/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.test.ts
@@ -575,7 +575,7 @@ describe('formula-aware copy coordination', () => {
});
const view = setup({ A1: { value: '=B1' } }, () => pending);
view.setRowCount(300);
- view.grid.fill(
+ const filling = view.grid.fill(
{ anchor: { row: 0, column: 0 }, focus: { row: 0, column: 0 } },
{ anchor: { row: 0, column: 0 }, focus: { row: 299, column: 0 } }
);
@@ -590,6 +590,7 @@ describe('formula-aware copy coordination', () => {
focus: { row: 0, column: 0 },
});
expect(view.grid.notice()).toBe('');
+ await filling;
}
);
diff --git a/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.ts b/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.ts
index e648df0fb9..bb0ebc86f1 100644
--- a/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.ts
+++ b/apps/web/src/features/block-spreadsheet/primitives/create-grid-controller.ts
@@ -605,7 +605,7 @@ export function createGridController(source: GridSource) {
function fillDirection(direction: 'down' | 'right') {
const { top, bottom, left, right } = selectionBounds(selection());
- fill(
+ void fill(
{
anchor: { row: top, column: left },
focus: {
diff --git a/apps/web/src/features/block-spreadsheet/primitives/create-range-move.test.ts b/apps/web/src/features/block-spreadsheet/primitives/create-range-move.test.ts
index 609a6ef5f3..e1286e3446 100644
--- a/apps/web/src/features/block-spreadsheet/primitives/create-range-move.test.ts
+++ b/apps/web/src/features/block-spreadsheet/primitives/create-range-move.test.ts
@@ -100,7 +100,7 @@ describe('moving selected cells', () => {
expect(rangeMove.confirming()).toBeUndefined();
expect(store.cells().A1.value).toBe('10');
expect(store.cells().C1.value).toBe('Taken');
- rangeMove.move(firstColumn, 0, 2);
+ await rangeMove.move(firstColumn, 0, 2);
await rangeMove.confirm();
expect(store.cells().A1).toBeUndefined();
expect(store.cells().C1).toEqual({ value: '10', bold: true });
@@ -126,7 +126,7 @@ describe('moving selected cells', () => {
it("cancels a confirmed move after a collaborator's edit and keeps both", async () => {
const { doc, store, rangeMove, setNotice } = setup();
- rangeMove.move(firstColumn, 0, 2);
+ await rangeMove.move(firstColumn, 0, 2);
const peer = new LoroDoc();
cleanups.push(() => peer.free());
peer.import(doc.export({ mode: 'snapshot' }));
diff --git a/apps/web/src/features/block-spreadsheet/queries/create-spreadsheet.ts b/apps/web/src/features/block-spreadsheet/queries/create-spreadsheet.ts
index 2fd70093b9..004d2c24f7 100644
--- a/apps/web/src/features/block-spreadsheet/queries/create-spreadsheet.ts
+++ b/apps/web/src/features/block-spreadsheet/queries/create-spreadsheet.ts
@@ -1,5 +1,6 @@
import { analytics } from '@app/lib/analytics';
import { contentHash } from '@core/util/hash';
+import { Telemetry } from '@macro-inc/observability';
import { invalidateUserQuota } from '@queries/auth';
import { setPreviewOnCreate } from '@queries/preview/preview';
import { refetchSoupEntity } from '@queries/soup/cache';
@@ -18,7 +19,7 @@ export async function createSpreadsheetDocument(args?: {
projectId: args?.projectId,
sha: await contentHash(new Uint8Array()),
});
- invalidateUserQuota();
+ void invalidateUserQuota();
if (created.isErr()) return;
const documentId = created.value.metadata.documentId;
@@ -31,7 +32,9 @@ export async function createSpreadsheetDocument(args?: {
refetchSoupEntity(documentId, 'document', {
ownTouch: true,
refreshGraphql: true,
- });
+ }).catch((error) =>
+ Telemetry.error(error, { surface: 'create-spreadsheet-document' })
+ );
analytics.track('create_entity', {
entityType: 'spreadsheet',
entityId: documentId,
diff --git a/apps/web/src/features/block-unknown/component/Block.tsx b/apps/web/src/features/block-unknown/component/Block.tsx
index 897d74ae1f..15361826c2 100644
--- a/apps/web/src/features/block-unknown/component/Block.tsx
+++ b/apps/web/src/features/block-unknown/component/Block.tsx
@@ -72,7 +72,7 @@ function BlockUnknownContent() {
const downloadDocument = createCallback(async () => {
try {
const blob = await getBlob();
- downloadFile(blob, downloadName());
+ void downloadFile(blob, downloadName());
} catch (error) {
console.error('error downloading file', error);
toast.failure('Error downloading file');
diff --git a/apps/web/src/features/block-unknown/component/TopBar.tsx b/apps/web/src/features/block-unknown/component/TopBar.tsx
index abc1e340aa..b6f607a02e 100644
--- a/apps/web/src/features/block-unknown/component/TopBar.tsx
+++ b/apps/web/src/features/block-unknown/component/TopBar.tsx
@@ -33,7 +33,7 @@ export function TopBar(props: { onShare: () => void }) {
const downloadDocument = createCallback(async () => {
try {
const blob = await getBlob();
- downloadFile(blob, downloadName());
+ void downloadFile(blob, downloadName());
} catch (e) {
console.error('error downloading file', e);
toast.failure('Error downloading file');
diff --git a/apps/web/src/features/calendar-view/calendar-target-request.ts b/apps/web/src/features/calendar-view/calendar-target-request.ts
index 5cfba98c99..623a89b169 100644
--- a/apps/web/src/features/calendar-view/calendar-target-request.ts
+++ b/apps/web/src/features/calendar-view/calendar-target-request.ts
@@ -1,3 +1,4 @@
+import { Telemetry } from '@macro-inc/observability';
import { fetchCalendarMentionPreview } from '@queries/calendar/mention-preview';
import { type Accessor, createSignal } from 'solid-js';
import {
@@ -131,9 +132,13 @@ export function createCalendarTargetAim(options: {
return;
}
if (typeof params.eventId === 'string' && params.eventId.length > 0) {
- resolveFromPreview(params, requestId).then((resolved) => {
- applyResolvedTarget(requestId, resolved);
- });
+ resolveFromPreview(params, requestId)
+ .then((resolved) => {
+ applyResolvedTarget(requestId, resolved);
+ })
+ .catch((error) =>
+ Telemetry.error(error, { surface: 'calendar-target' })
+ );
return;
}
applyResolvedTarget(requestId, undefined);
diff --git a/apps/web/src/features/calendar-view/calendar-view.tsx b/apps/web/src/features/calendar-view/calendar-view.tsx
index 503603a02d..adb64383e3 100644
--- a/apps/web/src/features/calendar-view/calendar-view.tsx
+++ b/apps/web/src/features/calendar-view/calendar-view.tsx
@@ -201,7 +201,7 @@ export function CalendarView(props: CalendarViewProps) {
};
const setPeriodView = (period: CalendarPeriodView) => {
if (routeParams.period === period) return;
- navigate({ route: props.route, params: { period } });
+ void navigate({ route: props.route, params: { period } });
};
onMount(() => {
diff --git a/apps/web/src/features/calendar/components/CalendarSettingsDropdown.tsx b/apps/web/src/features/calendar/components/CalendarSettingsDropdown.tsx
index c5a236e18e..43c3f8efbe 100644
--- a/apps/web/src/features/calendar/components/CalendarSettingsDropdown.tsx
+++ b/apps/web/src/features/calendar/components/CalendarSettingsDropdown.tsx
@@ -135,7 +135,7 @@ function createCalendarSettingsControls(isNarrow: () => boolean) {
// A brand-new account needs the mailbox scopes alongside calendar.
const connectAnotherAccount = () => {
calendarView.closeEventDetails();
- startAddInbox({ scopes: 'gmail_and_calendar' });
+ void startAddInbox({ scopes: 'gmail_and_calendar' });
};
return {
diff --git a/apps/web/src/features/drive-view/drive-detail-navigation.tsx b/apps/web/src/features/drive-view/drive-detail-navigation.tsx
index b8875da097..0797e656a9 100644
--- a/apps/web/src/features/drive-view/drive-detail-navigation.tsx
+++ b/apps/web/src/features/drive-view/drive-detail-navigation.tsx
@@ -154,7 +154,7 @@ export function DriveDetailNavigationProvider(
sameDocumentRoute(detailRouteFromTarget(endpoint), resolved.document);
if (endpointMatches) return true;
- navigate(driveDestination(props.location(), resolved.document), {
+ void navigate(driveDestination(props.location(), resolved.document), {
state: [...currentTrail, resolved.target],
});
return true;
@@ -164,7 +164,7 @@ export function DriveDetailNavigationProvider(
const resolved = resolveTarget(target, options);
if (!resolved) return false;
- navigate(
+ void navigate(
driveDestination(
options?.location ?? props.location(),
resolved.document
@@ -203,7 +203,7 @@ export function DriveDetailNavigationProvider(
const target = nextTrail.at(-1);
if (!target) return;
- navigate(
+ void navigate(
driveDestination(props.location(), detailRouteFromTarget(target)),
{ state: nextTrail }
);
@@ -214,7 +214,7 @@ export function DriveDetailNavigationProvider(
// not climb out of the folder/tab the user just selected.
if (!activeDocument() && !activeCallId()) return;
selectPreview(undefined);
- navigate(driveDestination(props.location()), {
+ void navigate(driveDestination(props.location()), {
replace: options?.replace,
});
},
diff --git a/apps/web/src/features/drive-view/primitives/drive-route-state.ts b/apps/web/src/features/drive-view/primitives/drive-route-state.ts
index 37a155c7fc..48e1dfd6e2 100644
--- a/apps/web/src/features/drive-view/primitives/drive-route-state.ts
+++ b/apps/web/src/features/drive-view/primitives/drive-route-state.ts
@@ -62,7 +62,7 @@ export function createDriveRouteState(
search: DriveSearchParams,
options: NavigationOptions = {}
) {
- navigate(driveDestination(location), {
+ void navigate(driveDestination(location), {
...options,
search: {
drive: driveSearch.serialize(search, {
diff --git a/apps/web/src/features/drive-view/queries/folder-creation.ts b/apps/web/src/features/drive-view/queries/folder-creation.ts
index a22098cc43..9e546c7803 100644
--- a/apps/web/src/features/drive-view/queries/folder-creation.ts
+++ b/apps/web/src/features/drive-view/queries/folder-creation.ts
@@ -1,10 +1,14 @@
import { uploadFiles } from '@core/util/upload';
+import { Telemetry } from '@macro-inc/observability';
import { refetchHistory } from '@queries/history/history';
import { refetchSoupEntity } from '@queries/soup/cache';
import { createProject } from '@queries/storage/projects';
import { propertiesServiceClient } from '@service-properties/client';
import type { FolderCreationCommands } from '../core/folder-composer';
+const reportRefetchError = (error: unknown) =>
+ Telemetry.error(error, { surface: 'drive-folder-creation' });
+
export function createFolderCommands(options: {
parentId?: string;
source?: string;
@@ -31,7 +35,9 @@ export function createFolderCommands(options: {
body: { properties },
});
if (result.isErr()) throw result.error;
- refetchSoupEntity(id, 'project', { refreshGraphql: true });
+ refetchSoupEntity(id, 'project', { refreshGraphql: true }).catch(
+ reportRefetchError
+ );
},
async upload(id, file) {
const [result] = await uploadFiles([file], 'dss', { projectId: id });
@@ -39,11 +45,15 @@ export function createFolderCommands(options: {
if (result.type === 'folder') {
const folderId = await result.projectId;
if (!folderId) throw new Error('Folder upload failed');
- refetchSoupEntity(folderId, 'project', { includeRoot: true });
+ refetchSoupEntity(folderId, 'project', { includeRoot: true }).catch(
+ reportRefetchError
+ );
} else {
- refetchSoupEntity(result.documentId, 'document');
+ refetchSoupEntity(result.documentId, 'document').catch(
+ reportRefetchError
+ );
}
- refetchHistory();
+ void refetchHistory();
},
};
}
diff --git a/apps/web/src/features/drive-view/views/CanvasDetail.tsx b/apps/web/src/features/drive-view/views/CanvasDetail.tsx
index ea2489c155..d7fff50b92 100644
--- a/apps/web/src/features/drive-view/views/CanvasDetail.tsx
+++ b/apps/web/src/features/drive-view/views/CanvasDetail.tsx
@@ -32,7 +32,7 @@ function CanvasDetailContent(props: {
);
const operations = [
downloadFileOperation(() => {
- downloadFile(props.savedFile() ?? props.data.file, downloadName);
+ void downloadFile(props.savedFile() ?? props.data.file, downloadName);
analytics.track('download', { blockType: 'canvas' });
}),
];
diff --git a/apps/web/src/features/drive-view/views/CodeDetail.tsx b/apps/web/src/features/drive-view/views/CodeDetail.tsx
index 9b42de729e..0b7f24cd18 100644
--- a/apps/web/src/features/drive-view/views/CodeDetail.tsx
+++ b/apps/web/src/features/drive-view/views/CodeDetail.tsx
@@ -73,7 +73,7 @@ function CodeDetailSession(props: {
const [text, setText] = createSignal(props.data.text);
const operations = [
downloadFileOperation(() => {
- downloadFile(
+ void downloadFile(
new Blob([text() ?? ''], { type: 'text/plain' }),
documentDownloadName(props.data.documentMetadata)
);
diff --git a/apps/web/src/features/drive-view/views/ImageDetail.tsx b/apps/web/src/features/drive-view/views/ImageDetail.tsx
index bcd7010084..f3da786124 100644
--- a/apps/web/src/features/drive-view/views/ImageDetail.tsx
+++ b/apps/web/src/features/drive-view/views/ImageDetail.tsx
@@ -19,7 +19,7 @@ export function ImageDetailDocument(props: {
}) {
const operations = [
downloadFileOperation(() => {
- downloadFile(
+ void downloadFile(
props.data.file,
documentDownloadName(props.data.documentMetadata)
);
diff --git a/apps/web/src/features/drive-view/views/UnknownDetail.tsx b/apps/web/src/features/drive-view/views/UnknownDetail.tsx
index b8a008e81f..b7ffbdaba8 100644
--- a/apps/web/src/features/drive-view/views/UnknownDetail.tsx
+++ b/apps/web/src/features/drive-view/views/UnknownDetail.tsx
@@ -37,7 +37,7 @@ export function UnknownDetailDocument(props: {
documentId: props.documentId,
documentVersionId: props.data.documentMetadata.documentVersionId,
});
- downloadFile(file, downloadName());
+ await downloadFile(file, downloadName());
} catch (error) {
console.error('error downloading file', error);
toast.failure('Error downloading file');
diff --git a/apps/web/src/features/email-compose/compose-adapter.ts b/apps/web/src/features/email-compose/compose-adapter.ts
index aab41f2388..23e31db4d8 100644
--- a/apps/web/src/features/email-compose/compose-adapter.ts
+++ b/apps/web/src/features/email-compose/compose-adapter.ts
@@ -258,7 +258,7 @@ export function createEmailComposeContext(
),
input.onVideos
)
- );
+ ).catch(reportError);
},
},
notices: {
diff --git a/apps/web/src/features/email-compose/editor-adapter.ts b/apps/web/src/features/email-compose/editor-adapter.ts
index 32724dc718..dda1a9e36f 100644
--- a/apps/web/src/features/email-compose/editor-adapter.ts
+++ b/apps/web/src/features/email-compose/editor-adapter.ts
@@ -10,6 +10,7 @@ import {
isFileUploadEntry,
type UploadInput,
} from '@core/util/upload';
+import { Telemetry } from '@macro-inc/observability';
import { type FocusableElement, tabbable } from 'tabbable';
import type { ComposeBodyActions } from './context/editor-capabilities';
import { makeAttachmentPublic } from './make-attachment-public';
@@ -83,7 +84,7 @@ export function createComposeBodyActions(): ComposeBodyActions {
),
onVideos
)
- );
+ ).catch((error) => Telemetry.error(error, { surface: 'email-compose' }));
},
};
}
diff --git a/apps/web/src/features/email-compose/primitives/attachment-persistence.test.ts b/apps/web/src/features/email-compose/primitives/attachment-persistence.test.ts
index cc47e086c9..ac87025108 100644
--- a/apps/web/src/features/email-compose/primitives/attachment-persistence.test.ts
+++ b/apps/web/src/features/email-compose/primitives/attachment-persistence.test.ts
@@ -99,8 +99,10 @@ describe('draft attachment persistence', () => {
};
state.form.attachments.add(local);
state.form.attachments.add(forwarded);
- state.persistence.remove(local);
- state.persistence.remove(forwarded);
+ const removals = [
+ state.persistence.remove(local),
+ state.persistence.remove(forwarded),
+ ];
expect(state.form.attachments.list()).toEqual([]);
expect(state.services.removeAttachment).toHaveBeenCalledWith({
draftId: 'draft',
@@ -112,7 +114,7 @@ describe('draft attachment persistence', () => {
attachmentId: 'forwarded',
inboxId: 'secondary-inbox',
});
- await Promise.resolve();
+ await Promise.all(removals);
});
it('re-uploads files after detach and ignores late callbacks from the obsolete upload', async () => {
diff --git a/apps/web/src/features/email-compose/primitives/send-schedule.test.ts b/apps/web/src/features/email-compose/primitives/send-schedule.test.ts
index e26758cdc0..8ce7b7e24b 100644
--- a/apps/web/src/features/email-compose/primitives/send-schedule.test.ts
+++ b/apps/web/src/features/email-compose/primitives/send-schedule.test.ts
@@ -932,8 +932,11 @@ describe('send and schedule ordering', () => {
const state = mountReplyComposer(composeContext);
try {
state.form.setSelectedInbox('secondary');
- state.handleAddAttachments([new File(['attachment'], 'review.txt')]);
+ const adding = state.handleAddAttachments([
+ new File(['attachment'], 'review.txt'),
+ ]);
await vi.advanceTimersByTimeAsync(500);
+ await adding;
expect(state.handleSendTimeChange(hoursFromNow(24))).toBe(true);
const scheduling = state.sendEmail();
await vi.advanceTimersByTimeAsync(0);
@@ -957,8 +960,11 @@ describe('send and schedule ordering', () => {
).mockReturnValueOnce(uploading);
const state = mountReplyComposer(composeContext);
try {
- state.handleAddAttachments([new File(['attachment'], 'review.txt')]);
+ const adding = state.handleAddAttachments([
+ new File(['attachment'], 'review.txt'),
+ ]);
await vi.advanceTimersByTimeAsync(500);
+ await adding;
expect(state.savedDraftId()).toBe('draft');
const discarded = state.deleteDraftAndReset();
expect(composeContext.drafts.deleteDraft).not.toHaveBeenCalled();
@@ -1040,7 +1046,7 @@ describe('send and schedule ordering', () => {
state.form.attachments.add(attachment);
state.edit('Forwarding');
await vi.advanceTimersByTimeAsync(500);
- state.handleRemoveAttachment(attachment);
+ const removing = state.handleRemoveAttachment(attachment);
expect(
composeContext.attachmentStorage.removeForwardedAttachment
).not.toHaveBeenCalled();
@@ -1049,6 +1055,7 @@ describe('send and schedule ordering', () => {
expect(
composeContext.attachmentStorage.addForwardedAttachments
).not.toHaveBeenCalled();
+ await removing;
} finally {
state.dispose();
}
diff --git a/apps/web/src/features/email-compose/undo-send.ts b/apps/web/src/features/email-compose/undo-send.ts
index 648fe57f14..7627d85d6c 100644
--- a/apps/web/src/features/email-compose/undo-send.ts
+++ b/apps/web/src/features/email-compose/undo-send.ts
@@ -80,7 +80,7 @@ export async function runUndoSend(options: {
);
return;
}
- queryClient.invalidateQueries({
+ void queryClient.invalidateQueries({
queryKey: emailKeys.previews._def,
});
diff --git a/apps/web/src/features/email-compose/views/reply-input.tsx b/apps/web/src/features/email-compose/views/reply-input.tsx
index dc139a6da7..e21679d1f4 100644
--- a/apps/web/src/features/email-compose/views/reply-input.tsx
+++ b/apps/web/src/features/email-compose/views/reply-input.tsx
@@ -260,7 +260,7 @@ function LoadedReplyInputView(props: ReplyInputViewProps) {
scopeId: composeHotkeyScope,
description: 'Send email',
keyDownHandler: () => {
- sendEmail();
+ sendEmail().catch(composeContext.notices.reportError);
return true;
},
runWithInputFocused: true,
@@ -273,7 +273,7 @@ function LoadedReplyInputView(props: ReplyInputViewProps) {
scopeId: composeHotkeyScope,
description: 'Send and mark done',
keyDownHandler: () => {
- sendEmail(true);
+ sendEmail(true).catch(composeContext.notices.reportError);
return true;
},
runWithInputFocused: true,
@@ -332,7 +332,7 @@ function LoadedReplyInputView(props: ReplyInputViewProps) {
if (isEmpty) {
// Delete draft and close reply
- deleteDraftAndReset();
+ deleteDraftAndReset().catch(() => {});
} else {
// Move focus back to the message
ctx.exitToThread('selected');
@@ -374,7 +374,7 @@ function LoadedReplyInputView(props: ReplyInputViewProps) {
}}
removable={!editingDisabled()}
onRemove={() => {
- if (!editingDisabled()) handleRemoveAttachment(attachment);
+ if (!editingDisabled()) void handleRemoveAttachment(attachment);
}}
onClick={attachmentViewer.onClickFor(attachment)}
/>
diff --git a/apps/web/src/features/email-message/attachment-action-adapter.ts b/apps/web/src/features/email-message/attachment-action-adapter.ts
index 8d5d3011bd..ccfc54058c 100644
--- a/apps/web/src/features/email-message/attachment-action-adapter.ts
+++ b/apps/web/src/features/email-message/attachment-action-adapter.ts
@@ -37,7 +37,9 @@ export function createEmailAttachmentOpener() {
);
}
- refetchSoupEntity(document_id, 'document');
+ refetchSoupEntity(document_id, 'document').catch((error) =>
+ Telemetry.error(error, { surface: 'email-attachment' })
+ );
const fileType = Object.values(FileTypeMap).findLast(
(type) => type.mime === attachment.mime_type
diff --git a/apps/web/src/features/email-thread/thread-action-adapter.tsx b/apps/web/src/features/email-thread/thread-action-adapter.tsx
index dd9262d680..45c12bd6c0 100644
--- a/apps/web/src/features/email-thread/thread-action-adapter.tsx
+++ b/apps/web/src/features/email-thread/thread-action-adapter.tsx
@@ -32,14 +32,17 @@ export function createThreadActionAdapter(
const blockSender = () => {
const senderEmail = getSenderEmail();
if (!senderEmail) return false;
- blockSenderWithToast(senderEmail, toHeaderLinkId(threadSource()?.link_id));
+ void blockSenderWithToast(
+ senderEmail,
+ toHeaderLinkId(threadSource()?.link_id)
+ );
return true;
};
const markSenderSignal = () => {
const senderEmail = getSenderEmail();
if (!senderEmail) return false;
- markSenderSignalWithToast(
+ void markSenderSignalWithToast(
senderEmail,
toHeaderLinkId(threadSource()?.link_id)
);
@@ -49,7 +52,7 @@ export function createThreadActionAdapter(
const markSenderNoise = () => {
const senderEmail = getSenderEmail();
if (!senderEmail) return false;
- markSenderNoiseWithToast(
+ void markSenderNoiseWithToast(
senderEmail,
toHeaderLinkId(threadSource()?.link_id)
);
diff --git a/apps/web/src/features/email-thread/thread-completion-adapter.tsx b/apps/web/src/features/email-thread/thread-completion-adapter.tsx
index 5b92bc257f..d0d5a84ab5 100644
--- a/apps/web/src/features/email-thread/thread-completion-adapter.tsx
+++ b/apps/web/src/features/email-thread/thread-completion-adapter.tsx
@@ -85,7 +85,7 @@ export function createThreadCompletionAdapter(
label: 'Undo',
icon: ArrowCounterClockwise,
onClick: () => {
- handle.undo({
+ void handle.undo({
onError: () => toast.failure('Failed to undo'),
});
},
diff --git a/apps/web/src/features/email-view/email-view-context.tsx b/apps/web/src/features/email-view/email-view-context.tsx
index 3e37a20dc4..5f6bd089ca 100644
--- a/apps/web/src/features/email-view/email-view-context.tsx
+++ b/apps/web/src/features/email-view/email-view-context.tsx
@@ -250,8 +250,8 @@ export const [EmailViewProvider, useEmailView] = createAssertedContextProvider<
!(event?.shiftKey || event?.metaKey || event?.ctrlKey || event?.altKey)
);
};
- const closeThread = () =>
- navigate(
+ const closeThread = () => {
+ void navigate(
{ route: emailSplitRoute, params: {} },
{
search: {
@@ -261,6 +261,7 @@ export const [EmailViewProvider, useEmailView] = createAssertedContextProvider<
},
}
);
+ };
const openThread = (
thread: EmailThreadTarget,
options?: EntityDetailNavigationOptions & { replace?: boolean }
@@ -270,7 +271,7 @@ export const [EmailViewProvider, useEmailView] = createAssertedContextProvider<
// The router may refuse a claimed destination. Check compatibility without
// claiming it until the accepted route changes.
if (!selectPreview.canSelect(selection)) return true;
- navigate(
+ void navigate(
{ route: emailThreadRoute, params: { threadId: thread.id } },
{
replace: options?.replace,
@@ -292,7 +293,7 @@ export const [EmailViewProvider, useEmailView] = createAssertedContextProvider<
: undefined;
if (!selectPreview(selection)) {
if (previous) {
- navigate(
+ void navigate(
{
route: emailThreadRoute,
params: { threadId: previous.id },
@@ -307,7 +308,7 @@ export const [EmailViewProvider, useEmailView] = createAssertedContextProvider<
}
);
} else {
- navigate(
+ void navigate(
{ route: emailSplitRoute, params: {} },
{
replace: true,
diff --git a/apps/web/src/features/home/home-calendar-preview.ts b/apps/web/src/features/home/home-calendar-preview.ts
index 6334285ac2..ea9d44987e 100644
--- a/apps/web/src/features/home/home-calendar-preview.ts
+++ b/apps/web/src/features/home/home-calendar-preview.ts
@@ -47,7 +47,7 @@ export function useHomeCalendarPreview(withTab: WithTab) {
// The same URL still needs to refocus the event in the inline calendar.
if (alreadyOpen) setCalendarRefocus((count) => count + 1);
else
- navigate(
+ void navigate(
{ route: homeCalendarRoute, params: navigation.params },
{ search: withTab(navigation.search) }
);
diff --git a/apps/web/src/features/home/home-view-context.tsx b/apps/web/src/features/home/home-view-context.tsx
index c6f19b2bd2..acbc20352c 100644
--- a/apps/web/src/features/home/home-view-context.tsx
+++ b/apps/web/src/features/home/home-view-context.tsx
@@ -160,15 +160,16 @@ export const [HomeViewProvider, useHomeView] = createAssertedContextProvider<
params: { documentType: blockType, documentId: previewId },
}
: { route: homePreviewRoute, params };
- navigate(target, { replace, search: withTab(search) });
+ void navigate(target, { replace, search: withTab(search) });
};
const navigateTarget = (target: PreviewBlockTarget, replace = false) =>
navigateDetail(homePreviewTargetNavigation(target), replace);
- const closePreview = () =>
- navigate(
+ const closePreview = () => {
+ void navigate(
{ route: homeSplitRoute, params: {} },
{ search: withTab(homeDetailSearch()) }
);
+ };
const [previewNavigationRequest, setPreviewNavigationRequest] =
createSignal(0);
const openPreview = (entity: PreviewSelection) => {
@@ -197,7 +198,7 @@ export const [HomeViewProvider, useHomeView] = createAssertedContextProvider<
if (selectPreview(target)) return;
if (previous) navigateTarget(previous, true);
else
- navigate(
+ void navigate(
{ route: homeSplitRoute, params: {} },
{ replace: true, search: withTab(homeDetailSearch()) }
);
diff --git a/apps/web/src/features/integrations/import-linear/ImportLinear.tsx b/apps/web/src/features/integrations/import-linear/ImportLinear.tsx
index 371f9aa74a..c2d90bdc4e 100644
--- a/apps/web/src/features/integrations/import-linear/ImportLinear.tsx
+++ b/apps/web/src/features/integrations/import-linear/ImportLinear.tsx
@@ -185,7 +185,7 @@ export default function ImportLinear() {
}
// Refresh soup items so the new tasks appear.
- queryClient.invalidateQueries({ queryKey: soupKeys.astItems._def });
+ void queryClient.invalidateQueries({ queryKey: soupKeys.astItems._def });
setCreatedIds(createdList);
setProgress({ type: 'done', created, skipped, failed });
diff --git a/apps/web/src/features/projects/project-detail.tsx b/apps/web/src/features/projects/project-detail.tsx
index 24cf1219c8..3b5caf5cea 100644
--- a/apps/web/src/features/projects/project-detail.tsx
+++ b/apps/web/src/features/projects/project-detail.tsx
@@ -300,7 +300,7 @@ function ProjectDetailHost(props: ProjectDetailProps) {
event?.altKey
)
) {
- navigate({
+ void navigate({
route: projectTaskRoute,
params: {
projectId: props.route.id,
diff --git a/apps/web/src/features/property/editor/PropertyEditorModal.tsx b/apps/web/src/features/property/editor/PropertyEditorModal.tsx
index 3035b043d0..f4d6d6f5f5 100644
--- a/apps/web/src/features/property/editor/PropertyEditorModal.tsx
+++ b/apps/web/src/features/property/editor/PropertyEditorModal.tsx
@@ -235,9 +235,11 @@ export function PropertyEditorModal() {
: count + ' entities'
}`;
- saveProperties(selectedEntities, targetProperty, value).then((success) => {
- if (success) toast.success(message);
- });
+ void saveProperties(selectedEntities, targetProperty, value).then(
+ (success) => {
+ if (success) toast.success(message);
+ }
+ );
if (!event?.shiftKey) closePropertyEditor();
};
diff --git a/apps/web/src/features/property/editors/inline/InlineLinkEditor.tsx b/apps/web/src/features/property/editors/inline/InlineLinkEditor.tsx
index e4b576d16f..f3191f6f06 100644
--- a/apps/web/src/features/property/editors/inline/InlineLinkEditor.tsx
+++ b/apps/web/src/features/property/editors/inline/InlineLinkEditor.tsx
@@ -115,7 +115,7 @@ export function InlineLinkEditor() {
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Enter') {
e.preventDefault();
- handleAddLink();
+ void handleAddLink();
} else if (e.key === 'Escape') {
e.preventDefault();
cancelAdding();
@@ -175,7 +175,7 @@ export function InlineLinkEditor() {
onKeyDown={handleKeyDown}
onBlur={() => {
setTimeout(() => {
- if (isAdding()) handleAddLink();
+ if (isAdding()) void handleAddLink();
}, 100);
}}
placeholder="Enter URL..."
diff --git a/apps/web/src/features/property/editors/inline/InlineNumberEditor.tsx b/apps/web/src/features/property/editors/inline/InlineNumberEditor.tsx
index 31fec491f5..9cebf674ee 100644
--- a/apps/web/src/features/property/editors/inline/InlineNumberEditor.tsx
+++ b/apps/web/src/features/property/editors/inline/InlineNumberEditor.tsx
@@ -25,7 +25,7 @@ export function InlineNumberEditor() {
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Enter') {
e.preventDefault();
- editor.save();
+ void editor.save();
} else if (e.key === 'Escape') {
e.preventDefault();
editor.cancelEdit();
diff --git a/apps/web/src/features/property/editors/inline/InlineTextEditor.tsx b/apps/web/src/features/property/editors/inline/InlineTextEditor.tsx
index 5542b91448..795df7b6a1 100644
--- a/apps/web/src/features/property/editors/inline/InlineTextEditor.tsx
+++ b/apps/web/src/features/property/editors/inline/InlineTextEditor.tsx
@@ -27,7 +27,7 @@ export function InlineTextEditor() {
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Enter') {
e.preventDefault();
- editor.save();
+ void editor.save();
} else if (e.key === 'Escape') {
e.preventDefault();
editor.cancelEdit();
diff --git a/apps/web/src/features/property/editors/popover/DateEditor.tsx b/apps/web/src/features/property/editors/popover/DateEditor.tsx
index f861d86ebc..c7e02bc379 100644
--- a/apps/web/src/features/property/editors/popover/DateEditor.tsx
+++ b/apps/web/src/features/property/editors/popover/DateEditor.tsx
@@ -44,7 +44,7 @@ function DateEditorBody() {
property={property}
selectedDate={selectedDate()}
onSelectDate={(date) => {
- commit(date);
+ void commit(date);
}}
onClose={() => ctx.closeEditor()}
/>
diff --git a/apps/web/src/features/property/editors/selectors/PropertyOptionSelector.tsx b/apps/web/src/features/property/editors/selectors/PropertyOptionSelector.tsx
index 7400843b4e..a41c05c4e1 100644
--- a/apps/web/src/features/property/editors/selectors/PropertyOptionSelector.tsx
+++ b/apps/web/src/features/property/editors/selectors/PropertyOptionSelector.tsx
@@ -206,7 +206,7 @@ export const PropertyOptionSelector = (props: SelectOptionsProps) => {
const handleSelectableItem = (idx: number, event?: KeyboardEvent) => {
const item = selectableItems()[idx];
if (item?.type === 'add') {
- handleAddOption(event);
+ void handleAddOption(event);
} else if (item?.type === 'clear') {
props.clearOption?.onClear();
if (shouldCloseAfterSelect(event) && props.onClose) {
diff --git a/apps/web/src/features/property/tags/TagPicker.tsx b/apps/web/src/features/property/tags/TagPicker.tsx
index 7c7adf69de..8223f3a5aa 100644
--- a/apps/web/src/features/property/tags/TagPicker.tsx
+++ b/apps/web/src/features/property/tags/TagPicker.tsx
@@ -654,7 +654,7 @@ function TagPickerBody(props: {
if (!item) return;
toggleSelected(item.option.id);
- if (!event?.shiftKey) saveAndClose();
+ if (!event?.shiftKey) void saveAndClose();
},
onClose: saveAndClose,
enableNumericHotkeys: false,
@@ -763,7 +763,7 @@ function TagPickerBody(props: {
}
onSelect={(event) => {
toggleSelected(item.option.id);
- if (!event.shiftKey) saveAndClose();
+ if (!event.shiftKey) void saveAndClose();
}}
onEdit={() => void beginEdit(item)}
onOpenTag={() => void openTaggedItems(item)}
@@ -798,7 +798,7 @@ function TagPickerBody(props: {
}
onSelect={(event) => {
toggleSelected(item.option.id);
- if (!event.shiftKey) saveAndClose();
+ if (!event.shiftKey) void saveAndClose();
}}
onEdit={() => void beginEdit(item)}
onOpenTag={() => void openTaggedItems(item)}
diff --git a/apps/web/src/features/reviews-view/reviews-view.tsx b/apps/web/src/features/reviews-view/reviews-view.tsx
index b7a48ce032..9145963d59 100644
--- a/apps/web/src/features/reviews-view/reviews-view.tsx
+++ b/apps/web/src/features/reviews-view/reviews-view.tsx
@@ -209,11 +209,12 @@ function ReviewsRoot() {
const searchForTab = (tab: ReviewsScope) => ({
[reviewsTabSearch.namespace]: reviewsTabSearchCodec.serialize({ tab }),
});
- const openList = () =>
- navigate(
+ const openList = () => {
+ void navigate(
{ route: reviewsSplitRoute, params: {} },
{ search: searchForTab(scope()) }
);
+ };
const selectScope = (next: ReviewsScope) =>
navigate(
{ route: reviewsSplitRoute, params: {} },
@@ -236,7 +237,7 @@ function ReviewsRoot() {
});
return;
}
- navigate(
+ void navigate(
{ route: reviewsPrRoute, params: { foreignEntityId } },
{ search: searchForTab(scope()) }
);
diff --git a/apps/web/src/features/scheduling/calendar-actions.tsx b/apps/web/src/features/scheduling/calendar-actions.tsx
index 45d6490536..70ca86cc1c 100644
--- a/apps/web/src/features/scheduling/calendar-actions.tsx
+++ b/apps/web/src/features/scheduling/calendar-actions.tsx
@@ -37,7 +37,7 @@ function Actions(props: { sidebar?: boolean }) {
const copyLink = async (event?: EventType) => {
const profile = source.isSuccess ? source.data : undefined;
if (!profile?.revision) {
- navigate({ route: bookingLinksRoute });
+ void navigate({ route: bookingLinksRoute });
return;
}
diff --git a/apps/web/src/features/settings/Appearance.tsx b/apps/web/src/features/settings/Appearance.tsx
index 6aea9e607f..de0f093128 100644
--- a/apps/web/src/features/settings/Appearance.tsx
+++ b/apps/web/src/features/settings/Appearance.tsx
@@ -61,8 +61,7 @@ function CopyThemeButton(props: { themeId: string; name: string }) {
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
- exportTheme(props.themeId);
- toast.success('Theme copied to clipboard');
+ void exportTheme(props.themeId);
}}
>
<ClipboardIcon class="size-3.5 mobile:size-5" />
diff --git a/apps/web/src/features/settings/Settings.tsx b/apps/web/src/features/settings/Settings.tsx
index b3df06d7a8..4e96c74885 100644
--- a/apps/web/src/features/settings/Settings.tsx
+++ b/apps/web/src/features/settings/Settings.tsx
@@ -132,7 +132,7 @@ export function SettingsPanel(props: SettingsPanelProps) {
const selectRoutedTab = (tab: SettingsTab) => {
setSearchSelection(undefined);
selectTab(tab, (next) => {
- splitNavigate(`/settings/${settingsTabToSlug(next)}`);
+ void splitNavigate(`/settings/${settingsTabToSlug(next)}`);
});
};
diff --git a/apps/web/src/features/tasks-view/components/TasksSidebar.tsx b/apps/web/src/features/tasks-view/components/TasksSidebar.tsx
index b9298a1b3d..886fac0103 100644
--- a/apps/web/src/features/tasks-view/components/TasksSidebar.tsx
+++ b/apps/web/src/features/tasks-view/components/TasksSidebar.tsx
@@ -198,7 +198,7 @@ export function TasksSidebar() {
openProject(layout, id, { newSplit: true });
return;
}
- navigate({
+ void navigate({
route: projectDetailRoute,
params: { projectId: id, section: 'overview' },
});
diff --git a/apps/web/src/features/tasks-view/route-views.tsx b/apps/web/src/features/tasks-view/route-views.tsx
index 506cf2e655..872722f19f 100644
--- a/apps/web/src/features/tasks-view/route-views.tsx
+++ b/apps/web/src/features/tasks-view/route-views.tsx
@@ -86,7 +86,7 @@ export function ProjectTaskRouteView() {
event?.altKey
)
return false;
- navigate({
+ void navigate({
route: projectTaskRoute,
params: {
projectId: params.projectId,
diff --git a/apps/web/src/features/tasks-view/tasks-view-context.tsx b/apps/web/src/features/tasks-view/tasks-view-context.tsx
index f1ff79e82b..0cb4d71bed 100644
--- a/apps/web/src/features/tasks-view/tasks-view-context.tsx
+++ b/apps/web/src/features/tasks-view/tasks-view-context.tsx
@@ -306,7 +306,7 @@ export const [TasksViewProvider, useTasksView] = createAssertedContextProvider<
};
const closeTask = () => {
if (props.onCloseTask) return props.onCloseTask();
- navigate(
+ void navigate(
{
route: state.tab === 'projects' ? tasksProjectsRoute : tasksSplitRoute,
params: {},
@@ -325,7 +325,7 @@ export const [TasksViewProvider, useTasksView] = createAssertedContextProvider<
if (props.onOpenTask) return props.onOpenTask(task, options);
if (!opensInline(options)) return false;
if (!selectPreview.canSelect(taskSelection(task.id))) return true;
- navigate(
+ void navigate(
{ route: taskDetailRoute, params: { taskId: task.id } },
{
search: {
@@ -341,7 +341,7 @@ export const [TasksViewProvider, useTasksView] = createAssertedContextProvider<
if (props.scopeKey || routeParams.projectId) return;
if (!selectPreview(task ? taskSelection(task.id) : undefined)) {
if (previous) {
- navigate(
+ void navigate(
{ route: taskDetailRoute, params: { taskId: previous.id } },
{
replace: true,
@@ -351,7 +351,7 @@ export const [TasksViewProvider, useTasksView] = createAssertedContextProvider<
}
);
} else {
- navigate(
+ void navigate(
{
route:
state.tab === 'projects' ? tasksProjectsRoute : tasksSplitRoute,
diff --git a/apps/web/src/features/tasks-view/tasks-view.tsx b/apps/web/src/features/tasks-view/tasks-view.tsx
index f77ad15d5c..eecacbdc57 100644
--- a/apps/web/src/features/tasks-view/tasks-view.tsx
+++ b/apps/web/src/features/tasks-view/tasks-view.tsx
@@ -54,7 +54,7 @@ function TasksViewBreadcrumbs(props: ParentProps) {
onChange={(next) => {
if (next === 'tasks-view') closeTask();
else if (params.projectId && next === `initiative:${params.projectId}`)
- navigate({
+ void navigate({
route: projectDetailRoute,
params: {
projectId: params.projectId,
@@ -141,7 +141,7 @@ function TasksViewRoot() {
});
return;
}
- navigate({
+ void navigate({
route: projectDetailRoute,
params: { projectId: id, section: 'overview' },
});
diff --git a/apps/web/src/features/theme/utils/themeUtils.ts b/apps/web/src/features/theme/utils/themeUtils.ts
index 200f101369..606ccb87a7 100644
--- a/apps/web/src/features/theme/utils/themeUtils.ts
+++ b/apps/web/src/features/theme/utils/themeUtils.ts
@@ -1,4 +1,5 @@
import { toast } from '@core/component/Toast/Toast';
+import { Telemetry } from '@macro-inc/observability';
import { batch, createEffect, on } from 'solid-js';
import { DEFAULT_DARK_THEME, DEFAULT_LIGHT_THEME } from '../constants';
import {
@@ -34,10 +35,16 @@ import {
import { convertThemev2v3 } from './themeMigrations';
import { isThemeV2, isThemeV3 } from './themeValidation';
-export function exportTheme(themeId?: string) {
+export async function exportTheme(themeId?: string): Promise<void> {
const id = themeId ?? currentThemeId();
const theme = JSON.stringify(themes().find((t) => t.id === id));
- navigator.clipboard.writeText(theme);
+ try {
+ await navigator.clipboard.writeText(theme);
+ toast.success('Theme copied to clipboard');
+ } catch (error) {
+ Telemetry.error(error, { surface: 'theme-export' });
+ toast.failure('Failed to copy theme to clipboard');
+ }
}
async function _importTheme(): Promise<void> {