Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(channels): remove open in other split from options, add split ctx menu (#7658)

Seamusc6fbc5400b22
diff --git a/apps/web/src/components/app/split-layout/components/SplitHeader.tsx b/apps/web/src/components/app/split-layout/components/SplitHeader.tsx
index e785434061..266c68a329 100644
--- a/apps/web/src/components/app/split-layout/components/SplitHeader.tsx
+++ b/apps/web/src/components/app/split-layout/components/SplitHeader.tsx
@@ -7,32 +7,19 @@ import type { DriveState } from '@app/features/drive-view/core/types';
import { useSoup } from '@app/features/next-soup/soup-context';
import { openEntityInSplitFromUnifiedList } from '@app/features/next-soup/utils';
import { projectRouteId } from '@app/features/projects/core/route';
-import { type PaneId, useSplitRouter } from '@app/lib/split-router';
import { useGlobalNotificationSource } from '@components/app/GlobalAppState';
import { type BlockName, NonDocumentBlockTypes } from '@core/block';
-import {
- ContextMenuContent,
- MenuItem,
- MenuSeparator,
-} from '@core/component/ContextMenu';
-import { toast } from '@core/component/Toast/Toast';
import { fileTypeToBlockName } from '@core/constant/allBlocks';
import { TOKENS } from '@core/hotkey/tokens';
import { isMobile } from '@core/mobile/isMobile';
import { isNativeMobilePlatform } from '@core/mobile/isNativeMobilePlatform';
import { isTouchDevice } from '@core/mobile/isTouchDevice';
import { type EntityDragEvent, isEntityDragEvent } from '@entity';
-import { ContextMenu } from '@kobalte/core/context-menu';
-import ArrowClockwise from '@phosphor/arrow-clockwise.svg';
-import ArrowLeft from '@phosphor/arrow-left.svg';
-import ArrowRight from '@phosphor/arrow-right.svg';
import CollapseIcon from '@phosphor/arrows-in.svg';
import ExpandIcon from '@phosphor/arrows-out.svg';
import CaretDown from '@phosphor/caret-down.svg';
import CaretLeft from '@phosphor/caret-left.svg';
import CaretUp from '@phosphor/caret-up.svg';
-import SplitIcon from '@phosphor/columns.svg';
-import CopyIcon from '@phosphor/copy.svg';
import CloseIcon from '@phosphor/x.svg';
import { mergeRefs } from '@solid-primitives/refs';
import { createDroppable, useDragDropContext } from '@thisbeyond/solid-dnd';
@@ -59,6 +46,7 @@ import {
type PriorityCollapseController,
PriorityCollapseOverflowSensor,
} from './PriorityCollapseOverflowSensor';
+import { SplitHeaderContextMenu } from './SplitHeaderContextMenu';
function getEntitySplitContent(data: EntityDragEvent['draggable']['data']):
| {
@@ -368,160 +356,6 @@ export function ListNavigationButtons(props: {
);
}
-function SplitHeaderContextMenu(props: ParentProps) {
- const panel = useContext(SplitPanelContext);
- const layout = useContext(SplitLayoutContext);
- const router = useSplitRouter();
- if (!panel || !layout) return props.children;
-
- const splitIndex = createMemo(() =>
- layout.manager.splits().findIndex((split) => split.id === panel.handle.id)
- );
- const hasOtherSplits = createMemo(() => layout.manager.splits().length > 1);
- const canDuplicateSplit = createMemo(
- () => panel.handle.content().type === 'component'
- );
- const canToggleSpotlight = createMemo(() => canSpotlight(layout.manager));
- const canSwapWith = (direction: 'left' | 'right') =>
- layout.manager.canSwapSplit(panel.handle.id, direction);
-
- const newSplitContent = () => ({
- type: 'component' as const,
- id: LIST_VIEW_ID.home,
- });
-
- const duplicateContent = (): SplitContent => ({ ...panel.handle.content() });
-
- const insertSplitBeside = (side: 'left' | 'right', content: SplitContent) => {
- const index = splitIndex();
- if (index < 0) return;
-
- const insertIndex = side === 'left' ? index : index + 1;
-
- layout.manager.createNewSplit({
- content,
- activate: true,
- allowDuplicate: true,
- insertIndex,
- referredFrom: null,
- });
- };
-
- const copyDebugInfo = async () => {
- try {
- const splits = layout.manager.splits();
- await navigator.clipboard.writeText(
- JSON.stringify(
- {
- activeSplitId: layout.manager.activeSplitId(),
- currentSplitId: panel.handle.id,
- currentSplitIndex: splitIndex(),
- currentSplitUrl: router.href(panel.handle.id as string as PaneId),
- splits: splits.map((split, index) => ({
- index,
- id: split.id,
- content: split.content,
- referredFrom: split.referredFrom,
- isCurrent: split.id === panel.handle.id,
- })),
- },
- null,
- 2
- )
- );
- toast.success('Debug info copied to clipboard');
- } catch (error) {
- console.error('Failed to copy split debug info', error);
- toast.failure('Failed to copy debug info');
- }
- };
-
- return (
- <ContextMenu>
- <ContextMenu.Trigger class="contents">
- {props.children}
- </ContextMenu.Trigger>
- <ContextMenu.Portal>
- <ContextMenuContent class="w-60">
- <MenuItem
- icon={SplitIcon}
- iconClass="rotate-180"
- text="New split left"
- disabled={!layout.manager.canAppendSplit()}
- onClick={() => insertSplitBeside('left', newSplitContent())}
- />
- <MenuItem
- icon={SplitIcon}
- text="New split right"
- disabled={!layout.manager.canAppendSplit()}
- onClick={() => insertSplitBeside('right', newSplitContent())}
- />
- <MenuItem
- icon={CopyIcon}
- text="Duplicate split"
- disabled={!layout.manager.canAppendSplit() || !canDuplicateSplit()}
- onClick={() => insertSplitBeside('right', duplicateContent())}
- />
- <MenuSeparator />
- <MenuItem
- icon={ArrowLeft}
- text="Swap split left"
- disabled={!canSwapWith('left')}
- onClick={() => layout.manager.swapSplit(panel.handle.id, 'left')}
- />
- <MenuItem
- icon={ArrowRight}
- text="Swap split right"
- disabled={!canSwapWith('right')}
- onClick={() => layout.manager.swapSplit(panel.handle.id, 'right')}
- />
- <MenuSeparator />
- <MenuItem
- icon={panel.handle.isSpotLight() ? CollapseIcon : ExpandIcon}
- hotkeyToken={TOKENS.window.spotlight.toggle}
- text={
- panel.handle.isSpotLight() ? 'Minimize split' : 'Spotlight split'
- }
- disabled={!canToggleSpotlight()}
- onClick={() => panel.handle.toggleSpotlight()}
- />
- <MenuSeparator />
- <MenuItem
- icon={CloseIcon}
- text="Close other splits"
- disabled={!hasOtherSplits()}
- onClick={() => {
- const currentSplitId = panel.handle.id;
- const otherSplitIds = layout.manager
- .splits()
- .map((split) => split.id)
- .filter((id) => id !== currentSplitId);
-
- for (const splitId of otherSplitIds) {
- layout.manager.removeSplit(splitId);
- }
-
- layout.manager.activateSplit(currentSplitId);
- }}
- />
- <MenuItem
- icon={ArrowClockwise}
- text="Reset sizes"
- disabled={!hasOtherSplits()}
- onClick={() => layout.manager.resizeContext()?.reset()}
- />
- <MenuSeparator />
- <MenuItem
- icon={CopyIcon}
- text="Copy debug info"
- onClick={copyDebugInfo}
- />
- </ContextMenuContent>
- </ContextMenu.Portal>
- </ContextMenu>
- );
-}
-
export function SplitHeader(props: {
ref: Setter<HTMLDivElement | null>;
collapseController: PriorityCollapseController;
diff --git a/apps/web/src/components/app/split-layout/components/SplitHeaderContextMenu.tsx b/apps/web/src/components/app/split-layout/components/SplitHeaderContextMenu.tsx
new file mode 100644
index 0000000000..cf983f4203
--- /dev/null
+++ b/apps/web/src/components/app/split-layout/components/SplitHeaderContextMenu.tsx
@@ -0,0 +1,188 @@
+import { LIST_VIEW_ID } from '@app/constants/list-views';
+import { type PaneId, useSplitRouter } from '@app/lib/split-router';
+import {
+ ContextMenuContent,
+ MenuItem,
+ MenuSeparator,
+} from '@core/component/ContextMenu';
+import { toast } from '@core/component/Toast/Toast';
+import { TOKENS } from '@core/hotkey/tokens';
+import { ContextMenu } from '@kobalte/core/context-menu';
+import ArrowClockwise from '@phosphor/arrow-clockwise.svg';
+import ArrowLeft from '@phosphor/arrow-left.svg';
+import ArrowRight from '@phosphor/arrow-right.svg';
+import CollapseIcon from '@phosphor/arrows-in.svg';
+import ExpandIcon from '@phosphor/arrows-out.svg';
+import SplitIcon from '@phosphor/columns.svg';
+import CopyIcon from '@phosphor/copy.svg';
+import CloseIcon from '@phosphor/x.svg';
+import { createMemo, type ParentProps, useContext } from 'solid-js';
+import { SplitLayoutContext, SplitPanelContext } from '../context';
+import type { SplitContent } from '../layoutManager';
+import { shouldShowSplitCloseButton } from '../layoutUtils';
+import { canSpotlight } from '../utils/canSpotlight';
+
+/** Split actions shared by legacy split chrome and composable view top bars. */
+export function SplitHeaderContextMenu(props: ParentProps) {
+ const panel = useContext(SplitPanelContext);
+ const layout = useContext(SplitLayoutContext);
+ if (!panel || !layout) return props.children;
+
+ const router = useSplitRouter();
+ const splitIndex = createMemo(() =>
+ layout.manager.splits().findIndex((split) => split.id === panel.handle.id)
+ );
+ const hasOtherSplits = createMemo(() => layout.manager.splits().length > 1);
+ const canCloseSplit = createMemo(() =>
+ shouldShowSplitCloseButton(layout.manager)
+ );
+ const canDuplicateSplit = createMemo(
+ () => panel.handle.content().type === 'component'
+ );
+ const canToggleSpotlight = createMemo(() => canSpotlight(layout.manager));
+ const canSwapWith = (direction: 'left' | 'right') =>
+ layout.manager.canSwapSplit(panel.handle.id, direction);
+
+ const newSplitContent = () => ({
+ type: 'component' as const,
+ id: LIST_VIEW_ID.home,
+ });
+
+ const duplicateContent = (): SplitContent => ({ ...panel.handle.content() });
+
+ const insertSplitBeside = (side: 'left' | 'right', content: SplitContent) => {
+ const index = splitIndex();
+ if (index < 0) return;
+
+ const insertIndex = side === 'left' ? index : index + 1;
+
+ layout.manager.createNewSplit({
+ content,
+ activate: true,
+ allowDuplicate: true,
+ insertIndex,
+ referredFrom: null,
+ });
+ };
+
+ const copyDebugInfo = async () => {
+ try {
+ const splits = layout.manager.splits();
+ await navigator.clipboard.writeText(
+ JSON.stringify(
+ {
+ activeSplitId: layout.manager.activeSplitId(),
+ currentSplitId: panel.handle.id,
+ currentSplitIndex: splitIndex(),
+ currentSplitUrl: router.href(panel.handle.id as string as PaneId),
+ splits: splits.map((split, index) => ({
+ index,
+ id: split.id,
+ content: split.content,
+ referredFrom: split.referredFrom,
+ isCurrent: split.id === panel.handle.id,
+ })),
+ },
+ null,
+ 2
+ )
+ );
+ toast.success('Debug info copied to clipboard');
+ } catch (error) {
+ console.error('Failed to copy split debug info', error);
+ toast.failure('Failed to copy debug info');
+ }
+ };
+
+ return (
+ <ContextMenu>
+ <ContextMenu.Trigger class="contents">
+ {props.children}
+ </ContextMenu.Trigger>
+ <ContextMenu.Portal>
+ <ContextMenuContent class="w-60">
+ <MenuItem
+ icon={SplitIcon}
+ iconClass="rotate-180"
+ text="New split left"
+ disabled={!layout.manager.canAppendSplit()}
+ onClick={() => insertSplitBeside('left', newSplitContent())}
+ />
+ <MenuItem
+ icon={SplitIcon}
+ text="New split right"
+ disabled={!layout.manager.canAppendSplit()}
+ onClick={() => insertSplitBeside('right', newSplitContent())}
+ />
+ <MenuItem
+ icon={CopyIcon}
+ text="Duplicate split"
+ disabled={!layout.manager.canAppendSplit() || !canDuplicateSplit()}
+ onClick={() => insertSplitBeside('right', duplicateContent())}
+ />
+ <MenuSeparator />
+ <MenuItem
+ icon={ArrowLeft}
+ text="Swap split left"
+ disabled={!canSwapWith('left')}
+ onClick={() => layout.manager.swapSplit(panel.handle.id, 'left')}
+ />
+ <MenuItem
+ icon={ArrowRight}
+ text="Swap split right"
+ disabled={!canSwapWith('right')}
+ onClick={() => layout.manager.swapSplit(panel.handle.id, 'right')}
+ />
+ <MenuSeparator />
+ <MenuItem
+ icon={panel.handle.isSpotLight() ? CollapseIcon : ExpandIcon}
+ hotkeyToken={TOKENS.window.spotlight.toggle}
+ text={
+ panel.handle.isSpotLight() ? 'Minimize split' : 'Spotlight split'
+ }
+ disabled={!canToggleSpotlight()}
+ onClick={() => panel.handle.toggleSpotlight()}
+ />
+ <MenuItem
+ icon={CloseIcon}
+ hotkeyToken={TOKENS.split.close}
+ text="Close split"
+ disabled={!canCloseSplit()}
+ onClick={() => panel.handle.close()}
+ />
+ <MenuSeparator />
+ <MenuItem
+ icon={CloseIcon}
+ text="Close other splits"
+ disabled={!hasOtherSplits()}
+ onClick={() => {
+ const currentSplitId = panel.handle.id;
+ const otherSplitIds = layout.manager
+ .splits()
+ .map((split) => split.id)
+ .filter((id) => id !== currentSplitId);
+
+ for (const splitId of otherSplitIds) {
+ layout.manager.removeSplit(splitId);
+ }
+
+ layout.manager.activateSplit(currentSplitId);
+ }}
+ />
+ <MenuItem
+ icon={ArrowClockwise}
+ text="Reset sizes"
+ disabled={!hasOtherSplits()}
+ onClick={() => layout.manager.resizeContext()?.reset()}
+ />
+ <MenuSeparator />
+ <MenuItem
+ icon={CopyIcon}
+ text="Copy debug info"
+ onClick={copyDebugInfo}
+ />
+ </ContextMenuContent>
+ </ContextMenu.Portal>
+ </ContextMenu>
+ );
+}
diff --git a/apps/web/src/components/view-shell/ViewShell.tsx b/apps/web/src/components/view-shell/ViewShell.tsx
index 7d088fdc95..7f5b5d4092 100644
--- a/apps/web/src/components/view-shell/ViewShell.tsx
+++ b/apps/web/src/components/view-shell/ViewShell.tsx
@@ -4,6 +4,7 @@ import {
type BreakpointThresholds,
createSizeBreakpoints,
} from '@app/util/create-size-breakpoints';
+import { SplitHeaderContextMenu } from '@components/app/split-layout/components/SplitHeaderContextMenu';
import { SplitPanelContext } from '@components/app/split-layout/context';
import { SplitPanel } from '@components/app/split-panel';
import { Resize } from '@core/component/Resize';
@@ -662,18 +663,20 @@ function Main(props: JSX.HTMLAttributes<HTMLElement>) {
function TopBar(props: JSX.HTMLAttributes<HTMLDivElement>) {
const [local, rest] = splitProps(props, ['children', 'class', 'ref']);
return (
- <div
- {...rest}
- ref={mergeRefs(local.ref, tourTarget(VIEW_SHELL_TOUR.topBar))}
- class={cn(
- '@container/split-header flex h-12 min-w-0 shrink-0 items-center gap-1 px-2 py-3 not-touch:pl-[13px] touch:hidden',
- local.class
- )}
- data-view-shell-top-bar=""
- >
- <ViewNavigationControls />
- {local.children}
- </div>
+ <SplitHeaderContextMenu>
+ <div
+ {...rest}
+ ref={mergeRefs(local.ref, tourTarget(VIEW_SHELL_TOUR.topBar))}
+ class={cn(
+ '@container/split-header flex h-12 min-w-0 shrink-0 items-center gap-1 px-2 py-3 not-touch:pl-[13px] touch:hidden',
+ local.class
+ )}
+ data-view-shell-top-bar=""
+ >
+ <ViewNavigationControls />
+ {local.children}
+ </div>
+ </SplitHeaderContextMenu>
);
}
diff --git a/apps/web/src/components/view-shell/ViewSidebar.tsx b/apps/web/src/components/view-shell/ViewSidebar.tsx
index bab8cae129..5d5a21a1b6 100644
--- a/apps/web/src/components/view-shell/ViewSidebar.tsx
+++ b/apps/web/src/components/view-shell/ViewSidebar.tsx
@@ -1,3 +1,4 @@
+import { SplitHeaderContextMenu } from '@components/app/split-layout/components/SplitHeaderContextMenu';
import CaretDownIcon from '@phosphor/caret-down.svg';
import { Button, type ButtonProps, cn } from '@ui';
import { CollapseTransition } from '@ui/components/CollapseTransition';
@@ -25,17 +26,19 @@ function Root(props: JSX.HTMLAttributes<HTMLElement>) {
function Header(props: JSX.HTMLAttributes<HTMLDivElement>) {
const [local, rest] = splitProps(props, ['children', 'class']);
return (
- <div
- {...rest}
- class={cn(
- 'flex h-12 min-w-0 shrink-0 items-center justify-between gap-3 py-3 pl-(--sidebar-content-inset) pr-(--sidebar-header-action-inset) [&_[data-split-panel-close]]:ml-(--sidebar-control-overhang)',
- local.class
- )}
- data-view-sidebar-header=""
- >
- {local.children}
- <ViewSidebarToggle action="collapse" />
- </div>
+ <SplitHeaderContextMenu>
+ <div
+ {...rest}
+ class={cn(
+ 'flex h-12 min-w-0 shrink-0 items-center justify-between gap-3 py-3 pl-(--sidebar-content-inset) pr-(--sidebar-header-action-inset) [&_[data-split-panel-close]]:ml-(--sidebar-control-overhang)',
+ local.class
+ )}
+ data-view-sidebar-header=""
+ >
+ {local.children}
+ <ViewSidebarToggle action="collapse" />
+ </div>
+ </SplitHeaderContextMenu>
);
}
diff --git a/apps/web/src/features/agents-view/components/AgentsSidebar.tsx b/apps/web/src/features/agents-view/components/AgentsSidebar.tsx
index 65f2199d19..205d0f91e2 100644
--- a/apps/web/src/features/agents-view/components/AgentsSidebar.tsx
+++ b/apps/web/src/features/agents-view/components/AgentsSidebar.tsx
@@ -47,6 +47,7 @@ const MODE_PAGE_FILL = 20;
const AGENTS_ACTION_VIEW_CONTEXT: EntityActionViewContext = {
supportsMarkDone: false,
+ supportsOpenInNewSplit: true,
senderBucket: undefined,
};
diff --git a/apps/web/src/features/channel/Participants/ChannelParticipantsTab.tsx b/apps/web/src/features/channel/Participants/ChannelParticipantsTab.tsx
index bfa22c468e..29c05d6553 100644
--- a/apps/web/src/features/channel/Participants/ChannelParticipantsTab.tsx
+++ b/apps/web/src/features/channel/Participants/ChannelParticipantsTab.tsx
@@ -188,23 +188,26 @@ export function ChannelParticipantsTab(props: {
<ChannelJoinLinkButton channelId={props.channelId} />
</Show>
</Panel.Header>
- <Panel.Toolbar class="h-15.25 px-2">
- <ParticipantsSearchInput
- value={searchQuery()}
- onInput={setSearchQuery}
- />
+ <Panel.Toolbar class="h-auto flex-col items-stretch border-edge-muted p-0">
+ <Show when={isEditable()}>
+ <div class="shrink-0 border-b border-edge-divider px-6 py-3">
+ <ParticipantsAddPanel
+ participants={participants}
+ onAddParticipants={addParticipants}
+ />
+ </div>
+ </Show>
+ <div class="h-15.25 shrink-0">
+ <ParticipantsSearchInput
+ value={searchQuery()}
+ onInput={setSearchQuery}
+ embedded
+ />
+ </div>
</Panel.Toolbar>
<Panel.Body>
<div class="flex h-full flex-col">
{teamSettings()}
- <Show when={isEditable()}>
- <div class="px-6 py-3 border-b border-edge-muted shrink-0">
- <ParticipantsAddPanel
- participants={participants}
- onAddParticipants={addParticipants}
- />
- </div>
- </Show>
<div class="relative min-h-0 flex-1">
<ParticipantsList
participants={filteredParticipants}
diff --git a/apps/web/src/features/channel/Participants/ParticipantsList.tsx b/apps/web/src/features/channel/Participants/ParticipantsList.tsx
index 3e511c64a4..84f21729a2 100644
--- a/apps/web/src/features/channel/Participants/ParticipantsList.tsx
+++ b/apps/web/src/features/channel/Participants/ParticipantsList.tsx
@@ -24,7 +24,7 @@ export function ParticipantsList(props: {
when={props.participants().length > 0}
fallback={<ParticipantsEmptyState searchQuery={props.searchQuery()} />}
>
- <div class="py-1">
+ <div class="px-2 py-1">
<Virtualizer
data={props.participants()}
scrollRef={scrollRoot()}
diff --git a/apps/web/src/features/channel/Participants/ParticipantsListItem.tsx b/apps/web/src/features/channel/Participants/ParticipantsListItem.tsx
index 759a6ddf09..9c8f9d8e74 100644
--- a/apps/web/src/features/channel/Participants/ParticipantsListItem.tsx
+++ b/apps/web/src/features/channel/Participants/ParticipantsListItem.tsx
@@ -71,7 +71,7 @@ export function ParticipantsListItem(props: {
</Item>
</a>
<Show when={props.editable}>
- <div class="absolute right-3 top-1/2 -translate-y-1/2">
+ <div class="absolute right-4 top-1/2 -translate-y-1/2">
<Button
label={
canRemove() ? 'Remove participant' : 'Cannot remove participant'
diff --git a/apps/web/src/features/channel/Participants/ParticipantsSearchInput.tsx b/apps/web/src/features/channel/Participants/ParticipantsSearchInput.tsx
index 1f8556eaa4..709e5f7486 100644
--- a/apps/web/src/features/channel/Participants/ParticipantsSearchInput.tsx
+++ b/apps/web/src/features/channel/Participants/ParticipantsSearchInput.tsx
@@ -4,10 +4,15 @@ import { InputGroup } from '@ui';
export function ParticipantsSearchInput(props: {
value: string;
placeholder?: string;
+ embedded?: boolean;
onInput: (value: string) => void;
}) {
return (
- <InputGroup size="lg" class="rounded-full">
+ <InputGroup
+ size="lg"
+ variant={props.embedded ? 'bare' : 'outline'}
+ class={props.embedded ? 'h-full rounded-none border-0' : 'rounded-full'}
+ >
<InputGroup.Addon>
<MagnifyingGlassIcon />
</InputGroup.Addon>
@@ -18,7 +23,10 @@ export function ParticipantsSearchInput(props: {
placeholder={props.placeholder ?? 'Search participants'}
aria-label={props.placeholder ?? 'Search participants'}
/>
- <InputGroup.Addon align="inline-end">
+ <InputGroup.Addon
+ align="inline-end"
+ class={props.embedded ? 'pe-6!' : undefined}
+ >
<InputGroup.ClearButton />
</InputGroup.Addon>
</InputGroup>
diff --git a/apps/web/src/features/channels-view/components/rail/ChannelRailItems.tsx b/apps/web/src/features/channels-view/components/rail/ChannelRailItems.tsx
index b256b5c64d..6cccf2f088 100644
--- a/apps/web/src/features/channels-view/components/rail/ChannelRailItems.tsx
+++ b/apps/web/src/features/channels-view/components/rail/ChannelRailItems.tsx
@@ -47,6 +47,7 @@ export type ChannelRailItemProps = {
export const CHANNEL_ACTION_VIEW_CONTEXT: EntityActionViewContext = {
supportsMarkDone: false,
+ supportsOpenInNewSplit: false,
senderBucket: undefined,
};
diff --git a/apps/web/src/features/next-soup/actions/entity-action-context.ts b/apps/web/src/features/next-soup/actions/entity-action-context.ts
index 9de691a72a..528b0246fb 100644
--- a/apps/web/src/features/next-soup/actions/entity-action-context.ts
+++ b/apps/web/src/features/next-soup/actions/entity-action-context.ts
@@ -13,6 +13,7 @@ export type EntityActionSenderBucket = 'signal' | 'noise';
export type EntityActionViewContext = {
supportsMarkDone: boolean;
+ supportsOpenInNewSplit: boolean;
senderBucket: EntityActionSenderBucket | undefined;
};
@@ -88,6 +89,7 @@ export function resolveEntityActionViewContext(options: {
activeTab !== undefined &&
isListViewID(activeListView) &&
canExecuteMarkDoneOnView(activeListView, activeTab),
+ supportsOpenInNewSplit: true,
senderBucket: resolveSenderBucket(activeTab),
};
}
diff --git a/apps/web/src/features/reviews-view/components/ReviewsList.tsx b/apps/web/src/features/reviews-view/components/ReviewsList.tsx
index c222b4cbca..4c36c631e4 100644
--- a/apps/web/src/features/reviews-view/components/ReviewsList.tsx
+++ b/apps/web/src/features/reviews-view/components/ReviewsList.tsx
@@ -181,7 +181,11 @@ export function ReviewsList(props: ReviewsListProps) {
selectedEntities: list.selection.items,
focusedEntity: list.focus.item,
restoreFocus: () => listElement()?.focus(),
- viewContext: () => ({ supportsMarkDone: false, senderBucket: undefined }),
+ viewContext: () => ({
+ supportsMarkDone: false,
+ supportsOpenInNewSplit: true,
+ senderBucket: undefined,
+ }),
splitHandle: panel.handle,
condition: panel.isPanelActive,
});
diff --git a/apps/web/src/features/soup/SoupEntityActionsMenu.test.tsx b/apps/web/src/features/soup/SoupEntityActionsMenu.test.tsx
index ee5488dd50..03bff89fd0 100644
--- a/apps/web/src/features/soup/SoupEntityActionsMenu.test.tsx
+++ b/apps/web/src/features/soup/SoupEntityActionsMenu.test.tsx
@@ -39,6 +39,7 @@ const group = (...labels: string[]): TestGroup => ({
const viewContext: EntityActionViewContext = {
supportsMarkDone: false,
+ supportsOpenInNewSplit: true,
senderBucket: undefined,
};
diff --git a/apps/web/src/features/soup/createSoupEntityActions.ts b/apps/web/src/features/soup/createSoupEntityActions.ts
index 613e1cce0c..08ba119194 100644
--- a/apps/web/src/features/soup/createSoupEntityActions.ts
+++ b/apps/web/src/features/soup/createSoupEntityActions.ts
@@ -271,7 +271,7 @@ export function createSoupEntityActions(): {
});
};
- if (openableEntity()) {
+ if (viewContext.supportsOpenInNewSplit && openableEntity()) {
topItems.push({
id: 'open-in-split',
label: 'Open in new split',