Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

Remove half-baked Discussion Thread button and fix agent shimmer behavior (#6088)

Eric Hayesd59848f753c4
diff --git a/apps/web/src/features/block-agent/component/AgentSplitHeader.tsx b/apps/web/src/features/block-agent/component/AgentSplitHeader.tsx
index 5c598465dc..8149d8607f 100644
--- a/apps/web/src/features/block-agent/component/AgentSplitHeader.tsx
+++ b/apps/web/src/features/block-agent/component/AgentSplitHeader.tsx
@@ -3,7 +3,6 @@ import {
ResponsiveBlockToolbar,
ToolButton,
} from '@components/app/ResponsiveBlockToolbar';
-import { useDrawerControl } from '@components/app/split-layout/components/SplitDrawerContext';
import type { FileOperation } from '@components/app/split-layout/components/SplitFileMenu';
import {
SplitHeaderLeft,
@@ -17,16 +16,11 @@ import { buildSimpleEntityUrl, openExternalUrl } from '@core/util/url';
import ArrowSquareOut from '@phosphor/arrow-square-out.svg';
import GitBranch from '@phosphor/git-branch.svg';
import LinkIcon from '@phosphor/link.svg';
-import TreeStructure from '@phosphor/tree-structure.svg';
import { handleAgentSessionRenamed } from '@queries/agent-session/session-metadata-sync';
import { agentHarnessServiceClient } from '@service-agent-harness/client';
import type { AgentSessionResponse } from '@service-agent-harness/generated/schemas';
import { For, Show } from 'solid-js';
import { useAgentSession } from '../context/AgentSessionContext';
-import {
- ORIGIN_THREAD_DRAWER_ID,
- sessionOriginThread,
-} from '../context/origin-thread';
/** 'claude-code' → 'Claude Code'; the fallback when the fold has no title. */
export function harnessTitle(harness: string | undefined): string {
@@ -60,7 +54,6 @@ export function AgentSplitHeader(props: {
return persistedName;
return props.title ?? persistedName ?? harnessTitle(props.session?.harness);
};
- const originThreadDrawer = useDrawerControl(ORIGIN_THREAD_DRAWER_ID);
const rename = async (name: string) => {
const id = sessionId();
@@ -83,13 +76,6 @@ export function AgentSplitHeader(props: {
};
const tools: BlockTool[] = [
- {
- label: 'Discussion Thread',
- icon: TreeStructure,
- action: originThreadDrawer.toggle,
- isActive: originThreadDrawer.isOpen,
- condition: () => sessionOriginThread(props.session) !== undefined,
- },
{
label: () => {
const provider = props.session?.external?.provider;
diff --git a/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.test.ts b/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.test.ts
index 2636ea195f..73dc2cfe33 100644
--- a/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.test.ts
+++ b/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.test.ts
@@ -131,7 +131,7 @@ describe('deriveMagicChipPresentation', () => {
expect(presentation).toEqual({
kind: 'answering',
markdown: 'Looking at t',
- activity: { label: 'Writing response', busy: true },
+ activity: { label: 'Writing response', busy: false },
});
});
diff --git a/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.ts b/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.ts
index d02b492318..a2032ec92f 100644
--- a/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.ts
+++ b/apps/web/src/lib/core/component/LexicalMarkdown/component/decorator/MagicChip/presentation.ts
@@ -84,7 +84,7 @@ function toolActivity(
function partActivity(part: MessagePart): MagicChipActivity {
return match(part)
- .with({ kind: 'text' }, () => ({ label: 'Writing response', busy: true }))
+ .with({ kind: 'text' }, () => ({ label: 'Writing response', busy: false }))
.with({ kind: 'thought' }, ({ text }) => ({
label: 'Thinking',
detail: text.trim() || undefined,