Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
chore(style): add note about suspense (#4956)
teod67a4e3d6075
diff --git a/.coderabbit.yaml b/.coderabbit.yamlindex f051e53005..001943bebd 100644--- a/.coderabbit.yaml+++ b/.coderabbit.yaml@@ -71,6 +71,7 @@ reviews:- Avoid deprecated SolidJS APIs: `blockSignals`, `blockMemos`, `blockResources`, etc.- Primitive UI components should be pure and prefer composition over complex global state/context.- If a Lexical Node is created or modified with breaking changes, the lexical version counter must be incremented (`apps/web/src/lib/core/component/LexicalMarkdown/version.ts`).+ - New or moved query call sites must have a deliberate Suspense boundary — walk up the tree from the call site and check which boundary would catch it (see FE-29 in docs/STYLE_GUIDE.md).- path: "infra/**/*.ts"instructions: |diff --git a/docs/STYLE_GUIDE.md b/docs/STYLE_GUIDE.mdindex 294c6db159..9282740fa1 100644--- a/docs/STYLE_GUIDE.md+++ b/docs/STYLE_GUIDE.md@@ -215,3 +215,10 @@ TypeScript · `[ui]` UI / UX conventionstarget the first tabbable element and preserve focus ownership for restoration.Override `onOpenAutoFocus` only for a proven lifecycle requirement, and verify`document.activeElement` after both opening and reopening in the live app.+- **FE-29** `[data]` Every new query call site (`useQuery`/`useInfiniteQuery` or a hook+ from `src/lib/queries/**`) needs a deliberate `Suspense` boundary: reading+ `query.data` suspends to the *nearest ancestor* boundary. When reviewing, walk up+ the component tree from the call site and determine which boundary would catch it.+ If none exists below the app root, or the nearest one is far outside the component's+ own UI scope (e.g. the route-level boundary in `apps/web/src/routes/Root.tsx`, whose+ fallback blanks unrelated UI), flag it and ask which boundary is intended.