Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(support): don't notify jt (#5115)

teod7e12d7b0588
diff --git a/services/authentication_service/src/service/user/support_channel_welcome.rs b/services/authentication_service/src/service/user/support_channel_welcome.rs
index 435ad7a329..dddcb91e9c 100644
--- a/services/authentication_service/src/service/user/support_channel_welcome.rs
+++ b/services/authentication_service/src/service/user/support_channel_welcome.rs
@@ -72,10 +72,9 @@ Julia",
user_mention(&jacob)?,
user_mention(&teo)?,
);
- let mentions = [&new_user, &jacob, &teo]
- .into_iter()
- .map(SimpleMention::user)
- .collect();
+ // Keep Jacob and Teo visually mentioned in the welcome copy without notifying them. Julia is
+ // the sender, so the channel notification policy excludes her automatically.
+ let mentions = [&new_user].into_iter().map(SimpleMention::user).collect();
gateway
.post_message(
diff --git a/services/authentication_service/src/service/user/support_channel_welcome/test.rs b/services/authentication_service/src/service/user/support_channel_welcome/test.rs
index 1fae2ce210..2f70e17ac2 100644
--- a/services/authentication_service/src/service/user/support_channel_welcome/test.rs
+++ b/services/authentication_service/src/service/user/support_channel_welcome/test.rs
@@ -34,7 +34,7 @@ fn user_id(email: &str) -> MacroUserIdStr<'static> {
}
#[tokio::test]
-async fn posts_welcome_as_julia_with_valid_user_mentions() {
+async fn posts_welcome_as_julia_and_notifies_only_the_new_user() {
let channel_id = Uuid::new_v4();
let gateway = RecordingGateway::default();
@@ -62,11 +62,7 @@ async fn posts_welcome_as_julia_with_valid_user_mentions() {
);
assert_eq!(
posted.request.mentions,
- vec![
- SimpleMention::user(&user_id("[email protected]")),
- SimpleMention::user(&user_id("[email protected]")),
- SimpleMention::user(&user_id("[email protected]")),
- ]
+ vec![SimpleMention::user(&user_id("[email protected]"))]
);
assert_eq!(posted.request.thread_id, None);
assert!(posted.request.attachments.is_empty());