Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(web): keep the PR breadcrumb caret off the title (#7285)
Wolf Mermelsteinf2924414005d
diff --git a/apps/web/src/components/view-shell/ViewBreadcrumbs.test.tsx b/apps/web/src/components/view-shell/ViewBreadcrumbs.test.tsxindex 0a20d7471b..6283b1288d 100644--- a/apps/web/src/components/view-shell/ViewBreadcrumbs.test.tsx+++ b/apps/web/src/components/view-shell/ViewBreadcrumbs.test.tsx@@ -8,6 +8,7 @@ import {import {createContext,createSignal,+ type JSX,onCleanup,Show,useContext,@@ -17,6 +18,11 @@ import { ViewBreadcrumbs } from './ViewBreadcrumbs';vi.mock('@ui', async () => ({...(await import('../ui/utils/classname')),+ Tooltip: (props: { class?: string; children?: JSX.Element }) => (+ <div data-testid="breadcrumb-tooltip" class={props.class}>+ {props.children}+ </div>+ ),}));afterEach(cleanup);@@ -77,3 +83,29 @@ describe('breadcrumb outlet transitions', () => {});});++describe('breadcrumb tooltip sizing', () => {+ it('keeps a return crumb from collapsing over the next item', () => {+ render(() => (+ <ViewBreadcrumbs.Root value="pr:1" onChange={() => {}}>+ <ViewBreadcrumbs.Item value="reviews" order={0} metadata={{}}>+ <ViewBreadcrumbs.ReturnButton tooltip="Involving me">+ Involving me+ </ViewBreadcrumbs.ReturnButton>+ </ViewBreadcrumbs.Item>+ <ViewBreadcrumbs.Item value="pr:1" order={1} metadata={{}}>+ <ViewBreadcrumbs.Button isActive tooltip="feat(agents): MCP">+ feat(agents): MCP+ </ViewBreadcrumbs.Button>+ </ViewBreadcrumbs.Item>+ <ViewBreadcrumbs.Outlet aria-label="Pull request location" />+ </ViewBreadcrumbs.Root>+ ));++ const [returnCrumb, titleCrumb] =+ screen.getAllByTestId('breadcrumb-tooltip');+ expect(returnCrumb?.className).toContain('shrink-0');+ expect(titleCrumb?.className).toContain('shrink');+ expect(titleCrumb?.className).not.toContain('shrink-0');+ });+});diff --git a/apps/web/src/components/view-shell/ViewBreadcrumbs.tsx b/apps/web/src/components/view-shell/ViewBreadcrumbs.tsxindex d3810eefa8..1d6967aa8a 100644--- a/apps/web/src/components/view-shell/ViewBreadcrumbs.tsx+++ b/apps/web/src/components/view-shell/ViewBreadcrumbs.tsx@@ -137,11 +137,19 @@ function BreadcrumbButton(props: ViewBreadcrumbsButtonProps) {return (<Show when={local.tooltip} fallback={button()}>- {(tooltip) => (- <Tooltip class="min-w-0" label={tooltip()}>- {button()}- </Tooltip>- )}+ {(tooltip) => {+ // The trigger is the flex item in the breadcrumb row. Sizing on the+ // button never reaches it, so a shrink-0 return crumb still collapses+ // and its label paints over the separator and the next item.+ return (+ <Tooltip+ class={cn('min-w-0', local.isActive && 'shrink', local.class)}+ label={tooltip()}+ >+ {button()}+ </Tooltip>+ );+ }}</Show>);}