Skip to content

armgit / macro

Public Imported from GitHub
0

Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.

fix(notifications): keep the desktop prompt off the call controls and chat (#8736)

gbirmanfe9656eb749a
diff --git a/.agents/rules/web/mobile.md b/.agents/rules/web/mobile.md
index 56bbfebcb8..59025214f1 100644
--- a/.agents/rules/web/mobile.md
+++ b/.agents/rules/web/mobile.md
@@ -70,7 +70,8 @@ read their code, and follow that pattern rather than inventing a new one.
controls sit right above the dock, as the email composer, email thread and
search results do; on desktop, where the prompt sits in the bottom-right
corner, mark a composer docked at the bottom of its pane (channel and agent
- composers, desktop only) or the view around it (email thread and composer).
+ composers, a call's control bar, desktop only) or the view around it (email
+ thread and composer).
A prompt in the transient region would cover a sheet's controls.
## Keyboard and focus
diff --git a/apps/web/src/features/channel/Call/CallOverlay.tsx b/apps/web/src/features/channel/Call/CallOverlay.tsx
index ebe79d1853..6655e2a575 100644
--- a/apps/web/src/features/channel/Call/CallOverlay.tsx
+++ b/apps/web/src/features/channel/Call/CallOverlay.tsx
@@ -1,6 +1,7 @@
import { useSplitPanel } from '@components/app/split-layout/layoutUtils';
import { UserIcon } from '@core/component/UserIcon';
import { useAuthor, useUserId } from '@core/context/user';
+import { isTouchDevice } from '@core/mobile/isTouchDevice';
import { getDisplayName, tryMacroId } from '@core/user';
import { fireAndForget } from '@core/util/fireAndForget';
import ChatIcon from '@phosphor/chat-circle.svg';
@@ -422,9 +423,12 @@ export function CallOverlay(props: {
</Show>
</Show>
</div>
- {/* Settings expand over the tiles; sharing stays clear of the controls. */}
+ {/* Settings expand over the tiles; sharing stays clear of the controls.
+ On desktop the bar (and the chat composer beside it) is the call's
+ last row, where the corner prompt sits, so the prompt waits. */}
<div
class="relative flex shrink-0 flex-col items-center gap-2 py-3"
+ data-holds-prompts={isTouchDevice() ? undefined : ''}
classList={{
'@min-[800px]/call:mr-90': canChat() && chatOpen(),
}}
diff --git a/docs/agent-guide/settings.md b/docs/agent-guide/settings.md
index 3af0887081..f1aa162c23 100644
--- a/docs/agent-guide/settings.md
+++ b/docs/agent-guide/settings.md
@@ -88,7 +88,9 @@ sheet is open (the calendar event details, for example). It also waits while an
email thread or the email composer is open, and on touch devices while search
results are open, since their last controls sit where the prompt would. On
desktop it waits while a channel, DM or agent conversation shows its composer at
-the bottom of a pane. It comes back when they close.
+the bottom of a pane, and while a call is on screen (its controls, Open chat and
+the chat composer sit in that corner). It comes back once none of them is on
+screen, for example after you leave the call view or end the call.
### Notification snoozes