Skip to content

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.

refactor: refactor MagicCard component for improved mouse event handling (#281)

Mohammad Reza Badri151ef680e338
diff --git a/registry/default/magicui/magic-card.tsx b/registry/default/magicui/magic-card.tsx
index 4177af64..e90ece6f 100644
--- a/registry/default/magicui/magic-card.tsx
+++ b/registry/default/magicui/magic-card.tsx
@@ -1,6 +1,6 @@
"use client";
-import React, { useCallback, useEffect } from "react";
+import React, { useCallback, useEffect, useRef } from "react";
import { motion, useMotionTemplate, useMotionValue } from "framer-motion";
import { cn } from "@/lib/utils";
@@ -18,32 +18,60 @@ export function MagicCard({
gradientColor = "#262626",
gradientOpacity = 0.8,
}: MagicCardProps) {
+ const cardRef = useRef<HTMLDivElement>(null);
const mouseX = useMotionValue(-gradientSize);
const mouseY = useMotionValue(-gradientSize);
const handleMouseMove = useCallback(
- (e: React.MouseEvent<HTMLDivElement>) => {
- const { left, top } = e.currentTarget.getBoundingClientRect();
- mouseX.set(e.clientX - left);
- mouseY.set(e.clientY - top);
+ (e: MouseEvent) => {
+ if (cardRef.current) {
+ const { left, top } = cardRef.current.getBoundingClientRect();
+ const clientX = e.clientX;
+ const clientY = e.clientY;
+ mouseX.set(clientX - left);
+ mouseY.set(clientY - top);
+ }
},
[mouseX, mouseY],
);
- const handleMouseLeave = useCallback(() => {
+ const handleMouseOut = useCallback(
+ (e: MouseEvent) => {
+ if (!e.relatedTarget) {
+ document.removeEventListener("mousemove", handleMouseMove);
+ mouseX.set(-gradientSize);
+ mouseY.set(-gradientSize);
+ }
+ },
+ [handleMouseMove, mouseX, gradientSize, mouseY],
+ );
+
+ const handleMouseEnter = useCallback(() => {
+ document.addEventListener("mousemove", handleMouseMove);
mouseX.set(-gradientSize);
mouseY.set(-gradientSize);
- }, [mouseX, mouseY, gradientSize]);
+ }, [handleMouseMove, mouseX, gradientSize, mouseY]);
+
+ useEffect(() => {
+ document.addEventListener("mousemove", handleMouseMove);
+ document.addEventListener("mouseout", handleMouseOut);
+ document.addEventListener("mouseenter", handleMouseEnter);
+
+ return () => {
+ document.removeEventListener("mousemove", handleMouseMove);
+ document.removeEventListener("mouseout", handleMouseOut);
+ document.removeEventListener("mouseenter", handleMouseEnter);
+ };
+ }, [handleMouseEnter, handleMouseMove, handleMouseOut]);
useEffect(() => {
mouseX.set(-gradientSize);
mouseY.set(-gradientSize);
- }, [mouseX, mouseY, gradientSize]);
+ }, [gradientSize, mouseX, mouseY]);
return (
<div
- onMouseMove={handleMouseMove}
- onMouseLeave={handleMouseLeave}
+ ref={cardRef}
className={cn(
"group relative flex size-full overflow-hidden rounded-xl bg-neutral-100 dark:bg-neutral-900 border text-black dark:text-white",
className,