Skip to content

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.

🐛 fix: shimmer button bug fixes

Dillion Vermabb267687b364
diff --git a/registry/components/magicui/shimmer-button.tsx b/registry/components/magicui/shimmer-button.tsx
index d283b3fc..d225c9e8 100644
--- a/registry/components/magicui/shimmer-button.tsx
+++ b/registry/components/magicui/shimmer-button.tsx
@@ -16,10 +16,10 @@ const ShimmerButton = React.forwardRef<HTMLButtonElement, ShimmerButtonProps>(
(
{
shimmerColor = "#ffffff",
- shimmerSize = "0.1em",
- shimmerDuration = "1.5s",
+ shimmerSize = "0.05em",
+ shimmerDuration = "3s",
borderRadius = "100px",
- background = "rgba(0, 0, 0)",
+ background = "rgba(0, 0, 0, 1)",
className,
children,
...props
@@ -40,6 +40,7 @@ const ShimmerButton = React.forwardRef<HTMLButtonElement, ShimmerButtonProps>(
}
className={cn(
"group relative z-0 flex cursor-pointer items-center justify-center overflow-hidden whitespace-nowrap border border-white/10 px-6 py-3 text-white [background:var(--bg)] [border-radius:var(--radius)] dark:text-black",
+ "transform-gpu transition-transform duration-300 ease-in-out active:translate-y-[1px]",
className,
)}
ref={ref}
@@ -48,21 +49,35 @@ const ShimmerButton = React.forwardRef<HTMLButtonElement, ShimmerButtonProps>(
{/* spark container */}
<div
className={cn(
- "-z-30 blur-sm",
+ "-z-30 blur-[2px]",
"absolute inset-0 overflow-visible [container-type:size]",
)}
>
{/* spark */}
<div className="absolute inset-0 h-[100cqh] animate-slide [aspect-ratio:1] [border-radius:0] [mask:none]">
{/* spark before */}
- <div className="absolute inset-[-100%] w-auto rotate-0 animate-spin [background:conic-gradient(from_calc(270deg-(var(--spread)*0.5)),transparent_0,hsl(0_0%_100%/1)_var(--spread),transparent_var(--spread))] [translate:0_0]" />
+ <div className="absolute inset-[-100%] w-auto rotate-0 animate-spin [background:conic-gradient(from_calc(270deg-(var(--spread)*0.5)),transparent_0,var(--shimmer-color)_var(--spread),transparent_var(--spread))] [translate:0_0]" />
</div>
</div>
-
{children}
{/* Highlight */}
- <div className="absolute bottom-0 left-1/2 h-2/5 w-3/4 -translate-x-1/2 rounded-full bg-white/10 opacity-50 blur-lg transition-all duration-300 ease-in-out group-hover:h-3/5 group-hover:opacity-100" />
+ <div
+ className={cn(
+ "insert-0 absolute h-full w-full",
+
+ "rounded-2xl px-4 py-1.5 text-sm font-medium shadow-[inset_0_-8px_10px_#ffffff1f]",
+
+ // transition
+ "transform-gpu transition-all duration-300 ease-in-out",
+
+ // on hover
+ "group-hover:shadow-[inset_0_-6px_10px_#ffffff3f]",
+
+ // on click
+ "group-active:shadow-[inset_0_-10px_10px_#ffffff3f]",
+ )}
+ />
{/* backdrop */}
<div