Skip to content

Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.

3.8 KB
Raw Blame
package netproxy

import (
	"net/url"
	"strings"
	"testing"

	"github.com/yetone/magpie/internal/settings"
)

// The settings status must not display credentials; requests still need them.
func TestDescribeHidesProxyCredentials(t *testing.T) {
	for _, source := range []string{"settings", "environment", "system"} {
		for _, tc := range []struct{ name, raw, want string }{
			{"plain", "socks5://127.0.0.1:1080", "socks5://127.0.0.1:1080"},
			{"authenticated", "socks5://alice:[email protected]:1080", "socks5://127.0.0.1:1080"},
			{"encoded", "socks5h://ali%40ce:p%3Aa%2Fss%25@[::1]:1080", "socks5h://[::1]:1080"},
			{"username", "http://[email protected]:7890", "http://127.0.0.1:7890"},
		} {
			t.Run(source+"/"+tc.name, func(t *testing.T) {
				t.Setenv("XDG_CONFIG_HOME", t.TempDir())
				for _, k := range []string{"HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy", "ALL_PROXY", "all_proxy", "NO_PROXY", "no_proxy"} {
					t.Setenv(k, "")
				}
				sysCache.at, sysCache.p = farFuture, Proxy{}
				t.Cleanup(func() { sysCache.at = zero })
				switch source {
				case "settings":
					if err := settings.Save(settings.Settings{Proxy: tc.raw}); err != nil {
						t.Fatal(err)
					}
				case "environment":
					t.Setenv("ALL_PROXY", tc.raw)
				case "system":
					sysCache.p.URL = tc.raw
				}
				if got, from := Describe(); got != tc.want || from != source {
					t.Fatalf("description = %q (%s), want %q (%s)", got, from, tc.want, source)
				}
				u, _ := url.Parse("https://vendor.example/request")
				if p, err := For(u); err != nil || p == nil || p.String() != tc.raw {
					t.Fatalf("description changed the proxy used by requests: %v", err)
				}
			})
		}
	}
}

func TestDescribeHidesMalformedSystemProxy(t *testing.T) {
	t.Setenv("XDG_CONFIG_HOME", t.TempDir())
	for _, k := range []string{"HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy", "ALL_PROXY", "all_proxy", "NO_PROXY", "no_proxy"} {
		t.Setenv(k, "")
	}
	sysCache.at, sysCache.p = farFuture, Proxy{URL: "socks5://alice:secret%[email protected]:1080"}
	t.Cleanup(func() { sysCache.at = zero })
	if got, from := Describe(); got != "" || from != "system" {
		t.Fatalf("malformed proxy description = %q (%s)", got, from)
	}
}

// #1886: Redact is what every log line, error, status and GUI text shows
// of a proxy. The user and password are written where a user writes them:
// http and socks5, with and without a scheme, percent-encoded, a user
// without a password. None of it is shown; the rest is kept as written.
func TestRedactLeavesOutUserAndPassword(t *testing.T) {
	for _, tc := range []struct{ raw, want string }{
		{"http://alice:[email protected]:8080", "http://10.0.0.2:8080"},
		{"https://alice:[email protected]:443", "https://proxy.example:443"},
		{"alice:[email protected]:8080", "10.0.0.2:8080"},
		{"socks5://alice:[email protected]:1080", "socks5://127.0.0.1:1080"},
		{"socks5h://alice:[email protected]:1080", "socks5h://127.0.0.1:1080"},
		{"http://ali%40ce:s3%3Acr%2Fet%[email protected]:8080", "http://10.0.0.2:8080"},
		{"socks5://ali%40ce:s3%40cret@[::1]:1080", "socks5://[::1]:1080"},
		{"ali%40ce:s3%40c[email protected]:8080", "10.0.0.2:8080"},
		{"http://[email protected]:8080", "http://10.0.0.2:8080"},
		{"socks5://[email protected]:1080", "socks5://127.0.0.1:1080"},
		{"[email protected]:8080", "10.0.0.2:8080"},
		{"http://alice:@10.0.0.2:8080", "http://10.0.0.2:8080"},
		{"socks5://alice:s3cret%[email protected]:1080", ""},
		{"alice:s3cret%[email protected]:8080", ""},
		{"http://10.0.0.2:8080", "http://10.0.0.2:8080"},
		{"10.0.0.2:8080", "10.0.0.2:8080"},
		{"direct", "direct"},
		{"", ""},
	} {
		got := Redact(tc.raw)
		if got != tc.want {
			t.Errorf("Redact(%q) = %q, want %q", tc.raw, got, tc.want)
		}
		for _, secret := range []string{"ali", "s3"} {
			if strings.Contains(got, secret) {
				t.Errorf("Redact(%q) = %q shows %q", tc.raw, got, secret)
			}
		}
	}
}