Skip to content

Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.

routing: a waiting row's dot keeps its whole glow (#2553, dumplings)

yetone3a213e1dc13c
diff --git a/internal/gui/assets/plugins/routing/routing.css b/internal/gui/assets/plugins/routing/routing.css
index 896202535..687fd5f4c 100644
--- a/internal/gui/assets/plugins/routing/routing.css
+++ b/internal/gui/assets/plugins/routing/routing.css
@@ -239,7 +239,10 @@
.rt-req .asked i.ag { flex: none; width: 8px; height: 8px; border-radius: 50%; background: var(--agent); }
.rt-req .asked .ic, .rt-req .asked .ic img, .rt-req .asked .ic svg { width: 14px; height: 14px; flex: none; }
.rt-req .m, .rt-req .to span { overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
-.rt-req .to { display: flex; align-items: center; gap: 6px; min-width: 0; overflow: hidden; color: var(--fg); }
+/* the waiting dot's 6px glow fits inside the clip: 6px on its left,
+ 1px more above and below, given back outside so nothing moves
+ (#2553, dumplings) */
+.rt-req .to { display: flex; align-items: center; gap: 6px; min-width: 0; overflow: hidden; color: var(--fg); padding: 1px 0 1px 6px; margin: -1px 0 -1px -6px; }
.rt-req .to .said { flex-shrink: 100000; min-width: min(9em, 60%); }
.rt-req .to .said.split { display: flex; }
.rt-req .to .said .who { flex: 0 1000 auto; min-width: 2.5em; }
diff --git a/internal/gui/tests/routing-wait-dot.test.cjs b/internal/gui/tests/routing-wait-dot.test.cjs
new file mode 100644
index 000000000..18d44cf76
--- /dev/null
+++ b/internal/gui/tests/routing-wait-dot.test.cjs
@@ -0,0 +1,92 @@
+// Run with Node's test runner and Playwright on the module path; see README.md.
+// A request still being answered shows a breathing dot whose glow reaches
+// 6px out of it; the row's answer cell clips its overflow, and with the dot
+// at its very edge the glow's left side was cut flat (#2553, dumplings).
+const assert = require("node:assert/strict");
+const fs = require("node:fs/promises");
+const path = require("node:path");
+const { test } = require("node:test");
+const { chromium, webkit } = require("playwright");
+
+const assets = path.resolve(__dirname, "../assets");
+const now = new Date();
+const day = [now.getFullYear(), now.getMonth() + 1, now.getDate()].map((n) => String(n).padStart(2, "0")).join("-");
+const at = (i) => new Date(now.getTime() - (i + 1) * 60e3).toISOString();
+const seat = { id: "codex", provider: "openai", name: "OpenAI", who: "Codex's own sign-in", kind: "account", agent: "pi", model: "gpt-6.1-sol" };
+const cases = [{ asked: "", sent: "" }, { asked: "", sent: "" }];
+const routes = cases.map((c, i) => ({
+ id: 100 - i, seq: 100 - i, time: at(i), agent: "pi", model: "codex/gpt-6.1-sol", provider: "openai", ...(c.asked ? { effort: c.asked } : {}),
+ order: [seat], tries: [{ id: seat.id, model: "gpt-6.1-sol", start: at(i), done: true, status: 200, ms: 900, ...(c.sent ? { effort: c.sent } : {}) }],
+ done: true, status: 200, ms: 900, tokens: 1200,
+}));
+
+function serve(lang) {
+ const state = { agents: [{ id: "pi", name: "Pi", path: "/test/config.toml", fields: [] }], profiles: [], settings: { lang, theme: "light" } };
+ return async (route) => {
+ const url = new URL(route.request().url());
+ const json = (data) => route.fulfill({ json: data });
+ if (url.pathname === "/boot.js") return route.fulfill({ contentType: "text/javascript", body: `window.bootPrefs = {lang:"${lang}",theme:"light",web:true};` });
+ if (url.pathname === "/wails/runtime.js") return route.fulfill({ contentType: "text/javascript", body: "export const Window = {};" });
+ if (url.pathname === "/api/state") return json(state);
+ if (url.pathname === "/api/gateway/trace") {
+ if (url.searchParams.get("wait")) await new Promise((r) => setTimeout(r, 20e3));
+ return json({ mine: true, now: now.toISOString(), seq: 1, totals: { requests: 0, rerouted: 0, errors: 0 }, routes: [] });
+ }
+ if (url.pathname === "/api/gateway/history") {
+ const d = url.searchParams.get("day");
+ return json({ cut: false, days: [{ day, requests: routes.length }], routes: d ? routes : [] });
+ }
+ if (url.pathname === "/api/groups") return json({ groups: [] });
+ if (url.pathname === "/api/providers") return json({ providers: [], gateway: { running: true, window: true } });
+ if (url.pathname.startsWith("/api/")) return json({});
+ const file = path.join(assets, url.pathname === "/" ? "index.html" : url.pathname);
+ const contentType = { ".html": "text/html", ".js": "text/javascript", ".css": "text/css", ".svg": "image/svg+xml", ".png": "image/png" }[path.extname(file)];
+ await route.fulfill({ body: await fs.readFile(file), contentType });
+ };
+}
+
+for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium", "webkit"])) {
+ for (const lang of ["en", "zh"]) {
+ for (const width of [1100, 420]) {
+ test(`${engine} ${lang} ${width}px: a waiting row's dot keeps its whole glow`, async (t) => {
+ const browser = await (engine === "webkit" ? webkit.launch() : chromium.launch({ channel: "chromium" }));
+ const context = await browser.newContext({ viewport: { width, height: 760 }, reducedMotion: "reduce" });
+ const page = await context.newPage();
+ page.setDefaultTimeout(5000);
+ const errors = [];
+ page.on("pageerror", (e) => errors.push(e.message));
+ await page.route("**/*", serve(lang));
+ t.after(async () => {
+ if (process.env.ARTIFACT_DIR) {
+ await fs.mkdir(process.env.ARTIFACT_DIR, { recursive: true });
+ await page.screenshot({ path: path.join(process.env.ARTIFACT_DIR, `${engine}-${lang}-${width}-wait-dot.png`), fullPage: true });
+ }
+ await browser.close();
+ });
+ await page.goto("http://magpie.test/?view=routing");
+ await page.locator(".rt-days .rt-day").nth(1).click();
+ await page.locator(".rt-req").nth(cases.length - 1).waitFor();
+
+ const r = await page.locator(".rt-req").first().evaluate((row) => {
+ const to = row.querySelector(".to"), dot = to.querySelector("i");
+ const before = { dot: dot.getBoundingClientRect(), row: row.getBoundingClientRect() };
+ row.classList.add("wait");
+ // the glow reaches 6px out of the dot (rtlive); overflow clips at
+ // .to's padding box
+ const b = to.getBoundingClientRect(), s = getComputedStyle(to), d = dot.getBoundingClientRect();
+ const clip = { left: b.left + parseFloat(s.borderLeftWidth), top: b.top + parseFloat(s.borderTopWidth), bottom: b.bottom - parseFloat(s.borderBottomWidth) };
+ return {
+ left: d.left - clip.left, top: d.top - clip.top, bottom: clip.bottom - d.bottom,
+ moved: Math.abs(d.left - before.dot.left) + Math.abs(d.top - before.dot.top),
+ dotFromRow: before.dot.left - before.row.left,
+ };
+ });
+ assert.ok(r.left >= 6, `left room ${r.left}`);
+ assert.ok(r.top >= 6, `top room ${r.top}`);
+ assert.ok(r.bottom >= 6, `bottom room ${r.bottom}`);
+ assert.ok(r.moved < 0.5, `the dot moved ${r.moved}px when the row started waiting`);
+ assert.deepEqual(errors, []);
+ });
+ }
+ }
+}