Skip to content

Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.

routing: the hidden tray panel no longer draws its Routing tab for every request (#2515)

yetone67f8dbb16c0d
diff --git a/internal/gui/assets/plugins/routing/client.js b/internal/gui/assets/plugins/routing/client.js
index e213da321..af0e65643 100644
--- a/internal/gui/assets/plugins/routing/client.js
+++ b/internal/gui/assets/plugins/routing/client.js
@@ -5618,6 +5618,8 @@ function routingPage(part) {
const P_ROWS = 6;
let today = null, todayAt = 0;
const pShown = () => pBox && document.body.dataset.ptab === "routing";
+ let pStale = false; // a draw skipped while the panel was hidden
+ if (pBox) document.addEventListener("visibilitychange", () => { if (pStale && !document.hidden) renderPanel(); });
async function loadToday() {
todayAt = performance.now();
try { today = await api("usage?period=today"); } catch { return; }
@@ -5672,6 +5674,7 @@ function routingPage(part) {
}
function pDraw() {
if (!pBox || !pStage.isConnected) return;
+ if (document.hidden) { pStale = true; return; }
const recent = [...routes.values()].sort((a, b) => b.id - a.id);
const flying = recent.filter((r) => pPlays.has(r.id));
const ags = [], dst = new Map(); // seat key → { name, sub, how }
@@ -5785,7 +5788,7 @@ function routingPage(part) {
}
const pRest = (ms) => new Promise((res) => setTimeout(res, pShown() && !still() ? ms : 0));
async function pPlay(id) {
- if (!pBox || !pShown() || still() || pPlays.has(id) || pPlays.size >= 4) return;
+ if (!pBox || !pShown() || document.hidden || still() || pPlays.has(id) || pPlays.size >= 4) return;
let r = routes.get(id);
if (!r) return;
pPlays.add(id);
@@ -5843,10 +5846,26 @@ function routingPage(part) {
}
}
// renderPanel draws the tab; counted is a request just done, for today's
- // totals to be read again (now and then)
+ // totals to be read again (now and then).
+ // While the panel is hidden, which is most of the time, it is drawn
+ // again only when its shape changes (what the panel's height is fitted
+ // to, every tab measured), and in full once it shows (#2515). A hidden
+ // page draws no frames, so the infinite CSS animations on what a draw
+ // replaces (the live dot, a waiting row's arrow, a waiting provider's
+ // mark) stay on the document's timeline, each holding its old tab, rows
+ // and all. On Windows, where a hidden WebView2 says so, the panel grew
+ // ~20 MB a minute under 1 request a second, 265k nodes in 11 minutes,
+ // and GBs over a day.
+ let pShape = "";
function renderPanel(counted) {
if (!pBox) return;
if (counted && (!todayAt || performance.now() - todayAt > 5e3)) loadToday();
+ const picks = panelPicks();
+ const rs = [...routes.values()].sort((a, b) => b.id - a.id).slice(0, P_ROWS);
+ const shape = [offMsg, loaded, rs.length, picks?.childElementCount || 0, !!today].join("|");
+ if (document.hidden && shape === pShape) { pStale = true; return; }
+ pStale = false;
+ pShape = shape;
const v = $("#view-agents"), keep = v.scrollTop;
const head = el("div", "pr-head");
const sum = el("span", "pr-today");
@@ -5860,9 +5879,7 @@ function routingPage(part) {
open.onclick = (e) => { api("window/main?view=routing", {}); e.currentTarget.blur(); };
head.append(el("span", "rt-livedot"), sum, el("span", "grow"), open);
const out = [head];
- const picks = panelPicks();
if (picks) out.push(picks);
- const rs = [...routes.values()].sort((a, b) => b.id - a.id).slice(0, P_ROWS);
if (!offMsg && loaded && rs.length) out.push(pStage);
if (offMsg) out.push(el("p", "pr-none", t(offMsg)));
else if (!loaded) for (let i = 0; i < 3; i++) out.push(el("span", "skeleton pr-sk-row"));
diff --git a/internal/gui/tests/panel-routing-hidden.test.cjs b/internal/gui/tests/panel-routing-hidden.test.cjs
new file mode 100644
index 000000000..c5b3b6e72
--- /dev/null
+++ b/internal/gui/tests/panel-routing-hidden.test.cjs
@@ -0,0 +1,118 @@
+// Run with Node's test runner and Playwright on the module path; see README.md.
+// The tray panel is hidden most of the time, and its Routing tab is not
+// drawn again for every request while it is (#2515): a hidden page draws no
+// frames, so the infinite animations on each replaced tab (the live dot, a
+// waiting row's arrow) stayed on the document's timeline and held every old
+// tab. On Windows the hidden panel grew to 265k nodes in 11 minutes and GBs
+// over a day. Hidden, the tab is drawn again only when its shape (what the
+// panel's height is fitted to) changes, no request's dot flies, and once
+// the panel shows it is drawn in full, newest request first. The page's
+// hidden state is faked here, as headless pages are never hidden.
+const assert = require("node:assert/strict");
+const fs = require("node:fs/promises");
+const path = require("node:path");
+const { test } = require("node:test");
+const { chromium, webkit } = require("playwright");
+
+const assets = path.resolve(__dirname, "../assets");
+const relay = { id: "relay:team", provider: "relay", name: "Relay", kind: "key", who: "team", model: "gpt-6-sol" };
+const route = (id, done) => ({
+ id, seq: id, time: new Date().toISOString(), agent: "codex", model: `relay/m-${id}`, provider: "relay", order: [relay],
+ tries: [{ id: relay.id, model: "gpt-6-sol", start: new Date().toISOString(), done, status: done ? 200 : 0, ms: done ? 900 : 0 }],
+ done, status: done ? 200 : 0, ms: done ? 900 : 0,
+});
+
+function serve(lang) {
+ const state = { agents: [{ id: "codex", name: "Codex", path: "/test/config.toml", fields: [] }], profiles: [], settings: { lang, theme: "light" } };
+ return async (r) => {
+ const req = r.request(), url = new URL(req.url());
+ const json = (data) => r.fulfill({ json: data });
+ if (url.pathname === "/boot.js") return r.fulfill({ contentType: "text/javascript", body: `window.bootPrefs = {lang:"${lang}",theme:"light",web:true};` });
+ if (url.pathname === "/wails/runtime.js") return r.fulfill({ contentType: "text/javascript", body: "export const Window = {};" });
+ if (url.pathname === "/api/state") return json(state);
+ if (url.pathname === "/api/gateway/trace") {
+ // a request every 80 ms, under way: each is a tab drawn again
+ const after = Number(url.searchParams.get("after"));
+ const now = new Date().toISOString();
+ if (!after) return json({ mine: true, now, seq: 2, totals: { requests: 2 }, routes: [route(1, true), route(2, true)] });
+ await new Promise((res) => setTimeout(res, 80));
+ return json({ mine: true, now, seq: after + 1, totals: { requests: after + 1 }, routes: [route(after + 1, false)] });
+ }
+ if (url.pathname === "/api/gateway/history") return json({ cut: false, days: [], routes: [] });
+ if (url.pathname === "/api/usage" && url.searchParams.get("period") === "today") return json({ calls: 2, input: 1000, output: 200, series: [] });
+ if (url.pathname === "/api/usage/quotas") return json([]);
+ if (url.pathname === "/api/groups") return json({ groups: [] });
+ if (url.pathname === "/api/providers") return json({ providers: [], gateway: { running: true, window: true } });
+ if (url.pathname.startsWith("/api/window/")) return r.fulfill({ status: 204 });
+ if (url.pathname.startsWith("/api/")) return json({});
+ const file = path.join(assets, url.pathname === "/" ? "index.html" : url.pathname);
+ const contentType = { ".html": "text/html", ".js": "text/javascript", ".css": "text/css", ".svg": "image/svg+xml", ".png": "image/png" }[path.extname(file)];
+ await r.fulfill({ body: await fs.readFile(file), contentType });
+ };
+}
+
+for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium", "webkit"])) {
+ for (const lang of ["en", "zh"]) {
+ test(`${engine} ${lang}: the hidden tray panel doesn't draw its Routing tab again for every request`, async (t) => {
+ const browser = await (engine === "webkit" ? webkit.launch() : chromium.launch({ channel: "chromium" }));
+ t.after(() => browser.close());
+ const ctx = await browser.newContext({ viewport: { width: 360, height: 560 }, reducedMotion: "no-preference" });
+ await ctx.addInitScript(() => {
+ try { localStorage.setItem("magpie.panelTab", "routing"); } catch {}
+ // the panel's window put away, as WebView2 tells a hidden page
+ window.__hid = false;
+ Object.defineProperty(Document.prototype, "hidden", { configurable: true, get: () => window.__hid });
+ Object.defineProperty(Document.prototype, "visibilityState", { configurable: true, get: () => (window.__hid ? "hidden" : "visible") });
+ window.__hide = (h) => { window.__hid = h; document.dispatchEvent(new Event("visibilitychange")); };
+ });
+ const page = await ctx.newPage();
+ const errors = [];
+ page.on("pageerror", (e) => errors.push(e.message));
+ page.setDefaultTimeout(5000);
+ await page.route("**/*", serve(lang));
+ await page.goto("http://magpie.test/?mode=panel");
+ await page.locator("#panelRouting .pr-req").first().waitFor();
+ assert(await page.locator("#panelRouting").isVisible());
+ // shown, the tab keeps up: its newest request is the one heard last
+ await page.waitForFunction(() => document.querySelectorAll("#panelRouting .pr-req").length === 6);
+
+ // hidden: requests keep coming, the tab is (nearly) never drawn again
+ const seqAt = await page.evaluate(() => {
+ window.__hide(true);
+ window.__draws = 0;
+ window.__dots = 0;
+ // each draw puts up a new head
+ new MutationObserver((ms) => {
+ for (const m of ms) for (const n of m.addedNodes) {
+ if (n.classList?.contains("pr-head")) window.__draws++;
+ if (n.classList?.contains("ps-dot")) window.__dots++;
+ }
+ }).observe(document.querySelector("#panelRouting"), { childList: true, subtree: true });
+ return Number(document.querySelector("#panelRouting .pr-req .pr-a .m").textContent.replace(/\D+/g, ""));
+ });
+ let heard = 0;
+ page.on("request", (q) => { if (q.url().includes("/api/gateway/trace")) heard++; });
+ for (let i = 0; i < 40 && heard < 20; i++) await page.waitForTimeout(100);
+ assert(heard >= 20, `the trace was read ${heard} times while hidden`);
+ const hidden = await page.evaluate(() => ({ draws: window.__draws, dots: window.__dots, shown: Number(document.querySelector("#panelRouting .pr-req .pr-a .m").textContent.replace(/\D+/g, "")) }));
+ assert.equal(hidden.draws, 0, `the hidden tab was drawn ${hidden.draws} times over ${heard} requests`);
+ assert.equal(hidden.dots, 0, "no request's dot flies in a hidden panel");
+ assert.equal(hidden.shown, seqAt, "what the tab shows is left as it was");
+
+ // shown again: drawn at once, the newest request first
+ const after = await page.evaluate(async () => {
+ window.__hide(false);
+ await Promise.resolve(); // the observer's records
+ return {
+ draws: window.__draws,
+ first: Number(document.querySelector("#panelRouting .pr-req .pr-a .m").textContent.replace(/\D+/g, "")),
+ rows: document.querySelectorAll("#panelRouting .pr-req").length,
+ };
+ });
+ assert.equal(after.draws, 1, "drawn once as the panel shows");
+ assert(after.first >= seqAt + 20, `the newest request is shown (${after.first}, was ${seqAt})`);
+ assert.equal(after.rows, 6);
+ assert.deepEqual(errors, []);
+ });
+ }
+}