Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.
agents: a model list's button says its ticks: all, one or two by name, or how many of how many (NG_shiyu on X)
yetone6915c8cdea50
diff --git a/docs/subsystems/gui-shell.md b/docs/subsystems/gui-shell.mdindex a1fac5050..dc44289af 100644--- a/docs/subsystems/gui-shell.md+++ b/docs/subsystems/gui-shell.md@@ -434,6 +434,7 @@ covers it in both engines, every language and a narrow window.- Hide accounts (`window.hideAccounts` at the end of [`app.js`](../../internal/gui/assets/app.js), stored in `magpie.maskEmails`, which the panel follows) masks every account name and address in the page's text and tooltips. While it is on, an account's name on the provider editor's row (`accountNameButton`, and the one-account line) and on its Usage card (`quotaWho`), and on the tray panel's Usage card (`panelQuotaCard`'s `.pq-who`, in sight while the card is hovered), has an eye (`hideAccounts.eye`), in sight on hover or keyboard focus. A click shows that one account, its address and the name the user gave it together (`kin`), everywhere that page draws it, tooltips included, while the others stay hidden (yogurt36 on Discord, for a screen share). The accounts shown are a set held in memory that `hits()` skips; nothing stores them. The window and the panel are pages of their own, each with its own set: one shown in the window stays hidden in the panel and the other way round, so a screenshot of either shows only what was shown there. Closing the window hides them again: the page stays loaded while the window is hidden, so `hideMain` runs `mainClosedJS` (`hideAccounts.closed`) first. Putting the panel away hides the panel's again, from its `visibilitychange` (the one that drops `panelPeek`) (`account-eye.test.cjs`, `TestClosingHidesShownAccounts`).- A new user's Agents page (the window's first page and the panel's Agents tab) has a *Get started* card above the agents in the welcome's place (wangye1644294 on X, `guideCard` in [`app.js`](../../internal/gui/assets/app.js)). Its three steps are: add a model source; connect an agent, where the agents magpie found that can be connected are named and each is connected in one click (`agents/connect`); and, optional, a routing group, with the most harmless starter template that can be made from the user's models (`provider.Templates`, Never stuck first) added in one click through `POST /api/groups/template`. Every tick comes from the state: the models magpie serves (`served` in `/api/state`, groups left out), an agent wired, or a group that isn't automatic. None comes from the card having been seen. The card goes once the first two steps are done. Its close button saves `settings.GuideHidden` through `POST /api/settings/guide`, so the panel, the window and a reload agree, and the Settings save keeps it. See `getting-started.test.cjs`.- A connected agent's row in the window opens and closes on a click anywhere on it that isn't one of its controls, as a disclosure row does on the Mac (NG_shiyu on X, `connectRow` in [`app.js`](../../internal/gui/assets/app.js)): the click is handed to the row's *Models {n}* link (`expandLink`), which stays the control the keyboard and a screen reader use and keeps `aria-expanded`. Buttons, links, inputs, anything with a role, the grip and the opened sheet (`.ag-exp`) keep their own clicks, and a click that ends a text selection does nothing. The panel's rows did this already (`agent-row-disclose.test.cjs`).+- An agent whose own model menu is the list picked in magpie (ZCode, Claude Desktop, Cursor Private Inference, …: `listsMenu`) says that list as its ticks are, on its button and on the panel row (`menuSaid` in [`app.js`](../../internal/gui/assets/app.js)): every model ticked is *All N models*, one or two by their names, more as *Showing x / N models*, none as *No models*. It never says the first names and a +N: routing groups come first, so that read as a pick of one group and one model while every model was on (NG_shiyu on X). Other agents' start pickers still say the one model or group they start on (`agent-menu-label.test.cjs`).- Every page of the window keeps to one width, at most 1200px of content centred, with a 16px gutter in a narrow window (`padding: max(16px, calc(50% - 600px))` on each `#view-…`, #860). Routing, Usage and Sessions are in that rule too (面条 on Discord), so a large screen doesn't stretch them edge to edge while the others sit in the middle; their columns follow the room they get (`byWidth`). See `page-width.test.cjs`.- The page must work in Chromium (Windows' WebView2) and WebKit (macOS, and WebKitGTK on Linux). GUI tests run in both engines.- In the design of macOS 26 the main window has the corners of a window with a plain title bar, and its lights stay where the toolbar had them. `TestMainWindowCorners` ([`titlebar_darwin_test.go`](../../internal/gui/titlebar_darwin_test.go)) measures this in a process of its own, with package `windowshape`: after a new title and size and a new system appearance, as AppKit draws that appearance, where a first press with another app in front begins a window drag, and where a sheet begins. It runs that process as linked against the macOS 26 SDK and against macOS 15's, whatever SDK the toolchain has (`runAppKitSDK` and `stampSDK` give the copy it runs that SDK, and sign it again). In the earlier design, on an older macOS or with macOS 15's SDK, it checks that the window keeps its toolbar; `TestMainWindowRightToLeft` checks that it keeps it with the lights on the right. Both run in CI's macOS job. No test covers `UIDesignRequiresCompatibility`: AppKit reads it from an app bundle's Info.plist, LaunchServices registers each bundle that runs, and a press sent within a process run from one doesn't always begin a window drag.diff --git a/internal/gui/assets/app.js b/internal/gui/assets/app.jsindex 497cfa9fb..74b582ffc 100644--- a/internal/gui/assets/app.js+++ b/internal/gui/assets/app.js@@ -1223,12 +1223,18 @@ const MENU_FROM_LIST = new Set(["claude-desktop", "cursor-local"]);const listsMenu = (a) => MENU_FROM_LIST.has(a.id) || !!a.menu;const menuFromList = (a) => listsMenu(a) && a.wired && !!a.models;-// menuSaid: the models such an agent lists, by name while they are few+// menuSaid: the models such an agent lists, as its list's ticks are. Every+// one ticked is said as all of them, a few picked by their names, and more+// as how many of how many. Its first two names and +N (routing groups come+// first) read as a pick of a group and a model while every model was on+// (NG_shiyu on X: 「路由组,模型+数字」 here, one 「路由」 on the row above,+// and every model in the list opened)function menuSaid(c) {if (!c.shown) return t("No models");+ if (c.shown >= c.listed) return t("All {n} models", { n: c.listed });const names = c.names || [];- if (!names.length) return t("{n} models", { n: c.shown });- return names.slice(0, 2).join(", ") + (c.shown > 2 ? " +" + (c.shown - 2) : "");+ if (c.shown <= 2 && names.length >= c.shown) return names.slice(0, c.shown).join(", ");+ return t("Showing {shown} / {listed} models", { shown: c.shown, listed: c.listed });}// menuButton: where the model picker stands in another agent's row, thediff --git a/internal/gui/tests/agent-menu-label.test.cjs b/internal/gui/tests/agent-menu-label.test.cjsnew file mode 100644index 000000000..c94e25d43--- /dev/null+++ b/internal/gui/tests/agent-menu-label.test.cjs@@ -0,0 +1,140 @@+// Run with Node's test runner and Playwright on the module path; see README.md.+// An agent whose own model menu is the list picked here (ZCode, Claude+// Desktop, Cursor Private Inference…) says on its closed button what that+// list holds, as the list opened ticks it: every model on is "All n+// models", one or two picked are named, more are counted "Showing x / n+// models", none is "No models". It named the first two models and +N+// (routing groups come first), which read as a pick of one group and one+// model while every model was ticked (NG_shiyu on X: 「路由组,模型+数字」+// on one row, one 「路由」 on the row above it, and every model in the+// list). The window's button and the tray panel's row words alike, in+// every language, in Chromium and WebKit. No backend: faked here.+const assert = require("node:assert/strict");+const fs = require("node:fs/promises");+const path = require("node:path");+const { test } = require("node:test");+const { chromium, webkit } = require("playwright");++const assets = path.resolve(__dirname, "../assets");++function fixture(lang) {+ const list = [+ { id: "group/steady", name: "Never stuck", group: "Routing groups", icons: ["deepseek"] },+ { id: "deepseek/pro", name: "DeepSeek Pro", group: "DeepSeek", icon: "deepseek" },+ { id: "deepseek/flash", name: "DeepSeek Flash", group: "DeepSeek", icon: "deepseek" },+ { id: "kimi/k3", name: "Kimi K3", group: "Kimi", icon: "generic" },+ ];+ const count = () => {+ const on = list.filter((m) => !m.hidden);+ const by = [];+ for (const m of on) {+ let g = by.find((x) => x.name === m.group);+ if (!g) by.push(g = { name: m.group, icon: m.icon, n: 0 });+ g.n++;+ }+ return { shown: on.length, listed: list.length, by, names: on.slice(0, 3).map((m) => m.name) };+ };+ const state = () => ({+ agents: [{+ id: "zcode", name: "ZCode", path: "~/.zcode/v2/config.json", icon: "zcode", wired: true, menu: true,+ fields: [{ key: "provider", label: "provider", value: "magpie", options: [{ value: "magpie", label: "magpie", icon: "magpie", note: "every magpie model in ZCode's picker" }] }],+ models: count(),+ }],+ profiles: [], settings: { lang, theme: "light" },+ });+ async function serve(route) {+ const req = route.request(), url = new URL(req.url());+ const json = (data) => route.fulfill({ json: data });+ if (url.pathname === "/boot.js") return route.fulfill({ contentType: "text/javascript", body: `window.bootPrefs = {lang:"${lang}",theme:"light",web:true};` });+ if (url.pathname === "/wails/runtime.js") return route.fulfill({ contentType: "text/javascript", body: "export const Window = {};" });+ if (url.pathname === "/api/state") return json(state());+ if (url.pathname === "/api/agent-models/zcode") {+ if (req.method() === "POST") {+ const { hidden } = req.postDataJSON();+ for (const m of list) m.hidden = hidden.includes(m.id);+ return json({ models: list, count: count() });+ }+ return json({ models: list });+ }+ if (url.pathname === "/api/usage/quotas") return json([]);+ if (url.pathname === "/api/groups") return json({ groups: [] });+ if (url.pathname === "/api/agents/cli") return json({ agents: {}, pending: false });+ if (url.pathname === "/api/providers") return json({ providers: [], gateway: { running: true } });+ if (url.pathname === "/api/plugins") return json({ plugins: [] });+ if (url.pathname.startsWith("/api/")) return json({});+ const file = path.join(assets, url.pathname === "/" ? "index.html" : url.pathname);+ const contentType = { ".html": "text/html", ".js": "text/javascript", ".css": "text/css", ".svg": "image/svg+xml", ".png": "image/png" }[path.extname(file)];+ const body = await fs.readFile(file).catch(() => null);+ await route.fulfill(body ? { body, contentType } : { status: 404, body: "" });+ }+ return { serve };+}++const row = '.row.agent[data-id="zcode"]';++for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium", "webkit"])) {+ for (const lang of ["en", "zh", "zh-TW", "ja", "de"]) {+ for (const where of ["window", "panel"]) {+ test(`${engine} ${lang} ${where}: the closed models button says what its list ticks`, async (t) => {+ const browser = await (engine === "webkit" ? webkit.launch() : chromium.launch({ channel: "chromium" }));+ t.after(() => browser.close());+ const page = await browser.newPage({ viewport: where === "panel" ? { width: 360, height: 640 } : { width: 1100, height: 700 } });+ page.setDefaultTimeout(5000);+ const errors = [];+ page.on("pageerror", (e) => errors.push(e.message));+ await page.route("**/*", fixture(lang).serve);+ await page.goto("http://magpie.test/" + (where === "panel" ? "?mode=panel" : ""));+ await page.locator(row).waitFor();+ const tr = (s, v) => page.evaluate(([s, v]) => t(s, v), [s, v]);+ // the button, and in the panel the row's words beside it+ const said = async () => {+ const b = await page.locator(".ag-menu .v").textContent();+ if (where === "panel") assert.equal(await page.locator(`${row} .ag-sum .vt`).textContent(), b, "the row's words and its button differ");+ return b;+ };+ const settle = (want) => page.waitForFunction((w) => document.querySelector(".ag-menu .v")?.textContent === w, want).catch(async () => assert.equal(await said(), want));++ let menu;+ if (where === "window") menu = page.locator(`${row} > .ag-menu`);+ else {+ await page.locator(`${row} .ag-sum`).click();+ menu = page.locator(`${row} .ag-open .ag-menu`);+ await page.waitForFunction((sel) => document.querySelector(sel)?.getBoundingClientRect().height > 0, `${row} .ag-open .ag-menu`);+ }+ // every model ticked, the group first: all of them, not the group+ // and a model +2+ const all = await tr("All {n} models", { n: 4 });+ assert.equal(await said(), all);+ assert.ok(!(await said()).includes("Never stuck"), "named the routing group as if picked");++ await menu.click();+ const box = page.locator(".am-pop:not(.leaving)");+ await box.waitFor();+ const ticked = () => box.locator(".am-mr").evaluateAll((es) => es.filter((e) => e.getAttribute("aria-checked") === "true").length);+ assert.equal(await ticked(), 4);+ const flip = (name) => box.locator(".am-mr", { hasText: name }).click();++ // three of four: counted as the list counts them+ await flip("Kimi K3");+ await settle(await tr("Showing {shown} / {listed} models", { shown: 3, listed: 4 }));+ assert.equal(await ticked(), 3);+ // two: named, both of them and nothing more+ await flip("Never stuck");+ await settle("DeepSeek Pro, DeepSeek Flash");+ // one+ await flip("DeepSeek Flash");+ await settle("DeepSeek Pro");+ // none+ await flip("DeepSeek Pro");+ await settle(await tr("No models"));+ // all back+ for (const n of ["DeepSeek Pro", "DeepSeek Flash", "Never stuck", "Kimi K3"]) await flip(n);+ await settle(all);+ assert.ok(!/\+\d/.test(await said()), "a +N left on the button");+ assert.equal(await page.locator("select").count(), 0, "a native select");+ assert.ok(await page.evaluate(() => document.documentElement.scrollWidth <= innerWidth), "the row runs past the window");+ assert.deepEqual(errors, []);+ });+ }+ }+}diff --git a/internal/gui/tests/cursor-local-models.test.cjs b/internal/gui/tests/cursor-local-models.test.cjsindex b16b0e0fa..7a9e4d9d4 100644--- a/internal/gui/tests/cursor-local-models.test.cjs+++ b/internal/gui/tests/cursor-local-models.test.cjs@@ -102,14 +102,14 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",assert.equal(await page.locator(`${cd} > .field.launch`).count(), 1, "the launch command's square is gone");menu = page.locator(`${cd} > .ag-menu`);} else {- assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), "DeepSeek V4.1 Flash, grok-4.6 +1");+ assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), await page.evaluate(() => t("Showing {shown} / {listed} models", { shown: 3, listed: 4 })));await page.locator(`${cd} .ag-sum`).click();menu = page.locator(`${cd} .ag-open .ag-menu`);await page.waitForFunction((sel) => document.querySelector(sel)?.getBoundingClientRect().height > 0, `${cd} .ag-open .ag-menu`);assert.equal(await page.locator(`${cd} .ag-conn-said`).textContent(), w.said);}assert.equal(await menu.count(), 1, "no model button");- assert.equal(await menu.locator(".v").textContent(), "DeepSeek V4.1 Flash, grok-4.6 +1");+ assert.equal(await menu.locator(".v").textContent(), await page.evaluate(() => t("Showing {shown} / {listed} models", { shown: 3, listed: 4 })));assert.ok((await menu.getAttribute("title")).includes(w.restart), await menu.getAttribute("title"));const y = await page.evaluate(() => scrollY);@@ -133,7 +133,7 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",if (where === "panel") assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), "DeepSeek V4.1 Flash, grok-4.6");// and Kimi K3 back inawait box.locator(".am-mr", { hasText: "Kimi K3" }).click();- await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === "DeepSeek V4.1 Flash, grok-4.6 +1");+ await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === t("Showing {shown} / {listed} models", { shown: 3, listed: 4 }));await page.waitForTimeout(150);assert.equal(fx.posts.length, 2);assert.deepEqual(fx.posts.at(-1), ["relay/glm-5"]);diff --git a/internal/gui/tests/desktop-model-menu.test.cjs b/internal/gui/tests/desktop-model-menu.test.cjsindex 088450f7b..4dd1495b7 100644--- a/internal/gui/tests/desktop-model-menu.test.cjs+++ b/internal/gui/tests/desktop-model-menu.test.cjs@@ -104,14 +104,14 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",assert.equal(await page.locator(`${cd} .ag-start`, { hasText: w.last }).count(), 0, "the opus tier still stands as the row's model");menu = page.locator(`${cd} > .ag-menu`);} else {- assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), "DeepSeek V4.1 Flash, grok-4.6 +1");+ assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), await page.evaluate(() => t("Showing {shown} / {listed} models", { shown: 3, listed: 4 })));await page.locator(`${cd} .ag-sum`).click();menu = page.locator(`${cd} .ag-open .ag-menu`);await page.waitForFunction((sel) => document.querySelector(sel)?.getBoundingClientRect().height > 0, `${cd} .ag-open .ag-menu`);assert.equal(await page.locator(`${cd} .ag-conn-said`).textContent(), w.said);}assert.equal(await menu.count(), 1, "no model button");- assert.equal(await menu.locator(".v").textContent(), "DeepSeek V4.1 Flash, grok-4.6 +1");+ assert.equal(await menu.locator(".v").textContent(), await page.evaluate(() => t("Showing {shown} / {listed} models", { shown: 3, listed: 4 })));assert.ok((await menu.getAttribute("title")).includes(w.restart), await menu.getAttribute("title"));const y = await page.evaluate(() => scrollY);@@ -135,7 +135,7 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",if (where === "panel") assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), "DeepSeek V4.1 Flash, grok-4.6");// and Kimi K3 back inawait box.locator(".am-mr", { hasText: "Kimi K3" }).click();- await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === "DeepSeek V4.1 Flash, grok-4.6 +1");+ await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === t("Showing {shown} / {listed} models", { shown: 3, listed: 4 }));await page.waitForTimeout(150);assert.equal(fx.posts.length, 2);assert.deepEqual(fx.posts.at(-1), ["relay/glm-5"]);diff --git a/internal/gui/tests/zcode-models.test.cjs b/internal/gui/tests/zcode-models.test.cjsindex 9b40cfdff..43d0536f6 100644--- a/internal/gui/tests/zcode-models.test.cjs+++ b/internal/gui/tests/zcode-models.test.cjs@@ -92,14 +92,14 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",assert.equal(await page.locator(`${cd} .ag-st-t`).textContent(), await said(3));menu = page.locator(`${cd} > .ag-menu`);} else {- assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), "DeepSeek Pro, DeepSeek Flash +1");+ assert.equal(await page.locator(`${cd} .ag-sum .vt`).textContent(), await page.evaluate(() => t("All {n} models", { n: 3 })));await page.locator(`${cd} .ag-sum`).click();menu = page.locator(`${cd} .ag-open .ag-menu`);await page.waitForFunction((sel) => document.querySelector(sel)?.getBoundingClientRect().height > 0, `${cd} .ag-open .ag-menu`);assert.equal(await page.locator(`${cd} .ag-conn-said`).textContent(), await said(3));}assert.equal(await menu.count(), 1, "no models button");- assert.equal(await menu.locator(".v").textContent(), "DeepSeek Pro, DeepSeek Flash +1");+ assert.equal(await menu.locator(".v").textContent(), await page.evaluate(() => t("All {n} models", { n: 3 })));const y = await page.evaluate(() => scrollY);await menu.click();@@ -118,7 +118,7 @@ for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium",assert.equal(await page.locator(where === "window" ? `${cd} .ag-st-t` : `${cd} .ag-conn-said`).textContent(), await said(2));// and back inawait box.locator(".am-mr", { hasText: "DeepSeek Flash" }).click();- await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === "DeepSeek Pro, DeepSeek Flash +1");+ await page.waitForFunction(() => document.querySelector(".ag-menu .v")?.textContent === t("All {n} models", { n: 3 }));await page.waitForTimeout(150);assert.deepEqual(fx.posts.at(-1), []);