Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.
gui: the Windows app's confirmation backdrop goes without blur too (#3980)
yetone7323255b4ed0
diff --git a/internal/gui/assets/app.css b/internal/gui/assets/app.cssindex c809a3701..cb1c7509b 100644--- a/internal/gui/assets/app.css+++ b/internal/gui/assets/app.css@@ -3628,7 +3628,9 @@ html.theming, html.theming *, html.theming *::before, html.theming *::after {}/* Full-window filtering stalls provider tests and sign-in dialogs on someWebView2 GPUs. Keep the veil, without filtering the page behind it. */-.win body:not(.web) .modal { -webkit-backdrop-filter: none; backdrop-filter: none; }+/* The Remove/Sign out confirmation's backdrop covers the window the same way. */+.win body:not(.web) .modal,+.win body:not(.web) .action-confirm::backdrop { -webkit-backdrop-filter: none; backdrop-filter: none; }/* opening and closing are animated from app.js (openModal, closeModal) */.modal.out { pointer-events: none; }/* open, it holds its place from a top app.js gives it (holdModal) */diff --git a/internal/gui/tests/modal-backdrop.test.cjs b/internal/gui/tests/modal-backdrop.test.cjsindex 5f3d988f5..94f2e99c9 100644--- a/internal/gui/tests/modal-backdrop.test.cjs+++ b/internal/gui/tests/modal-backdrop.test.cjs@@ -16,7 +16,7 @@ for (const engine of process.env.BROWSER ? [process.env.BROWSER] : ["chromium",t.after(() => browser.close());const page = await browser.newPage({ viewport: { width: 1552, height: 905 } });await page.route("**/*", (route) => route.request().isNavigationRequest()- ? route.fulfill({ contentType: "text/html", body: '<div class="modal"><div class="dialog">Provider editor</div></div>' })+ ? route.fulfill({ contentType: "text/html", body: '<div class="modal"><div class="dialog">Provider editor</div></div><dialog class="action-confirm"><h2>Remove?</h2></dialog>' }): route.abort());await page.goto(`http://magpie.test/?mode=${mode}`);await page.evaluate(({ platform, web }) => {@@ -30,11 +30,19 @@ for (const engine of process.env.BROWSER ? [process.env.BROWSER] : ["chromium",return { filter: style.backdropFilter || style.webkitBackdropFilter,background: style.backgroundColor, pointerEvents: style.pointerEvents };});+ // the confirmation dialog's ::backdrop covers the window too+ const confirm = await page.locator("dialog.action-confirm").evaluate((element) => {+ element.showModal();+ const style = getComputedStyle(element, "::backdrop");+ return style.backdropFilter || style.webkitBackdropFilter;+ });if (platform === "Win32" && !web) {assert.equal(backdrop.filter, "none", "the Windows app must not filter the full-window backdrop");+ assert.equal(confirm, "none", "nor the confirmation's");} else {assert.match(backdrop.filter, /blur\(8px\)/, "other surfaces keep their existing blur");assert.match(backdrop.filter, /saturate\(1\.1\)/);+ assert.match(confirm, /blur\(4px\)/, "the confirmation keeps its blur");}assert.equal(backdrop.background, "rgba(0, 0, 0, 0.28)", "the dimming veil remains");assert.equal(backdrop.pointerEvents, "auto", "the backdrop still receives clicks");