Skip to content

Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.

routing: the stage's pulses play again with no layout, and the list's heights keep only its rows (#3731)

yetone7bdefe212fd0
diff --git a/internal/gui/assets/plugins/routing/client.js b/internal/gui/assets/plugins/routing/client.js
index 6a45d206d..5d8d8da90 100644
--- a/internal/gui/assets/plugins/routing/client.js
+++ b/internal/gui/assets/plugins/routing/client.js
@@ -314,7 +314,22 @@ function routingPage(part) {
// setAttr: an attribute written only when it changes, as setText: the
// list's head is told again on every trace answer (#3731)
const setAttr = (e, k, v) => { if (e.getAttribute(k) !== v) e.setAttribute(k, v); };
- const tick = (e) => { e.classList.remove("tick"); void e.offsetWidth; e.classList.add("tick"); };
+ // rerun: a class's animation played again from its start. Taking the
+ // class off and reading offsetWidth to start it again laid the whole page
+ // out, three or four times a request (gpboyer2, #3731): a running one is
+ // rewound, and the class comes off when it ends, so putting it on again
+ // starts it with no layout
+ const replaying = new WeakSet();
+ const rerun = (e, cls, name) => {
+ const a = e.getAnimations?.().find((x) => x.animationName === name);
+ if (a) { a.currentTime = 0; return; }
+ if (!replaying.has(e)) {
+ replaying.add(e);
+ e.addEventListener("animationend", (ev) => { if (ev.target === e && ev.animationName === name) e.classList.remove(cls); });
+ }
+ e.classList.add(cls);
+ };
+ const tick = (e) => rerun(e, "tick", "rttick");
// ---------- words ----------
@@ -1593,7 +1608,7 @@ function routingPage(part) {
if (capQ.length > 3) capQ.shift();
kick();
}
- function show(c) { capLo = !!c.lo; cap.textContent = c.s; cap.classList.remove("in"); void cap.offsetWidth; cap.classList.add("in"); capAt = performance.now(); }
+ function show(c) { capLo = !!c.lo; cap.textContent = c.s; rerun(cap, "in", "rtin"); capAt = performance.now(); }
// curve is a wire's S from (x0, y0) to (x3, y3), its bends at mx: one
// cubic, cut into exact pieces of it about 1000 px tall (the middle ones
@@ -3569,6 +3584,9 @@ function routingPage(part) {
heights.set(itemKey(listItems[i0 + i]), e.getBoundingClientRect().height + parseFloat(s.marginTop) + parseFloat(s.marginBottom));
});
let total = 0;
+ // the rows gone from the list leave the average: kept, every row ever
+ // measured was summed again on each draw (gpboyer2, #3731)
+ if (heights.size > n) { const keep = new Set(listItems.map(itemKey)); for (const k of heights.keys()) if (!keep.has(k)) heights.delete(k); }
for (const h of heights.values()) total += h;
winAvg = heights.size ? total / heights.size : 0;
est = winAvg || 31; // the rows not drawn as tall as those just measured, not as the average before
@@ -4060,7 +4078,7 @@ function routingPage(part) {
tick(A.node);
break;
}
- row.li.classList.remove("hit"); void row.li.offsetWidth; row.li.classList.add("hit", "tagged");
+ rerun(row.li, "hit", "rthit"); row.li.classList.add("tagged");
row.tg.textContent = `${tr.status} · ${failWord(tr.fail)}`;
setTimeout(() => row.li.classList.remove("tagged"), 1800);
say(tryWhy(r, i));
diff --git a/internal/gui/tests/routing-tick-no-layout.test.cjs b/internal/gui/tests/routing-tick-no-layout.test.cjs
new file mode 100644
index 000000000..e06a4bc80
--- /dev/null
+++ b/internal/gui/tests/routing-tick-no-layout.test.cjs
@@ -0,0 +1,99 @@
+// Run with Node's test runner and Playwright on the module path; see README.md.
+// Routing: the stage's nodes pulse as a request passes them with no layout
+// of the page (gpboyer2, #3731). Each pulse took its class off, read
+// offsetWidth to start the animation again, and put the class back, which
+// laid the whole page out three or four times a request under steady
+// traffic. With requests streaming in, nothing reads an animated node's
+// offsetWidth, and the pulse still plays. In Chromium and WebKit.
+const assert = require("node:assert/strict");
+const { test } = require("node:test");
+const fs = require("node:fs/promises");
+const path = require("node:path");
+const { chromium, webkit } = require("playwright");
+
+const assets = path.resolve(__dirname, "../assets");
+const now = Date.now(), iso = (ms) => new Date(ms).toISOString();
+const seat = { id: "codex@me", provider: "codex", name: "ChatGPT", who: "[email protected]", kind: "account", model: "gpt-6.1-sol", known: true, plan: "Pro" };
+const prompt = (n) => ({ window: 272000, tokens: 90000 + n * 8000, counted: true, turns: n, parts: [
+ { kind: "system", tokens: 9000, items: [{ name: "prompt", tokens: 9000 }] },
+ { kind: "files", tokens: 30000 + n * 4000, items: Array.from({length: 1 + (n % 5)}, (_, i) => ({ name: "/work/f" + i + ".js", tag: "read", tokens: 3000 })) },
+ { kind: "chat", tokens: 19000 + n * 2000, items: [{ name: "turn", tag: "turns", n, tokens: 19000 + n * 2000 }] } ] });
+function req(id, step) {
+ const t0 = now - (400 - id) * 1000, done = step === "done";
+ return { id, seq: id * 10 + ({ start: 0, read: 1, done: 2 })[step], time: iso(t0), agent: "codex", session: "019a-session", model: "gpt-6.1-sol", provider: "codex",
+ order: [seat], tries: [{ id: seat.id, model: seat.model, start: iso(t0), done, ...(done ? { status: 200, ms: 4000 } : {}) }],
+ done, ...(done ? { status: 200, ms: 4000, tokens: 2000, cost: 0.05, priced: true, usage: [{ in: 3000, cache_read: 87000, out: 400 }] } : {}),
+ ...(step === "start" ? {} : { prompt: prompt(id - 100) }) };
+}
+const first = [101, 102, 103].map((i) => req(i, "done"));
+const models = [{ id: "a/sol", name: "sol", providerName: "A", icon: "generic" }, { id: "b/flash", name: "flash", providerName: "B", icon: "generic" }];
+const base = { members: ["a/sol", "b/flash"], ready: true, memberInfo: [{ id: "a/sol", ready: true }, { id: "b/flash", ready: true }], offers: [], shared: [] };
+const groups = { models, pools: [], groups: [{ ...base, id: "hand", name: "Hand", routing: "manual", pick: "a/sol", picked: "a/sol" }, { ...base, id: "auto", name: "Auto", routing: "order" }] };
+function serve(feed) {
+ const state = { agents: [{ id: "codex", name: "Codex", path: "/test/codex", fields: [] }], profiles: [], settings: { lang: "en", theme: "light" } };
+ return async (route) => {
+ const url = new URL(route.request().url()); const json = (d) => route.fulfill({ json: d });
+ if (url.pathname === "/boot.js") return route.fulfill({ contentType: "text/javascript", body: 'window.bootPrefs = {lang:"en",theme:"light",web:true};' });
+ if (url.pathname === "/wails/runtime.js") return route.fulfill({ contentType: "text/javascript", body: "export const Window = {};" });
+ if (url.pathname === "/api/state") return json(state);
+ if (url.pathname === "/api/gateway/trace") {
+ const trace = (routes) => json({ mine: true, now: new Date().toISOString(), seq: routes.length ? routes[routes.length - 1].seq : Number(url.searchParams.get("after")), totals: { requests: 0, rerouted: 0, errors: 0 }, routes });
+ if (!url.searchParams.get("wait")) return trace(first);
+ return trace([await new Promise((res) => { feed.next = res; })]);
+ }
+ if (url.pathname === "/api/gateway/history") return json({ cut: false, days: [], routes: [] });
+ if (url.pathname === "/api/groups") return json(groups);
+ if (url.pathname === "/api/providers") return json({ providers: [], presets: [], excluded: [], gateway: { running: true, window: true, url: "http://127.0.0.1:3999" } });
+ if (url.pathname.startsWith("/api/")) return json({});
+ const file = path.join(assets, url.pathname === "/" ? "index.html" : url.pathname);
+ const ct = { ".html": "text/html", ".js": "text/javascript", ".css": "text/css", ".svg": "image/svg+xml", ".png": "image/png" }[path.extname(file)];
+ await route.fulfill({ body: await fs.readFile(file).catch(() => ""), contentType: ct });
+ };
+}
+for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium", "webkit"])) {
+ test(`${engine}: the stage pulses with no layout as requests come in`, async (t) => {
+ const browser = await (engine === "webkit" ? webkit.launch() : chromium.launch({ channel: "chromium" }));
+ t.after(() => browser.close());
+ const context = await browser.newContext({ viewport: { width: 1100, height: 900 } });
+ const page = await context.newPage();
+ page.setDefaultTimeout(5000);
+ const errors = [];
+ page.on("pageerror", (e) => errors.push(e.message));
+ // every read of an animated node's offsetWidth counted, and every pulse
+ // started or rewound
+ await page.addInitScript(() => {
+ window.reads = 0; window.pulses = 0;
+ const d = Object.getOwnPropertyDescriptor(HTMLElement.prototype, "offsetWidth");
+ Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, get() {
+ if (this.matches?.(".rt-hub, .rt-src, .rt-cap, .rt-accts li")) window.reads++;
+ return d.get.call(this);
+ } });
+ document.addEventListener("animationstart", (e) => { if (e.animationName === "rttick") window.pulses++; });
+ setInterval(() => {
+ for (const e of document.querySelectorAll(".rt-hub, .rt-src"))
+ if (e.getAnimations().some((a) => a.animationName === "rttick" && a.playState === "running")) window.pulses += 0.001;
+ }, 50);
+ });
+ const feed = {};
+ await page.route("**/*", serve(feed));
+ await page.goto("http://magpie.test/?view=routing");
+ await page.locator(".rt-hub").waitFor();
+ await page.waitForTimeout(800);
+ const was = await page.evaluate(() => window.reads);
+ for (let id = 104; id < 112; id++) for (const s of ["start", "read", "done"]) {
+ for (let i = 0; i < 60 && !feed.next; i++) await page.waitForTimeout(50);
+ const next = feed.next;
+ assert(next, "the page asks for the next trace");
+ feed.next = null;
+ next(req(id, s));
+ await page.waitForTimeout(250);
+ }
+ await page.waitForTimeout(1500);
+ const [reads, pulses] = await page.evaluate(() => [window.reads, window.pulses]);
+ assert.equal(reads - was, 0, "no animated node's offsetWidth read as requests came in");
+ assert(pulses >= 1, `the stage still pulses: ${pulses}`);
+ assert.deepEqual(errors, []);
+ feed.next?.(req(999, "done"));
+ await context.close();
+ });
+}