Skip to content

Every agent's model. One place. Codex on DeepSeek, Claude Code on Kimi, from the menu bar.

gui: a menu with nothing to tick keeps no tick column in Safari 15.0 too (#4020)

yetonebe0fbfe08d25
diff --git a/internal/gui/assets/app.css b/internal/gui/assets/app.css
index 581785016..da233a16e 100644
--- a/internal/gui/assets/app.css
+++ b/internal/gui/assets/app.css
@@ -2701,7 +2701,7 @@ body.window .ag-sk-icon { width: 22px; height: 22px; border-radius: 6px; }
.proto-menu .pm-tick { width: 14px; height: 16px; flex: none; display: grid; place-items: center; color: var(--fg); }
/* a menu of actions, where nothing is or can be ticked, keeps no room for
a tick: its items line up with its heading */
-.proto-menu:not(:has(.pm-item.on, [role=menuitemcheckbox])) .pm-tick { display: none; }
+.proto-menu.pm-bare .pm-tick { display: none; }
.proto-menu .pm-words { display: grid; gap: 1px; min-width: 0; }
.proto-menu .pm-name { font-size: 12.5px; font-weight: 500; line-height: 16px; }
.proto-menu .pm-note { font-size: 11px; color: var(--muted); line-height: 15px; }
diff --git a/internal/gui/assets/app.js b/internal/gui/assets/app.js
index fa0bff548..322dc7260 100644
--- a/internal/gui/assets/app.js
+++ b/internal/gui/assets/app.js
@@ -14670,6 +14670,8 @@ function placeMenu(box, anchor, align = "left", dx = 0) {
box.style.left = Math.max(pad, Math.min(left, innerWidth - w - pad)) + "px";
box.style.top = Math.max(top, y) + "px";
}
+// no tick column with nothing to tick (#4020)
+const bareTicks = (box, items) => box.classList.toggle("pm-bare", !items.some((b) => b.matches(".on, [role=menuitemcheckbox]")));
function openProtoMenu(anchor, opts, value, choose, head = "Protocol this key speaks", cls = "", align = "left", live = false, search = "") {
closeProtoMenu();
const multi = Array.isArray(value);
@@ -14717,6 +14719,7 @@ function openProtoMenu(anchor, opts, value, choose, head = "Protocol this key sp
box.append(b);
return b;
});
+ bareTicks(box, items);
if (filter) filter.oninput = () => {
const q = filter.value.trim().toLocaleLowerCase();
items.forEach((b, i) => { b.hidden = !opts[i].always && !opts[i].name.toLocaleLowerCase().includes(q); });
@@ -18773,6 +18776,7 @@ function openSessCombo(anchor, all, opts, value, choose, head) {
const cur = !words.length && value && !shown.some((o) => o.v === value) && opts.find((o) => o.v === value);
items = [...(words.length ? [] : [{ v: "", name: t(all), note: "" }]), ...(cur ? [cur] : []), ...shown].map(item);
list.replaceChildren(...items);
+ bareTicks(box, items);
if (!hit.length) list.append(el("div", "sc-none", t("No match")));
else if (hit.length > shown.length) list.append(el("div", "sc-more", t("{n} more — type to narrow", { n: fmtN(hit.length - shown.length) })));
};