Skip to content

Email for professionals and teams

Name the controls on routing rules (#129)

Can K.42e3690752ee
diff --git a/public/locales/tr.json b/public/locales/tr.json
index f22f7dc..f77df14 100644
--- a/public/locales/tr.json
+++ b/public/locales/tr.json
@@ -676,6 +676,7 @@
"routing.rejectReason": "Reddetme nedeni",
"routing.rejectPlaceholder": "İleti yönlendirme kuralı tarafından reddedildi",
"routing.noRules": "Henüz kural yok.",
+ "routing.enableRule": "Kuralı etkinleştir",
"routing.disabled": "Devre dışı",
"routing.stats": "Öncelik {priority} · {count}× eşleşti · son: {last}",
"export.failed": "Dışa aktarma başarısız oldu",
diff --git a/src/components/settings/domain-routing/domain-routing.tsx b/src/components/settings/domain-routing/domain-routing.tsx
index d4d814d..0177d87 100644
--- a/src/components/settings/domain-routing/domain-routing.tsx
+++ b/src/components/settings/domain-routing/domain-routing.tsx
@@ -336,6 +336,7 @@ export function DomainRouting({ domain }: DomainRoutingProps = {}) {
<Switch
checked={form.keepCopy}
onCheckedChange={(keepCopy) => setForm({ ...form, keepCopy })}
+ aria-label={t("routing.keepCopy")}
/>
</div>
)}
@@ -407,6 +408,7 @@ function RuleSection({
) : (
rules.map((rule) => {
const Icon = ACTION_ICONS[rule.action];
+ const ruleName = rule.name || describeRule(rule, mailboxes, hostname, t);
return (
<div
key={rule.id}
@@ -416,7 +418,7 @@ function RuleSection({
<div className="min-w-0 flex-1">
<div className="flex items-center gap-2">
<p className="truncate text-sm font-medium">
- {rule.name || describeRule(rule, mailboxes, hostname, t)}
+ {ruleName}
</p>
{!rule.enabled && <Badge variant="secondary">{t("routing.disabled")}</Badge>}
</div>
@@ -429,11 +431,11 @@ function RuleSection({
{t("routing.stats", { priority: rule.priority, count: rule.matchCount, last: formatLastMatched(rule.lastMatchedAt, t) })}
</p>
</div>
- <Switch checked={rule.enabled} onCheckedChange={() => onToggle(rule)} />
- <Button variant="ghost" size="sm" onClick={() => onEdit(rule)}>
+ <Switch checked={rule.enabled} onCheckedChange={() => onToggle(rule)} aria-label={`${t("routing.enableRule")}: ${ruleName}`} />
+ <Button variant="ghost" size="sm" onClick={() => onEdit(rule)} aria-label={`${t("routing.editRule")}: ${ruleName}`}>
<Pencil className="h-4 w-4" />
</Button>
- <Button variant="ghost" size="sm" onClick={() => onDelete(rule.id)}>
+ <Button variant="ghost" size="sm" onClick={() => onDelete(rule.id)} aria-label={`${t("rules.delete")}: ${ruleName}`}>
<Trash2 className="h-4 w-4 text-red-600" />
</Button>
</div>
diff --git a/src/lib/i18n/en.json b/src/lib/i18n/en.json
index 776cd1b..d579f54 100644
--- a/src/lib/i18n/en.json
+++ b/src/lib/i18n/en.json
@@ -685,6 +685,7 @@
"routing.rejectReason": "Rejection reason",
"routing.rejectPlaceholder": "Message rejected by routing rule",
"routing.noRules": "No rules yet.",
+ "routing.enableRule": "Enable rule",
"routing.disabled": "Disabled",
"routing.stats": "Priority {priority} · matched {count}× · last {last}",
"export.failed": "Export failed",