Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

make sure that if updating is suspended for a parent mobject, children are still updated (#4402)

Benjamin Hackl00d0b297b4bb
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 1b9a342a3..e25f7d0b6 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -892,16 +892,15 @@ class Mobject:
:meth:`get_updaters`
"""
- if self.updating_suspended:
- return self
- for updater in self.updaters:
- if "dt" in inspect.signature(updater).parameters:
- updater(self, dt)
- else:
- updater(self)
+ if not self.updating_suspended:
+ for updater in self.updaters:
+ if "dt" in inspect.signature(updater).parameters:
+ updater(self, dt)
+ else:
+ updater(self)
if recursive:
for submob in self.submobjects:
- submob.update(dt, recursive)
+ submob.update(dt, recursive=recursive)
return self
def get_time_based_updaters(self) -> list[TimeBasedUpdater]:
diff --git a/manim/mobject/opengl/opengl_mobject.py b/manim/mobject/opengl/opengl_mobject.py
index 206a114cc..e071fdb48 100644
--- a/manim/mobject/opengl/opengl_mobject.py
+++ b/manim/mobject/opengl/opengl_mobject.py
@@ -1515,12 +1515,11 @@ class OpenGLMobject:
self.updating_suspended: bool = False
def update(self, dt: float = 0, recurse: bool = True) -> Self:
- if not self.has_updaters or self.updating_suspended:
- return self
- for time_based_updater in self.time_based_updaters:
- time_based_updater(self, dt)
- for non_time_updater in self.non_time_updaters:
- non_time_updater(self)
+ if self.has_updaters and not self.updating_suspended:
+ for time_based_updater in self.time_based_updaters:
+ time_based_updater(self, dt)
+ for non_time_updater in self.non_time_updaters:
+ non_time_updater(self)
if recurse:
for submob in self.submobjects:
submob.update(dt, recurse)