Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

Enables Use of input_to_graph_point() by CurvesAsSubmobjects Instances (#3190)

JinchuLi20020902eef61f79
diff --git a/manim/mobject/types/vectorized_mobject.py b/manim/mobject/types/vectorized_mobject.py
index b5cf76ec0..12b6a85b6 100644
--- a/manim/mobject/types/vectorized_mobject.py
+++ b/manim/mobject/types/vectorized_mobject.py
@@ -2345,6 +2345,69 @@ class CurvesAsSubmobjects(VGroup):
part.match_style(vmobject)
self.add(part)
+ def point_from_proportion(self, alpha: float) -> np.ndarray:
+ """Gets the point at a proportion along the path of the :class:`CurvesAsSubmobjects`.
+
+ Parameters
+ ----------
+ alpha
+ The proportion along the the path of the :class:`CurvesAsSubmobjects`.
+
+ Returns
+ -------
+ :class:`numpy.ndarray`
+ The point on the :class:`CurvesAsSubmobjects`.
+
+ Raises
+ ------
+ :exc:`ValueError`
+ If ``alpha`` is not between 0 and 1.
+ :exc:`Exception`
+ If the :class:`CurvesAsSubmobjects` has no submobjects, or no submobject has points.
+ """
+ if alpha < 0 or alpha > 1:
+ raise ValueError(f"Alpha {alpha} not between 0 and 1.")
+
+ self._throw_error_if_no_submobjects()
+ submobjs_with_pts = self._get_submobjects_with_points()
+
+ if alpha == 1:
+ return submobjs_with_pts[-1].points[-1]
+
+ submobjs_arc_lengths = tuple(
+ part.get_arc_length() for part in submobjs_with_pts
+ )
+
+ total_length = sum(submobjs_arc_lengths)
+ target_length = alpha * total_length
+ current_length = 0
+
+ for i, part in enumerate(submobjs_with_pts):
+ part_length = submobjs_arc_lengths[i]
+ if current_length + part_length >= target_length:
+ residue = (target_length - current_length) / part_length
+ return part.point_from_proportion(residue)
+
+ current_length += part_length
+
+ def _throw_error_if_no_submobjects(self):
+ if len(self.submobjects) == 0:
+ caller_name = sys._getframe(1).f_code.co_name
+ raise Exception(
+ f"Cannot call CurvesAsSubmobjects.{caller_name} for a CurvesAsSubmobject with no submobjects"
+ )
+
+ def _get_submobjects_with_points(self):
+ submobjs_with_pts = tuple(
+ part for part in self.submobjects if len(part.points) > 0
+ )
+ if len(submobjs_with_pts) == 0:
+ caller_name = sys._getframe(1).f_code.co_name
+ raise Exception(
+ f"Cannot call CurvesAsSubmobjects.{caller_name} for a CurvesAsSubmobject whose submobjects have no points"
+ )
+ return submobjs_with_pts
+
class DashedVMobject(VMobject, metaclass=ConvertToOpenGL):
"""A :class:`VMobject` composed of dashes instead of lines.
diff --git a/tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py b/tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py
index 5e87c820c..a17383fd9 100644
--- a/tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py
+++ b/tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py
@@ -5,6 +5,7 @@ import pytest
from manim import (
Circle,
+ CurvesAsSubmobjects,
Line,
Mobject,
Polygon,
@@ -41,6 +42,38 @@ def test_vmobject_point_from_propotion():
obj.point_from_proportion(0)
+def test_curves_as_submobjects_point_from_proportion():
+ obj = CurvesAsSubmobjects(VGroup())
+
+ with pytest.raises(ValueError, match="between 0 and 1"):
+ obj.point_from_proportion(2)
+ with pytest.raises(Exception, match="with no submobjects"):
+ obj.point_from_proportion(0)
+
+ obj.add(VMobject())
+ with pytest.raises(Exception, match="have no points"):
+ obj.point_from_proportion(0)
+
+ # submobject[0] is a line of length 4
+ obj.submobjects[0].set_points_as_corners(
+ [
+ np.array([0, 0, 0]),
+ np.array([4, 0, 0]),
+ ],
+ )
+ obj.add(VMobject())
+ # submobject[1] is a line of length 2
+ obj.submobjects[1].set_points_as_corners(
+ [
+ np.array([4, 0, 0]),
+ np.array([4, 2, 0]),
+ ],
+ )
+
+ # point at proportion 0.5 should be at length 3, point [3, 0, 0]
+ np.testing.assert_array_equal(obj.point_from_proportion(0.5), np.array([3, 0, 0]))
+
+
def test_vgroup_init():
"""Test the VGroup instantiation."""
VGroup()