A community-maintained Python framework for creating mathematical animations.
Bugfix: Raise NotImplementedError when trying to chain overridden method animations (#957)
Benjamin Hackl19e8752f522f
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.pyindex 7aaa38dd6..9ff5d4831 100644--- a/manim/mobject/mobject.py+++ b/manim/mobject/mobject.py@@ -1351,18 +1351,20 @@ class _AnimationBuilder:self.mobject = mobjectself.overridden_animation = Noneself.mobject.generate_target()+ self.is_chaining = Falsedef __getattr__(self, method_name):method = getattr(self.mobject.target, method_name)+ has_overridden_animation = hasattr(method, "_override_animate")- if self.overridden_animation:+ if (self.is_chaining and has_overridden_animation) or self.overridden_animation:raise NotImplementedError("Method chaining is currently not supported for ""overridden animations")def update_target(*method_args, **method_kwargs):- if hasattr(method, "_override_animate"):+ if has_overridden_animation:self.overridden_animation = method._override_animate(self.mobject, *method_args, **method_kwargs)@@ -1370,6 +1372,7 @@ class _AnimationBuilder:method(*method_args, **method_kwargs)return self+ self.is_chaining = Truereturn update_targetdef build(self):diff --git a/tests/test_animate.py b/tests/test_animate.pyindex b9f68695b..b092147cf 100644--- a/tests/test_animate.py+++ b/tests/test_animate.py@@ -1,4 +1,5 @@import numpy as np+import pytestfrom manim.mobject.mobject import override_animatefrom manim.mobject.types.vectorized_mobject import VGroup@@ -45,3 +46,31 @@ def test_overridden_animate():anim = dots_with_line.animate.remove_line().build()assert len(dots_with_line.submobjects) == 2assert type(anim) is Uncreate+++def test_chaining_overridden_animate():+ class DotsWithLine(VGroup):+ def __init__(self):+ super().__init__()+ self.left_dot = Dot().shift((-1, 0, 0))+ self.right_dot = Dot().shift((1, 0, 0))+ self.line = Line(self.left_dot, self.right_dot)+ self.add(self.left_dot, self.right_dot, self.line)++ def remove_line(self):+ self.remove(self.line)++ @override_animate(remove_line)+ def _remove_line_animation(self):+ self.remove_line()+ return Uncreate(self.line)++ with pytest.raises(+ NotImplementedError, match="not supported for overridden animations"+ ):+ DotsWithLine().animate.shift((1, 0, 0)).remove_line()++ with pytest.raises(+ NotImplementedError, match="not supported for overridden animations"+ ):+ DotsWithLine().animate.remove_line().shift((1, 0, 0))