Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

Added VMobject.get_subcurve, and cleaned up implementation of DashedVMobject

Grant Sanderson3de8c2f04cee
diff --git a/manimlib/mobject/types/vectorized_mobject.py b/manimlib/mobject/types/vectorized_mobject.py
index 4f1939579..2f7886762 100644
--- a/manimlib/mobject/types/vectorized_mobject.py
+++ b/manimlib/mobject/types/vectorized_mobject.py
@@ -788,6 +788,11 @@ class VMobject(Mobject):
))
return self
+ def get_subcurve(self, a, b):
+ vmob = self.copy()
+ vmob.pointwise_become_partial(self, a, b)
+ return vmob
+
class VGroup(VMobject):
def __init__(self, *vmobjects, **kwargs):
@@ -834,21 +839,31 @@ class CurvesAsSubmobjects(VGroup):
self.add(part)
-class DashedMobject(VMobject):
+class DashedVMobject(VMobject):
CONFIG = {
- "dashes_num": 15,
- "spacing": 0.5,
+ "num_dashes": 15,
+ "positive_space_ratio": 0.5,
"color": WHITE
}
- def __init__(self, mobject, **kwargs):
+ def __init__(self, vmobject, **kwargs):
VMobject.__init__(self, **kwargs)
-
- buff = float(self.spacing) / self.dashes_num
-
- for i in range(self.dashes_num):
- a = ((1 + buff) * i) / self.dashes_num
- b = 1 - ((1 + buff) * (self.dashes_num - 1 - i)) / self.dashes_num
- dash = VMobject(color=self.get_color())
- dash.pointwise_become_partial(mobject, a, b)
- self.submobjects.append(dash)
+ num_dashes = self.num_dashes
+ ps_ratio = self.positive_space_ratio
+
+ # End points of the unit interval for division
+ alphas = np.linspace(0, 1, num_dashes + 1)
+ # This determines the length of each "dash"
+ full_d_alpha = (1.0 / num_dashes)
+ partial_d_alpha = full_d_alpha * ps_ratio
+ # Rescale so that the last point of vmobject will
+ # be the end of the last dash
+ alphas /= (1 - full_d_alpha + partial_d_alpha)
+
+ self.add(*[
+ vmobject.get_subcurve(alpha, alpha + partial_d_alpha)
+ for alpha in alphas[:-1]
+ ])
+ # Family is already taken care of by get_subcurve
+ # implementation
+ self.match_style(vmobject, family=False)