A community-maintained Python framework for creating mathematical animations.
add test_quality to constants.QUALITIES
leotrs449a68dedb00
diff --git a/docs/source/manim_directive.py b/docs/source/manim_directive.pyindex 1ac1f19a6..46c6343c2 100644--- a/docs/source/manim_directive.py+++ b/docs/source/manim_directive.py@@ -78,6 +78,8 @@ from typing import Listimport shutil+from manim import QUALITIES+classnamedict = {}@@ -150,29 +152,13 @@ class ManimDirective(Directive):else:ref_block = ""- frame_rate = 30- pixel_height = 480- pixel_width = 854-if "quality" in self.options:- quality = self.options["quality"]- if quality == "low":- pixel_height = 480- pixel_width = 854- frame_rate = 15- elif quality == "medium":- pixel_height = 720- pixel_width = 1280- frame_rate = 30- elif quality == "high":- pixel_height = 1440- pixel_width = 2560- frame_rate = 60- elif quality == "fourk":- pixel_height = 2160- pixel_width = 3840- frame_rate = 60-+ quality = f'{self.options["quality"]}_quality'+ else:+ quality = 'test_quality'+ frame_rate = QUALITIES[quality]['frame_rate']+ pixel_height = QUALITIES[quality]['pixel_height']+ pixel_width = QUALITIES[quality]['pixel_width']qualitydir = f"{pixel_height}p{frame_rate}"state_machine = self.state_machinediff --git a/manim/_config/main_utils.py b/manim/_config/main_utils.pyindex 1e3075c8f..395b9edef 100644--- a/manim/_config/main_utils.py+++ b/manim/_config/main_utils.py@@ -314,7 +314,11 @@ def _parse_args_no_subcmd(args):parser.add_argument("-q","--quality",- choices=[constants.QUALITIES[q]["flag"] for q in constants.QUALITIES],+ choices=[+ constants.QUALITIES[q]["flag"]+ for q in constants.QUALITIES+ if constants.QUALITIES[q]["flag"]+ ],default=constants.DEFAULT_QUALITY_SHORT,help="Render at specific quality, short form of the --*_quality flags",)diff --git a/manim/_config/utils.py b/manim/_config/utils.pyindex 84d8168df..62edfd14c 100644--- a/manim/_config/utils.py+++ b/manim/_config/utils.py@@ -126,6 +126,7 @@ def _determine_quality(args):passelif getattr(args, quality, None) or (hasattr(args, "quality")+ and args.quality is not Noneand args.quality == constants.QUALITIES[quality]["flag"]):return qualitydiff --git a/manim/constants.py b/manim/constants.pyindex ec78076db..a77265200 100644--- a/manim/constants.py+++ b/manim/constants.py@@ -171,6 +171,12 @@ QUALITIES = {"pixel_width": 854,"frame_rate": 15,},+ "test_quality": {+ "flag": None,+ "pixel_height": 480,+ "pixel_width": 854,+ "frame_rate": 30,+ },}DEFAULT_QUALITY = "high_quality"diff --git a/tests/test_quality_flags.py b/tests/test_quality_flags.pyindex 616eeef9e..e1f1f081b 100644--- a/tests/test_quality_flags.py+++ b/tests/test_quality_flags.py@@ -11,6 +11,9 @@ def test_quality_flags():assert _determine_quality(parsed) == constants.DEFAULT_QUALITYfor quality in constants.QUALITIES.keys():+ if not constants.QUALITIES[quality]["flag"]:+ continue+flag = constants.QUALITIES[quality]["flag"]# Assert that quality is properly set when using -q*arguments = f"manim -q{flag} dummy_filename".split()