Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

Fixed passing custom arrow shapes to :class:`~.CurvedArrow` (#1950)

vinnniii154923086fc918
diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py
index 05ae64819..8fff08326 100644
--- a/manim/mobject/geometry.py
+++ b/manim/mobject/geometry.py
@@ -461,8 +461,9 @@ class ArcBetweenPoints(Arc):
class CurvedArrow(ArcBetweenPoints):
def __init__(self, start_point, end_point, **kwargs):
+ tip_shape = kwargs.pop("tip_shape", ArrowTriangleFilledTip)
super().__init__(start_point, end_point, **kwargs)
- self.add_tip(tip_shape=kwargs.pop("tip_shape", ArrowTriangleFilledTip))
+ self.add_tip(tip_shape=tip_shape)
class CurvedDoubleArrow(CurvedArrow):
diff --git a/tests/control_data/graphical_units_data/geometry/CurvedArrowCustomTip.npz b/tests/control_data/graphical_units_data/geometry/CurvedArrowCustomTip.npz
new file mode 100644
index 000000000..b6ca4008c
Binary files /dev/null and b/tests/control_data/graphical_units_data/geometry/CurvedArrowCustomTip.npz differ
diff --git a/tests/test_graphical_units/test_geometry.py b/tests/test_graphical_units/test_geometry.py
index c451ed92e..b3d2c4b71 100644
--- a/tests/test_graphical_units/test_geometry.py
+++ b/tests/test_graphical_units/test_geometry.py
@@ -200,3 +200,19 @@ def test_Star(scene):
def test_AngledArrowTip(scene):
arrow = Arrow(start=ORIGIN, end=UP + RIGHT + OUT)
scene.add(arrow)
+
+
+@frames_comparison
+def test_CurvedArrowCustomTip(scene):
+ arrow = CurvedArrow(
+ LEFT,
+ RIGHT,
+ tip_shape=ArrowCircleTip,
+ )
+ double_arrow = CurvedDoubleArrow(
+ LEFT,
+ RIGHT,
+ tip_shape_start=ArrowCircleTip,
+ tip_shape_end=ArrowSquareFilledTip,
+ )
+ scene.add(arrow, double_arrow)