Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

Changing the 'side_length' attribute to a property (#3901)

Irvanal Haq8deac51abc98
diff --git a/manim/mobject/geometry/polygram.py b/manim/mobject/geometry/polygram.py
index 0a9edbadd..d441ff8ed 100644
--- a/manim/mobject/geometry/polygram.py
+++ b/manim/mobject/geometry/polygram.py
@@ -685,9 +685,16 @@ class Square(Rectangle):
"""
def __init__(self, side_length: float = 2.0, **kwargs) -> None:
- self.side_length = side_length
super().__init__(height=side_length, width=side_length, **kwargs)
+ @property
+ def side_length(self):
+ return np.linalg.norm(self.get_vertices()[0] - self.get_vertices()[1])
+
+ @side_length.setter
+ def side_length(self, value):
+ self.scale(value / self.side_length)
+
class RoundedRectangle(Rectangle):
"""A rectangle with rounded corners.
diff --git a/tests/module/mobject/geometry/test_unit_geometry.py b/tests/module/mobject/geometry/test_unit_geometry.py
index e953ef2de..53ee79aff 100644
--- a/tests/module/mobject/geometry/test_unit_geometry.py
+++ b/tests/module/mobject/geometry/test_unit_geometry.py
@@ -4,7 +4,7 @@ import logging
import numpy as np
-from manim import BackgroundRectangle, Circle, Sector
+from manim import BackgroundRectangle, Circle, Sector, Square
logger = logging.getLogger(__name__)
@@ -25,3 +25,22 @@ def test_BackgroundRectangle(manim_caplog):
"Argument {'hello': 'world'} is ignored in BackgroundRectangle.set_style."
in manim_caplog.text
)
+
+
+def test_Square_side_length_reflets_correct_width_and_height():
+ sq = Square(side_length=1).scale(3)
+ assert sq.side_length == 3
+ assert sq.height == 3
+ assert sq.width == 3
+
+
+def test_changing_Square_side_length_updates_the_square_appropriately():
+ sq = Square(side_length=1)
+ sq.side_length = 3
+ assert sq.height == 3
+ assert sq.width == 3
+
+
+def test_Square_side_length_consistent_after_scale_and_rotation():
+ sq = Square(side_length=1).scale(3).rotate(np.pi / 4)
+ assert np.isclose(sq.side_length, 3)