Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

revert a change that caused disable_caching to break

leotrsacccf3ef8b1c
diff --git a/manim/scene/scene_file_writer.py b/manim/scene/scene_file_writer.py
index b73753f80..8aa01aa8c 100644
--- a/manim/scene/scene_file_writer.py
+++ b/manim/scene/scene_file_writer.py
@@ -545,11 +545,8 @@ class SceneFileWriter(object):
if not self.includes_sound:
commands.insert(-1, "-an")
- try:
- subprocess.check_call(commands)
- except subprocess.CalledProcessError as exc:
- logger.error(f"FFMPEG returned with code {exc.returncode}")
- raise exc
+ combine_process = subprocess.Popen(commands)
+ combine_process.wait()
if self.includes_sound:
sound_file_path = movie_file_path.replace(