Skip to content

armgit / manim

Public Imported from GitHub
0

A community-maintained Python framework for creating mathematical animations.

Properly define init_points methods (#4360)

Francisco Manríquez Novoab3df1cf79efe
diff --git a/manim/mobject/geometry/arc.py b/manim/mobject/geometry/arc.py
index f9d5a84fd..87e692ea4 100644
--- a/manim/mobject/geometry/arc.py
+++ b/manim/mobject/geometry/arc.py
@@ -916,7 +916,8 @@ class AnnularSector(Arc):
self.append_points(outer_arc.points)
self.add_line_to(inner_arc.points[0])
- init_points = generate_points
+ def init_points(self) -> None:
+ self.generate_points()
class Sector(AnnularSector):
@@ -990,7 +991,8 @@ class Annulus(Circle):
self.append_points(inner_circle.points)
self.shift(self.arc_center)
- init_points = generate_points
+ def init_points(self) -> None:
+ self.generate_points()
class CubicBezier(VMobject, metaclass=ConvertToOpenGL):
diff --git a/manim/mobject/geometry/line.py b/manim/mobject/geometry/line.py
index 5e84cae09..6901819c6 100644
--- a/manim/mobject/geometry/line.py
+++ b/manim/mobject/geometry/line.py
@@ -147,7 +147,8 @@ class Line(TipableVMobject):
self._account_for_buff(buff)
- init_points = generate_points
+ def init_points(self) -> None:
+ self.generate_points()
def _account_for_buff(self, buff: float) -> None:
if buff <= 0:
diff --git a/manim/mobject/graphing/functions.py b/manim/mobject/graphing/functions.py
index 22313b282..44e0c3704 100644
--- a/manim/mobject/graphing/functions.py
+++ b/manim/mobject/graphing/functions.py
@@ -182,7 +182,8 @@ class ParametricFunction(VMobject, metaclass=ConvertToOpenGL):
self.make_smooth()
return self
- init_points = generate_points
+ def init_points(self) -> None:
+ self.generate_points()
class FunctionGraph(ParametricFunction):
@@ -328,4 +329,5 @@ class ImplicitFunction(VMobject, metaclass=ConvertToOpenGL):
self.make_smooth()
return self
- init_points = generate_points
+ def init_points(self) -> None:
+ self.generate_points()
diff --git a/manim/mobject/svg/svg_mobject.py b/manim/mobject/svg/svg_mobject.py
index 84f278efe..03264dd8c 100644
--- a/manim/mobject/svg/svg_mobject.py
+++ b/manim/mobject/svg/svg_mobject.py
@@ -496,7 +496,7 @@ class VMobjectFromSVGPath(VMobject, metaclass=ConvertToOpenGL):
super().__init__(**kwargs)
- def init_points(self) -> None:
+ def generate_points(self) -> None:
# TODO: cache mobject in a re-importable way
self.handle_commands()
@@ -509,7 +509,8 @@ class VMobjectFromSVGPath(VMobject, metaclass=ConvertToOpenGL):
# Get rid of any null curves
self.set_points(self.get_points_without_null_curves())
- generate_points = init_points
+ def init_points(self) -> None:
+ self.generate_points()
def handle_commands(self) -> None:
all_points: list[np.ndarray] = []