A community-maintained Python framework for creating mathematical animations.
fix: removed partial_movie_files (#2213)
Christopher Beschc72245e19a4a
diff --git a/manim/scene/scene_file_writer.py b/manim/scene/scene_file_writer.pyindex c9aa80eac..00c6888b8 100644--- a/manim/scene/scene_file_writer.py+++ b/manim/scene/scene_file_writer.py@@ -417,7 +417,7 @@ class SceneFileWriter:if time_diff < frame_duration:sleep(frame_duration - time_diff)- def finish(self, partial_movie_files=None):+ def finish(self):"""Finishes writing to the FFMPEG buffer or writing imagesto output directory.@@ -429,7 +429,7 @@ class SceneFileWriter:if write_to_movie():if hasattr(self, "writing_process"):self.writing_process.terminate()- self.combine_to_movie(partial_movie_files=partial_movie_files)+ self.combine_to_movie()if config.save_sections:self.combine_to_section_videos()if config["flush_cache"]:@@ -576,12 +576,11 @@ class SceneFileWriter:combine_process = subprocess.Popen(commands)combine_process.wait()- def combine_to_movie(self, partial_movie_files=None):+ def combine_to_movie(self):"""Used internally by Manim to combine the separatepartial movie files that make up a Scene into a singlevideo file for that Scene."""- # TODO: remove partial_movie_files from parameter <- gets immediately overwrittenpartial_movie_files = [el for el in self.partial_movie_files if el is not None]# NOTE: Here we should do a check and raise an exception if partial# movie file is empty. We can't, as a lot of stuff (in particular, indiff --git a/tests/test_graphical_units/testing/_test_class_makers.py b/tests/test_graphical_units/testing/_test_class_makers.pyindex 3f0174ffd..7d70fb958 100644--- a/tests/test_graphical_units/testing/_test_class_makers.py+++ b/tests/test_graphical_units/testing/_test_class_makers.py@@ -56,8 +56,7 @@ class DummySceneFileWriter(SceneFileWriter):def end_animation(self, allow_write):pass- # TODO: remove redundant partial_movie_files parameter- def combine_to_movie(self, partial_movie_files):+ def combine_to_movie(self):passdef combine_to_section_videos(self):