Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: add requires() to set_ui_element_value, set_model_value, function_call (#9113)

Myles Scolnick03ff68d48287
diff --git a/marimo/_server/api/endpoints/execution.py b/marimo/_server/api/endpoints/execution.py
index 171f4ea0a7..56d1197fc1 100644
--- a/marimo/_server/api/endpoints/execution.py
+++ b/marimo/_server/api/endpoints/execution.py
@@ -46,6 +46,7 @@ router = APIRouter()
@router.post("/set_ui_element_value")
+@requires("read")
async def set_ui_element_values(
*,
request: Request,
@@ -86,6 +87,7 @@ async def set_ui_element_values(
@router.post("/set_model_value")
+@requires("read")
async def set_model_values(
*,
request: Request,
@@ -151,6 +153,7 @@ async def instantiate(
@router.post("/function_call")
+@requires("read")
async def function_call(
*,
request: Request,
diff --git a/tests/_server/api/endpoints/test_requires_decorator.py b/tests/_server/api/endpoints/test_requires_decorator.py
new file mode 100644
index 0000000000..0b411c6f5c
--- /dev/null
+++ b/tests/_server/api/endpoints/test_requires_decorator.py
@@ -0,0 +1,118 @@
+# Copyright 2026 Marimo. All rights reserved.
+"""Test that all POST endpoints have @requires decorator for auth."""
+
+from __future__ import annotations
+
+import ast
+from pathlib import Path
+
+# Endpoints that are intentionally exempt from @requires.
+# Each entry is (filename, path).
+EXEMPT_ENDPOINTS: set[tuple[str, str]] = {
+ # Login endpoints must be accessible without authentication
+ ("login.py", "/login"),
+ # Service worker must load before auth
+ ("assets.py", "/public-files-sw.js"),
+ # Static frontend assets (JS/CSS) must load before auth
+ ("assets.py", "/{path:path}"),
+}
+
+ENDPOINTS_DIR = Path(__file__).resolve().parents[4] / (
+ "marimo/_server/api/endpoints"
+)
+
+
+def _get_endpoints_missing_requires(
+ methods: tuple[str, ...] = ("post", "get"),
+) -> list[str]:
+ """Parse all endpoint files and find routes missing @requires."""
+ missing: list[str] = []
+
+ for filepath in sorted(ENDPOINTS_DIR.glob("*.py")):
+ filename = filepath.name
+ if filename.startswith("_"):
+ continue
+
+ source = filepath.read_text()
+ tree = ast.parse(source, filename=str(filepath))
+
+ for node in ast.walk(tree):
+ if not isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
+ continue
+
+ route_method: str | None = None
+ route_path: str | None = None
+ has_requires = False
+
+ for decorator in node.decorator_list:
+ if not isinstance(decorator, ast.Call):
+ continue
+ func = decorator.func
+
+ # Check for router.<method>(...)
+ if (
+ isinstance(func, ast.Attribute)
+ and func.attr in methods
+ and isinstance(func.value, ast.Name)
+ and func.value.id == "router"
+ and decorator.args
+ ):
+ route_method = func.attr.upper()
+ route_path = ast.literal_eval(decorator.args[0])
+
+ # Check for requires(...)
+ if isinstance(func, ast.Name) and func.id == "requires":
+ has_requires = True
+
+ if route_method and not has_requires:
+ if (filename, route_path) not in EXEMPT_ENDPOINTS:
+ missing.append(
+ f"{filename}: {route_method} {route_path} "
+ f"(function: {node.name}, line: {node.lineno})"
+ )
+
+ return missing
+
+
+class TestRequiresDecorator:
+ def test_all_endpoints_have_requires(self) -> None:
+ """Every @router.post / @router.get endpoint must have @requires.
+
+ If you're adding a new endpoint, add @requires("edit") or
+ @requires("read") depending on the permission level needed.
+
+ Only endpoints in EXEMPT_ENDPOINTS are allowed to skip @requires
+ (e.g. the login endpoint which must be accessible without auth).
+ """
+ missing = _get_endpoints_missing_requires()
+ assert not missing, (
+ "Endpoints missing @requires decorator:\n"
+ + "\n".join(f" - {m}" for m in missing)
+ + "\n\nAdd @requires('edit') or @requires('read') to each."
+ )
+
+ def test_endpoints_dir_exists(self) -> None:
+ assert ENDPOINTS_DIR.is_dir(), (
+ f"Endpoints dir not found: {ENDPOINTS_DIR}"
+ )
+
+ def test_finds_at_least_some_endpoints(self) -> None:
+ """Sanity check that the AST parsing actually finds endpoints."""
+ count = 0
+ for filepath in ENDPOINTS_DIR.glob("*.py"):
+ source = filepath.read_text()
+ tree = ast.parse(source)
+ for node in ast.walk(tree):
+ if not isinstance(
+ node, (ast.FunctionDef, ast.AsyncFunctionDef)
+ ):
+ continue
+ for decorator in node.decorator_list:
+ if (
+ isinstance(decorator, ast.Call)
+ and isinstance(decorator.func, ast.Attribute)
+ and decorator.func.attr == "post"
+ ):
+ count += 1
+ # We know there are many POST endpoints
+ assert count > 30, f"Expected 30+ POST endpoints, found {count}"