Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: use seconds precision in ibis time binning to avoid sqlglotc Mod error (#8740)

Myles Scolnick15a661fc20dd
diff --git a/marimo/_plugins/ui/_impl/tables/ibis_table.py b/marimo/_plugins/ui/_impl/tables/ibis_table.py
index f7ca58f266..d3d0bc4f46 100644
--- a/marimo/_plugins/ui/_impl/tables/ibis_table.py
+++ b/marimo/_plugins/ui/_impl/tables/ibis_table.py
@@ -135,21 +135,24 @@ class IbisTableManagerFactory(TableManagerFactory):
) -> list[BinValue]:
data = self._original_data
- def _convert_ms_to_time(ms: int) -> datetime.time:
- hours = ms // 3600000
- minutes = (ms % 3600000) // 60000
- seconds = (ms % 60000) // 1000
- microseconds = (ms % 1000) * 1000
- return datetime.time(hours, minutes, seconds, microseconds)
+ def _convert_seconds_to_time(
+ secs: int,
+ ) -> datetime.time:
+ hours = secs // 3600
+ minutes = (secs % 3600) // 60
+ seconds = secs % 60
+ return datetime.time(hours, minutes, seconds)
col = data[column]
if dtype.is_time():
+ # Avoid millisecond()/microsecond() as they
+ # produce Mod expressions that fail with
+ # sqlglotc's strict type checks.
col_agg = (
- col.hour().cast("int64") * 3600000
- + col.minute().cast("int64") * 60000
- + col.second().cast("int64") * 1000
- + col.millisecond().cast("int64")
+ col.hour().cast("int64") * 3600
+ + col.minute().cast("int64") * 60
+ + col.second().cast("int64")
)
else:
col_agg = col.epoch_seconds()
@@ -169,11 +172,10 @@ class IbisTableManagerFactory(TableManagerFactory):
bin_start = datetime.date.fromtimestamp(row.bin_start)
bin_end = datetime.date.fromtimestamp(row.bin_end)
elif dtype.is_time():
- ms = int(row.bin_start)
- bin_start = _convert_ms_to_time(ms)
-
- ms = int(row.bin_end)
- bin_end = _convert_ms_to_time(ms)
+ bin_start = _convert_seconds_to_time(
+ int(row.bin_start)
+ )
+ bin_end = _convert_seconds_to_time(int(row.bin_end))
else:
bin_start = datetime.datetime.fromtimestamp(
row.bin_start