A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
improvement: don't show uv metadata error for new scripts (#7082)
Myles Scolnick17ec4b9c1249
diff --git a/marimo/_runtime/packages/pypi_package_manager.py b/marimo/_runtime/packages/pypi_package_manager.pyindex eb277780b6..2bf5a10f03 100644--- a/marimo/_runtime/packages/pypi_package_manager.py+++ b/marimo/_runtime/packages/pypi_package_manager.py@@ -156,6 +156,8 @@ class UvPackageManager(PypiPackageManager):name = "uv"docs_url = "https://docs.astral.sh/uv/"+ SCRIPT_METADATA_MARKER = "# /// script"+@cached_propertydef _uv_bin(self) -> str:return find_uv_bin()@@ -465,10 +467,20 @@ class UvPackageManager(PypiPackageManager):cmd = [self._uv_bin, "pip", "list", "--format=json", "-p", PY_EXE]return self._list_packages_from_cmd(cmd)+ def _has_script_metadata(self, filename: str) -> bool:+ """Check if a file contains PEP 723 inline script metadata."""+ try:+ file = Path(filename)+ return self.SCRIPT_METADATA_MARKER in file.read_text(+ encoding="utf-8"+ )+ except (OSError, UnicodeDecodeError):+ return False+def dependency_tree(self, filename: Optional[str] = None) -> Optional[DependencyTreeNode]:- """Return the project’s dependency tree using the `uv tree` command."""+ """Return the project's dependency tree using the `uv tree` command."""# Skip if not a script and not inside a uv-managed projectif filename is None and not self.is_in_uv_project:@@ -496,7 +508,9 @@ class UvPackageManager(PypiPackageManager):return treeexcept subprocess.CalledProcessError:- LOGGER.error(f"Failed to get dependency tree for {filename}")+ # Only log error if the script has dependency metadata+ if filename and self._has_script_metadata(filename):+ LOGGER.error(f"Failed to get dependency tree for {filename}")return Nonediff --git a/tests/_runtime/packages/test_pypi_package_manager.py b/tests/_runtime/packages/test_pypi_package_manager.pyindex 5a296dbb0e..1aea16eb0e 100644--- a/tests/_runtime/packages/test_pypi_package_manager.py+++ b/tests/_runtime/packages/test_pypi_package_manager.py@@ -3,6 +3,7 @@ from __future__ import annotationsimport jsonimport sysfrom functools import partial+from typing import TYPE_CHECKINGfrom unittest.mock import MagicMock, patchfrom marimo._ast import compiler@@ -12,6 +13,9 @@ from marimo._runtime.packages.pypi_package_manager import (UvPackageManager,)+if TYPE_CHECKING:+ from pathlib import Path+parse_cell = partial(compiler.compile_cell, cell_id="0")PY_EXE = sys.executable@@ -525,3 +529,54 @@ def test_uv_pip_list_uses_utf8_encoding(mock_run: MagicMock):call_kwargs = mock_run.call_args[1]assert call_kwargs.get("encoding") == "utf-8"assert call_kwargs.get("text") is True+++def test_has_script_metadata_with_metadata(tmp_path: Path):+ """Test that _has_script_metadata returns True when script has metadata"""+ script_file = tmp_path / "script_with_metadata.py"+ script_file.write_text(+ """# /// script+# requires-python = ">=3.11"+# dependencies = [+# "requests",+# "pandas",+# ]+# ///++import marimo as mo+"""+ )++ mgr = UvPackageManager()+ assert mgr._has_script_metadata(str(script_file)) is True+++def test_has_script_metadata_without_metadata(tmp_path: Path):+ """Test that _has_script_metadata returns False when script has no metadata"""+ script_file = tmp_path / "script_without_metadata.py"+ script_file.write_text(+ """import marimo as mo+import pandas as pd++# This is a regular comment+# Not a script metadata block+"""+ )++ mgr = UvPackageManager()+ assert mgr._has_script_metadata(str(script_file)) is False+++def test_has_script_metadata_nonexistent_file():+ """Test that _has_script_metadata returns False for nonexistent files"""+ mgr = UvPackageManager()+ assert mgr._has_script_metadata("/nonexistent/path/to/file.py") is False+++def test_has_script_metadata_binary_file(tmp_path: Path):+ """Test that _has_script_metadata returns False for binary files"""+ binary_file = tmp_path / "binary.bin"+ binary_file.write_bytes(b"\x00\x01\x02\x03\xff\xfe\xfd")++ mgr = UvPackageManager()+ assert mgr._has_script_metadata(str(binary_file)) is False