A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix 6353: enter for renaming a cell not working (#6376)
Max Koretskyi27607bc8b4cc
diff --git a/frontend/src/components/editor/actions/name-cell-input.tsx b/frontend/src/components/editor/actions/name-cell-input.tsxindex 0102f71ced..08cc03025d 100644--- a/frontend/src/components/editor/actions/name-cell-input.tsx+++ b/frontend/src/components/editor/actions/name-cell-input.tsx@@ -19,12 +19,14 @@ interface Propsvalue: string;onChange: (newName: string) => void;placeholder?: string;+ onEnterKey?: () => void;}export const NameCellInput: React.FC<Props> = ({value,onChange,placeholder,+ onEnterKey,...props}) => {const ref = useRef<HTMLInputElement>(null);@@ -53,7 +55,10 @@ export const NameCellInput: React.FC<Props> = ({ref={ref}placeholder={placeholder}className="shadow-none! hover:shadow-none focus:shadow-none focus-visible:shadow-none"- onKeyDown={Events.onEnter(Events.stopPropagation())}+ onKeyDown={Events.onEnter((e) => {+ Events.stopPropagation()(e);+ onEnterKey?.();+ })}{...props}/>);diff --git a/frontend/src/components/editor/actions/useCellActionButton.tsx b/frontend/src/components/editor/actions/useCellActionButton.tsxindex a5f4fe0f1f..4a5ba0626e 100644--- a/frontend/src/components/editor/actions/useCellActionButton.tsx+++ b/frontend/src/components/editor/actions/useCellActionButton.tsx@@ -73,9 +73,10 @@ export interface CellActionButtonPropsinterface Props {cell: CellActionButtonProps | null;+ closePopover?: () => void;}-export function useCellActionButtons({ cell }: Props) {+export function useCellActionButtons({ cell, closePopover }: Props) {const {createNewCell: createCell,updateCellConfig,@@ -177,6 +178,7 @@ export function useCellActionButtons({ cell }: Props) {placeholder={"cell name"}value={name}onChange={(newName) => updateCellName({ cellId, name: newName })}+ onEnterKey={() => closePopover?.()}/>),},diff --git a/frontend/src/components/editor/cell/cell-actions.tsx b/frontend/src/components/editor/cell/cell-actions.tsxindex cd2f553445..269ca5261f 100644--- a/frontend/src/components/editor/cell/cell-actions.tsx+++ b/frontend/src/components/editor/cell/cell-actions.tsx@@ -56,7 +56,8 @@ const CellActionsDropdownInternal = (ref: React.Ref<CellActionsDropdownHandle>,) => {const [open, setOpen] = useState(false);- const actions = useCellActionButtons({ cell: props });+ const closePopover = () => setOpen(false);+ const actions = useCellActionButtons({ cell: props, closePopover });// store the last focused element so we can restore it when the popover closesconst restoreFocus = useRestoreFocus();