A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: use css for full-width of altair (#8746)
Myles Scolnick2f13d94531c4
diff --git a/frontend/src/components/data-table/charts/lazy-chart.tsx b/frontend/src/components/data-table/charts/lazy-chart.tsxindex 6f5b749b38..85afd496b9 100644--- a/frontend/src/components/data-table/charts/lazy-chart.tsx+++ b/frontend/src/components/data-table/charts/lazy-chart.tsx@@ -4,6 +4,7 @@ import React from "react";import type { TopLevelSpec } from "vega-lite";import { LazyVegaEmbed } from "@/components/charts/lazy";import { tooltipHandler } from "@/components/charts/tooltip";+import { getContainerWidth } from "@/plugins/impl/vega/utils";import { useTheme } from "@/theme/useTheme";import type { ErrorMessage } from "./chart-spec/spec";import { augmentSpecWithData } from "./chart-spec/spec";@@ -30,6 +31,7 @@ export const LazyChart: React.FC<{<React.Suspense fallback={<LoadingChart />}><LazyVegaEmbedspec={spec}+ data-container-width={getContainerWidth(spec)}options={{theme: theme === "dark" ? "dark" : undefined,height: height,diff --git a/frontend/src/components/data-table/column-summary/column-summary.tsx b/frontend/src/components/data-table/column-summary/column-summary.tsxindex 3ef0883ac9..35b158ca24 100644--- a/frontend/src/components/data-table/column-summary/column-summary.tsx+++ b/frontend/src/components/data-table/column-summary/column-summary.tsx@@ -45,6 +45,7 @@ export const TableColumnSummary = <TData, TValue>({<Suspense fallback={skeleton}><LazyVegaEmbedspec={spec}+ data-container-width="container"options={{width: 80,height: 30,diff --git a/frontend/src/components/datasources/column-preview.tsx b/frontend/src/components/datasources/column-preview.tsxindex 6654f754b3..65cdc7dd12 100644--- a/frontend/src/components/datasources/column-preview.tsx+++ b/frontend/src/components/datasources/column-preview.tsx@@ -224,6 +224,7 @@ export function renderChart(chartSpec: string, theme: Theme) {return (<Suspense fallback={LoadingChart}><LazyVegaEmbed+ data-container-width="container"spec={updateSpec(JSON.parse(chartSpec) as TopLevelFacetedUnitSpec)}options={{theme: theme === "dark" ? "dark" : "vox",diff --git a/frontend/src/components/editor/Output.tsx b/frontend/src/components/editor/Output.tsxindex 7300ca1e34..55a4ad661e 100644--- a/frontend/src/components/editor/Output.tsx+++ b/frontend/src/components/editor/Output.tsx@@ -27,6 +27,7 @@ import { useOverflowDetection } from "@/hooks/useOverflowDetection";import { renderHTML } from "@/plugins/core/RenderHTML";import { Banner } from "@/plugins/impl/common/error-banner";import type { TopLevelFacetedUnitSpec } from "@/plugins/impl/data-explorer/queries/types";+import { getContainerWidth } from "@/plugins/impl/vega/utils";import { useTheme } from "@/theme/useTheme";import { Events } from "@/utils/events";import { invariant } from "@/utils/invariant";@@ -205,6 +206,7 @@ export const OutputRenderer: React.FC<{<Suspense fallback={<ChartLoadingState />}><LazyVegaEmbedspec={parsedJsonData as TopLevelFacetedUnitSpec}+ data-container-width={getContainerWidth(parsedJsonData)}options={{theme: theme === "dark" ? "dark" : undefined,mode: "vega-lite",diff --git a/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx b/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsxindex 93d2f27541..81f8434f60 100644--- a/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx+++ b/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx@@ -5,6 +5,7 @@ import { useAtom } from "jotai";import { CrosshairIcon, PinIcon, PinOffIcon, XIcon } from "lucide-react";import type { PropsWithChildren } from "react";import { Panel, PanelResizeHandle } from "react-resizable-panels";+import { raf2 } from "@/components/editor/navigation/focus-utils";import { Button } from "@/components/ui/button";import { Toggle } from "@/components/ui/toggle";import { Tooltip } from "@/components/ui/tooltip";@@ -151,6 +152,11 @@ const ResizableComponent = ({ children }: ResizableComponentProps) => {startingWidth: 400,minWidth: 300,maxWidth: 1500,+ onResize: () => {+ raf2(() => {+ window.dispatchEvent(new Event("resize"));+ });+ },});return (diff --git a/frontend/src/components/editor/chrome/wrapper/__tests__/utils.test.ts b/frontend/src/components/editor/chrome/wrapper/__tests__/utils.test.tsnew file mode 100644index 0000000000..695715e1c5--- /dev/null+++ b/frontend/src/components/editor/chrome/wrapper/__tests__/utils.test.ts@@ -0,0 +1,35 @@+/* Copyright 2026 Marimo. All rights reserved. */++import { describe, expect, it, vi } from "vitest";+import { handleDragging } from "../utils";++describe("handleDragging", () => {+ it("should dispatch a resize event after dragging ends", async () => {+ const listener = vi.fn();+ window.addEventListener("resize", listener);++ handleDragging(false);++ // raf2: wait two animation frames+ await new Promise((resolve) => requestAnimationFrame(resolve));+ await new Promise((resolve) => requestAnimationFrame(resolve));++ expect(listener).toHaveBeenCalledTimes(1);++ window.removeEventListener("resize", listener);+ });++ it("should not dispatch a resize event while dragging", async () => {+ const listener = vi.fn();+ window.addEventListener("resize", listener);++ handleDragging(true);++ await new Promise((resolve) => requestAnimationFrame(resolve));+ await new Promise((resolve) => requestAnimationFrame(resolve));++ expect(listener).not.toHaveBeenCalled();++ window.removeEventListener("resize", listener);+ });+});diff --git a/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx b/frontend/src/components/editor/chrome/wrapper/app-chrome.tsxindex 2e444d7984..228c0fbd8e 100644--- a/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx+++ b/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx@@ -17,6 +17,7 @@ import "./app-chrome.css";import { TooltipProvider } from "@radix-ui/react-tooltip";import { useAtom, useAtomValue } from "jotai";import { XIcon } from "lucide-react";+import useEvent from "react-use-event-hook";import { Button } from "@/components/ui/button";import { ReorderableList } from "@/components/ui/reorderable-list";import { Tabs, TabsList, TabsTrigger } from "@/components/ui/tabs";@@ -26,6 +27,7 @@ import { capabilitiesAtom } from "@/core/config/capabilities";import { getFeatureFlag } from "@/core/config/feature-flag";import { cn } from "@/utils/cn";import { ErrorBoundary } from "../../boundary/ErrorBoundary";+import { raf2 } from "../../navigation/focus-utils";import { ContextAwarePanel } from "../panels/context-aware-panel/context-aware-panel";import { PanelSectionProvider } from "../panels/panel-context";import { panelLayoutAtom, useChromeActions, useChromeState } from "../state";@@ -147,6 +149,14 @@ export const AppChrome: React.FC<PropsWithChildren> = ({ children }) => {});}, [panelLayout.sidebar, capabilities]);+ const emitResizeEvent = useEvent(() => {+ // HACK: Unfortunately, we have to do this twice to make sure the+ // panel is fully expanded before we dispatch the resize event+ raf2(() => {+ window.dispatchEvent(new Event("resize"));+ });+ });+// sync sidebaruseEffect(() => {if (!sidebarRef.current) {@@ -162,13 +172,7 @@ export const AppChrome: React.FC<PropsWithChildren> = ({ children }) => {}// Dispatch a resize event so widgets know to resize- requestAnimationFrame(() => {- // HACK: Unfortunately, we have to do this twice to make sure it the- // panel is fully expanded before we dispatch the resize event- requestAnimationFrame(() => {- window.dispatchEvent(new Event("resize"));- });- });+ emitResizeEvent();}, [isSidebarOpen]);// sync panel@@ -186,13 +190,7 @@ export const AppChrome: React.FC<PropsWithChildren> = ({ children }) => {}// Dispatch a resize event so widgets know to resize- requestAnimationFrame(() => {- // HACK: Unfortunately, we have to do this twice to make sure it the- // panel is fully expanded before we dispatch the resize event- requestAnimationFrame(() => {- window.dispatchEvent(new Event("resize"));- });- });+ emitResizeEvent();}, [isDeveloperPanelOpen]);// Auto-correct developer panel selection when the selected tab is no longer availablediff --git a/frontend/src/components/editor/chrome/wrapper/utils.ts b/frontend/src/components/editor/chrome/wrapper/utils.tsindex 923111c865..8ccecf37e2 100644--- a/frontend/src/components/editor/chrome/wrapper/utils.ts+++ b/frontend/src/components/editor/chrome/wrapper/utils.ts@@ -1,8 +1,12 @@/* Copyright 2026 Marimo. All rights reserved. */+import { raf2 } from "../../navigation/focus-utils";+export function handleDragging(isDragging: boolean) {if (!isDragging) {// Once the user is done dragging, dispatch a resize event- window.dispatchEvent(new Event("resize"));+ raf2(() => {+ window.dispatchEvent(new Event("resize"));+ });}}diff --git a/frontend/src/plugins/impl/data-explorer/ConnectedDataExplorerComponent.tsx b/frontend/src/plugins/impl/data-explorer/ConnectedDataExplorerComponent.tsxindex 87653963ca..533cfe2940 100644--- a/frontend/src/plugins/impl/data-explorer/ConnectedDataExplorerComponent.tsx+++ b/frontend/src/plugins/impl/data-explorer/ConnectedDataExplorerComponent.tsx@@ -17,6 +17,7 @@ import { cn } from "@/utils/cn";import { Objects } from "@/utils/objects";import { ErrorBanner } from "../common/error-banner";import { vegaLoadData } from "../vega/loader";+import { getContainerWidth } from "../vega/utils";import { ColumnSummary } from "./components/column-summary";import { QueryForm } from "./components/query-form";import type { SpecificEncoding } from "./encoding";@@ -140,16 +141,18 @@ export const DataExplorerComponent = ({const responsiveSpec = makeResponsive(spec);// TODO: We can optimize by updating the data dynamically. https://github.com/vega/react-vega?tab=readme-ov-file#recipesconst augmentedSpec = augmentSpecWithData(responsiveSpec, chartData);- const isContainerWidth = responsiveSpec.width === "container";return (<divclassName={cn("flex overflow-y-auto justify-center items-center flex-1 w-[90%]",- isContainerWidth && "vega-container-width",)}>- <VegaEmbed spec={augmentedSpec} options={chartOptions(theme)} />+ <VegaEmbed+ data-container-width={getContainerWidth(augmentedSpec)}+ spec={augmentedSpec}+ options={chartOptions(theme)}+ /></div>);};diff --git a/frontend/src/plugins/impl/vega/__tests__/utils.test.ts b/frontend/src/plugins/impl/vega/__tests__/utils.test.tsnew file mode 100644index 0000000000..37104d804b--- /dev/null+++ b/frontend/src/plugins/impl/vega/__tests__/utils.test.ts@@ -0,0 +1,36 @@+/* Copyright 2026 Marimo. All rights reserved. */++import { describe, expect, it } from "vitest";+import { getContainerWidth } from "../utils";++describe("getContainerWidth", () => {+ it('should return "container" when spec width is "container"', () => {+ expect(getContainerWidth({ width: "container" })).toBe("container");+ });++ it("should return a numeric width", () => {+ expect(getContainerWidth({ width: 500 })).toBe(500);+ });++ it("should return undefined when spec has no width", () => {+ expect(getContainerWidth({ height: 300 })).toBeUndefined();+ });++ it("should return undefined for null", () => {+ expect(getContainerWidth(null)).toBeUndefined();+ });++ it("should return undefined for undefined", () => {+ expect(getContainerWidth(undefined)).toBeUndefined();+ });++ it("should return undefined for non-object values", () => {+ expect(getContainerWidth("string")).toBeUndefined();+ expect(getContainerWidth(42)).toBeUndefined();+ expect(getContainerWidth(true)).toBeUndefined();+ });++ it("should return undefined when width is explicitly undefined", () => {+ expect(getContainerWidth({ width: undefined })).toBeUndefined();+ });+});diff --git a/frontend/src/plugins/impl/vega/utils.ts b/frontend/src/plugins/impl/vega/utils.tsindex 046996eaaa..093c328618 100644--- a/frontend/src/plugins/impl/vega/utils.ts+++ b/frontend/src/plugins/impl/vega/utils.ts@@ -3,6 +3,20 @@import { Objects } from "@/utils/objects";import type { DataType, FieldTypes, VegaDataType } from "./vega-loader";+export type ContainerWidth = number | "container";++/**+ * Get the container width from a VegaLite spec.+ * @param spec - The VegaLite spec.+ * @returns The container width.+ */+export function getContainerWidth(spec: unknown): ContainerWidth | undefined {+ if (typeof spec === "object" && spec !== null && "width" in spec) {+ return spec.width as ContainerWidth | undefined;+ }+ return undefined;+}+export function mergeAsArrays<T>(left: T | T[] | undefined,right: T | T[] | undefined,diff --git a/frontend/src/plugins/impl/vega/vega-component.tsx b/frontend/src/plugins/impl/vega/vega-component.tsxindex a4827e2d3f..a7eb025798 100644--- a/frontend/src/plugins/impl/vega/vega-component.tsx+++ b/frontend/src/plugins/impl/vega/vega-component.tsx@@ -27,6 +27,7 @@ import { makeSelectable } from "./make-selectable";import { getSelectionParamNames, ParamNames } from "./params";import { resolveVegaSpecData } from "./resolve-data";import type { VegaLiteSpec } from "./types";+import { getContainerWidth } from "./utils";// register arrow reader under type 'arrow'formats("arrow", arrow);@@ -305,16 +306,14 @@ const LoadedVegaComponent = ({</Alert>)}<div- className={cn(- "relative",- "width" in selectableSpec &&- selectableSpec.width === "container" &&- "vega-container-width",- )}+ className={cn("relative")}// Capture the pointer down event to prevent the parent from handling itonPointerDown={Events.stopPropagation()}>- <div ref={vegaRef} />+ <div+ ref={vegaRef}+ data-container-width={getContainerWidth(selectableSpec)}+ />{renderHelpContent()}</div></>diff --git a/frontend/src/plugins/impl/vega/vega.css b/frontend/src/plugins/impl/vega/vega.cssindex e4c66deb5c..16c129f3a1 100644--- a/frontend/src/plugins/impl/vega/vega.css+++ b/frontend/src/plugins/impl/vega/vega.css@@ -4,7 +4,7 @@max-width: 100%;}-.vega-container-width .vega-embed {+.vega-embed[data-container-width="container"] {width: 100%;}