A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
Forward `Ctrl+Escape` from CodeMirror to parent elements (#6114)
Trevor Manz3080561869cc
diff --git a/frontend/src/core/codemirror/keymaps/vim.ts b/frontend/src/core/codemirror/keymaps/vim.tsindex bf1989637b..fc9b472773 100644--- a/frontend/src/core/codemirror/keymaps/vim.ts+++ b/frontend/src/core/codemirror/keymaps/vim.ts@@ -1,7 +1,7 @@/* Copyright 2024 Marimo. All rights reserved. */import type { Extension } from "@codemirror/state";-import { type EditorView, keymap, ViewPlugin } from "@codemirror/view";+import { EditorView, keymap, ViewPlugin } from "@codemirror/view";import {type CodeMirror,type CodeMirrorV,@@ -97,6 +97,18 @@ export function vimKeymapExtension(): Extension[] {};}),ViewPlugin.define((view) => new VimCursorVisibilityPlugin({ view })),+ // FIXME: The vim extension swallows `Ctrl+Escape` events, preventing them+ // from bubbling to parent elements where react-aria's useKeyboard is listening.+ // Re-dispatch the event to ensure it propagates up for vim mode transitions.+ EditorView.domEventHandlers({+ keydown(event, view) {+ if (event.ctrlKey && event.key === "Escape") {+ view.dom.dispatchEvent(new KeyboardEvent(event.type, event));+ return true;+ }+ return false;+ },+ }),];}